[09:03:08] good morning hashar [09:03:53] should we tag a new quibble release? or do you want to get the parallelism patches in first? [09:04:47] (I'd like to see if `--parallel-npm-install` has a positive impact on job runtime) [09:05:26] kostajh: good morning [09:07:50] there are a bunch of interesting patches pending but well I should polish the first [09:08:07] the parallel series I talked with awight about it we got one more change merged in but I haven't checked the others :\ [09:08:13] so yeah guess we can tag a new one [09:10:21] lets grab a coffee and stuff first ;] [09:10:40] we could include https://gerrit.wikimedia.org/r/c/integration/quibble/+/587888, perhaps [09:10:49] or maybe it's safer to include that in a later release, i don't know [09:14:35] we could tag e.g. 1.3.0 and 1.3.1 and build two images, to cut down on work in case rollback of jobs is needed [09:17:00] that one depends on "Parallelism as a command object" [09:17:11] which is the next in the queue [09:17:20] I don't mind tagging / rebuilding as many images as needed :] [09:33:44] right [09:35:15] (03CR) 10Kosta Harlan: Parallelism as a command object (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (https://phabricator.wikimedia.org/T235449) (owner: 10Awight) [09:38:22] anyway, yeah to be safe, maybe 1.3.0 is the current state of the repo, and 1.4.0 is `587885` and `587888`; jjb jobs could skip straight to 1.4.0 and if it's problematic, we'd move them back to 1.3.0 [09:39:02] although, maybe the parallel npm install stuff should be rewritten to use Parallel command [09:39:05] I'll have a look at that now [09:40:36] bah, no I don't want to do that now. It will be too involved for the time I have this morning [09:43:57] (03PS50) 10Awight: Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (https://phabricator.wikimedia.org/T235449) [10:05:39] kostajh: don't worry I will cut a release [10:05:46] busy with something else this morning though [10:05:50] *cough* java *cough* [10:10:14] heh [10:19:04] (03CR) 10Kosta Harlan: [C: 03+1] Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (https://phabricator.wikimedia.org/T235449) (owner: 10Awight) [10:19:37] (03PS18) 10Kosta Harlan: Split extension and skin npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 (owner: 10Awight) [10:21:46] (03CR) 10Kosta Harlan: [C: 03+1] Split extension and skin npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 (owner: 10Awight) [13:33:58] kostajh: I'd be happy to rewrite anything using ParallelCommand, if there's a task or more description of what should be achieved? [13:36:37] awight: it would be to convert https://gerrit.wikimedia.org/r/c/integration/quibble/+/738061 to use ParallelCommand. The parallelism logic is inside BrowserTests. However, maybe it makes sense to keep there? I can see a use case for commands wanting to parallelize some of their internal logic. [15:22:13] (03PS1) 10Hashar: Release Quibble 1.3.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/754524 (https://phabricator.wikimedia.org/T297480) [15:22:16] (03PS1) 10Hashar: changelog: being new 1.3.1 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/754525 [15:22:24] awight: kostajh ^ :) [15:22:56] double check welcome [15:23:30] (03PS1) 10Hashar: Review access change [integration/quibble] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/754139 [15:23:55] (03CR) 10Hashar: [V: 03+2 C: 03+2] "This should give you rights to push a signed tag" [integration/quibble] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/754139 (owner: 10Hashar) [15:24:16] and you should be able to create a tag [15:24:27] or I will do whne I am back from school and then bump the images [15:36:07] (03CR) 10Kosta Harlan: changelog: being new 1.3.1 version cycle (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/754525 (owner: 10Hashar) [15:36:35] (03CR) 10Kosta Harlan: Release Quibble 1.3.0 (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/754524 (https://phabricator.wikimedia.org/T297480) (owner: 10Hashar) [15:37:03] (03CR) 10Kosta Harlan: "nice, thanks!" [integration/quibble] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/754139 (owner: 10Hashar) [15:43:23] (03CR) 10Hashar: changelog: being new 1.3.1 version cycle (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/754525 (owner: 10Hashar) [15:43:31] (03PS2) 10Hashar: changelog: begin new 1.3.1 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/754525 [15:45:04] (03PS2) 10Hashar: Release Quibble 1.3.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/754524 (https://phabricator.wikimedia.org/T297480) [15:45:10] (03CR) 10Hashar: Release Quibble 1.3.0 (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/754524 (https://phabricator.wikimedia.org/T297480) (owner: 10Hashar) [15:45:14] (03CR) 10Kosta Harlan: [C: 03+2] changelog: begin new 1.3.1 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/754525 (owner: 10Hashar) [15:45:29] kostajh: I have amneded the patch that had a typo in your name [15:45:42] (03PS3) 10Hashar: changelog: begin new 1.3.1 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/754525 [15:45:58] (03CR) 10Kosta Harlan: [C: 03+1] Release Quibble 1.3.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/754524 (https://phabricator.wikimedia.org/T297480) (owner: 10Hashar) [15:46:13] kostajh: I guess you can +2 it ;) [15:46:25] (03CR) 10Kosta Harlan: [C: 03+2] Release Quibble 1.3.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/754524 (https://phabricator.wikimedia.org/T297480) (owner: 10Hashar) [15:46:33] ha, i wrote in -releng [15:46:33] done [15:46:35] and I had to rebase the dummy change that follow [15:46:39] ha -releng vs -quibble :] [16:04:10] (03Merged) 10jenkins-bot: Release Quibble 1.3.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/754524 (https://phabricator.wikimedia.org/T297480) (owner: 10Hashar) [16:06:40] (03Merged) 10jenkins-bot: changelog: begin new 1.3.1 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/754525 (owner: 10Hashar)