[10:28:34] (03CR) 10Kosta Harlan: [C: 03+2] Parallelism as a command object (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (https://phabricator.wikimedia.org/T235449) (owner: 10Awight) [10:43:50] (03Merged) 10jenkins-bot: Parallelism as a command object [integration/quibble] - 10https://gerrit.wikimedia.org/r/587885 (https://phabricator.wikimedia.org/T235449) (owner: 10Awight) [10:58:26] (03PS22) 10Awight: Split extension and skin npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 [10:58:40] (03CR) 10Awight: "PS 22: manual rebase" [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 (owner: 10Awight) [10:59:15] (03PS7) 10Awight: Split core npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 [11:00:16] (03PS1) 10Kosta Harlan: GitClean: Default to background processing [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 [11:02:38] (03CR) 10jerkins-bot: [V: 04-1] Split core npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 (owner: 10Awight) [11:03:37] (03CR) 10jerkins-bot: [V: 04-1] GitClean: Default to background processing [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [11:04:38] (03PS2) 10Kosta Harlan: GitClean: Default to background processing [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 [11:05:14] (03CR) 10Awight: "This makes me realize that I'm not sure what purpose GitClean has? If it's just lowering disk usage, then this patch is ideal. But if th" [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [11:06:29] (03CR) 10Kosta Harlan: GitClean: Default to background processing (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [11:08:22] (03CR) 10jerkins-bot: [V: 04-1] GitClean: Default to background processing [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [11:21:40] kostajh: I see what you mean about the use cases, we seem to only do git-clean out of a superstition that dependency and test artifacts might influence later e.g. php or browser tests? [11:21:50] Maybe we can skip it entirely? [11:23:23] Yeah that’s another option [11:23:34] I think h-ashar was explaining once that the linters and subsequent more expensive tests would ideally be running in two separate containers so they are fully reset between runs, but we stick them together in quibble just as an optimization, for example short-circuiting before the more expensive tests run. [11:23:41] Although progressively removing files may make the final container deletion go faster? [11:24:47] I doubt it will improve overall performance, since it's a recursive delete combined with git calculations, and even after your patch here will be competing with tests for resources... [11:25:13] but I have no intuitive sense of VPS/CI low-level ops [11:25:40] (03CR) 10Kosta Harlan: [C: 03+2] Split extension and skin npm and composer tests (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 (owner: 10Awight) [11:27:20] (03PS8) 10Awight: Split core npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 [11:27:22] (03PS6) 10Awight: Sequence of commands as a command [integration/quibble] - 10https://gerrit.wikimedia.org/r/588083 [11:28:26] (03CR) 10Awight: "PS 6: manual rebase" [integration/quibble] - 10https://gerrit.wikimedia.org/r/588083 (owner: 10Awight) [11:30:48] (03CR) 10jerkins-bot: [V: 04-1] Sequence of commands as a command [integration/quibble] - 10https://gerrit.wikimedia.org/r/588083 (owner: 10Awight) [11:35:52] awight: yeah, I don't know. if we do want to move that patch forward, I'd need some help with the unit test failure [11:39:26] kostajh: the GitClean thing? Maybe we should lure hashar in to help explore the impact. [11:40:58] As for the V-1, I think we need to update the test to mock Popen rather than check_call. [11:41:30] (03Merged) 10jenkins-bot: Split extension and skin npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/587888 (owner: 10Awight) [11:46:16] (03PS9) 10Awight: Split core npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 [11:46:18] (03PS7) 10Awight: Sequence of commands as a command [integration/quibble] - 10https://gerrit.wikimedia.org/r/588083 [12:56:10] (03PS3) 10Awight: GitClean: Default to background processing [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [12:56:17] (03CR) 10jerkins-bot: [V: 04-1] GitClean: Default to background processing [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [12:58:10] (03PS4) 10Awight: GitClean: Default to background processing [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [12:58:41] (03CR) 10Awight: "PS 3: fix test" [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [13:09:26] (03CR) 10Kosta Harlan: "In the output from CI full run, I see" [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 (owner: 10Awight) [13:10:57] (03CR) 10Kosta Harlan: GitClean: Default to background processing (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [13:12:03] (03PS10) 10Kosta Harlan: BrowserTests: Rework npm parallel install using ParallelCommand [integration/quibble] - 10https://gerrit.wikimedia.org/r/754866 [13:12:29] (03CR) 10jerkins-bot: [V: 04-1] GitClean: Default to background processing [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [13:56:44] kostajh: I think the background clean pulled the rug out from under us: > 14:12:12 Error: API_TESTING_CONFIG_FILE was set but neither '/workspace/src/api-testing-quibble.json' nor '/workspace/src/configs//workspace/src/api-testing-quibble.json' exist. [14:53:22] (03CR) 10Awight: Split core npm and composer tests (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 (owner: 10Awight) [15:03:02] (03CR) 10Awight: "This change is ready for review." [integration/quibble] - 10https://gerrit.wikimedia.org/r/756610 (owner: 10Awight) [15:04:34] (03PS10) 10Awight: Split core npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 [15:04:51] (03CR) 10Awight: "PS 10: give parallel group a title" [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 (owner: 10Awight) [15:07:36] (03CR) 10jerkins-bot: [V: 04-1] Split core npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 (owner: 10Awight) [15:14:49] (03PS2) 10Awight: Default label for parallel command [integration/quibble] - 10https://gerrit.wikimedia.org/r/756610 [15:14:51] (03PS11) 10Awight: Split core npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 [15:18:00] (03CR) 10jerkins-bot: [V: 04-1] Default label for parallel command [integration/quibble] - 10https://gerrit.wikimedia.org/r/756610 (owner: 10Awight) [15:20:46] (03PS3) 10Awight: Default label for parallel command [integration/quibble] - 10https://gerrit.wikimedia.org/r/756610 [15:20:50] (03PS12) 10Awight: Split core npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 [15:27:39] (03CR) 10jerkins-bot: [V: 04-1] Split core npm and composer tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 (owner: 10Awight) [15:56:46] (03CR) 10Kosta Harlan: [C: 03+1] Default label for parallel command (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/756610 (owner: 10Awight) [16:09:17] (03CR) 10Kosta Harlan: "Hmm, why are we linting PHP files in node_modules? https://integration.wikimedia.org/ci/job/integration-quibble-fullrun/597/console" [integration/quibble] - 10https://gerrit.wikimedia.org/r/588087 (owner: 10Awight) [18:55:41] (03CR) 10Kosta Harlan: [C: 03+2] Default label for parallel command [integration/quibble] - 10https://gerrit.wikimedia.org/r/756610 (owner: 10Awight) [19:07:45] (03CR) 10jerkins-bot: [V: 04-1] Default label for parallel command [integration/quibble] - 10https://gerrit.wikimedia.org/r/756610 (owner: 10Awight) [19:26:20] (03CR) 10Kosta Harlan: [C: 03+2] Default label for parallel command [integration/quibble] - 10https://gerrit.wikimedia.org/r/756610 (owner: 10Awight) [19:47:11] (03Merged) 10jenkins-bot: Default label for parallel command [integration/quibble] - 10https://gerrit.wikimedia.org/r/756610 (owner: 10Awight) [22:06:02] (03CR) 10Awight: "Yes, I think this uncovered a bug: when node modules are present, composer lint scans them unnecessarily. The directory should be exclude" [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan) [22:43:14] (03CR) 10Awight: GitClean: Default to background processing (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/756543 (owner: 10Kosta Harlan)