[07:03:44] (03PS2) 10Kosta Harlan: release: Quibble 1.4.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/758952 (https://phabricator.wikimedia.org/T300340) [07:04:01] (03CR) 10Kosta Harlan: release: Quibble 1.4.0 (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/758952 (https://phabricator.wikimedia.org/T300340) (owner: 10Kosta Harlan) [07:04:33] (03PS1) 10Kosta Harlan: release: Start 1.4.1 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/759148 [07:58:47] (03CR) 10Kosta Harlan: release: Quibble 1.4.0 (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/758952 (https://phabricator.wikimedia.org/T300340) (owner: 10Kosta Harlan) [09:00:10] Looks exciting! [10:21:16] hashar: sorry just saw your message [10:21:23] I could do it now if you want [10:22:33] (03PS10) 10Kosta Harlan: ci-full-run: Add extensions to full run [integration/quibble] - 10https://gerrit.wikimedia.org/r/757381 [10:36:44] kostajh: This is the first time I really looked at ci-full-run. It seems wrong that we're running quibble twice, is this related to T211702? [10:37:42] [todo: we should invite stashbot to this channel] [10:37:55] awight: I was about to split that up, actually. I think what we should do is have ci-full-run-core and ci-full-run-extensions. Then in jjb we can have those two jobs execute in parallel. [10:38:13] We want one job that is using mediawiki/core as the project and another using an extension as the project in order to simulate what is going on in CI [10:38:19] if we do all that, maybe it should be a mode of quibble itself? [10:38:30] I think they don't need to conflict [10:39:01] what do you mean? [10:39:23] It would be fine to run cwd=project_repo jobs while cwd=mediawiki_root clones its projects and runs full integration jobs. [10:41:52] (03CR) 10jerkins-bot: [V: 04-1] ci-full-run: Add extensions to full run [integration/quibble] - 10https://gerrit.wikimedia.org/r/757381 (owner: 10Kosta Harlan) [10:48:50] kostajh: sorry for the nitpick yesterday about the changelog entry :D [10:49:10] (03CR) 10Hashar: [C: 03+1] release: Quibble 1.4.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/758952 (https://phabricator.wikimedia.org/T300340) (owner: 10Kosta Harlan) [10:49:22] (03CR) 10Hashar: [C: 03+1] release: Start 1.4.1 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/759148 (owner: 10Kosta Harlan) [10:49:34] I am going to have lunch with kids [10:49:37] hashar: stepping out for lunch now [10:49:38] ha [10:49:56] ok, so maybe later, but we can always pair on 1.4.1 or 1.5.0 if you want to do it yourself later... up to you [10:50:05] kostajh: then you and awight should have the right to push a gpg signed tag [10:50:25] and thiemo as well for some reason ;) [10:51:32] lunch && kids duties [10:56:57] 10Quibble: Clean up indentation of quibble plan - https://phabricator.wikimedia.org/T300718 (10awight) [11:04:43] kostajh: sorry, I misunderstood how you were splitting up the quibble ci-full-run self-tests. We would be testing the two main code paths depending on whether a core or ext patch is under test. It makes complete sense to split that into two jjb jobs as you were saying, and keep as two separate commandlines, not a standard mode of running quibble. [11:08:43] 10Quibble: Clean up indentation of quibble plan - https://phabricator.wikimedia.org/T300718 (10awight) [11:14:06] 10Quibble: Consolidate temp dir creation - https://phabricator.wikimedia.org/T300724 (10awight) [11:19:00] (03PS11) 10Kosta Harlan: ci-fullrun: Add extension variant [integration/quibble] - 10https://gerrit.wikimedia.org/r/757381 [11:19:04] hashar: I've been resisting it, but I accept learning quibble deployment duties any time it makes sense, now or in the future (for example, this one in case we need a revert of my garbage code) [11:19:54] (03PS12) 10Kosta Harlan: ci-fullrun: Add extension variant [integration/quibble] - 10https://gerrit.wikimedia.org/r/757381 [11:25:42] 10Quibble: Document backend.py and its registry - https://phabricator.wikimedia.org/T300725 (10awight) [11:29:39] 10Quibble: Extract chromedriver and Xvfb into container - https://phabricator.wikimedia.org/T300726 (10awight) [11:32:57] 10Quibble: Rename cmd.py to distinguish from Command - https://phabricator.wikimedia.org/T300727 (10awight) [11:39:36] 10Quibble: Self-test ci-full-run should dump db - https://phabricator.wikimedia.org/T300729 (10awight) [11:39:45] (just going through old notes) [12:22:02] awight: garbage code sounds a bit extreme :) [12:23:43] the code kinda creeps me out is all, and I need to justify tearing it apart and rewriting again soon /o\ [12:54:53] awight: kostajh: hi, I am here for ~ 40 minutes or so [12:55:12] I am not sure where to write the doc :D [12:55:38] I guess integration/config is the proper place [12:55:56] hashar: I have a meeting now, sorry [12:56:03] no worries :D [12:56:12] maybe if awight is around you can pair on deploying. otherwise, documentation is good :) [12:56:41] actually there is some doc at https://www.mediawiki.org/wiki/Continuous_integration/Quibble [12:56:46] for the jjb part [12:57:05] also, https://gerrit.wikimedia.org/r/c/integration/quibble/+/758783 and https://gerrit.wikimedia.org/r/c/integration/quibble/+/757381 could be nice to include in the 1.4.0 release but it could also be in the next one, to reduce risk [12:59:04] I don't get why it is translated to indonesian really ( https://www.mediawiki.org/wiki/Continuous_integration/Quibble/id ) [13:01:44] Change on 12www.mediawiki.org a page Continuous integration/Quibble was modified, changed by Hashar link https://www.mediawiki.org/w/index.php?diff=5051665 edit summary: [-657] use headers instead of sub lists [13:02:11] OH [13:02:42] going to proof read that page [13:20:22] Change on 12www.mediawiki.org a page Continuous integration/Quibble was modified, changed by Hashar link https://www.mediawiki.org/w/index.php?diff=5051711 edit summary: [+188] [13:20:33] essentially https://www.mediawiki.org/wiki/Continuous_integration/Quibble [13:20:40] it is good. Thanks to James Forrester [13:26:18] (03CR) 10Hashar: [C: 03+2] "Some code can be factored out by invoking utils/ci-fullrun.sh and pass it whatever env variable. But that can be improved later. Lets merg" [integration/quibble] - 10https://gerrit.wikimedia.org/r/757381 (owner: 10Kosta Harlan) [13:32:24] (03CR) 10Hashar: [C: 03+1] "In the initial code Quibble ran everything serially running first the fast tests (composer test) and finishing with the longest ones (PhpU" [integration/quibble] - 10https://gerrit.wikimedia.org/r/758783 (https://phabricator.wikimedia.org/T235449) (owner: 10Kosta Harlan) [13:41:38] (03Merged) 10jenkins-bot: ci-fullrun: Add extension variant [integration/quibble] - 10https://gerrit.wikimedia.org/r/757381 (owner: 10Kosta Harlan) [14:07:03] Change on 12www.mediawiki.org a page Continuous integration/Quibble was modified, changed by KHarlan (WMF) link https://www.mediawiki.org/w/index.php?diff=5051739 edit summary: [-6] /* Creating the release */ [14:08:16] hashar: what does this last part mean? "manually edit the Dockerfile.template for the primary Quibble image to specify the new version (as of 2022-02-02, this is for quibble-buster). That is done in the pip3 install command line." [14:19:16] (03CR) 10Awight: Parallelize phpunit -databaseless, -standalone and -database (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/758783 (https://phabricator.wikimedia.org/T235449) (owner: 10Kosta Harlan) [14:20:31] 10Quibble: Test that the first error cancels all other Parallel forks - https://phabricator.wikimedia.org/T300741 (10awight) [14:20:58] (03CR) 10Awight: Parallelize phpunit -databaseless, -standalone and -database (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/758783 (https://phabricator.wikimedia.org/T235449) (owner: 10Kosta Harlan) [14:29:22] (03CR) 10Kosta Harlan: Parallelize phpunit -databaseless, -standalone and -database (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/758783 (https://phabricator.wikimedia.org/T235449) (owner: 10Kosta Harlan) [14:48:32] hashar: did we talk about this task already, I can't remember T300742 [17:03:09] kostajh: yeah my bad sorry [17:03:21] we install quibble in the docker image by running pip3 against the git repository [17:03:28] and mention the version in the pip command line [17:03:47] dockerfiles/quibble-buster/Dockerfile.template:107: && pip3 install git+https://gerrit.wikimedia.org/r/p/integration/quibble.git@"1.3.0"#egg=quibble \ [17:07:03] kostajh: for docker-pkg I have no idea :\ [17:07:30] I probably haven't reinstalled it for a while [17:07:38] I found the solution :) [17:07:44] I’ll make a patch later maybe [17:10:56] great [17:10:59] should I cut the release ? [17:11:11] or do you want to pair on it tomorrow morning? [17:11:31] the longest being to remember the gpg key passphrase and writing the changelog.md :D [17:12:48] also I am not sure what happens if main cache is set to memcached when there is no memcached config defined [17:13:07] but we will find out eventually [19:25:30] hashar: go for it, if you'd like [19:26:02] the memcached change should be safe. it's only going to evaluate if the memcached extension is loaded, which it currently is not