[07:32:40] I am pushing 1.4.0 to the CI jenkins jobs [12:46:44] Ping me if my changes burst into flame :-) [13:48:16] looks like it worked well [14:52:17] awight: kostajh https://phabricator.wikimedia.org/T302226 :( [14:59:31] 10Quibble, 10ci-test-error (WMF-deployed Build Failure): Merges in mediawiki/core failing with "KeyError: 'server'" - https://phabricator.wikimedia.org/T302226 (10hashar) [15:00:06] Probably from the change to how the DB object is serialized for parallelizing [15:00:07] 10Quibble, 10ci-test-error (WMF-deployed Build Failure): Merges in mediawiki/core failing with "KeyError: 'server'" - https://phabricator.wikimedia.org/T302226 (10hashar) Looks like something is off with Quibble 1.4.0 when running some tasks in parallel :-\ [15:00:16] I am reverting it [15:00:21] It is probably a one line fix but revert is easier [15:00:30] I mean, I am rolling back the jenkins jobs to 1.3.0 [15:01:09] good, thanks [15:01:09] also I am wondering why we run in parallel phpunit, npm install and mediawiki installer :D [15:01:39] Because we can :P [15:02:02] anyway the failure on T302226 seems related to sqlite [15:02:13] but Ihaven't looked at a change to see which jobs were failing [15:03:10] oh the coverage job failed as well (it triggers at 16:00 CET) https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-master/1966/console [15:03:15] I will rebuild it [15:11:30] yeah i think it’s because that key doesn’t exist for SQLite backed. But it does for the other DB servers [15:11:52] Anyway it is parallelized because it can be, so it would speed up the build overall [15:47:43] 10Quibble, 10ci-test-error (WMF-deployed Build Failure): Merges in mediawiki/core failing with "KeyError: 'server'" - https://phabricator.wikimedia.org/T302226 (10hashar) p:05Unbreak!→03High I have rolled back the jobs. We will find out how to fix it in #quibble [15:55:31] (03Abandoned) 10Hashar: Support for ~/.config/quibble.ini [integration/quibble] - 10https://gerrit.wikimedia.org/r/735414 (https://phabricator.wikimedia.org/T238225) (owner: 10Hashar) [16:05:38] hashar: we should make a full run job for quibble CI that uses SQLite, probably [16:06:38] maybe [16:06:52] what I am wondering is why the sqlite backend fails when using parallel task [16:08:43] (03CR) 10Hashar: [C: 03+2] Remove Dockerfile [integration/quibble] - 10https://gerrit.wikimedia.org/r/757888 (owner: 10Kosta Harlan) [16:23:03] I think cause the “server” key exists for actual backend services (MySQL, Postgres) but not for SQLite which is just a file [16:24:18] then the server key has been around for a while? [16:24:47] AH no [16:25:07] that got added by the commit "Run post-dependency install, pre-test steps in parallel" [16:25:39] I don't even know what __getstate__() is :/ [16:40:13] right. We were passing in the entire DB object. But serializing it for parallel threads doesn’t work [16:41:21] ah yeah right [16:43:03] so that commit reworked to use a plain object with just key/value needed. But lazily didn’t check if ‘server’ actually existed before using it [16:45:13] (03CR) 10jerkins-bot: [V: 04-1] Remove Dockerfile [integration/quibble] - 10https://gerrit.wikimedia.org/r/757888 (owner: 10Kosta Harlan) [17:09:33] (03PS1) 10Kosta Harlan: backend: Check if key exists before deleting [integration/quibble] - 10https://gerrit.wikimedia.org/r/764419 (https://phabricator.wikimedia.org/T302226) [17:10:46] hashar: untested, but I think that should do it? Anyway I am going back to mostly-afk mode for the week. [17:18:39] (03CR) 10Kosta Harlan: [C: 03+2] "Per Antoine." [integration/quibble] - 10https://gerrit.wikimedia.org/r/757888 (owner: 10Kosta Harlan) [17:30:12] kostajh: thanks and happy afk! [17:31:05] (03CR) 10Hashar: [C: 03+2] backend: Check if key exists before deleting [integration/quibble] - 10https://gerrit.wikimedia.org/r/764419 (https://phabricator.wikimedia.org/T302226) (owner: 10Kosta Harlan) [17:31:34] +2ed your patch kostajh ! [17:56:02] (03CR) 10jerkins-bot: [V: 04-1] backend: Check if key exists before deleting [integration/quibble] - 10https://gerrit.wikimedia.org/r/764419 (https://phabricator.wikimedia.org/T302226) (owner: 10Kosta Harlan) [18:05:05] (03CR) 10jerkins-bot: [V: 04-1] Remove Dockerfile [integration/quibble] - 10https://gerrit.wikimedia.org/r/757888 (owner: 10Kosta Harlan) [18:21:42] the api test failures both have patches pending review. They just need to call runAllJobs() afaik [19:20:58] (03CR) 10Kosta Harlan: [C: 03+2] "per Antoine" [integration/quibble] - 10https://gerrit.wikimedia.org/r/764419 (https://phabricator.wikimedia.org/T302226) (owner: 10Kosta Harlan) [20:09:25] (03CR) 10jerkins-bot: [V: 04-1] backend: Check if key exists before deleting [integration/quibble] - 10https://gerrit.wikimedia.org/r/764419 (https://phabricator.wikimedia.org/T302226) (owner: 10Kosta Harlan) [20:10:15] (03CR) 10Kosta Harlan: [C: 03+2] "looks like I missed a few cases in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/761883" [integration/quibble] - 10https://gerrit.wikimedia.org/r/764419 (https://phabricator.wikimedia.org/T302226) (owner: 10Kosta Harlan) [20:52:25] (03CR) 10jerkins-bot: [V: 04-1] backend: Check if key exists before deleting [integration/quibble] - 10https://gerrit.wikimedia.org/r/764419 (https://phabricator.wikimedia.org/T302226) (owner: 10Kosta Harlan)