[09:59:02] 10Quibble, 10GrowthExperiments, 10Continuous-Integration-Config, 10Growth-Team (Current Sprint), and 3 others: api-testing tests break for GrowthExperiments - https://phabricator.wikimedia.org/T320935 (10kostajh) @hashar somehow QUIBBLE_APACHE environment variable isn't set in the api-testing context. We p... [10:09:01] (03PS1) 10Kosta Harlan: api-testing: Set QUIBBLE_APACHE flag [integration/quibble] - 10https://gerrit.wikimedia.org/r/843422 (https://phabricator.wikimedia.org/T320935) [10:10:35] (03PS2) 10Kosta Harlan: api-testing: Set QUIBBLE_APACHE flag [integration/quibble] - 10https://gerrit.wikimedia.org/r/843422 (https://phabricator.wikimedia.org/T320935) [10:14:11] (03CR) 10CI reject: [V: 04-1] api-testing: Set QUIBBLE_APACHE flag [integration/quibble] - 10https://gerrit.wikimedia.org/r/843422 (https://phabricator.wikimedia.org/T320935) (owner: 10Kosta Harlan) [10:16:01] 10Quibble, 10GrowthExperiments, 10Continuous-Integration-Config, 10Growth-Team (Current Sprint), and 3 others: api-testing tests break for GrowthExperiments - https://phabricator.wikimedia.org/T320935 (10kostajh) >>! In T320935#8320470, @gerritbot wrote: > Change 843421 had a related patch set uploaded (by... [10:19:14] (03PS3) 10Kosta Harlan: api-testing: Set QUIBBLE_APACHE flag [integration/quibble] - 10https://gerrit.wikimedia.org/r/843422 (https://phabricator.wikimedia.org/T320935) [10:20:43] (03PS1) 10Kosta Harlan: test_commands: Mark tset as broken on macOS [integration/quibble] - 10https://gerrit.wikimedia.org/r/843424 (https://phabricator.wikimedia.org/T318029) [10:21:43] kostajh: oh cause QUIBBLE_APACHE is only set for webdriver.io :] [10:21:53] 10Quibble, 10MediaWiki-extensions-ExternalData, 10Patch-For-Review, 10Release-Engineering-Team (Blocking 🧱), 10ci-test-error: Quibble fails with UnicodeDecodeError when test output has invalid unicode - https://phabricator.wikimedia.org/T318029 (10kostajh) >>! In T318029#8320495, @gerritbot wrote: > Chan... [10:22:05] hashar: yes but it is supposed to be set by the bash script... see my last comment in that task [10:22:05] we should set it whenever webdriver_env is external bah [10:22:25] (03PS2) 10Kosta Harlan: test_commands: Mark test as broken on macOS [integration/quibble] - 10https://gerrit.wikimedia.org/r/843424 (https://phabricator.wikimedia.org/T318029) [10:32:32] (03CR) 10Hashar: [C: 04-1] "That is one it did for quibble.commands.UserScripts in 53055780c4. It would need to set QUIBBLE_APACHE=1 as well ;)" [integration/quibble] - 10https://gerrit.wikimedia.org/r/843422 (https://phabricator.wikimedia.org/T320935) (owner: 10Kosta Harlan) [10:33:00] kostajh: you would need to set `QUIBBLE_APACHE=1` to `quibble.commands.UserScripts` [10:33:08] that can be made in a follow up change though [10:33:43] and maybe set them directly in _setup_environment which is applied to all stages [10:33:49] anyway, change looks good :-] [10:48:55] (03CR) 10CI reject: [V: 04-1] api-testing: Set QUIBBLE_APACHE flag [integration/quibble] - 10https://gerrit.wikimedia.org/r/843422 (https://phabricator.wikimedia.org/T320935) (owner: 10Kosta Harlan) [10:51:05] (03CR) 10CI reject: [V: 04-1] test_commands: Mark test as broken on macOS [integration/quibble] - 10https://gerrit.wikimedia.org/r/843424 (https://phabricator.wikimedia.org/T318029) (owner: 10Kosta Harlan) [11:51:12] 10Quibble, 10MediaWiki-extensions-ExternalData, 10Patch-For-Review, 10Release-Engineering-Team (Blocking 🧱), 10ci-test-error: Quibble fails with UnicodeDecodeError when test output has invalid unicode - https://phabricator.wikimedia.org/T318029 (10hashar) Oups. May you paste the output of the test with v... [12:09:54] 10Quibble, 10MediaWiki-extensions-WikibaseRepository: Wikibase\Repo\Tests\Hooks\OutputPageBeforeHTMLHookHandlerTest::testGivenExternallyRenderedMarkup_usesRespectivePlaceholderExpander Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiat... - https://phabricator.wikimedia.org/T320952 [12:10:12] 10Quibble, 10MediaWiki-extensions-WikibaseRepository: Wikibase\Repo\Tests\Hooks\OutputPageBeforeHTMLHookHandlerTest::testGivenExternallyRenderedMarkup_usesRespectivePlaceholderExpander Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiat... - https://phabricator.wikimedia.org/T320952 [13:01:31] 10Quibble, 10MediaWiki-extensions-ExternalData, 10Patch-For-Review, 10Release-Engineering-Team (Blocking 🧱), 10ci-test-error: Quibble fails with UnicodeDecodeError when test output has invalid unicode - https://phabricator.wikimedia.org/T318029 (10kostajh) >>! In T318029#8320787, @hashar wrote: > Oups. M... [13:49:27] 10Quibble, 10MediaWiki-extensions-ExternalData, 10Patch-For-Review, 10Release-Engineering-Team (Blocking 🧱), 10ci-test-error: Quibble fails with UnicodeDecodeError when test output has invalid unicode - https://phabricator.wikimedia.org/T318029 (10hashar) At least the `log.info` seems to be called: `Actu... [13:58:11] 10Quibble, 10MediaWiki-extensions-ExternalData, 10Patch-For-Review, 10Release-Engineering-Team (Blocking 🧱), 10ci-test-error: Quibble fails with UnicodeDecodeError when test output has invalid unicode - https://phabricator.wikimedia.org/T318029 (10kostajh) Oh, looking at T299840, it is because stdout is... [14:55:10] 10Quibble, 10MediaWiki-extensions-ExternalData, 10Patch-For-Review, 10Release-Engineering-Team (Blocking 🧱), 10ci-test-error: Quibble fails with UnicodeDecodeError when test output has invalid unicode - https://phabricator.wikimedia.org/T318029 (10hashar) Oops indeed that is the same issue well found ;) [14:58:30] 10Quibble: Quibble concurrent capture tests fail on MacOS - https://phabricator.wikimedia.org/T299840 (10hashar) [16:27:57] 10Quibble, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase\Repo\Tests\Hooks\OutputPageBeforeHTMLHookHandlerTest::testGivenExternallyRenderedMarkup_usesRespectivePlaceholderExpander Wikimedia\Services\RecursiveServiceDependencyException: Recursive ser... - https://phabricator.wikimedia.org/T320952 [16:36:19] 10Quibble, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10User-ItamarWMDE: Wikibase\Repo\Tests\Hooks\OutputPageBeforeHTMLHookHandlerTest::testGivenExternallyRenderedMarkup_usesRespectivePlaceholderExpander Wikimedia\Services\RecursiveServiceDependencyExce... - https://phabricator.wikimedia.org/T320952 [16:53:46] 10Quibble, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10User-ItamarWMDE: Wikibase\Repo\Tests\Hooks\OutputPageBeforeHTMLHookHandlerTest::testGivenExternallyRenderedMarkup_usesRespectivePlaceholderExpander Wikimedia\Services\Recursiv... - https://phabricator.wikimedia.org/T320952 [19:28:18] (03PS3) 10Kosta Harlan: test_commands: Mark test as broken on macOS [integration/quibble] - 10https://gerrit.wikimedia.org/r/843424 (https://phabricator.wikimedia.org/T299840) [19:34:34] kostajh: :) [19:34:35] 00:04:10.347 Wikimedia\Services\RecursiveServiceDependencyException: Recursive service instantiation: Circular dependency when creating service! UserOptionsLookup -> UserOptionsManager -> DBLoadBalancer -> DBLoadBalancerFactory -> UserNameUtils -> TitleParser -> _MediaWikiTitleCodec -> GenderCache -> DBLoadBalancer [19:34:40] that failure is "fun" [19:39:34] (03PS4) 10Kosta Harlan: api-testing: Set QUIBBLE_APACHE flag [integration/quibble] - 10https://gerrit.wikimedia.org/r/843422 (https://phabricator.wikimedia.org/T320935) [19:40:20] hashar: yep [19:43:05] (03CR) 10CI reject: [V: 04-1] api-testing: Set QUIBBLE_APACHE flag [integration/quibble] - 10https://gerrit.wikimedia.org/r/843422 (https://phabricator.wikimedia.org/T320935) (owner: 10Kosta Harlan) [19:59:36] blake / flake8 line length conflicts, more fun [20:03:26] kostajh: I think I encountered that once, even thoughtheorically black is set to use the same line #, it must fail in some case :-( [20:04:31] kostajh: ah yeah that is the same line I had the issue with [20:04:44] and why I had `# fmt: skip` added to it [20:12:22] will be back tomorrow