[08:10:45] (03CR) 10Hashar: [C: 03+2] black: Apply formatting fixes [integration/quibble] - 10https://gerrit.wikimedia.org/r/890415 (owner: 10Kosta Harlan) [08:38:28] (03Merged) 10jenkins-bot: black: Apply formatting fixes [integration/quibble] - 10https://gerrit.wikimedia.org/r/890415 (owner: 10Kosta Harlan) [11:08:46] (03PS1) 10Kosta Harlan: black: Pin major version for black [integration/quibble] - 10https://gerrit.wikimedia.org/r/890791 [11:32:38] (03CR) 10Hashar: [C: 03+2] black: Pin major version for black [integration/quibble] - 10https://gerrit.wikimedia.org/r/890791 (owner: 10Kosta Harlan) [11:40:34] kostajh: I think the last thing is `requests.post` does not have a timeout by default so I think it will keep idling if the destination is unreachable [11:41:10] hashar: ok, let me see about that [11:41:13] or maybe not [11:41:28] from a dumb try here, if the other side refuses the connection an exception is thrown [11:41:59] I will +2 it when you give a go ;) [11:42:09] might be worth adding some documentation but that can be done later [11:42:20] and I think I will then cut 1.5.0 [11:43:19] or maybe you want to test a bit more? [11:43:56] hashar: I think it is good to go [11:44:00] I can add the timeout if you want [11:45:25] in Jenkins, we need to set QUIBBLE_API_KEY and I need to update my bot on toolforge to use that value [11:48:31] (03PS25) 10Kosta Harlan: Allow sending build failure data to external endpoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/866376 (https://phabricator.wikimedia.org/T323750) [11:48:33] (03PS21) 10Kosta Harlan: CI: Add reporting URL for ci-fullrun [integration/quibble] - 10https://gerrit.wikimedia.org/r/866596 [11:56:06] yeah 5 seconds sound great [11:56:18] (03CR) 10Hashar: [C: 03+2] "LETS GOOOOO!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/866376 (https://phabricator.wikimedia.org/T323750) (owner: 10Kosta Harlan) [11:56:40] so I guess I should cut 1.5.0 from that one right? [11:56:58] the following change "CI: Add reporting URL for ci-fullrun" being merely for the integration tests [11:57:05] so I think: [11:57:13] 1) cut 1.5.0 with changelog etc [11:57:21] 2) rebuild Docker images and switch jobs [11:57:40] 3) `recheck` that "CI: Add reporting URL for ci-fullrun" [11:57:44] 4) update all the other jobs [12:00:25] I think "CI: Add reporting URL for ci-fullrun" probably doesn't need to be merged, because that is a special case somewhat... [12:00:32] but yes, cut 1.5.0 is a first step [12:00:53] then we need `QUIBBLE_API_KEY` and to update jjb config to point to https://earlywarningbot.toolforge.org [12:08:38] I guess we will add the key as a jenkins credential and have it injected in the job [12:08:49] (03Merged) 10jenkins-bot: black: Pin major version for black [integration/quibble] - 10https://gerrit.wikimedia.org/r/890791 (owner: 10Kosta Harlan) [12:08:57] yes, similar to the codehealth job [12:08:58] given it is not too complicated to retrieve it from a job (just dump the environment variables) [12:17:32] (03CR) 10CI reject: [V: 04-1] CI: Add reporting URL for ci-fullrun [integration/quibble] - 10https://gerrit.wikimedia.org/r/866596 (owner: 10Kosta Harlan) [12:27:35] (03Merged) 10jenkins-bot: Allow sending build failure data to external endpoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/866376 (https://phabricator.wikimedia.org/T323750) (owner: 10Kosta Harlan) [12:53:47] (03PS1) 10Kosta Harlan: release: Quibble 1.5.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/890809 (https://phabricator.wikimedia.org/T323750) [12:54:15] (03Abandoned) 10Kosta Harlan: CI: Add reporting URL for ci-fullrun [integration/quibble] - 10https://gerrit.wikimedia.org/r/866596 (owner: 10Kosta Harlan) [12:58:26] (03PS2) 10Hashar: release: Quibble 1.5.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/890809 (https://phabricator.wikimedia.org/T323750) (owner: 10Kosta Harlan) [12:58:53] kostajh: I have removed the entry for `master` frmo the changelog https://gerrit.wikimedia.org/r/c/integration/quibble/+/890809/1..2/CHANGELOG.rst [12:59:11] (03CR) 10Hashar: [C: 03+2] release: Quibble 1.5.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/890809 (https://phabricator.wikimedia.org/T323750) (owner: 10Kosta Harlan) [12:59:20] I am out for lunch [13:09:42] (03PS1) 10Kosta Harlan: release: Start 1.5.1 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/890813 [13:09:42] ty [13:25:57] (03CR) 10Hashar: [C: 03+2] release: Start 1.5.1 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/890813 (owner: 10Kosta Harlan) [13:26:16] I am preparing and eating lunch faster than Quibble can run all those tests :D [13:28:53] (03Merged) 10jenkins-bot: release: Quibble 1.5.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/890809 (https://phabricator.wikimedia.org/T323750) (owner: 10Kosta Harlan) [13:33:45] kostajh: do you want to do the signed tag or should I? [13:35:18] bah my key has expired again [13:39:01] hashar: um, I can try to do it, if I remember how [13:39:18] oh, it's in RELEASING.rst [13:39:22] it is all documented in RELEASING.rst [13:39:23] yeah ;) [13:39:35] just have to make sure to sign the proper commit! [13:40:27] hashar: what is the tag message supposed to be? [13:40:55] `Signed 1.5.0 release` is what I have been using since start [13:40:58] for lack of a better idea ;) [13:41:00] ok [13:41:21] I am crafting the Docker images update [13:41:38] hashar: ok, pushed [13:41:46] hopefully I did that correctly :D [13:42:30] looks legit ;) [13:46:24] remote: https://gerrit.wikimedia.org/r/c/integration/config/+/890817 dockerfiles: update to Quibble 1.5.0 [NEW] [13:48:37] (03PS1) 10Kosta Harlan: releasing: Clarify the message to use with the git tag [integration/quibble] - 10https://gerrit.wikimedia.org/r/890818 [13:49:33] (03CR) 10Hashar: [C: 03+2] releasing: Clarify the message to use with the git tag [integration/quibble] - 10https://gerrit.wikimedia.org/r/890818 (owner: 10Kosta Harlan) [13:50:08] that is even included in the Sphinx doc and thus ends up published at https://doc.wikimedia.org/quibble/releasing.html ! [13:53:02] (03PS1) 10Kosta Harlan: releasing: Make git tagging less prone to typos [integration/quibble] - 10https://gerrit.wikimedia.org/r/890821 [13:57:52] (03Merged) 10jenkins-bot: release: Start 1.5.1 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/890813 (owner: 10Kosta Harlan) [14:20:05] (03Merged) 10jenkins-bot: releasing: Clarify the message to use with the git tag [integration/quibble] - 10https://gerrit.wikimedia.org/r/890818 (owner: 10Kosta Harlan) [14:46:16] (03PS2) 10Hashar: releasing: Make git tagging less prone to typos [integration/quibble] - 10https://gerrit.wikimedia.org/r/890821 (owner: 10Kosta Harlan) [14:46:23] (03CR) 10Hashar: [C: 03+2] releasing: Make git tagging less prone to typos [integration/quibble] - 10https://gerrit.wikimedia.org/r/890821 (owner: 10Kosta Harlan) [14:46:53] kostajh: the integration-quibble* jobs have been switched and there is a patch going through CI [14:47:17] (03CR) 10CI reject: [V: 04-1] releasing: Make git tagging less prone to typos [integration/quibble] - 10https://gerrit.wikimedia.org/r/890821 (owner: 10Kosta Harlan) [14:47:36] that one is me [15:12:53] kostajh: looks like now we can setup the `QUIBBLE_API_KEY` [15:16:45] (03Merged) 10jenkins-bot: releasing: Make git tagging less prone to typos [integration/quibble] - 10https://gerrit.wikimedia.org/r/890821 (owner: 10Kosta Harlan) [15:24:55] I am off for a while [15:49:34] cool, thanks [15:52:08] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity: Provide early feedback when a patch has job failures - https://phabricator.wikimedia.org/T323750 (10kostajh) Next step is to create `QUIBBLE_API_KEY` for use with quibble jobs (similar to `SONAR_API_KEY`) and I can add it to the co... [16:39:47] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity: Provide early feedback when a patch has job failures - https://phabricator.wikimedia.org/T323750 (10hashar) We can store the key in Jenkins credentials store then inject it as `QUIBBLE_API_KEY` in the Quibble jobs using the Credent... [21:39:43] 10Quibble, 10Patch-Needs-Improvement: [Clean-up] Finish encapsulating Quibble pipeline - https://phabricator.wikimedia.org/T249775 (10Aklapper)