[07:57:39] kostajh: yeah I don't think it is any easily achievable [07:58:21] if it is causing issue in practice, it can be revisisted [07:58:58] given the bot is not intended to prevent a change from being merged, it should not even vote verified - 1 [07:59:49] since it is about raising awareness, we could make it to vote another label which would not block voting [08:00:18] and alternatveliy, I have some experimental code which show up the status of the change from the Zuul status page [09:24:41] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity: Provide early feedback when a patch has job failures - https://phabricator.wikimedia.org/T323750 (10hashar) a:03kostajh [09:25:58] 10Quibble, 10Continuous-Integration-Config: Update quibble jobs to run maintenance scripts via maintenance/run.php - https://phabricator.wikimedia.org/T326333 (10hashar) 05Open→03Resolved Quibble 1.5.0 uses `maintenance/run.php` when it exists (else fallback to directly invoke the requested PHP script). It... [09:27:45] 10Quibble, 10Growth-Team, 10GrowthExperiments, 10ci-test-error: Quibble build fails with Error: Class 'Doctrine\Common\Annotations\Annotation' not found - https://phabricator.wikimedia.org/T321795 (10hashar) 05Open→03Resolved a:03hashar The issue has not been fixed cause we haven't found the root cau... [10:38:57] hashar: yeah I think a custom label would be good, maybe something like "All jobs pass" which the bot could vote with -1 on https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_custom [10:40:27] and if we configure that labels to not be blocking merges, I think that will work, still giving feedback to the users though [10:40:44] gotta be configured somewhere in mediawiki.git refs/meta/config [10:41:33] https://gerrit.wikimedia.org/r/Documentation/config-labels.html#label_custom [10:44:26] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity: Create customized Gerrit label for "All-Jobs-Passed" - https://phabricator.wikimedia.org/T330741 (10kostajh) [10:44:49] hashar: ^ T330741 [10:50:34] although, I think it would be confusing to have a new label appear on all changes in Gerrit... [10:51:13] I think it could be sufficient to tell people to manually remove "Verified" if they are running "recheck". [10:55:28] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity: Provide early feedback when a patch has job failures - https://phabricator.wikimedia.org/T323750 (10kostajh) [10:56:02] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10Patch-For-Review: Create customized Gerrit label for "All-Jobs-Passed" - https://phabricator.wikimedia.org/T330741 (10kostajh) 05Open→03Declined On second thought, it would be confusing to have this label always display, ev... [13:27:39] 10Quibble, 10Developer Productivity: earlywarningbot: Provide instructions for "recheck" - https://phabricator.wikimedia.org/T330749 (10kostajh) [13:31:13] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity: Quibble: Include the failed command in data passed to external endpoint - https://phabricator.wikimedia.org/T330750 (10kostajh) [14:38:08] kostajh: yeah I don't know about the new label to be fair :-\ [14:38:30] maybe the bot can Code-Review +1 / -1 instead? [14:38:54] this way that does not interfere with the submit requirements [14:39:09] and I should be able to make the EarlyWarning bot stand out in the Checks UI [14:39:27] aka if the bot voted -1 add a warning to the list of Checks [14:39:40] given if some job failed, surely Zuul / jenkins-bot will end up voting Verified -1 anyway [14:40:07] the new label might be a solution, but I am not entirely sure about the mess it could cause :-\ [14:56:53] yeah, I don't think we should add a new label [14:57:15] and using Code-Review label doesn't seem right either. [14:58:09] with Fix Suggester Bot, I subscribed to the stream of Gerrit events, I could do something similar and filter just for comments with "recheck" and then it is fairly easy to see if there is a Verified -1 vote from the bot on that particular patch, and if so, remove it. but again, more work [15:51:20] so IMO the easiest thing is T330749 [16:24:41] (03PS1) 10Kosta Harlan: reporting: Include CalledProcessError.cmd in payload [integration/quibble] - 10https://gerrit.wikimedia.org/r/893016 (https://phabricator.wikimedia.org/T330750) [16:26:45] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10Patch-For-Review: Quibble: Include the failed command in data passed to external endpoint - https://phabricator.wikimedia.org/T330750 (10kostajh) a:03kostajh [16:28:18] (03CR) 10CI reject: [V: 04-1] reporting: Include CalledProcessError.cmd in payload [integration/quibble] - 10https://gerrit.wikimedia.org/r/893016 (https://phabricator.wikimedia.org/T330750) (owner: 10Kosta Harlan) [18:35:51] (03PS2) 10Kosta Harlan: reporting: Include CalledProcessError.cmd in payload [integration/quibble] - 10https://gerrit.wikimedia.org/r/893016 (https://phabricator.wikimedia.org/T330750) [18:39:27] (03CR) 10CI reject: [V: 04-1] reporting: Include CalledProcessError.cmd in payload [integration/quibble] - 10https://gerrit.wikimedia.org/r/893016 (https://phabricator.wikimedia.org/T330750) (owner: 10Kosta Harlan) [19:26:53] 10Quibble, 10Code-Review-Workgroup, 10Continuous-Integration-Infrastructure, 10Quality-and-Test-Engineering-Team (QTE) (Test engineering): Lightweight preview environment for gerrit changes - https://phabricator.wikimedia.org/T241140 (10TAdeleye_WMF)