[08:22:05] kostajh: morning, I want ahead and did the javascript bit to integrate EarlyWarning bot in the Gerrit check ui [08:22:13] https://phabricator.wikimedia.org/T330850#8664535 has a screenshot [08:22:44] it always flag the report as an ERROR and merely show the whole Gerrit message. That is probably good enough for a first step [08:23:08] if that sounds more or less correct, I will roll it in 40 minutes while upgrading Gerrit (from 3.5.4 to 3.5.5) [08:26:37] hashar: that looks OK, but the "Verified +2" label looks confusing next to "A Zuul job already failed". But better to have something rather than nothing [08:27:18] does the JS code handle situations where multiple jobs fail (and thus multiple early warning bot comments) ? [08:31:43] good question :) [08:32:25] I think I will repeat [ EarlyWarning | A Zuul job already failed ] [08:32:30] s/I/it will/ [08:33:01] maybe the bot can skip commenting if it already reported? (aka a given change/patchset already has a cr-1 by EarlyWarning) [08:56:41] I will hold that patch [08:56:42] ;) [08:58:30] yeah, not sure... I think it is useful to know that e.g. both `composer test` and `npm test` failed [08:59:22] hashar: ICYMI, I unpublished the blog post, we need to deploy https://gerrit.wikimedia.org/r/c/integration/quibble/+/894213 before promoting this bot more widely, I think [08:59:38] https://gerrit.wikimedia.org/r/c/integration/quibble/+/894216 would also be nice. sorry for all the trouble! [09:00:15] no worries :] [09:22:09] (03CR) 10Hashar: [C: 03+2] reporting: Include `pipeline` in payload [integration/quibble] - 10https://gerrit.wikimedia.org/r/894213 (https://phabricator.wikimedia.org/T331236) (owner: 10Urbanecm) [09:26:01] (03CR) 10Hashar: [C: 03+2] reporting: Command name can be a string (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/894216 (https://phabricator.wikimedia.org/T323750) (owner: 10Kosta Harlan) [09:26:21] done :D [09:26:45] a note for later, when joining commands you want to use `import shlex; shlex.join(['echo', 'hello world'])` [09:27:09] which quotes args having a space: `echo 'hello world'` [09:27:13] but it does not matterhere [09:27:24] that can be enhanced later :] [09:27:28] so I have +2ed it [09:27:40] I think the patches will conflict due to the CHANGELOG entries [09:30:39] (03PS3) 10Hashar: reporting: Command name can be a string [integration/quibble] - 10https://gerrit.wikimedia.org/r/894216 (https://phabricator.wikimedia.org/T323750) (owner: 10Kosta Harlan) [09:31:01] (03CR) 10Hashar: [C: 03+2] "rebased to fix conflict with https://gerrit.wikimedia.org/r/c/integration/quibble/+/894213/" [integration/quibble] - 10https://gerrit.wikimedia.org/r/894216 (https://phabricator.wikimedia.org/T323750) (owner: 10Kosta Harlan) [09:48:01] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10Patch-For-Review, 10User-Urbanecm: Exclude certain jobs from early feedback - https://phabricator.wikimedia.org/T331236 (10kostajh) a:03Urbanecm This will be resolved with the deployment of Quibble 1.5.2. Thank you @Urbanecm! [09:53:21] (03Merged) 10jenkins-bot: reporting: Include `pipeline` in payload [integration/quibble] - 10https://gerrit.wikimedia.org/r/894213 (https://phabricator.wikimedia.org/T331236) (owner: 10Urbanecm) [09:58:02] noted [10:01:30] (03PS1) 10Kosta Harlan: release: Quibble 1.5.2 [integration/quibble] - 10https://gerrit.wikimedia.org/r/894535 (https://phabricator.wikimedia.org/T331236) [10:01:48] (03Merged) 10jenkins-bot: reporting: Command name can be a string [integration/quibble] - 10https://gerrit.wikimedia.org/r/894216 (https://phabricator.wikimedia.org/T323750) (owner: 10Kosta Harlan) [10:01:59] (03PS1) 10Kosta Harlan: release: Start 1.5.3 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/894536 [10:07:17] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10Patch-For-Review: Exclude certain jobs from early feedback - https://phabricator.wikimedia.org/T331236 (10Urbanecm_WMF) a:05Urbanecm→03Urbanecm_WMF [10:11:46] I was going to file a task about excluding duplicate messages (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/894506/1#message-abb101a6bf9c169f5e30d7e0195999336109c2c3) but I think it is probably better to keep it as is. That said, do we need to run "npm test/composer test" for both wmf-quibble-vendor-mysql-php74-docker and quibble-vendor-mysql-php74-noselenium-docker? [10:18:28] (03CR) 10Hashar: [C: 03+2] release: Quibble 1.5.2 [integration/quibble] - 10https://gerrit.wikimedia.org/r/894535 (https://phabricator.wikimedia.org/T331236) (owner: 10Kosta Harlan) [10:18:39] (03CR) 10Hashar: [C: 03+2] release: Start 1.5.3 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/894536 (owner: 10Kosta Harlan) [10:33:18] (03CR) 10CI reject: [V: 04-1] release: Quibble 1.5.2 [integration/quibble] - 10https://gerrit.wikimedia.org/r/894535 (https://phabricator.wikimedia.org/T331236) (owner: 10Kosta Harlan) [10:40:54] (03CR) 10Kosta Harlan: [C: 03+2] "Per hashar" [integration/quibble] - 10https://gerrit.wikimedia.org/r/894535 (https://phabricator.wikimedia.org/T331236) (owner: 10Kosta Harlan) [10:42:14] (03CR) 10CI reject: [V: 04-1] release: Start 1.5.3 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/894536 (owner: 10Kosta Harlan) [10:53:11] (03CR) 10Hashar: [C: 03+2] release: Quibble 1.5.2 [integration/quibble] - 10https://gerrit.wikimedia.org/r/894535 (https://phabricator.wikimedia.org/T331236) (owner: 10Kosta Harlan) [10:53:23] (03CR) 10Hashar: [C: 03+2] release: Start 1.5.3 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/894536 (owner: 10Kosta Harlan) [11:23:54] (03Merged) 10jenkins-bot: release: Quibble 1.5.2 [integration/quibble] - 10https://gerrit.wikimedia.org/r/894535 (https://phabricator.wikimedia.org/T331236) (owner: 10Kosta Harlan) [11:27:51] (03Merged) 10jenkins-bot: release: Start 1.5.3 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/894536 (owner: 10Kosta Harlan) [12:40:33] !log Updating Jenkins jobs to Quibble 1.5.2 [12:41:58] wrong channel [13:10:13] danke [14:01:18] seems to work well, so far [14:36:03] awesome :)