[08:41:57] (03CR) 10Hashar: env: Export MW_QUIBBLE_CI (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/896084 (https://phabricator.wikimedia.org/T331621) (owner: 10Kosta Harlan) [08:42:12] (03PS7) 10Hashar: env: Export MW_QUIBBLE_CI [integration/quibble] - 10https://gerrit.wikimedia.org/r/896084 (https://phabricator.wikimedia.org/T331621) (owner: 10Kosta Harlan) [08:42:22] (03CR) 10Hashar: [C: 03+2] env: Export MW_QUIBBLE_CI [integration/quibble] - 10https://gerrit.wikimedia.org/r/896084 (https://phabricator.wikimedia.org/T331621) (owner: 10Kosta Harlan) [08:42:58] (03CR) 10Hashar: [C: 03+2] env: Export MW_QUIBBLE_CI (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/896084 (https://phabricator.wikimedia.org/T331621) (owner: 10Kosta Harlan) [08:54:31] (03CR) 10Kosta Harlan: env: Export MW_QUIBBLE_CI (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/896084 (https://phabricator.wikimedia.org/T331621) (owner: 10Kosta Harlan) [09:10:50] (03CR) 10CI reject: [V: 04-1] env: Export MW_QUIBBLE_CI [integration/quibble] - 10https://gerrit.wikimedia.org/r/896084 (https://phabricator.wikimedia.org/T331621) (owner: 10Kosta Harlan) [09:21:25] (03CR) 10Hashar: [C: 03+2] "CI fails because of some ParserIntegrationTest tests :-\ I will reach out to #content-transformers team." [integration/quibble] - 10https://gerrit.wikimedia.org/r/896084 (https://phabricator.wikimedia.org/T331621) (owner: 10Kosta Harlan) [09:50:32] (03CR) 10CI reject: [V: 04-1] env: Export MW_QUIBBLE_CI [integration/quibble] - 10https://gerrit.wikimedia.org/r/896084 (https://phabricator.wikimedia.org/T331621) (owner: 10Kosta Harlan) [09:54:20] (03PS12) 10Kosta Harlan: [WIP] commands: Replace subprocess.check_call with subprocess.Popen [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) [09:54:46] (03PS13) 10Kosta Harlan: [WIP] commands: Replace subprocess.check_call with subprocess.Popen [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) [09:57:11] (03CR) 10CI reject: [V: 04-1] [WIP] commands: Replace subprocess.check_call with subprocess.Popen [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [10:17:26] hashar: oof, are we gonna need to do something like https://blog.samuel.domains/blog/programming/how-to-mock-stdout-runtime-attribute-of-subprocess-popen-python ? :( [10:22:30] maybe we could use the testfixtures library https://stackoverflow.com/a/58114850 [10:27:39] (03PS1) 10Hashar: (DO NOT SUBMIT) test with parsoid v0.17.0-a20 [integration/quibble] - 10https://gerrit.wikimedia.org/r/897838 [10:27:47] so well parsoid is broken for som ereason [10:28:02] I have investigated a bit with Isabelle but we eventually gave up cause it only affects quibble as far as I can tell [10:28:10] C. Scott would know for sure ;) [10:28:29] I have tried pinning parsoid using the latest tag but I don't think it is going to work [10:30:22] for mocking, I don't know. I have to revisit the experiment I have made last friday :] [10:50:29] ok [10:51:39] what do you think about renaming the early warning bot to quibble-bot? I don't know if it will be more or less confusing to developers to see comments from "Quibble Bot" with the build failure messages and output [10:55:04] (03CR) 10CI reject: [V: 04-1] (DO NOT SUBMIT) test with parsoid v0.17.0-a20 [integration/quibble] - 10https://gerrit.wikimedia.org/r/897838 (owner: 10Hashar) [10:56:37] (03Abandoned) 10Hashar: (DO NOT SUBMIT) test with parsoid v0.17.0-a20 [integration/quibble] - 10https://gerrit.wikimedia.org/r/897838 (owner: 10Hashar) [12:57:03] 10Quibble, 10Parsoid, 10ci-test-error: CI Parser tests fail on integration/quibble - https://phabricator.wikimedia.org/T331871 (10hashar) [13:04:50] 10Quibble, 10Parsoid, 10ci-test-error: CI Parser tests fail on integration/quibble - https://phabricator.wikimedia.org/T331871 (10cscott) Probably caused by the merge of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/891358 at 03:40 Mar 13. [13:12:14] 10Quibble, 10Parsoid, 10ci-test-error: CI Parser tests fail on integration/quibble - https://phabricator.wikimedia.org/T331871 (10hashar) I went to do a diff between there two builds, they both have parsoid at 26a03541b821deb8746da87a4db32acdde289039 `mediawiki/vendor` is different though: | Good | 888dc9d... [13:16:20] 10Quibble, 10Parsoid, 10ci-test-error: CI Parser tests fail on integration/quibble - https://phabricator.wikimedia.org/T331871 (10cscott) Ah, the 891358 patch should have been listed as depending on https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/888116 -- I'd never tested them in isolation and... [13:53:49] (03PS1) 10Hashar: (DO NOT SUBMIT) tests with patched Parsoid [integration/quibble] - 10https://gerrit.wikimedia.org/r/897884 (https://phabricator.wikimedia.org/T331871) [14:30:05] (03Abandoned) 10Hashar: (DO NOT SUBMIT) tests with patched Parsoid [integration/quibble] - 10https://gerrit.wikimedia.org/r/897884 (https://phabricator.wikimedia.org/T331871) (owner: 10Hashar) [14:30:29] the CI build failure is being addressed via https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/897879 [14:30:31] which got a +2 :) [14:35:50] (03CR) 10Hashar: [C: 03+2] "+2 again after https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/897879 / T331871" [integration/quibble] - 10https://gerrit.wikimedia.org/r/896084 (https://phabricator.wikimedia.org/T331621) (owner: 10Kosta Harlan) [14:37:40] 10Quibble, 10Parsoid, 10Patch-For-Review, 10ci-test-error: CI Parser tests fail on integration/quibble - https://phabricator.wikimedia.org/T331871 (10hashar) a:03cscott I have confirmed the fix via https://gerrit.wikimedia.org/r/c/integration/quibble/+/897884/ which depended on the pending change for Par... [14:38:10] 10Quibble, 10Parsoid, 10Patch-For-Review, 10ci-test-error: CI Parser tests fail on integration/quibble - https://phabricator.wikimedia.org/T331871 (10hashar) 05Open→03Resolved [15:08:36] (03Merged) 10jenkins-bot: env: Export MW_QUIBBLE_CI [integration/quibble] - 10https://gerrit.wikimedia.org/r/896084 (https://phabricator.wikimedia.org/T331621) (owner: 10Kosta Harlan) [15:57:57] nice work [16:13:50] I am afraid the subprocess capturing will have to wait tomorrow [16:14:00] Tyler told me earlier today scap might have a similar system already [17:46:31] no worries [18:24:39] https://gitlab.wikimedia.org/repos/releng/scap/-/blob/master/scap/runcmd.py, i guess?