[06:16:50] possibly, then that code does capture outputs, but it doesn not stream them to the console [08:25:03] (03CR) 10Hashar: "Marking old comments of mine as solved since a solution has been found ;)" [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [08:31:33] I am going to investigate the unit tests failures [09:31:52] (03CR) 10Hashar: "I found the unit test failures! They still mock `subprocess.Popen` when they should mock `quibble.commands.run`. I am slowly progressing " [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [09:59:00] aha [09:59:04] well found hashar [09:59:49] when you say you are progressing through each of them, do you mean you'll push an update to the patch, or do you want me to do that? (either is fine by me) [10:04:01] I got them all addressed :) [10:04:27] I will add a test to ensure quibble.commands.run manages invalid unicode [10:04:39] but I am in a call with daniel this morning then will have lunch with my kid [10:11:49] nice, thank you [11:00:51] (03PS14) 10Hashar: commands: wrap subprocess in order to capture output [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [11:00:52] DONE! :) [11:01:17] mocking quibble.commands.run to assert it is passed the proper arg simplify the tests :) [11:01:35] previously you have renamed mock_check_call to mock_run but it was still mocking subprocess.Popen [11:01:58] which forced to add shell=True, stdout=subprocess.pipe to all call assertions [11:02:02] that is no more needed :] [11:02:27] test_run_handles_invalid_unicode line 710 ish covers the feature [11:02:43] with the exception of a command emitting to stderr, but I got lazy ;) [11:04:17] (03CR) 10Hashar: commands: wrap subprocess in order to capture output (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [11:04:21] lunch & [11:11:34] (03CR) 10Kosta Harlan: commands: wrap subprocess in order to capture output (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [11:21:29] nice [11:22:36] (03CR) 10Kosta Harlan: commands: wrap subprocess in order to capture output (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [12:19:49] (03CR) 10Hashar: commands: wrap subprocess in order to capture output (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [12:19:53] (03PS15) 10Hashar: commands: wrap subprocess in order to capture output [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [12:20:14] kostajh: amended and that is ready to go imho :) [12:20:48] (03CR) 10Kosta Harlan: [C: 03+1] commands: wrap subprocess in order to capture output [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [12:20:58] hashar: nice! want me to +2 or will you? [12:21:06] we can do it both :) [12:21:28] (03CR) 10Hashar: [C: 03+2] commands: wrap subprocess in order to capture output [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [12:21:36] I am quite happy about my hack :] [12:21:41] then really [12:22:01] (03CR) 10Kosta Harlan: [C: 03+2] "\o/" [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [12:22:03] we should investigate at having the various test commands to emit machine friendly reports [12:22:05] (03Abandoned) 10Kosta Harlan: DNM: CI test [integration/quibble] - 10https://gerrit.wikimedia.org/r/896018 (owner: 10Kosta Harlan) [12:22:16] (03Restored) 10Kosta Harlan: DNM: CI test [integration/quibble] - 10https://gerrit.wikimedia.org/r/896018 (owner: 10Kosta Harlan) [12:22:20] (03PS7) 10Kosta Harlan: DNM: CI test [integration/quibble] - 10https://gerrit.wikimedia.org/r/896018 [12:43:58] (03CR) 10CI reject: [V: 04-1] commands: wrap subprocess in order to capture output [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [12:44:20] (03CR) 10CI reject: [V: 04-1] DNM: CI test [integration/quibble] - 10https://gerrit.wikimedia.org/r/896018 (owner: 10Kosta Harlan) [12:45:19] (03CR) 10Kosta Harlan: "LGTM, error output is present in the logs https://integration.wikimedia.org/ci/job/integration-quibble-fullrun-defaults/34/console" [integration/quibble] - 10https://gerrit.wikimedia.org/r/896018 (owner: 10Kosta Harlan) [12:45:23] (03Abandoned) 10Kosta Harlan: DNM: CI test [integration/quibble] - 10https://gerrit.wikimedia.org/r/896018 (owner: 10Kosta Harlan) [12:45:51] (03CR) 10Kosta Harlan: [C: 03+2] "sigh. Flaky Selenium test." [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [12:48:46] hashar: I had a quick look at that... for phpunit we can use e.g. --log-file=output.xml. [12:52:47] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity: Quibble: Include the failed command in data passed to external endpoint - https://phabricator.wikimedia.org/T330750 (10kostajh) 05Open→03Resolved [12:52:51] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10MW-1.40-notes (1.40.0-wmf.26; 2023-03-06): Provide early feedback when a patch has job failures - https://phabricator.wikimedia.org/T323750 (10kostajh) [12:53:04] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity: Exclude certain jobs from early feedback - https://phabricator.wikimedia.org/T331236 (10kostajh) 05Open→03Resolved [12:53:06] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity, 10MW-1.40-notes (1.40.0-wmf.26; 2023-03-06): Provide early feedback when a patch has job failures - https://phabricator.wikimedia.org/T323750 (10kostajh) [12:55:41] 10Quibble, 10Continuous-Integration-Infrastructure, 10Developer Productivity: Quibble: Generate structured output for command success/failures - https://phabricator.wikimedia.org/T331996 (10kostajh) [12:55:49] ^ hashar [13:10:31] yeah [13:11:30] which I think mean https://phabricator.wikimedia.org/T299257 can be closed :) [13:11:53] grr wrong window [13:14:26] (03Merged) 10jenkins-bot: commands: wrap subprocess in order to capture output [integration/quibble] - 10https://gerrit.wikimedia.org/r/895854 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [13:38:06] (03PS9) 10Kosta Harlan: release: Quibble 1.5.3 [integration/quibble] - 10https://gerrit.wikimedia.org/r/896061 (https://phabricator.wikimedia.org/T331061) [13:38:51] (03PS10) 10Kosta Harlan: release: Quibble 1.5.3 [integration/quibble] - 10https://gerrit.wikimedia.org/r/896061 (https://phabricator.wikimedia.org/T331061) [13:39:02] (03CR) 10Kosta Harlan: [C: 03+1] release: Quibble 1.5.3 [integration/quibble] - 10https://gerrit.wikimedia.org/r/896061 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [13:39:07] (03PS9) 10Kosta Harlan: release: Start 1.5.4 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/896062 [13:48:03] (03CR) 10Hashar: [C: 03+2] release: Quibble 1.5.3 [integration/quibble] - 10https://gerrit.wikimedia.org/r/896061 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [13:48:11] (03CR) 10Hashar: [C: 03+2] release: Start 1.5.4 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/896062 (owner: 10Kosta Harlan) [13:52:14] hashar: probably doesn't matter that much, but should it be quibble 1.6.0 since there is a new feature? [13:59:17] or it is bug fixing earlywarning bot :) [13:59:27] I dont' think it matters most [14:01:12] yeah its' fine [14:18:55] (03Merged) 10jenkins-bot: release: Quibble 1.5.3 [integration/quibble] - 10https://gerrit.wikimedia.org/r/896061 (https://phabricator.wikimedia.org/T331061) (owner: 10Kosta Harlan) [14:18:59] (03Merged) 10jenkins-bot: release: Start 1.5.4 cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/896062 (owner: 10Kosta Harlan) [16:38:51] ah it merged [17:21:47] hashar: I am sort of around this evening if you want to roll it out, else we could try tomorrow morning?