[00:00:09] (03CR) 10CI reject: [V: 04-1] Use AutoLoader::registerNamespaces [integration/quibble] - 10https://gerrit.wikimedia.org/r/902517 (owner: 10Arlolra) [00:28:04] (03CR) 10Jforrester: [C: 03+1] "Failure is unrelated (due to GrowthExperiments using a novel node feature that quibble's image doesn't support; don't worry about it for t" [integration/quibble] - 10https://gerrit.wikimedia.org/r/902517 (owner: 10Arlolra) [04:54:40] kostajh: somehow the CI for Quibble fails at https://integration.wikimedia.org/ci/job/integration-quibble-fullrun-extensions/334/console [04:54:48] cause of 23:44:26 Error: Cannot find module 'node:fs' [04:55:13] which indicate that somehow code requiring nodejs 16 got introduced in GrowthExperiments and somehow manage to pass through CI running nodejs 14? [05:04:42] (03CR) 10Hashar: [C: 04-1] "I think the only use case for this code is when running Quibble from the mediawiki/services/parsoid repository." [integration/quibble] - 10https://gerrit.wikimedia.org/r/902517 (owner: 10Arlolra) [06:53:46] hashar: yes, that is T332387 and T332386 [06:54:05] it got through CI, because we don't run `npm test` through the main quibble image but instead through a standalone node image, which uses node 16 [06:54:28] so I guess we could adjust quibble CI full run to skip `npm` since in our current CI setup, we don't use quibble for node tests anyways [06:54:59] if we eventually did T332179, then it would make sense to place `npm test` back into the fullrun jobs for quibble's CI [08:07:54] ahhh I forgot about the npm test dedicated job [08:08:02] +1 on skipping npm indeed [08:41:51] (03PS1) 10Kosta Harlan: build: Skip npm-test for ci-fullrun scripts [integration/quibble] - 10https://gerrit.wikimedia.org/r/902665 (https://phabricator.wikimedia.org/T332386) [08:55:55] (03PS2) 10Kosta Harlan: build: Skip npm-test for ci-fullrun scripts [integration/quibble] - 10https://gerrit.wikimedia.org/r/902665 (https://phabricator.wikimedia.org/T332386) [09:09:59] (03CR) 10CI reject: [V: 04-1] build: Skip npm-test for ci-fullrun scripts [integration/quibble] - 10https://gerrit.wikimedia.org/r/902665 (https://phabricator.wikimedia.org/T332386) (owner: 10Kosta Harlan) [09:11:01] damn [10:26:27] hashar: not sure what I'm doing wrong, maybe we need to set `--skip npm-test` in jjb? [10:38:59] oh, I think I see what's happening [10:39:19] we are always running NpmInstall unless --skip-deps is passed. But I don't think that's needed; I'll make a patch with an idea [10:45:44] (03PS3) 10Kosta Harlan: build: Skip npm-test for ci-fullrun scripts [integration/quibble] - 10https://gerrit.wikimedia.org/r/902665 (https://phabricator.wikimedia.org/T332386) [10:45:46] (03PS1) 10Kosta Harlan: Don't run 'npm install' in core project [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) [10:58:54] (03CR) 10CI reject: [V: 04-1] build: Skip npm-test for ci-fullrun scripts [integration/quibble] - 10https://gerrit.wikimedia.org/r/902665 (https://phabricator.wikimedia.org/T332386) (owner: 10Kosta Harlan) [10:59:37] (03CR) 10CI reject: [V: 04-1] Don't run 'npm install' in core project [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) (owner: 10Kosta Harlan) [11:25:08] (03PS2) 10Kosta Harlan: Don't run 'npm install' in core project [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) [11:25:10] (03PS4) 10Kosta Harlan: build: Skip npm-test for ci-fullrun scripts [integration/quibble] - 10https://gerrit.wikimedia.org/r/902665 (https://phabricator.wikimedia.org/T332386) [11:25:42] (03CR) 10Kosta Harlan: Use AutoLoader::registerNamespaces (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/902517 (owner: 10Arlolra) [11:29:55] (03CR) 10CI reject: [V: 04-1] Don't run 'npm install' in core project [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) (owner: 10Kosta Harlan) [11:30:26] (03CR) 10CI reject: [V: 04-1] build: Skip npm-test for ci-fullrun scripts [integration/quibble] - 10https://gerrit.wikimedia.org/r/902665 (https://phabricator.wikimedia.org/T332386) (owner: 10Kosta Harlan) [11:30:36] (03PS3) 10Kosta Harlan: Don't run 'npm install' in core project [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) [11:30:38] (03PS5) 10Kosta Harlan: build: Skip npm-test for ci-fullrun scripts [integration/quibble] - 10https://gerrit.wikimedia.org/r/902665 (https://phabricator.wikimedia.org/T332386) [11:32:01] (03PS4) 10Kosta Harlan: Don't run 'npm install' in core project [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) [11:32:03] (03PS6) 10Kosta Harlan: build: Skip npm-test for ci-fullrun scripts [integration/quibble] - 10https://gerrit.wikimedia.org/r/902665 (https://phabricator.wikimedia.org/T332386) [11:45:23] (03CR) 10CI reject: [V: 04-1] build: Skip npm-test for ci-fullrun scripts [integration/quibble] - 10https://gerrit.wikimedia.org/r/902665 (https://phabricator.wikimedia.org/T332386) (owner: 10Kosta Harlan) [11:45:58] (03PS5) 10Kosta Harlan: Don't run 'npm install' in core project [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) [11:57:26] (03CR) 10CI reject: [V: 04-1] Don't run 'npm install' in core project [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) (owner: 10Kosta Harlan) [12:00:14] (03PS6) 10Kosta Harlan: Don't run 'npm install' in core project [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) [12:04:49] hashar: I made https://gerrit.wikimedia.org/r/c/integration/config/+/902695 because it turns out `--skip {foo} --skip {bar}` results in only `{bar}` getting skipped 🤦 so we can't control it in ci-fullrun-extensions.sh, afaict. [12:05:36] so I think if you deploy that jjb patch, then https://gerrit.wikimedia.org/r/902685 should pass, then Quibble CI would be unbroken. I am unconvinced that this is a better alternative to updating Quibble's node version from 14.7.5->14.8.0 or latest stable node 14. [12:14:50] (03CR) 10CI reject: [V: 04-1] Don't run 'npm install' in core project [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) (owner: 10Kosta Harlan) [13:44:55] (03CR) 10C. Scott Ananian: [C: 03+1] "Parsoid namespace part looks good." [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) (owner: 10Kosta Harlan) [13:50:00] kostajh: ah multiple `--skip` override each others bah :/ [13:51:32] kostajh: I have deployed your change [13:51:35] sorry for the delay [13:55:24] 10Quibble, 10VPS-project-Codesearch: Add integration/quibble to codesearch - https://phabricator.wikimedia.org/T332995 (10Reedy) [16:43:27] (03CR) 10Arlolra: Don't run 'npm install' in core project (032 comments) [integration/quibble] - 10https://gerrit.wikimedia.org/r/902685 (https://phabricator.wikimedia.org/T332386) (owner: 10Kosta Harlan) [16:44:39] (03PS2) 10Arlolra: Use AutoLoader::registerNamespaces [integration/quibble] - 10https://gerrit.wikimedia.org/r/902517 [16:46:28] (03CR) 10Arlolra: Use AutoLoader::registerNamespaces (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/902517 (owner: 10Arlolra) [17:17:44] (03CR) 10Hashar: [C: 03+2] "Excellent. I think this one can be merged rather than the part included in https://gerrit.wikimedia.org/r/c/integration/quibble/+/902685 (" [integration/quibble] - 10https://gerrit.wikimedia.org/r/902517 (owner: 10Arlolra) [17:35:08] (03CR) 10Reedy: Use AutoLoader::registerNamespaces (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/902517 (owner: 10Arlolra) [17:42:46] (03Merged) 10jenkins-bot: Use AutoLoader::registerNamespaces [integration/quibble] - 10https://gerrit.wikimedia.org/r/902517 (owner: 10Arlolra) [18:44:59] (03CR) 10Arlolra: Use AutoLoader::registerNamespaces (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/902517 (owner: 10Arlolra) [22:30:05] 10Quibble, 10VPS-project-Codesearch, 10Patch-For-Review: Add integration/quibble to codesearch - https://phabricator.wikimedia.org/T332995 (10Ladsgroup) 05Open→03Resolved a:03Ladsgroup It should be there in a couple of hours. [22:30:19] 10Quibble, 10VPS-project-Codesearch, 10Patch-For-Review: Add integration/quibble to codesearch - https://phabricator.wikimedia.org/T332995 (10Ladsgroup) a:05Ladsgroup→03Jdforrester-WMF