[01:27:04] Project beta-scap-sync-world build #7474: 04FAILURE in 12 min: https://integration.wikimedia.org/ci/job/beta-scap-sync-world/7474/ [01:30:15] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698045 (owner: 10DannyS712) [01:31:27] Yippee, build fixed! [01:31:27] Project beta-scap-sync-world build #7475: 09FIXED in 2 min 56 sec: https://integration.wikimedia.org/ci/job/beta-scap-sync-world/7475/ [01:33:52] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698286 (https://phabricator.wikimedia.org/T278348) (owner: 10DannyS712) [01:36:00] James_F: node 12 won't run on Qemu it seems [01:36:02] https://github.com/nodejs/node/issues/34709 [01:36:12] node 14 broken too [01:36:25] Qemu/KVM has some sort of stdout buffer bug [01:56:52] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: UnsortedUseStatementsSniff doesn't complain about use statements in namespace {} - https://phabricator.wikimedia.org/T278348 (10DannyS712) Same issue with UnusedUseStatementSniff, sending a patch to fix that too [01:58:00] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Analzye if MediaWiki.PHPUnit.AssertionOrder could handle more complex cases - https://phabricator.wikimedia.org/T281910 (10DannyS712) [01:58:11] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Analyze if MediaWiki.PHPUnit.AssertionOrder could handle more complex cases - https://phabricator.wikimedia.org/T281910 (10DannyS712) [02:14:26] 10MediaWiki-Codesniffer: Sniff SpaceyParenthesis reports wrong error on trailing space about spacing of parenthesis - https://phabricator.wikimedia.org/T260177 (10DannyS712) The issue (I think) is that there is both the single space and the newline+tabs, and that there should either be * a single space, followed... [02:17:18] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: False positive MediaWiki.Commenting.PropertyDocumentation.SpacingAfter when visibility is not on same line as property name - https://phabricator.wikimedia.org/T271267 (10DannyS712) [02:22:26] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698288 (https://phabricator.wikimedia.org/T271267) (owner: 10DannyS712) [02:40:08] 10MediaWiki-Codesniffer, 10Upstream: Auto-fix misses to add a required newline to single-line if() - https://phabricator.wikimedia.org/T246630 (10DannyS712) [02:40:16] 10MediaWiki-Codesniffer, 10Upstream: Auto-fix misses to add a required newline to single-line if() - https://phabricator.wikimedia.org/T246630 (10DannyS712) The autofix is from Generic.ControlStructures.InlineControlStructure, reported at https://github.com/squizlabs/PHP_CodeSniffer/issues/3372 [02:47:56] 10MediaWiki-Codesniffer: Add a sniff to warn when public methods lack `@since` - https://phabricator.wikimedia.org/T251785 (10DannyS712) 05Open→03Declined I have envisioned this as just for core, but per above its probably not the most helpful since it would likely be disabled everywhere in the repo, given h... [02:53:38] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698289 (https://phabricator.wikimedia.org/T273575) (owner: 10DannyS712) [02:55:37] (03PS3) 10DannyS712: PHPUnitTestTrait: check if extending a class that sounds like a test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698289 (https://phabricator.wikimedia.org/T273575) [02:57:49] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698287 (https://phabricator.wikimedia.org/T278348) (owner: 10DannyS712) [02:58:49] (03CR) 10jerkins-bot: [V: 04-1] PHPUnitTestTrait: check if extending a class that sounds like a test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698289 (https://phabricator.wikimedia.org/T273575) (owner: 10DannyS712) [02:59:56] (03PS4) 10DannyS712: PHPUnitTestTrait: check if extending a class that sounds like a test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698289 (https://phabricator.wikimedia.org/T273575) [03:18:39] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Split up FunctionCommentSniff - https://phabricator.wikimedia.org/T250958 (10DannyS712) ^ wrong task, sorry [03:23:36] (03CR) 10DannyS712: "This change is ready for review." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698290 (https://phabricator.wikimedia.org/T273806) (owner: 10DannyS712) [04:19:02] (03CR) 10Jforrester: [C: 04-1] "On hold until the team has discussed it." [VisualEditor/VisualEditor] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/698042 (https://phabricator.wikimedia.org/T284360) (owner: 10DannyS712) [04:19:46] Krinkle: Oh, bother. [07:40:04] (03CR) 10Thiemo Kreuz (WMDE): UnsortedUseStatementsSniff: add early returns (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698045 (owner: 10DannyS712) [07:42:31] (03CR) 10DannyS712: UnsortedUseStatementsSniff: add early returns (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698045 (owner: 10DannyS712) [07:56:00] 10phan, 10Upstream: Phan should detect invalid constant access - https://phabricator.wikimedia.org/T273152 (10DannyS712) The upstream issue was resolved in January - has our version of phan been updated, and can this be closed? [08:46:07] 10MediaWiki-Releasing, 10MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), 10Security: Release MediaWiki 1.31.13/1.35.2 - https://phabricator.wikimedia.org/T270458 (10DannyS712) Given that T270466 was done, can this be closed? [10:05:58] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), 10Patch-For-Review: Upgrade all CI jobs for WMF-deployed projects from Node 10 to Node 12 - https://phabricator.wikimedia.org/T284345 (10hashar) >>! In T284345#7135717, @Jdforrester-WMF wrote: > Announc... [12:08:46] 10Phabricator, 10Release-Engineering-Team (Seen), 10User-Matthewrbowker: Phacility (Maintainer of Phabricator) is winding down. Upstream support ending. - https://phabricator.wikimedia.org/T283980 (10stjn) >>! In T283980#7135209, @mmodell wrote: > Several of Phabricator's users and long time contributors are... [12:26:42] 10Phabricator, 10Release-Engineering-Team (Seen), 10User-Matthewrbowker: Phacility (Maintainer of Phabricator) is winding down. Upstream support ending. - https://phabricator.wikimedia.org/T283980 (10DannyS712) >>! In T283980#7136114, @stjn wrote: >>>! In T283980#7135209, @mmodell wrote: >> Several of Phabri... [12:31:12] 10Phabricator, 10Release-Engineering-Team (Seen), 10User-Matthewrbowker: Phacility (Maintainer of Phabricator) is winding down. Upstream support ending. - https://phabricator.wikimedia.org/T283980 (10Matthewrbowker) >>! In T283980#7136131, @DannyS712 wrote: >>>! In T283980#7136114, @stjn wrote: >>>>! In T283... [12:32:58] 10Phabricator, 10Release-Engineering-Team (Seen), 10User-Matthewrbowker: Phacility (Maintainer of Phabricator) is winding down. Upstream support ending. - https://phabricator.wikimedia.org/T283980 (10RhinosF1) https://docs.google.com/document/d/1YxQ_JGdhWYPSdoaI_m1TLzwbGLZdtOD7ux2SVL263Ow/edit# had data from... [13:01:33] (03CR) 10Hashar: [C: 03+2] "Lets go! And next week we can do some deployments :]" [software/gerrit] (wmf/stable-3.2) - 10https://gerrit.wikimedia.org/r/684411 (owner: 10Hashar) [13:07:37] (03Merged) 10jenkins-bot: [WMF] script to build our plugins [software/gerrit] (wmf/stable-3.2) - 10https://gerrit.wikimedia.org/r/684411 (owner: 10Hashar) [13:40:06] 10phan, 10Upstream: Phan should detect invalid constant access - https://phabricator.wikimedia.org/T273152 (10Daimona) >>! In T273152#7135995, @DannyS712 wrote: > The upstream issue was resolved in January - has our version of phan been updated, and can this be closed? No. We're still using 3.2.6, but the fix... [15:06:17] 10Phabricator, 10Release-Engineering-Team (Seen), 10User-Matthewrbowker: Phacility (Maintainer of Phabricator) is winding down. Upstream support ending. - https://phabricator.wikimedia.org/T283980 (10Izno) >>! In T283980#7136114, @stjn wrote: >>>! In T283980#7135209, @mmodell wrote: >> Several of Phabricator... [15:21:26] 10Phabricator, 10Release-Engineering-Team (Seen), 10User-Matthewrbowker: Phacility (Maintainer of Phabricator) is winding down. Upstream support ending. - https://phabricator.wikimedia.org/T283980 (10ReaperDawn) >>! In T283980#7136171, @Izno wrote: >>>! In T283980#7136114, @stjn wrote: >>>>! In T283980#71352... [15:37:57] (03PS1) 10Cicalese: Update TitleIcon [integration/config] - 10https://gerrit.wikimedia.org/r/698285 [16:33:59] (03CR) 10Daimona Eaytoy: "As with other sniffs not strictly related to the coding style, I wonder how accurate this sniff can be in general. Determining whether a v" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693531 (https://phabricator.wikimedia.org/T283446) (owner: 10DannyS712) [18:53:24] (03PS2) 10Jforrester: Zuul: [mediawiki/extensions/TitleIcon] Switch quibble to non-composer, with-selenium [integration/config] - 10https://gerrit.wikimedia.org/r/698285 (owner: 10Cicalese) [18:54:36] (03CR) 10jerkins-bot: [V: 04-1] Zuul: [mediawiki/extensions/TitleIcon] Switch quibble to non-composer, with-selenium [integration/config] - 10https://gerrit.wikimedia.org/r/698285 (owner: 10Cicalese) [20:17:42] (03PS3) 10Jforrester: Zuul: [mediawiki/extensions/TitleIcon] Switch to non-composer, with-selenium [integration/config] - 10https://gerrit.wikimedia.org/r/698285 (owner: 10Cicalese) [20:19:34] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/TitleIcon] Switch to non-composer, with-selenium [integration/config] - 10https://gerrit.wikimedia.org/r/698285 (owner: 10Cicalese) [20:20:36] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/TitleIcon] Switch to non-composer, with-selenium [integration/config] - 10https://gerrit.wikimedia.org/r/698285 (owner: 10Cicalese) [20:34:22] !log Zuul: [mediawiki/extensions/TitleIcon] Switch to non-composer, with-selenium [20:34:24] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:05:32] (03CR) 10Cicalese: "Thank you!" [integration/config] - 10https://gerrit.wikimedia.org/r/698285 (owner: 10Cicalese) [22:06:33] 10Phabricator, 10Voice & Tone: Grammar error in Wikimedia-GitHub phab project description - https://phabricator.wikimedia.org/T284379 (10EpicPupper) [22:12:11] 10Phabricator, 10Voice & Tone: Grammar error in Wikimedia-GitHub phab project description - https://phabricator.wikimedia.org/T284379 (10JJMC89) 05Open→03Resolved a:03JJMC89 [23:11:43] (03CR) 10DannyS712: "> Patch Set 2:" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/693531 (https://phabricator.wikimedia.org/T283446) (owner: 10DannyS712)