[00:57:08] 10Release-Engineering-Team, 10GitLab (Initialization), 10Patch-For-Review, 10User-brennen: Prevent creation of private projects by default on WMF GitLab - https://phabricator.wikimedia.org/T284962 (10thcipriani) > To be clear, this assumes that we can set the policy to: > > * Users may create publicly vis... [01:34:29] 10Release-Engineering-Team, 10GitLab (Initialization), 10Patch-For-Review, 10User-brennen: Prevent creation of private projects by default on WMF GitLab - https://phabricator.wikimedia.org/T284962 (10Peachey88) [01:39:59] (03CR) 10Ottomata: Revert "Restore generic-node10-docker" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/699563 (owner: 10Jforrester) [03:50:05] 10Release-Engineering-Team, 10GitLab (Initialization), 10Patch-For-Review, 10User-brennen: Prevent creation of private projects by default on WMF GitLab - https://phabricator.wikimedia.org/T284962 (10brennen) > This is an improvement on the current status quo where users file a request for all project crea... [04:55:25] (03CR) 10Lars Wirzenius: [C: 03+2] Update pip3 to "install" scap [tools/train-dev] - 10https://gerrit.wikimedia.org/r/699797 (owner: 10Ahmon Dancy) [04:58:24] (03CR) 10Lars Wirzenius: [C: 03+2] Install python3 packages for scap [tools/train-dev] - 10https://gerrit.wikimedia.org/r/699816 (owner: 10Ahmon Dancy) [04:59:52] (03CR) 10Lars Wirzenius: [C: 03+2] fix: Python 3 str/bytes translations [tools/scap] - 10https://gerrit.wikimedia.org/r/699801 (owner: 10Ahmon Dancy) [05:00:33] (03Merged) 10jenkins-bot: fix: Python 3 str/bytes translations [tools/scap] - 10https://gerrit.wikimedia.org/r/699801 (owner: 10Ahmon Dancy) [05:01:29] 10Release-Engineering-Team (Next), 10Scap: Fix or drop disabled unit tests in Scap - https://phabricator.wikimedia.org/T283018 (10LarsWirzenius) p:05Triage→03Medium a:03dancy [05:07:57] 10Scap: Scap .deb build patches bin/scap for hashbang - https://phabricator.wikimedia.org/T268349 (10LarsWirzenius) 05Open→03Resolved This is already done. [05:27:02] 10MediaWiki-Codesniffer, 10MediaWiki-Documentation, 10Patch-For-Review: Standardize return type hint spacing - https://phabricator.wikimedia.org/T220719 (10thiemowmde) > In the absence of consensus, how about we just go with spaces for now? How about we don't act as if we have consensus if we don't have con... [05:28:01] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "There is no consensus documented anywhere, as far as I'm aware of. PSR is a standard, and it asks for *no* space before the colon." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/679844 (https://phabricator.wikimedia.org/T220719) (owner: 10DannyS712) [05:28:20] 10Release-Engineering-Team (Doing), 10MediaWiki Train Development Environment: train-dev: pre-built images and people getting login access to them - https://phabricator.wikimedia.org/T259607 (10LarsWirzenius) 05Open→03Declined This is obsolete, now that train-dev is using Docker. [05:30:14] 10Release-Engineering-Team (Seen), 10Scap, 10Epic, 10Goal: Automate the Train - https://phabricator.wikimedia.org/T196515 (10LarsWirzenius) [05:30:24] 10Release-Engineering-Team (Next), 10Scap: Automate scap patch - https://phabricator.wikimedia.org/T245185 (10LarsWirzenius) 05Open→03Resolved a:03LarsWirzenius I believe `scap apply-patches` does this now. [05:36:38] 10Release-Engineering-Team (Doing), 10Scap: scap uses unsafe YAML loading of data - https://phabricator.wikimedia.org/T261307 (10LarsWirzenius) I note there is one remaining instance of yaml.load in Scap. [06:42:16] 10MediaWiki-Codesniffer, 10MediaWiki-Documentation, 10Patch-For-Review: Standardize return type hint spacing - https://phabricator.wikimedia.org/T220719 (10DannyS712) >>! In T220719#7157113, @thiemowmde wrote: >> In the absence of consensus, how about we just go with spaces for now? > > How about we don't a... [06:47:36] 10Phabricator, 10Patch-For-Review, 10User-DannyS712: Fix typo in description of train deployments tasks - https://phabricator.wikimedia.org/T274402 (10DannyS712) @thcipriani has "accepted" the patch (D1189#24018) but was it merged? Looking at the example task I mentioned in the description (T271344) shows th... [06:50:55] 10Phabricator, 10User-DannyS712: "No View Permission" under a subscriber name is confusing for public tasks - https://phabricator.wikimedia.org/T284976 (10DannyS712) [06:54:41] 10Phabricator, 10User-DannyS712: "No View Permission" under a subscriber name is confusing for public tasks - https://phabricator.wikimedia.org/T284976 (10Majavah) The "Slowvote" application itself is [[ https://phabricator.wikimedia.org/applications/view/PhabricatorSlowvoteApplication/ | restricted to ]] memb... [06:56:12] 10Phabricator, 10User-DannyS712: "No View Permission" under a subscriber name is confusing for public tasks - https://phabricator.wikimedia.org/T284976 (10DannyS712) >>! In T284976#7157239, @Majavah wrote: > The "Slowvote" application itself is [[ https://phabricator.wikimedia.org/applications/view/Phabricator... [06:59:42] 10Phabricator, 10User-DannyS712: "No View Permission" under a subscriber name is confusing for public tasks - https://phabricator.wikimedia.org/T284976 (10Aklapper) 05Open→03Declined ksmith does not have permissions to view V9. So it says "No View permission". > clicking on it for the policy details shou... [07:00:10] 10Phabricator: "No View Permission" under a subscriber name is confusing for public tasks - https://phabricator.wikimedia.org/T284976 (10DannyS712) [07:02:19] 10Phabricator (Upstream), 10Upstream: Add reason to Phabricator emails why you received that notification - https://phabricator.wikimedia.org/T77917 (10Aklapper) 05Open→03Resolved Closing per above [07:38:08] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [extensions/NaylorAMS] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/699902 [07:38:10] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [extensions/NaylorAMS] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/699902 (owner: 10QChris) [07:38:24] (03PS1) 10QChris: Import done. Revoke import grants [extensions/NaylorAMS] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/699903 [07:38:26] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [extensions/NaylorAMS] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/699903 (owner: 10QChris) [08:16:01] (03PS1) 1020after4: Limit length to avoid URL limit [releng/phatality] - 10https://gerrit.wikimedia.org/r/699905 [08:17:50] (03PS2) 1020after4: Limit length of stack trace to avoid URL length limit [releng/phatality] - 10https://gerrit.wikimedia.org/r/699905 (https://phabricator.wikimedia.org/T255671) [08:28:21] (03PS3) 1020after4: Limit length of stack trace to avoid URL length limit [releng/phatality] - 10https://gerrit.wikimedia.org/r/699905 (https://phabricator.wikimedia.org/T255671) [10:52:46] 10Phabricator, 10Patch-For-Review, 10User-DannyS712: Fix typo in description of train deployments tasks - https://phabricator.wikimedia.org/T274402 (10Ammarpad) It was fixed as part of d238db85b8d8 [11:15:33] 10Phabricator, 10User-DannyS712: Fix typo in description of train deployments tasks - https://phabricator.wikimedia.org/T274402 (10DannyS712) 05Open→03Resolved a:03thcipriani >>! In T274402#7157628, @Ammarpad wrote: > It was fixed as part of d238db85b8d8 Thanks - I abandoned my patch [11:25:30] 10Continuous-Integration-Infrastructure, 10Zuul: Depends-On should not work across branches - https://phabricator.wikimedia.org/T210685 (10Aklapper) >>! In T210685#4789091, @hashar wrote: > the issue is solved in Zuul v3 so that is pending upgrade :/ Is there a ticket about that upgrade, or do we plan to never... [11:34:04] 10Phabricator: "The owner of a task can always view and edit it." is confusing - https://phabricator.wikimedia.org/T279827 (10DannyS712) The text "The owner of a task can always view and edit it." comes from upstream, specifically in ManiphestTaskPolicyCodex::getPolicySpecialRuleDescriptions() [1] - since upstre... [11:55:22] PROBLEM - SSH on contint2001.mgmt is CRITICAL: CRITICAL - Socket timeout after 10 seconds https://wikitech.wikimedia.org/wiki/Dc-operations/Hardware_Troubleshooting_Runbook [12:55:20] RECOVERY - SSH on contint2001.mgmt is OK: SSH OK - OpenSSH_6.6 (protocol 2.0) https://wikitech.wikimedia.org/wiki/Dc-operations/Hardware_Troubleshooting_Runbook [13:01:47] 10Phabricator: "The owner of a task can always view and edit it." is confusing - https://phabricator.wikimedia.org/T279827 (10Aklapper) It might be simpler to add a `translation.override` item to https://gerrit.wikimedia.org/g/operations/puppet/+/refs/heads/production/modules/phabricator/data/fixed_settings.yaml... [13:49:05] 10Continuous-Integration-Infrastructure, 10Zuul: Depends-On should not work across branches - https://phabricator.wikimedia.org/T210685 (10thcipriani) >>! In T210685#7157696, @Aklapper wrote: >>>! In T210685#4789091, @hashar wrote: >> the issue is solved in Zuul v3 so that is pending upgrade :/ > Is there a ti... [14:00:19] (03CR) 10Thcipriani: Limit length of stack trace to avoid URL length limit (031 comment) [releng/phatality] - 10https://gerrit.wikimedia.org/r/699905 (https://phabricator.wikimedia.org/T255671) (owner: 1020after4) [14:12:14] (03CR) 10Ahmon Dancy: [V: 03+2] Install python3 packages for scap [tools/train-dev] - 10https://gerrit.wikimedia.org/r/699816 (owner: 10Ahmon Dancy) [14:12:27] (03CR) 10Ahmon Dancy: [V: 03+2] Update pip3 to "install" scap [tools/train-dev] - 10https://gerrit.wikimedia.org/r/699797 (owner: 10Ahmon Dancy) [14:50:07] 10MediaWiki-Codesniffer, 10MediaWiki-Documentation, 10Patch-For-Review: Standardize return type hint spacing - https://phabricator.wikimedia.org/T220719 (10thiemowmde) I did not explain my point of view enough. Sorry. This is a bit like the famous "tabs vs. spaces" discussion. In a situation like this where... [14:54:00] 10MediaWiki-Codesniffer, 10MediaWiki-Documentation, 10Patch-For-Review: Standardize return type hint spacing - https://phabricator.wikimedia.org/T220719 (10thiemowmde) [14:58:08] 10Release-Engineering-Team: puppet CI task failing with: Cannot allocate memory - https://phabricator.wikimedia.org/T284998 (10jbond) [15:19:29] (03CR) 10Addshore: WIP: Xdebug: always install xdebug module, move config to core (032 comments) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/692737 (https://phabricator.wikimedia.org/T273682) (owner: 10Brennen Bearnes) [15:27:53] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: puppet CI task failing with: Cannot allocate memory - https://phabricator.wikimedia.org/T284998 (10thcipriani) [16:15:41] (03PS1) 10Lars Wirzenius: assert Python version >= 3 [tools/scap] - 10https://gerrit.wikimedia.org/r/699950 [16:17:37] (03PS2) 10Lars Wirzenius: assert Python version >= 3 [tools/scap] - 10https://gerrit.wikimedia.org/r/699950 [16:27:44] (03CR) 10Ahmon Dancy: [C: 04-1] assert Python version >= 3 (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/699950 (owner: 10Lars Wirzenius) [16:31:27] (03PS3) 10Lars Wirzenius: assert Python version >= 3 [tools/scap] - 10https://gerrit.wikimedia.org/r/699950 [16:34:32] (03CR) 10Ahmon Dancy: [C: 03+2] assert Python version >= 3 [tools/scap] - 10https://gerrit.wikimedia.org/r/699950 (owner: 10Lars Wirzenius) [16:35:13] (03Merged) 10jenkins-bot: assert Python version >= 3 [tools/scap] - 10https://gerrit.wikimedia.org/r/699950 (owner: 10Lars Wirzenius) [17:22:06] (03CR) 1020after4: Limit length of stack trace to avoid URL length limit (031 comment) [releng/phatality] - 10https://gerrit.wikimedia.org/r/699905 (https://phabricator.wikimedia.org/T255671) (owner: 1020after4) [17:23:38] (03CR) 10Krinkle: "Maybe just skip the stack trace instead of trimming it, that way it encourages the user to copy it accross separately instead of a filing " [releng/phatality] - 10https://gerrit.wikimedia.org/r/699905 (https://phabricator.wikimedia.org/T255671) (owner: 1020after4) [17:24:40] (03CR) 1020after4: "> Patch Set 3:" [releng/phatality] - 10https://gerrit.wikimedia.org/r/699905 (https://phabricator.wikimedia.org/T255671) (owner: 1020after4) [17:31:06] 10Continuous-Integration-Infrastructure, 10DC-Ops, 10netops, 10serviceops: Flapping codfw management alarm ( contint2001.mgmt/SSH is CRITICAL ) - https://phabricator.wikimedia.org/T283582 (10Dzahn) I can confirm since a while these have been happening. The pattern is always: - only mgmt - only codfw - ran... [17:34:04] (03CR) 10Thcipriani: [V: 03+2 C: 03+2] "Overall looks like a net improvement over the current status quo of: doesn't work at all 😜" (031 comment) [releng/phatality] - 10https://gerrit.wikimedia.org/r/699905 (https://phabricator.wikimedia.org/T255671) (owner: 1020after4) [18:10:48] Project beta-scap-sync-world build #9009: 15ABORTED in 57 sec: https://integration.wikimedia.org/ci/job/beta-scap-sync-world/9009/ [19:04:34] (03PS1) 10Ahmon Dancy: Enable udp2log_host on deploy server [tools/train-dev] - 10https://gerrit.wikimedia.org/r/699964 [19:04:49] (03CR) 10Ahmon Dancy: [V: 03+2 C: 03+2] Enable udp2log_host on deploy server [tools/train-dev] - 10https://gerrit.wikimedia.org/r/699964 (owner: 10Ahmon Dancy) [19:06:26] (03PS1) 10Ahmon Dancy: Udp2LogHandler.makePickle() [tools/scap] - 10https://gerrit.wikimedia.org/r/699965 [19:06:48] (03CR) 10Ahmon Dancy: [C: 03+2] Udp2LogHandler.makePickle() [tools/scap] - 10https://gerrit.wikimedia.org/r/699965 (owner: 10Ahmon Dancy) [19:09:45] (03Merged) 10jenkins-bot: Udp2LogHandler.makePickle() [tools/scap] - 10https://gerrit.wikimedia.org/r/699965 (owner: 10Ahmon Dancy) [19:34:33] (03PS4) 10Umherirrender: DocumentationTypeTrait: complain about `type` as a type [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698290 (https://phabricator.wikimedia.org/T273806) (owner: 10DannyS712) [19:34:53] (03CR) 10Umherirrender: [C: 03+2] DocumentationTypeTrait: complain about `type` as a type [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698290 (https://phabricator.wikimedia.org/T273806) (owner: 10DannyS712) [19:35:32] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: codesniffer could warn when "type" is used as type for @return/@param/@var - https://phabricator.wikimedia.org/T273806 (10Umherirrender) 05Open→03Resolved a:03DannyS712 [19:36:24] (03Merged) 10jenkins-bot: DocumentationTypeTrait: complain about `type` as a type [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698290 (https://phabricator.wikimedia.org/T273806) (owner: 10DannyS712) [19:37:58] 10MediaWiki-Codesniffer, 10User-DannyS712: phpcs should treat {@inheritDoc} like @inheritDoc - https://phabricator.wikimedia.org/T270830 (10Umherirrender) 05Open→03Resolved a:03DannyS712 [19:46:59] (03CR) 10Umherirrender: PropertyDocumentationSniff: handle visibility on its own line (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/698288 (https://phabricator.wikimedia.org/T271267) (owner: 10DannyS712) [22:01:46] PROBLEM - SSH on contint2001.mgmt is CRITICAL: CRITICAL - Socket timeout after 10 seconds https://wikitech.wikimedia.org/wiki/Dc-operations/Hardware_Troubleshooting_Runbook