[03:45:15] (03PS1) 10AndyRussG: Add new fundraising-smashpig-buster-php73-apache3 image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/704651 (https://phabricator.wikimedia.org/T268687) [03:49:15] (03CR) 10Eileen: [V: 03+2 C: 03+2] Fundraising images: Separate Mediawiki and Civi setups [releng/dev-images] - 10https://gerrit.wikimedia.org/r/663294 (https://phabricator.wikimedia.org/T262975) (owner: 10AndyRussG) [03:53:25] 10Release-Engineering-Team (Radar), 10FR-Docker, 10Fundraising-Backlog, 10Gerrit-Privilege-Requests, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10AndyRussG) >>! In T274303#7212283, @thcipriani wrote: > Adjusted to give you V+... [03:55:13] (03PS1) 10Eileen: Added image for civiproxy [releng/dev-images] - 10https://gerrit.wikimedia.org/r/704652 (https://phabricator.wikimedia.org/T268683) [03:56:40] 10Release-Engineering-Team (Radar), 10FR-Docker, 10Fundraising-Backlog, 10Gerrit-Privilege-Requests, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10Eileenmcnaughton) @thcipriani is there an extra permission required to be able t... [03:57:27] (03CR) 10Eileen: [C: 03+2] "I was able to push up a new review with a new change id but not rebase this - which still seems like permissions - see https://gerrit.wiki" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/664919 (https://phabricator.wikimedia.org/T268683) (owner: 10Jgleeson) [04:04:45] (03CR) 10Eileen: [V: 03+2 C: 03+2] "This is the code I +2d in https://gerrit.wikimedia.org/r/c/releng/dev-images/+/664919 - but I couldn't rebase that one because we seem to " [releng/dev-images] - 10https://gerrit.wikimedia.org/r/704652 (https://phabricator.wikimedia.org/T268683) (owner: 10Eileen) [04:05:49] (03CR) 10Eileen: [C: 03+2] "I have neither permissionto rebase or abandon this but it should be abandoned as I put up a separate gerrit with this code https://gerrit." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/664919 (https://phabricator.wikimedia.org/T268683) (owner: 10Jgleeson) [04:07:46] 10Release-Engineering-Team (Radar), 10FR-Docker, 10Fundraising-Backlog, 10Gerrit-Privilege-Requests, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10Eileenmcnaughton) Also - I replaced the above since I couldn't rebase - and then... [05:00:36] (03CR) 10Eileen: [V: 03+2 C: 03+2] "Works for me!" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/704651 (https://phabricator.wikimedia.org/T268687) (owner: 10AndyRussG) [05:03:51] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704660 [05:03:53] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704660 (owner: 10TrainBranchBot) [05:05:14] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704660 (owner: 10TrainBranchBot) [05:10:31] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704662 [05:10:33] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704662 (owner: 10TrainBranchBot) [05:11:36] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704662 (owner: 10TrainBranchBot) [05:16:46] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704663 [05:16:48] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704663 (owner: 10TrainBranchBot) [05:17:43] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704663 (owner: 10TrainBranchBot) [06:53:26] 10Beta-Cluster-Infrastructure: Puppet errors on deployment-logstash03.deployment-prep.eqiad.wmflabs - https://phabricator.wikimedia.org/T286567 (10Majavah) I think the easiest option here would be to just delete logstash03. It's running an old version of ELK (T283013) and the only reason I've not deleted it yet... [08:45:30] 10Release-Engineering-Team, 10Community-Relations: Expand the list of group 1 wikis to contain at least one (preferably 2) smaller "top ten size" wikis - https://phabricator.wikimedia.org/T286664 (10Jdforrester-WMF) [09:04:18] (03CR) 10Hashar: [C: 03+2] "Job operations-puppet-catalog-compiler-test updated!" [integration/config] - 10https://gerrit.wikimedia.org/r/701370 (owner: 10Kormat) [09:05:32] (03Merged) 10jenkins-bot: jjb: Support pcc hosts: comments [integration/config] - 10https://gerrit.wikimedia.org/r/701370 (owner: 10Kormat) [09:22:17] James_F do you have any other simple patches you want reviewed? [09:24:13] DannyS712: None right now, I think. Thank you! [09:25:56] hope to help - reviewing lets me discover parts of the code that I haven't seen before (eg at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/691273/3/maintenance/deleteOrphanedRevisions.php there is no reason for $dbw to be passed by reference (and arguably no reason for that separate method, but thats a decision the original author made)) [09:26:06] s/hope to help/happy to help [09:29:26] ^ I just sent a patch to fix that, sorry for causing you a merge conflict [09:59:21] (03CR) 10Hashar: [C: 03+2] "Maybe composer merge plugin did not support glob() pattern and we just carried the logic since then. I might have done it this way so that" [integration/quibble] - 10https://gerrit.wikimedia.org/r/703177 (owner: 10Kosta Harlan) [10:01:53] (03PS2) 10Hashar: composer: Simplify construction of composer.local.json [integration/quibble] - 10https://gerrit.wikimedia.org/r/703177 (owner: 10Kosta Harlan) [10:02:13] (03CR) 10Hashar: [C: 03+2] composer: Simplify construction of composer.local.json [integration/quibble] - 10https://gerrit.wikimedia.org/r/703177 (owner: 10Kosta Harlan) [10:03:03] James_F: hi, in case you are around I could use your insight about having quibble running "composer run phpunit:entrypoint" https://gerrit.wikimedia.org/r/c/integration/quibble/+/692372/9/quibble/commands.py [10:03:20] James_F: the change looks fine and I would +2 it but could use a second pair of eyes in case I missed something ;D [10:05:49] hashar: Yeah, the fallback means this doesn't need us running around. :-) [10:07:03] (03CR) 10Jforrester: [C: 03+1] phpunit: Use composer phpunit:entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/692372 (https://phabricator.wikimedia.org/T90875) (owner: 10Kosta Harlan) [10:07:16] ty! [10:10:12] hashar: https://gerrit.wikimedia.org/r/c/integration/quibble/+/703401 is so cool. [10:10:57] (03CR) 10Hashar: [C: 03+2] "TY :)" [integration/quibble] - 10https://gerrit.wikimedia.org/r/692372 (https://phabricator.wikimedia.org/T90875) (owner: 10Kosta Harlan) [10:11:21] I am doing some sprint reviews for Quibble and attend to cut the release at some point this afternoon [10:11:28] gerrit-fix yes [10:11:34] kosta wrote something similar for SonarQube [10:11:42] Yeah. [10:11:47] It all ties together. [10:11:56] Very cool demo run linked from the task. [10:11:56] and there is some related code for PHP CodeSniffer [10:12:07] Yup, I've merged that already. [10:12:15] Will do a codesniffer release some time this week. [10:12:15] what I would want in the ideal world is to have the linter/test results to be written to disk as whatever XML/log/txt xyz [10:12:25] then have a standalone tool that consumes those files and write the comment to gerrit [10:12:34] That is what's happening. [10:12:36] so that standalone tool could then be used for pretty much anything [10:12:44] but I haven't followed the effort on that front [10:12:49] Our SonarQube coupling is the stand-alone tool, but we could factor it out. [10:12:59] No idea how this'll apply in a GitLab world. [10:13:07] I should read that quibble patch :D [10:13:37] :-D [10:14:32] It gets codesniffer to output the auto-fixes to 'cache/gerrit-fix-suggestions.json' which quibble then pings the bot about. [10:15:25] I need to hire Kosta :D [10:15:31] Ha. [10:20:58] (03Merged) 10jenkins-bot: composer: Simplify construction of composer.local.json [integration/quibble] - 10https://gerrit.wikimedia.org/r/703177 (owner: 10Kosta Harlan) [10:27:27] DannyS712: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/691273/4 rebased onto HEAD if you want to merge. :-) [10:28:58] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Use composer phpunit:entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/692372 (https://phabricator.wikimedia.org/T90875) (owner: 10Kosta Harlan) [10:30:34] +2'ed [10:31:34] (03CR) 10Jforrester: [C: 03+2] "Whee, timeout failure." [integration/quibble] - 10https://gerrit.wikimedia.org/r/692372 (https://phabricator.wikimedia.org/T90875) (owner: 10Kosta Harlan) [10:41:35] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments: 1.37.0-wmf.14 deployment blockers - https://phabricator.wikimedia.org/T281155 (10Ladsgroup) T286679 is a problem but I don't think it should be a train blocker, its impact is really limited. [10:52:31] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Use composer phpunit:entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/692372 (https://phabricator.wikimedia.org/T90875) (owner: 10Kosta Harlan) [11:10:39] (03PS3) 10Jforrester: Rename buster to fundraising-buster, create a buster top-level image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/698878 (https://phabricator.wikimedia.org/T273100) (owner: 10Brennen Bearnes) [11:10:41] (03PS5) 10Jforrester: WIP: add buster php images [releng/dev-images] - 10https://gerrit.wikimedia.org/r/698880 (https://phabricator.wikimedia.org/T273100) (owner: 10Brennen Bearnes) [11:10:43] (03PS1) 10Jforrester: Move common files out of stretch so they can be re-used [releng/dev-images] - 10https://gerrit.wikimedia.org/r/704765 [11:12:32] (03CR) 10Jforrester: "Follow-up work in I8ec767b3e3c7039113a7dab95f2c5340121aebdc to not make the 'buster' image FR-specific too." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/663294 (https://phabricator.wikimedia.org/T262975) (owner: 10AndyRussG) [12:23:45] (03CR) 10Hashar: [C: 04-1] "Grmblblb:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/692372 (https://phabricator.wikimedia.org/T90875) (owner: 10Kosta Harlan) [12:31:30] (03PS10) 10Hashar: phpunit: Use composer phpunit:entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/692372 (https://phabricator.wikimedia.org/T90875) (owner: 10Kosta Harlan) [12:33:18] ACKNOWLEDGEMENT - SSH on contint2001.mgmt is CRITICAL: CRITICAL - Socket timeout after 10 seconds daniel_zahn https://phabricator.wikimedia.org/T283582 https://wikitech.wikimedia.org/wiki/Dc-operations/Hardware_Troubleshooting_Runbook [12:33:44] (03PS11) 10Hashar: phpunit: Use composer phpunit:entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/692372 (https://phabricator.wikimedia.org/T90875) (owner: 10Kosta Harlan) [12:35:00] 10Beta-Cluster-Infrastructure, 10User-Majavah: Migrate beta cluster to ELK7 - https://phabricator.wikimedia.org/T283013 (10Majavah) This has two (three) issues remaining: * T283013#7163536, which is currently solved with a cronjob on deployment-cumin that automatically deletes those log files every other hour... [13:11:19] James_F: had to disable some composer built in timeout @ 300 s : https://gerrit.wikimedia.org/r/c/integration/quibble/+/692372/9..11/quibble/commands.py :) [13:19:56] (03CR) 10Hashar: [C: 03+2] phpunit: Use composer phpunit:entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/692372 (https://phabricator.wikimedia.org/T90875) (owner: 10Kosta Harlan) [13:26:58] 10Release-Engineering-Team (Radar), 10FR-Docker, 10Fundraising-Backlog, 10Gerrit-Privilege-Requests, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10thcipriani) >>! In T274303#7214004, @Eileenmcnaughton wrote: > Also - I replaced... [13:29:23] (03CR) 10Hashar: [C: 03+2] Add support for connecting to already running MySQL [integration/quibble] - 10https://gerrit.wikimedia.org/r/692412 (owner: 10Kosta Harlan) [13:32:59] (03CR) 10Hashar: [C: 03+2] "Lets go for it :)" [integration/quibble] - 10https://gerrit.wikimedia.org/r/703182 (https://phabricator.wikimedia.org/T218534) (owner: 10Kosta Harlan) [13:36:22] (03Merged) 10jenkins-bot: phpunit: Use composer phpunit:entrypoint [integration/quibble] - 10https://gerrit.wikimedia.org/r/692372 (https://phabricator.wikimedia.org/T90875) (owner: 10Kosta Harlan) [13:45:55] (03Merged) 10jenkins-bot: Add support for connecting to already running MySQL [integration/quibble] - 10https://gerrit.wikimedia.org/r/692412 (owner: 10Kosta Harlan) [13:56:22] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Metrics-Platform, 10Product-Data-Infrastructure, and 2 others: Add a Swift image to Wikimedia's docker registry for testing - https://phabricator.wikimedia.org/T284195 (10Mholloway) 05Open→03Resolved Looks like it's working well! T... [14:00:14] (03CR) 10jerkins-bot: [V: 04-1] Load Parsoid from vendor as fallback, and configure [integration/quibble] - 10https://gerrit.wikimedia.org/r/703182 (https://phabricator.wikimedia.org/T218534) (owner: 10Kosta Harlan) [15:19:25] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments: 1.37.0-wmf.14 deployment blockers - https://phabricator.wikimedia.org/T281155 (10dancy) >>! In T281155#7214748, @Ladsgroup wrote: > T286679 is a problem but I don't think it should be a train blocker, its impact is really limited. Thanks @L... [15:19:38] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments: 1.37.0-wmf.14 deployment blockers - https://phabricator.wikimedia.org/T281155 (10dancy) [15:53:29] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments: 1.37.0-wmf.15 deployment blockers - https://phabricator.wikimedia.org/T281156 (10Krinkle) [16:23:38] 10Release-Engineering-Team (Radar), 10FR-Docker, 10Fundraising-Backlog, 10Gerrit-Privilege-Requests, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10AndyRussG) @thcipriani thanks so much for all your help on this, it's hugely app... [16:31:50] 10Release-Engineering-Team (Radar), 10FR-Docker, 10Fundraising-Backlog, 10Gerrit-Privilege-Requests, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10thcipriani) >>! In T274303#7215535, @AndyRussG wrote: > @thcipriani thanks so mu... [16:53:25] 10Release-Engineering-Team (Radar), 10FR-Docker, 10Fundraising-Backlog, 10Gerrit-Privilege-Requests, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10brennen) > My understanding is there's still a manual step of actually publishin... [17:08:50] 10Release-Engineering-Team (Radar), 10FR-Docker, 10Fundraising-Backlog, 10Gerrit-Privilege-Requests, and 3 others: dev-images +2 rights and Docker registry credentials for FR-Tech - https://phabricator.wikimedia.org/T274303 (10AndyRussG) >>! In T274303#7215593, @brennen wrote: >> My understanding is there'... [17:18:06] well too late to do that Quibble release [17:18:10] so I guess it will be for tomorrow [17:18:13] * hashar waves [18:22:36] 10Release-Engineering-Team (Radar), 10MW-on-K8s, 10SRE, 10serviceops: The restricted/mediawiki-webserver image should include skins and resources - https://phabricator.wikimedia.org/T285232 (10dduvall) >>! In T285232#7199870, @Joe wrote: > So after some more scavenging, We need the following directories to... [18:34:55] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704848 [18:34:57] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704848 (owner: 10TrainBranchBot) [18:35:55] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704848 (owner: 10TrainBranchBot) [18:41:36] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704849 [18:41:38] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704849 (owner: 10TrainBranchBot) [18:42:42] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704849 (owner: 10TrainBranchBot) [18:48:08] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704850 [18:48:10] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704850 (owner: 10TrainBranchBot) [18:49:18] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704850 (owner: 10TrainBranchBot) [20:02:26] 10phabricator maintenance bot: Maintenance bot creates duplicates - https://phabricator.wikimedia.org/T286740 (10Urbanecm) [20:03:01] 10phabricator maintenance bot: Maintenance bot creates duplicates for new wiki tasks - https://phabricator.wikimedia.org/T286740 (10Urbanecm) [20:05:47] 10phabricator maintenance bot: Maintenance bot creates duplicates for new wiki tasks - https://phabricator.wikimedia.org/T286740 (10Urbanecm) This happens because of https://github.com/Ladsgroup/Phabricator-maintenance-bot/blob/master/lib.py#L194, which is called before creating any subtasks. According to https:... [20:23:58] 10phabricator maintenance bot: Maintenance bot creates duplicates for new wiki tasks - https://phabricator.wikimedia.org/T286740 (10Ladsgroup) Ugh, yeah for now we should close them early but let me think what we can do here. [20:58:35] (03CR) 10Jeena Huneidi: [C: 03+2] Fix teardown execution upon caught exception [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/704411 (https://phabricator.wikimedia.org/T286511) (owner: 10Dduvall) [20:59:13] (03Merged) 10jenkins-bot: Fix teardown execution upon caught exception [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/704411 (https://phabricator.wikimedia.org/T286511) (owner: 10Dduvall) [21:36:20] (03CR) 10Nikki Nikkhoui: "Dependent patch has been merged for this in case anyone thinks its ready for a +2 :D" [integration/config] - 10https://gerrit.wikimedia.org/r/698774 (https://phabricator.wikimedia.org/T281132) (owner: 10Nikki Nikkhoui) [23:21:39] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704876 [23:21:41] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704876 (owner: 10TrainBranchBot) [23:22:46] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704876 (owner: 10TrainBranchBot) [23:28:19] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704877 [23:28:21] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704877 (owner: 10TrainBranchBot) [23:29:17] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/704877 (owner: 10TrainBranchBot)