[00:09:55] (03CR) 1020after4: [C: 03+1] "Only +1 because this is sort of a drive-by review but it all looks pretty good to me." (033 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [01:18:11] docker-registry.wikimedia.org/mwcachedir 0.0.1 ecfbfbea6f26 9 months ago 6GB [01:18:31] anyone know what that is / if I can delete it from deneb? [01:20:06] hmm, it's in the registry, I'll delete it [01:39:28] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments, 10User-brennen: 1.37.0-wmf.12 deployment blockers - https://phabricator.wikimedia.org/T281153 (10Etonkovidova) [04:05:55] (03CR) 10DannyS712: Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [05:41:26] 10Release-Engineering-Team (Radar), 10MW-on-K8s, 10SRE, 10serviceops: The restricted/mediawiki-webserver image should include skins and resources - https://phabricator.wikimedia.org/T285232 (10Joe) So after discussion yesterday, it appears we've come to a consensus that given we're now building incremental... [06:36:42] 10Release-Engineering-Team (Radar), 10MW-on-K8s, 10SRE, 10serviceops: The restricted/mediawiki-webserver image should include skins and resources - https://phabricator.wikimedia.org/T285232 (10Joe) Things that get served statically include: * Favicons (like https://en.wikipedia.org/static/favicon/wikipedi... [07:33:16] (03CR) 10Addshore: [C: 03+2] doc: add footer link to wikitech documentation [integration/docroot] - 10https://gerrit.wikimedia.org/r/706582 (owner: 10Hashar) [07:34:49] (03Merged) 10jenkins-bot: doc: add footer link to wikitech documentation [integration/docroot] - 10https://gerrit.wikimedia.org/r/706582 (owner: 10Hashar) [07:54:02] 10Continuous-Integration-Config, 10Release-Engineering-Team (Seen), 10Scap, 10MW-on-K8s, and 4 others: Define variant Wikimedia production config in compiled, static files - https://phabricator.wikimedia.org/T223602 (10Joe) This would indeed be quite important for mediawiki on kubernetes. If we moved the y... [09:18:55] 10Project-Admins: Is #Contributors-UX-Research still in use? - https://phabricator.wikimedia.org/T279953 (10Aklapper) 05Open→03Resolved a:03Aklapper @dchen: Thanks! :) * Archived #Contributors-UX-Research at https://phabricator.wikimedia.org/project/profile/2203/ * Resolved tasks https://phabricator.wikim... [09:20:25] (03CR) 10Hashar: [C: 03+2] "Deployed (scap on deployment server)" [integration/docroot] - 10https://gerrit.wikimedia.org/r/706582 (owner: 10Hashar) [11:49:41] (03PS1) 10Daniel Kinzler: Add landing page for code metrics [integration/docroot] - 10https://gerrit.wikimedia.org/r/707333 [12:04:16] (03CR) 10Hashar: "Having a dedicated page for PHPMetrics is an excellent idea. Will look at relocating all those reports to /phpmetrics/ so we get them lis" (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/707333 (owner: 10Daniel Kinzler) [12:30:53] (03CR) 10Hashar: [C: 03+2] "Awesome. Thank you for the thorough investigation C. Scott. I will tag 1.0.1 after this as merged, build the related CI image and will at" [integration/quibble] - 10https://gerrit.wikimedia.org/r/705907 (https://phabricator.wikimedia.org/T218534) (owner: 10C. Scott Ananian) [12:48:36] (03Merged) 10jenkins-bot: Revert "Load Parsoid from vendor as fallback, and configure" [integration/quibble] - 10https://gerrit.wikimedia.org/r/705907 (https://phabricator.wikimedia.org/T218534) (owner: 10C. Scott Ananian) [13:00:09] (03PS1) 10Hashar: Release Quibble 1.0.1 [integration/quibble] - 10https://gerrit.wikimedia.org/r/707337 (https://phabricator.wikimedia.org/T287001) [13:00:11] (03PS1) 10Hashar: changelog: begin new 1.0.2 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/707338 [13:03:49] (03PS1) 10Zabe: Archive the FlvHandler extension [integration/config] - 10https://gerrit.wikimedia.org/r/707339 (https://phabricator.wikimedia.org/T285818) [13:09:42] (03CR) 10Hashar: [C: 03+2] changelog: begin new 1.0.2 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/707338 (owner: 10Hashar) [13:23:09] (03CR) 10Hashar: [C: 03+2] Release Quibble 1.0.1 [integration/quibble] - 10https://gerrit.wikimedia.org/r/707337 (https://phabricator.wikimedia.org/T287001) (owner: 10Hashar) [13:29:32] (03CR) 10Kosta Harlan: "> Patch Set 2:" [integration/quibble] - 10https://gerrit.wikimedia.org/r/705907 (https://phabricator.wikimedia.org/T218534) (owner: 10C. Scott Ananian) [13:29:34] (03PS1) 10Hashar: setup.cfg: replace dashes with underscores [integration/quibble] - 10https://gerrit.wikimedia.org/r/707345 [13:44:03] (03Merged) 10jenkins-bot: Release Quibble 1.0.1 [integration/quibble] - 10https://gerrit.wikimedia.org/r/707337 (https://phabricator.wikimedia.org/T287001) (owner: 10Hashar) [13:44:05] (03CR) 10jerkins-bot: [V: 04-1] changelog: begin new 1.0.2 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/707338 (owner: 10Hashar) [13:44:23] (03CR) 10Hashar: [C: 03+2] changelog: begin new 1.0.2 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/707338 (owner: 10Hashar) [13:45:57] !log Tag Quibble 1.0.1 @ 5a2548699a # T287001 [13:46:01] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:46:02] T287001: Core tests failing due to Flow HTTP requests and ServiceContainer access - https://phabricator.wikimedia.org/T287001 [13:48:02] (03CR) 10jerkins-bot: [V: 04-1] changelog: begin new 1.0.2 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/707338 (owner: 10Hashar) [13:50:33] (03PS1) 10Hashar: dockerfiles: update to Quibble 1.0.1 [integration/config] - 10https://gerrit.wikimedia.org/r/707348 (https://phabricator.wikimedia.org/T287001) [13:50:55] (03CR) 10Hashar: [C: 03+2] changelog: begin new 1.0.2 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/707338 (owner: 10Hashar) [14:04:30] (03CR) 10Hashar: [C: 03+2] "Lets build them now so we can eventually test them :)" [integration/config] - 10https://gerrit.wikimedia.org/r/707348 (https://phabricator.wikimedia.org/T287001) (owner: 10Hashar) [14:05:35] (03Merged) 10jenkins-bot: dockerfiles: update to Quibble 1.0.1 [integration/config] - 10https://gerrit.wikimedia.org/r/707348 (https://phabricator.wikimedia.org/T287001) (owner: 10Hashar) [14:08:18] !log Building Docker images for quibble 1.0.1 [14:08:22] (03Merged) 10jenkins-bot: changelog: begin new 1.0.2 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/707338 (owner: 10Hashar) [14:08:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:35:14] 10Gerrit: Make a PolyGerrit plugin to welcome new users - https://phabricator.wikimedia.org/T201246 (10Aklapper) [14:59:25] (03CR) 10Hashar: [C: 03+2] Archive the FlvHandler extension [integration/config] - 10https://gerrit.wikimedia.org/r/707339 (https://phabricator.wikimedia.org/T285818) (owner: 10Zabe) [15:01:04] (03Merged) 10jenkins-bot: Archive the FlvHandler extension [integration/config] - 10https://gerrit.wikimedia.org/r/707339 (https://phabricator.wikimedia.org/T285818) (owner: 10Zabe) [15:21:59] 10Gerrit, 10Release-Engineering-Team, 10Patch-For-Review: resolve gerrit.config disprepancy between managed config and gerrit init - https://phabricator.wikimedia.org/T287122 (10dancy) [15:29:58] (03PS33) 10Ahmon Dancy: Incremental mediawiki container image build process [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) [15:31:11] 10Gerrit, 10Regression: Gitiles monospaced text is bolded again - https://phabricator.wikimedia.org/T287189 (10hashar) I have asked upstream whether a new version can be cut, then it would be all about setting `GITILES_VERS = "0.5"` and adjust the checksum. An alternative is to build our own gitiles and publi... [15:31:30] (03CR) 10Ahmon Dancy: Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [15:49:50] dancy: I gave up on the java side of "gerrit init" :) [15:50:24] I think it is just bugged / need work when having a host with v4 and v6 and I thus gave up :] [15:50:57] nod. [15:55:07] will got that one deployed with m.utante early next week [16:09:15] 10Gerrit, 10Release-Engineering-Team, 10Patch-For-Review: resolve gerrit.config disprepancy between managed config and gerrit init - https://phabricator.wikimedia.org/T287122 (10thcipriani) After doing some grepping, it seems like the current on-disk config matches except for the listenAddress. Does gerrit i... [16:09:46] oh, I guess I should have looked at scrollback :) [16:44:20] (03PS34) 10Ahmon Dancy: Incremental mediawiki container image build process [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) [16:45:30] (03CR) 10Ahmon Dancy: Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [16:56:40] (03CR) 10Ahmon Dancy: "All comments so far have been addressed. Thanks for the reviews!" [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [19:12:41] selenium is failing on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Score/+/707507 and I've looked at the logs and can't actually find the failure [19:12:46] https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/33090/consoleFull [19:13:03] I'm 99% confident it's unrelated to my change, but it seems reliably failing [19:25:31] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 37.0.0 [tools/release] - 10https://gerrit.wikimedia.org/r/707530 (owner: 10Libraryupgrader) [19:25:55] 10Release-Engineering-Team (Doing), 10GitLab (Initialization), 10User-brennen: Experiment with gitlab-runners project and provision a pool of shared runners for general use - https://phabricator.wikimedia.org/T287279 (10brennen) [19:26:46] !log gitlab-runners: launched runner-1001, g3.cores8.ram36.disk20 to install baseline experimental runner (T287279) [19:26:49] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:26:49] T287279: Experiment with gitlab-runners project and provision a pool of shared runners for general use - https://phabricator.wikimedia.org/T287279 [19:38:56] well. I see the failure: karma:main in grunt qunit [19:39:30] I don't see what failed there... [19:41:16] maybe it's the sockethangup when requesting Special:JavaScriptTest/qunit/export [19:45:41] samething happened for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CodeMirror/+/707547 [19:52:25] 10Phabricator (Upstream), 10Upstream: After adding an action in Chrome on a device with a low resolution (e.g. phone), it cannot be removed (i.e. there is no cross on the right) - https://phabricator.wikimedia.org/T272788 (10IN) [21:20:45] (03CR) 10Jeena Huneidi: "This change is ready for review." [tools/scap] - 10https://gerrit.wikimedia.org/r/701615 (https://phabricator.wikimedia.org/T287041) (owner: 10Jeena Huneidi) [21:20:57] (03CR) 10jerkins-bot: [V: 04-1] [WIP] scap backport command [tools/scap] - 10https://gerrit.wikimedia.org/r/701615 (https://phabricator.wikimedia.org/T287041) (owner: 10Jeena Huneidi) [21:21:10] (03PS6) 10Jeena Huneidi: scap backport command [tools/scap] - 10https://gerrit.wikimedia.org/r/701615 (https://phabricator.wikimedia.org/T287041) [21:21:43] (03CR) 10jerkins-bot: [V: 04-1] scap backport command [tools/scap] - 10https://gerrit.wikimedia.org/r/701615 (https://phabricator.wikimedia.org/T287041) (owner: 10Jeena Huneidi) [21:26:49] (03PS7) 10Jeena Huneidi: scap backport command [tools/scap] - 10https://gerrit.wikimedia.org/r/701615 (https://phabricator.wikimedia.org/T287041) [21:27:20] (03CR) 10jerkins-bot: [V: 04-1] scap backport command [tools/scap] - 10https://gerrit.wikimedia.org/r/701615 (https://phabricator.wikimedia.org/T287041) (owner: 10Jeena Huneidi) [21:30:14] (03PS8) 10Jeena Huneidi: scap backport command [tools/scap] - 10https://gerrit.wikimedia.org/r/701615 (https://phabricator.wikimedia.org/T287041) [21:30:45] (03CR) 10jerkins-bot: [V: 04-1] scap backport command [tools/scap] - 10https://gerrit.wikimedia.org/r/701615 (https://phabricator.wikimedia.org/T287041) (owner: 10Jeena Huneidi) [21:32:16] (03PS9) 10Jeena Huneidi: scap backport command [tools/scap] - 10https://gerrit.wikimedia.org/r/701615 (https://phabricator.wikimedia.org/T287041) [21:35:20] (03PS10) 10Jeena Huneidi: scap backport command [tools/scap] - 10https://gerrit.wikimedia.org/r/701615 (https://phabricator.wikimedia.org/T287041) [21:43:55] legoktm: thcipriani i'm getting the same problem on all of my repos [21:45:44] hmm [21:45:53] maybe a core regression then? [21:46:13] yeh i think so [21:46:19] The karma:main job [21:46:32] I'm seeing it in Vector which doesn't use Grunt, so that would make sense [21:47:08] https://gerrit.wikimedia.org/r/q/project:mediawiki/core+branch:master+status:merged nothing looks suspicious. the LibUp commit just bumped svgo [21:49:40] yeh I suspect it's an extension introducing a QUnit test [21:49:51] since karma:main is basically an integration test of all unit tests [21:51:08] but wouldn't we see the qunit failure then? [21:51:22] I think thcipriani was onto something with the warnings around Special:JavaScriptTest/qunit/export [21:51:55] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/705678 looks like the only new qunit test I see [21:53:50] It was working at 11.04am and not working at 1.22pm so I reckon a patch within that timeframe [21:54:40] I looked through the integration project. I see some changes from this morning, but not to those jobs. I don't think anything has changed about the docker images running jobs. [21:54:54] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/707407 was submitted for testing after that WikimediaEvents patch landed and is passing [21:55:07] Jdlrobson: PDT or UTC? [21:55:09] in the CodeMirror patch, all tests are passing. so it's not an issue with qunit or the qunit tests. [21:55:13] legoktm: PDT [21:55:21] Krinkle: can I rebase that core change? [21:55:30] curious if it fails now [21:56:10] The reason karma exited non-zero is because: "Chrome Headless 90.0.4430.93 (Linux x86_64) ERROR Some of your tests did a full page reload!" [21:56:35] so it seems after the tests finished, and reported sucess, something tried to restart it [21:56:44] o.O [21:56:44] which then gets socket hangup because karma already started tearing down the chromium process. [21:57:06] is it deterministic? affecting other repos? [21:57:42] it's seemingly deterministic on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Score/+/707507 [21:58:35] it's affecting a few repos. Looking at common dependencies I see: https://gist.github.com/thcipriani/ae54e6107d7b40acff16ae626f87378a [21:59:16] (looking at EXT_DEPENDENCIES for 9 failing jobs and doing uniq -c ^) [22:00:34] right, that would explain core and wmf-integrated tests passing [22:00:42] so there's a common skin or extension that makes some repos fail [22:02:09] https://gerrit.wikimedia.org/r/q/is:merged+branch:master+project:%2522%255Emediawiki/(skin%257Cext).*%2522+-owner:libraryupgrader [22:08:10] okay, so, I think what's going on is that WikimediaEvents did indeed cause the issue. [22:08:24] It is setting mw.config without passing in the newMwEnvironment() to tear it down. [22:09:26] I'm guessing some other code in another repo is wrongly executing UI initialisation code during a test suite, and probably has been for a long time, but reacting badly to seeing `mw.config.get( 'wgAction' ) == 'history'` [22:09:28] FWIW, this is the first failure of this type that I see (for the php72-noselenium job anyway) https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/95446/ [22:13:35] thcipriani: that one is not faiing the same way. That's a normal assertino failure from incomplete code from the patch it tested against [22:13:47] "FAILED TESTS: ext.globalwatchlist.WatchlistUtils" [22:14:14] that patch is now passing: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/705472 [22:15:21] this was based on: https://gist.github.com/thcipriani/b02c0848ab2e441b21bc14ce40ed4ceb [22:15:48] (disregarding the early ones from march in the 68000 build numbers) [22:16:17] ok, that just means the quibble 'grunt qunit' task failed in some way. [22:16:31] most of those are going to be genuine assertion failures from CI doing its job [22:17:27] try looking for `Some of your tests did a full page reload` [22:18:34] * thcipriani greps [22:19:18] https://gist.github.com/thcipriani/fe1a23b1aa6d2a6ec2a8ea72fff0c206 [22:19:50] so that's around the time it was first noticed: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/96781/ [22:24:51] right, that's 20min after the WikimediaEvnets patch landed [22:25:35] I was already writing a follow-up patch to clean up some of the new WikimediaEvents tests as they're using a fairly odd pattern that is not established elsewhere (e.g. side-loading source files instead of loading them as dependencies, and a few other things). [22:25:42] I'll expedite this part of it. [22:26:14] <3 [22:26:55] Jdlrobson: mind +2'ing the qunit upgrade? I was going to showcase assert.true/false() in this follow-up patch :) https://gerrit.wikimedia.org/r/c/mediawiki/core/+/707407 [23:01:33] Krinkle: +2'd [23:05:08] can eslint warn about not using assert.ok/not, like your blog post?