[00:04:35] (03CR) 10Reedy: [C: 03+2] Add cover-skins/index.php [integration/docroot] - 10https://gerrit.wikimedia.org/r/709557 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [00:05:35] (03CR) 10Krinkle: [C: 03+2] Add cover-skins/index.php [integration/docroot] - 10https://gerrit.wikimedia.org/r/709557 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [00:06:10] (03Merged) 10jenkins-bot: Add cover-skins/index.php [integration/docroot] - 10https://gerrit.wikimedia.org/r/709557 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [00:26:45] (03PS1) 10Reedy: Less gref, more href [integration/docroot] - 10https://gerrit.wikimedia.org/r/709573 [00:27:31] (03CR) 10Reedy: [C: 03+2] Less gref, more href [integration/docroot] - 10https://gerrit.wikimedia.org/r/709573 (owner: 10Reedy) [00:28:17] (03Merged) 10jenkins-bot: Less gref, more href [integration/docroot] - 10https://gerrit.wikimedia.org/r/709573 (owner: 10Reedy) [00:40:39] (03CR) 10Krinkle: Add cover-skins/index.php (033 comments) [integration/docroot] - 10https://gerrit.wikimedia.org/r/709557 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [00:40:46] Reedy: ah, yes. [00:42:11] (03PS1) 10Reedy: And one more gref with feeling [integration/docroot] - 10https://gerrit.wikimedia.org/r/709574 [00:42:48] (03CR) 10Reedy: [C: 03+2] And one more gref with feeling [integration/docroot] - 10https://gerrit.wikimedia.org/r/709574 (owner: 10Reedy) [00:42:55] really the HTML spec should support common typos like this [00:43:30] (03Merged) 10jenkins-bot: And one more gref with feeling [integration/docroot] - 10https://gerrit.wikimedia.org/r/709574 (owner: 10Reedy) [00:43:36] heh [01:08:13] (03PS1) 10Reedy: WIP: Setup cover-skins jobs [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) [01:27:21] (03PS2) 10Reedy: WIP: Setup cover-skins jobs [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) [01:30:18] (03PS3) 10Reedy: WIP: Setup cover-skins jobs [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) [01:32:17] (03PS4) 10Reedy: WIP: Setup cover-skins jobs [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) [01:38:00] (03PS5) 10Reedy: WIP: Setup cover-skins jobs [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) [01:39:00] (03CR) 10jerkins-bot: [V: 04-1] WIP: Setup cover-skins jobs [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [01:50:14] (03PS6) 10Reedy: Setup cover-skins jobs [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) [01:56:32] (03CR) 10Reedy: "All of the copy paste... Probably somewhere near beyond bumping and rebuilding images to bring in the new/copy pasta shell scripts?" [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [02:02:25] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709577 [02:02:27] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709577 (owner: 10TrainBranchBot) [02:03:25] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709577 (owner: 10TrainBranchBot) [02:21:04] 10Project-Admins: Create a generic #SVG tag - https://phabricator.wikimedia.org/T287930 (10Volker_E) [02:21:30] 10Project-Admins: Create a generic #SVG tag - https://phabricator.wikimedia.org/T287930 (10Volker_E) [02:23:05] 10Project-Admins: Create a generic #SVG tag - https://phabricator.wikimedia.org/T287930 (10Volker_E) [02:36:40] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709581 [02:36:42] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709581 (owner: 10TrainBranchBot) [02:37:42] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709581 (owner: 10TrainBranchBot) [03:11:32] (03CR) 10Krinkle: Setup cover-skins jobs (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [05:54:23] hashar: oh! I think i found a better fix for the mobile issue: https://gerrit-review.googlesource.com/c/gerrit/+/313467 [07:18:37] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Phatality, 10Wikimedia-Logstash, 10observability: Phatality doesn't work with Kibana 7 - https://phabricator.wikimedia.org/T272655 (10fgiunchedi) [07:38:40] paladox possibly? :D Javascript / DOM are an entire mystery to me nowadays [07:51:01] (03PS1) 10Awight: Review access change [analytics/reportupdater-queries] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/709646 [12:27:46] 10Release-Engineering-Team (Doing): ReleaseNotesBot no longer posting deploy notes - https://phabricator.wikimedia.org/T287627 (10hashar) [12:28:37] 10Continuous-Integration-Config, 10Release-Engineering-Team (Next), 10Wikibase (3rd party installations), 10Wikidata, and 3 others: Move some Wikibase selenium tests to a standalone job - https://phabricator.wikimedia.org/T287582 (10hashar) [12:35:13] 10Release-Engineering-Team (Seen): jenkins-bot LDAP entry contains pmtpa references - https://phabricator.wikimedia.org/T198271 (10hashar) 05Open→03Resolved a:03hashar I have deleted the key since it had a `from="10.4.0.58"` restriction. We have long moved out of that IP block. [12:46:25] 10Release-Engineering-Team (Seen), 10Browser-Tests: [Bug] SSL failure doesn't cause browser test to be marked as failed - https://phabricator.wikimedia.org/T214047 (10hashar) 05Open→03Declined Declining since that was related to the ruby based MediaWiki selenium which we have dropped back in 2017 in favor... [12:51:46] 10MediaWiki-Releasing, 10Release-Engineering-Team (Seen): Remove 1.32-rc.1 folder from releases.wikimedia.org/mediawiki/ - https://phabricator.wikimedia.org/T225324 (10hashar) 05Open→03Resolved a:03hashar I have deleted `/srv/org/wikimedia/releases/mediawiki/1.32-rc.1/` from both releases1002 and release... [12:53:59] 10Diffusion, 10Release-Engineering-Team (Seen), 10Developer Productivity: Reduce task notification noise/frequency of changes to associated open patchsets - https://phabricator.wikimedia.org/T143162 (10fgiunchedi) >>! In T143162#7252814, @Krinkle wrote: >>>! In T143162#7252768, @mmodell wrote: >> @krinkle: F... [13:18:01] 10Phabricator, 10User-Addshore: Convert "Addbot" phabricator account to a bot account before it start making changes - https://phabricator.wikimedia.org/T287744 (10Addshore) **Name **: `Addbot` **Purpose **: Initially querying the Phabricator API to pull task information out and put it into a google sheet, in... [13:31:31] 10Release-Engineering-Team (Doing), 10Wikidata, 10Wikidata-Query-Service, 10Discovery-Search (Current work): wikidata-query-rdf-maven-release-docker build is too slow and always times out - https://phabricator.wikimedia.org/T287445 (10dcausse) The build succeeded yesterday in 12 minutes: ` 19:13:39 [INFO]... [13:36:36] 10Phabricator, 10User-Addshore: Convert "Addbot" phabricator account to a bot account before it start making changes - https://phabricator.wikimedia.org/T287744 (10Aklapper) a:03Aklapper * Deleted normal user https://phabricator.wikimedia.org/p/Addbot/ via `sudo /srv/phab/phabricator/bin/remove destroy @Addb... [13:37:31] 10Release-Engineering-Team (Seen), 10Wikidata, 10wdwb-tech, 10MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), and 3 others: Stop using jsonlint and instead use eslint-plugin-json for the linting - https://phabricator.wikimedia.org/T220036 (10Addshore) p:05Medium→03Low [13:43:13] 10Phabricator, 10User-Addshore: Convert "Addbot" phabricator account to a bot account before it start making changes - https://phabricator.wikimedia.org/T287744 (10Addshore) I'm pretty sure it is working! (Though because of caching of webrequests in my google sheets it'll take a little while to all look fixed!) [13:43:34] 10Phabricator, 10User-Addshore: Convert "Addbot" phabricator account to a bot account before it start making changes - https://phabricator.wikimedia.org/T287744 (10Addshore) 05Open→03Resolved will reopen if it continues to not work once the caches are gone [13:51:06] 10Continuous-Integration-Config, 10Wikidata, 10wdwb-tech: Investigate moving some Wikibase tests to @group Standalone - https://phabricator.wikimedia.org/T285950 (10Addshore) [14:10:31] 10Project-Admins: Create a generic #SVG tag - https://phabricator.wikimedia.org/T287930 (10Bugreporter) [14:25:39] 10Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), 10Phatality, 10SRE Observability, 10Wikimedia-Logstash, 10observability: Phatality doesn't work with Kibana 7 - https://phabricator.wikimedia.org/T272655 (10herron) [14:31:30] 10Project-Admins: Create a generic #SVG tag - https://phabricator.wikimedia.org/T287930 (10Aklapper) Same as T194188: Generally in favor; though I'd like to see a sentence explaining when to use #Wikimedia-SVG-rendering instead. [14:31:53] 10Continuous-Integration-Config, 10Wikidata, 10wdwb-tech, 10Patch-For-Review, and 2 others: Run CI tests daily on master for ungated extensions - https://phabricator.wikimedia.org/T285049 (10Ladsgroup) I haven't forgotten about this. It's just that no one has looked at my patch to see if it'll work or not :( [15:05:43] (03CR) 10Reedy: Setup cover-skins jobs (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [15:23:58] (03CR) 10Krinkle: Setup cover-skins jobs (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [15:26:27] (03CR) 10Krinkle: "Yeah, splitting makes sense. That also gives you space to confirm that the image rebuilding works and passes, possibly iterate, and then p" [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [15:51:10] (03CR) 10Reedy: "Should I be splitting the dockerfiles to one commit (and the changelog rebuild which isn't here just yet), the JJB ontop of that (with the" [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [15:52:51] (03CR) 10Jforrester: "> Patch Set 6:" [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [15:53:26] (03CR) 10Reedy: "I'll do that later today then :)" [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [16:08:47] (03CR) 10Ahmon Dancy: [C: 03+2] pom: overwrite gerrit.war [software/gerrit] (deploy/wmf/stable-3.2) - 10https://gerrit.wikimedia.org/r/709509 (owner: 10Hashar) [16:09:00] (03Merged) 10jenkins-bot: pom: overwrite gerrit.war [software/gerrit] (deploy/wmf/stable-3.2) - 10https://gerrit.wikimedia.org/r/709509 (owner: 10Hashar) [16:09:07] (03PS7) 10Reedy: Setup cover-skins jobs [integration/config] - 10https://gerrit.wikimedia.org/r/709575 (https://phabricator.wikimedia.org/T287918) [16:09:10] (03PS1) 10Reedy: Add scripts to quibble-buster-php73-coverage for cover-skins [integration/config] - 10https://gerrit.wikimedia.org/r/709744 (https://phabricator.wikimedia.org/T287918) [16:09:12] (03PS1) 10Reedy: JJB changes for cover-skins [integration/config] - 10https://gerrit.wikimedia.org/r/709745 (https://phabricator.wikimedia.org/T287918) [16:11:13] (03CR) 10Reedy: "Still needs https://www.mediawiki.org/wiki/Continuous_integration/Docker#Adjusting_an_image doing" [integration/config] - 10https://gerrit.wikimedia.org/r/709744 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [16:13:15] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments: 1.37.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T281158 (10dduvall) >>! In T281158#7253300, @Ladsgroup wrote: > o/ If you see anything with flagged revs, ping me. Thanks! Is there any risky patch in particular that bea... [16:16:19] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments: 1.37.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T281158 (10Ladsgroup) It's https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/709218 but I don't think it's big enough to warrant a "risky patch" comment [16:18:26] (03CR) 10Ahmon Dancy: [C: 03+2] Merge branch 'wmf/stable-3.2' into wmf/stable-3.3 [software/gerrit] (wmf/stable-3.3) - 10https://gerrit.wikimedia.org/r/705934 (https://phabricator.wikimedia.org/T262241) (owner: 10Hashar) [16:19:23] (03CR) 10Reedy: "seems docker-pkg doesn't quite like me atm..." [integration/config] - 10https://gerrit.wikimedia.org/r/709744 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [16:20:06] (03CR) 10Reedy: [C: 04-1] "This needs version bumps when we know what versions they are going to be..." [integration/config] - 10https://gerrit.wikimedia.org/r/709745 (https://phabricator.wikimedia.org/T287918) (owner: 10Reedy) [16:23:44] (03CR) 10Ahmon Dancy: [C: 03+2] Gerrit 3.3.5 + plugins [software/gerrit] (deploy/wmf/stable-3.3) - 10https://gerrit.wikimedia.org/r/709501 (https://phabricator.wikimedia.org/T262241) (owner: 10Hashar) [16:27:01] (03Merged) 10jenkins-bot: Merge branch 'wmf/stable-3.2' into wmf/stable-3.3 [software/gerrit] (wmf/stable-3.3) - 10https://gerrit.wikimedia.org/r/705934 (https://phabricator.wikimedia.org/T262241) (owner: 10Hashar) [16:27:07] (03Merged) 10jenkins-bot: Gerrit 3.3.5 + plugins [software/gerrit] (deploy/wmf/stable-3.3) - 10https://gerrit.wikimedia.org/r/709501 (https://phabricator.wikimedia.org/T262241) (owner: 10Hashar) [16:36:03] '4d945db823e5f6ca6dd83ad1f5fbcc43' => $vendorDir . '/wikimedia/relpath/src/RelPath/RelPath.php', [16:36:03] '6513700b70192b7dfd0e5e9fc8082cf3' => $vendorDir . '/wikimedia/relpath/src/Wikimedia/RelPath.php', [16:36:07] Huh, we still have both? [16:52:17] Krinkle: No one has tagged a release since 2018 :D [16:52:27] https://github.com/wikimedia/RelPath/compare/2.1.1...master [16:52:49] looks pretty overdue [16:54:04] Shouldn't be difficult... Tag a v3 and rollout [16:54:50] Ah, ok. That explains. [16:54:52] * Krinkle does [16:55:37] Krinkle: https://gerrit.wikimedia.org/r/c/RelPath/+/709786 for the changelog fix [16:55:51] Probably wants a few rows adding [16:55:52] * Reedy looks [16:57:12] Meh, not particularl [16:57:15] Most of it is build stuff [16:58:05] Added one line that's observable to the API [16:58:08] (types) [16:58:16] hm.. Gerrit moved its cheeses around a bit today [16:58:28] "Bring to the attention of: Reedy" [16:58:41] Heh, yeah [16:58:44] https://gerrit-review.googlesource.com/Documentation/user-attention-set.html [16:58:45] Some review stuff [16:59:21] So "Assignee", "Owner", "Reviewer", and "CC" wasn't enough [16:59:25] lol [16:59:25] now we have Attention set as well. [16:59:31] Eww, the new gerrit has very slightly different colours for the SUCCESS/FAILURE labels and clearly this is the end of the world! ;-) [16:59:43] James_F: ^ in our infinite free time/when we get bored... We're probably should do another round of "which libs do we need to do the periodic bumps for" [17:00:05] Reedy: Yeah, our last task was April 2019 I think? [17:00:15] also, apparently the latest change ate away the padding in the name bubbles. [17:00:21] looks unintended. [17:00:22] Indeed. [17:00:47] `cancel-left-padding=""` [17:00:53] well, it's intended alright. [17:00:56] * Krinkle shrugs [17:02:08] oh, I see. attention set is not a new group [17:02:12] it's a marker you can pass around [17:02:16] Yeah. [17:02:38] so basically they formalised temporary assignee changes. So if you have a change and assign review to me, I can bring it back to you without changing the assignee field. [17:02:41] Yup. [17:02:55] That's not entirely terrible. And it shows why it changed as well. Time saver, I guess. [17:03:12] https://usercontent.irccloud-cdn.com/file/TohHNZio/Screenshot%202021-08-03%20at%2018.01.59.png [17:03:41] Reedy: wanna tag then? [17:04:56] >Error 403 (Forbidden): Cannot create annotated tag "refs/tags/3.0.0" [17:05:03] 10Release-Engineering-Team (Doing), 10Gerrit (Gerrit 3.3), 10Patch-For-Review: Upgrade Gerrit to 3.3 - https://phabricator.wikimedia.org/T262241 (10hashar) 05Open→03Resolved [17:05:21] * Reedy fixes [17:05:27] 10Release-Engineering-Team (Doing), 10Gerrit (Gerrit 3.3), 10Patch-For-Review: Upgrade Gerrit to 3.3 - https://phabricator.wikimedia.org/T262241 (10hashar) a:05hashar→03dancy We are now running Gerrit 3.3 . The deployment got conducted by @dancy with @brennen and @hashar assisting. [17:06:30] Krinkle: Assignee is gone :] [17:07:14] hashar: oh! [17:07:16] right [17:07:20] even better [17:07:21] Reedy: I swear there's a task to follow-on from, but all I can find is T235266 (for third party deps) and T182273 (from ages ago) [17:07:22] T182273: Tag releases of wikimedia libraries, bump in core and update usages - https://phabricator.wikimedia.org/T182273 [17:07:22] T235266: Composer Library Updates, late 2019/early 2020 edition - https://phabricator.wikimedia.org/T235266 [17:07:24] https://packagist.org/packages/wikimedia/relpath has it now. Just gotta wait for their caches to expire [17:07:24] the idea is that as a developer you would add some folks as reviewers and raise their attention [17:07:36] then if you get the attention from one, you would go back and forth with that person [17:07:40] James_F: Yeah.. I thought we'd done something too... Maybe [17:07:48] then you can raise attention to someone else for the final approval [17:08:00] it is a slight enhancement to the previous workflow [17:08:12] Reedy: Oh, maybe I'm thinking of T271575? [17:08:12] T271575: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0 - https://phabricator.wikimedia.org/T271575 [17:08:29] heh, possibly. We've done different bumps for different reasons... [17:08:32] Yeah. [17:09:30] Created T287972. [17:09:30] T287972: Make new releases of all Wikimedia-authored libraries, and bump their usages (mid-2021) - https://phabricator.wikimedia.org/T287972 [17:09:52] Cheers. Worth potentially doing some point releases even if major ones aren't needed [17:10:03] Yeah. [17:11:13] Do we have a nice list of our libraries? [17:11:39] A nice one? Probably not [17:11:52] :-D [17:11:59] mediawiki-vendor/composer.json and grep for wikimedia or mediawiki prefixes? :P [17:12:06] Or https://packagist.org/?query=wikimedia [17:12:24] Ah, https://packagist.org/packages/wikimedia/ exists. [17:14:45] there's also https://packagist.org/packages/mediawiki/ which has a lot of weird stuff in it [17:15:07] Oh goody, rando-extension spam. [17:15:15] Let's pretend that doesn't exist. [17:15:31] oh [17:15:43] so some cmoe from some very early experiment we did to ship extensions via composer/packagist [17:15:49] and are afaik of no use [17:15:58] except you'll enrage people if you remove them [17:16:05] there might be some coming from Jeroen DeDauw as well [17:16:09] That's… the idea? [17:16:21] James_F: I think most of our mediawiki/ ones are dev dependancies, so we probably don't "care" about them in this cycle [17:16:26] Ack. [17:16:46] I think the experiment I did had a custom composer installer to have the downloaded extension to be written to ./extensions/Foobar instead of vendor/mediawiki/foobar [17:16:54] Anyway, T287972 now has a list of all the current ones in wikimedia/. [17:16:54] T287972: Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021) - https://phabricator.wikimedia.org/T287972 [17:17:00] with dash separated to camelcase rewritting [17:17:10] so possibly we can drop those [17:17:22] hashar: That can be your epic project. We'll do this one instead. ;-) [17:17:31] touché [17:18:09] seems like anyone can add a apackage under wikimedia or mediawiki namespace ? [17:18:53] anyway good luck. I am off for dinner [17:19:40] AFAIK, yeah [17:19:47] No idea of "protected" namespaces [17:19:53] So then people come thinking it's official [17:23:20] Oh, hmm, the "hide bot comments" toggle is gone. [17:24:08] 10Continuous-Integration-Config, 10Release-Engineering-Team (Doing): Create a coverage job for skins - https://phabricator.wikimedia.org/T265407 (10hashar) [17:24:10] 10Continuous-Integration-Config, 10Patch-For-Review, 10Test-Coverage: Enable coverage on all WMF deployed and MW bundled skins - https://phabricator.wikimedia.org/T287918 (10hashar) [17:24:46] 10Continuous-Integration-Config, 10Release-Engineering-Team (Doing): Create a coverage job for skins - https://phabricator.wikimedia.org/T265407 (10hashar) That got resurrected via T287918 [17:26:24] wheee :) [17:26:59] (03CR) 10Ahmon Dancy: "> Patch Set 48:" (032 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [17:27:07] James_F: lack of filtering of autogenerated / robot comments sounds like a regression :-\ [17:28:04] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: Request access to deployment-prep - https://phabricator.wikimedia.org/T286584 (10mepps) As the engineering manager supporting AHT while Jay Cano is out, I approve this. I'm tagging the Release-Engineering-Team based on the other ticket. [17:34:17] Reedy: Oh, yeah, what do you want to do about https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/682004 ? Whether or not upstream has fixed it for others, we've not updated to versions which remove them… [17:34:39] James_F: so the CI messages are shown solely for the current patchset and the messages send to previous patchsets are hidden by default [17:34:47] can be seen at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/709204 which had several patchset [17:35:01] flipping "show all entries" will show the CI messages on PS3 and before [17:35:07] found that via https://www.gerritcodereview.com/2020-05-06-change-log-experiment.html [17:35:20] James_F: I guess *ideally* we should do some other updates from upstreams... :D [17:35:24] There's also EXPAND ALL on the right. [17:35:36] oh, but that only applies to the shown comments. [17:35:41] ignore me. :-) [17:35:45] Reedy: Yeah yeah. [17:35:58] Could be something to do during the Wikimania hackathon? [17:36:08] "Submit including parents" is new. [17:36:10] hashar: But doesn't hide the bot comments. :-( [17:36:18] yeah [17:36:37] hashar: My normal use case is "this patch has dozens of patchsets, I want to make sure I've replied to every comment before we merge". [17:36:48] those kind of changes are driven by Google UX folks based on usage metrics and internal surveys [17:36:50] Hide-old-PS-comments is actively useless. [17:37:08] apparently from the blog post feedback can be send to https://bugs.chromium.org/p/gerrit/issues/entry?template=Experiment+Change+Log [17:37:36] From a year ago? They'll probably ignore feedback this 'late'. [17:37:38] for comments you have not replied to, they should still be in "unresolved" state [17:37:55] or maybe that can got further tuned in gerrit 3.4 [17:38:03] Yeah. [17:41:41] were patch set comments changed to be like file comments in Gerrit 3.3, or am I being confused by the interface? [17:44:10] Lucas_WMDE: that surprised me too [17:46:28] I think I’ll get used to it but it’s pretty irritating at the moment ^^ [17:46:39] Lucas_WMDE: yes that is a change indeed. I tried a bit and did not find it to be a concern [17:46:57] it is listed as a new feature, second bullet at https://www.gerritcodereview.com/3.3.html#new-features [17:47:33] I don't have the reasoning behind that change though :-\ [17:48:09] I can see how it would be useful, having several parallel threads that aren’t attached to any particular part of the code [17:48:17] and being able to mark them as resolved or unresolved [17:48:28] at least I’m assuming that’s possible, based on how it looks in the UI [17:49:14] Will "recheck" work with the new comment system? [17:49:24] > This is useful if your CI system parses back change messages (e.g. “/rerun”) and has not been updated yet to parse patchset level comments. [17:49:29] it should yes [17:49:52] Sounds like a test is in order [17:49:53] that actually got broken in stream-events which got caught cause that broke bunch of CI system relying on `/rerun` or our `recheck` [17:50:04] and I tested it locally with zuul [17:50:12] Nice [17:50:12] but maybe I got confused and failed my test :-\ [17:52:01] yeah that works. I commented `recheck` on https://gerrit.wikimedia.org/r/c/test/gerrit-ping/+/683803 and that enqueued the job https://integration.wikimedia.org/zuul/#q=gerrit-ping [17:52:19] awesome [17:52:51] one of Gerrit maintainer also maintain a Jenkins plugin for gerrit and must have noticed the potential breakage [17:53:03] even before 3.3.0 got cut or during the rc phase [17:53:07] (03CR) 10Jeena Huneidi: [C: 03+1] Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [17:53:18] UI changes are confusing [17:53:42] anyway I am off for dinner and a game of Cluedo [17:54:28] hmm, my notification mails now come with "null" before the comment location :/ [17:55:38] https://en.wikipedia.org/wiki/Cluedo [17:57:08] (03CR) 10Dduvall: "Overall, amazing work. The performance gains this yields, at build time, in registry storage, at deployment, are huge and can't be oversta" [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [18:03:16] hi releng! Im trying to debug a container inside my local minikube cluster, and i very simply want to go in and put some console logs to see whats going on, but i might be misunderstanding the architecture a bit as I can't seem to get the logs to output. Would anyone be able to help me out? [18:05:57] (03PS50) 10Ahmon Dancy: Incremental mediawiki container image build process [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) [18:06:08] (03CR) 10Ahmon Dancy: Incremental mediawiki container image build process (033 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [18:06:44] Hi nikkinikk_. I might be able to help. How would you like to work through it? [18:07:54] dancy: appreciate it! I can DM you? [18:08:01] (03CR) 10Dduvall: Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [18:08:01] Yep [18:09:32] (03CR) 10Ahmon Dancy: Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [18:34:43] Hey there I'm trying to work out how to use the new "attention set" feature in Gerrit. [18:34:46] https://gerrit.wikimedia.org/r/q/project:mediawiki/skins/Vector+AND+status:open+AND+is:unassigned [18:34:58] I want to find all patches without attention set. Does anyone know what query I should be used? [18:37:27] A quick check of the search docs doesn't show any way to (efficiently) do a query like that [18:38:13] I guess I should raise a bug dancy ? [18:38:35] Nod. [18:38:50] Btw, was there a way to do a similar query for no-assignee prior to the upgrade? [18:39:39] yep [18:39:46] is:assigned [18:40:09] so did you do something like "NOT is:assigned" before? [18:43:02] seems so. That (or -is:assigned) does work. No such thing for "NOT attention:" [18:44:38] I did [18:44:39] https://gerrit.wikimedia.org/r/q/(hashtag:%2522team:readingweb%2522+OR+project:mediawiki/extensions/MobileFrontend+OR+project:mediawiki/extensions/Popups+OR+project:mediawiki/extensions/QuickSurveys+OR+project:mediawiki/extensions/RelatedArticles+OR+project:mediawiki/extensions/WikidataPageBanner+OR+project:mediawiki/skins/MinervaNeue+OR+project:mediawiki/skins/Vector)+AND+status:open+AND+NOT+is:wip+AND+NOT+is:assigned+AN [18:44:39] D+NOT+hashtag:%2522priority:low%2522+AND+NOT+hashtag:%2522team:wmde%2522++AND+NOT+hashtag:%2522team:growth%2522+AND+NOT+hashtag:%2522team:editing%2522+AND+NOT+hashtag:%2522team:qte%2522+NOT+hashtag:%2522status:blocked%2522+AND+NOT+hashtag:%2522team:security%2522+AND+NOT+hashtag:%2522team:product-infrastructure%2522)+ before [18:44:47] long query :) [18:45:15] Raised a task to capture. It's possible I just need to rethink our old process. [18:47:04] hmm.. seems like the bug submitter is not working for me rightn ow [19:15:38] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments: 1.37.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T281158 (10dduvall) >>! In T281158#7256035, @Ladsgroup wrote: > It's https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/709218 but I don't think it's big... [19:20:31] https://bugs.chromium.org/p/gerrit/issues/detail?id=14856 < @dancy [19:27:14] 👍🏾 [19:37:34] 10Release-Engineering-Team (Radar), 10Platform Engineering, 10Wikimedia-production-error: PHP Warning: Class __PHP_Incomplete_Class has no unserializer - https://phabricator.wikimedia.org/T287988 (10dduvall) p:05Triage→03Unbreak! [19:37:54] 10Release-Engineering-Team (Radar), 10Platform Engineering, 10Wikimedia-production-error: PHP Warning: Class __PHP_Incomplete_Class has no unserializer - https://phabricator.wikimedia.org/T287988 (10dduvall) [19:37:56] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments: 1.37.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T281158 (10dduvall) [19:39:19] 10Release-Engineering-Team (Radar), 10Platform Engineering, 10Patch-For-Review, 10Wikimedia-production-error: PHP Warning: Class __PHP_Incomplete_Class has no unserializer - https://phabricator.wikimedia.org/T287988 (10dduvall) IRC discussion suggests https://gerrit.wikimedia.org/r/c/mediawiki/core/+/69127... [19:39:37] 10Release-Engineering-Team (Radar), 10Performance-Team, 10Platform Engineering, 10Patch-For-Review, 10Wikimedia-production-error: PHP Warning: Class __PHP_Incomplete_Class has no unserializer - https://phabricator.wikimedia.org/T287988 (10dduvall) [19:42:58] 10Release-Engineering-Team (Radar), 10Performance-Team, 10Platform Engineering, 10Wikimedia-Rdbms, and 2 others: PHP Warning: Class __PHP_Incomplete_Class has no unserializer - https://phabricator.wikimedia.org/T287988 (10Majavah) [19:48:30] 10Release-Engineering-Team (Radar), 10Performance-Team, 10Wikimedia-Rdbms, 10Patch-For-Review, 10Wikimedia-production-error: PHP Warning: Class __PHP_Incomplete_Class has no unserializer - https://phabricator.wikimedia.org/T287988 (10Krinkle) [20:00:04] (03CR) 10Thcipriani: Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [20:02:23] (03PS51) 10Ahmon Dancy: Incremental mediawiki container image build process [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) [20:02:30] (03CR) 10Ahmon Dancy: Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [20:06:07] 10Release-Engineering-Team (Doing), 10MW-on-K8s, 10MediaWiki Train Development Environment, 10Release Pipeline: Train-dev: Ability to deploy to k8s - https://phabricator.wikimedia.org/T287993 (10jeena) [20:11:46] 10Release-Engineering-Team (Doing), 10MW-on-K8s, 10Release Pipeline, 10User-brennen: Scap backport change_url command - https://phabricator.wikimedia.org/T287042 (10jeena) [20:29:39] (03CR) 10Thcipriani: [C: 03+1] "Can confirm this works locally with https://github.com/dancysoft/image-test-hacks" [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [20:38:23] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709823 [20:38:25] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709823 (owner: 10TrainBranchBot) [20:39:29] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709823 (owner: 10TrainBranchBot) [20:52:06] (03CR) 10Brennen Bearnes: "> Patch Set 1:" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/704765 (owner: 10Jforrester) [21:00:07] (03CR) 10Thcipriani: [C: 04-1] Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [21:07:50] (03PS8) 10Brennen Bearnes: add buster php images [releng/dev-images] - 10https://gerrit.wikimedia.org/r/698880 (https://phabricator.wikimedia.org/T273100) [21:09:20] (03CR) 10Jeena Huneidi: [C: 03+2] add buster php images [releng/dev-images] - 10https://gerrit.wikimedia.org/r/698880 (https://phabricator.wikimedia.org/T273100) (owner: 10Brennen Bearnes) [21:09:31] (03CR) 10Jeena Huneidi: [V: 03+2 C: 03+2] add buster php images [releng/dev-images] - 10https://gerrit.wikimedia.org/r/698880 (https://phabricator.wikimedia.org/T273100) (owner: 10Brennen Bearnes) [21:09:40] jeena: https://gerrit.wikimedia.org/r/c/mediawiki/tools/cli/+/709827 ;) [21:09:59] (03CR) 10Jeena Huneidi: [V: 03+2 C: 03+2] Rename buster to fundraising-buster, create a buster top-level image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/698878 (https://phabricator.wikimedia.org/T273100) (owner: 10Brennen Bearnes) [21:10:10] (03CR) 10Jeena Huneidi: [V: 03+2 C: 03+2] Move common files out of stretch so they can be re-used [releng/dev-images] - 10https://gerrit.wikimedia.org/r/704765 (owner: 10Jforrester) [21:12:31] !log Updating dev-images docker-pkg files on primary contint for [[gerrit:698880|add buster php images]] [21:12:33] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:14:40] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709828 [21:14:42] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709828 (owner: 10TrainBranchBot) [21:16:02] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709828 (owner: 10TrainBranchBot) [21:28:50] 10Continuous-Integration-Infrastructure, 10MediaWiki-Docker, 10mwcli, 10Patch-For-Review: Set up CI for mwcli - https://phabricator.wikimedia.org/T248779 (10Addshore) But most recently my gitlab CI tests ran into some issues due to rate limits {F34575126} I guess I could add a secret for the CI runner /... [21:35:13] there's been a client error spike. https://grafana.wikimedia.org/d/000000566/overview?viewPanel=16&orgId=1 I'm looking into it. Looks like a gadget [21:35:21] (03PS1) 10Brennen Bearnes: WIP: log to stderr / stdout [releng/dev-images] - 10https://gerrit.wikimedia.org/r/709831 [21:40:06] (03PS2) 10Brennen Bearnes: WIP: add buster-apache2, log errors to stdio [releng/dev-images] - 10https://gerrit.wikimedia.org/r/709831 [21:43:59] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments, 10User-jeena: 1.37.0-wmf.19 deployment blockers - https://phabricator.wikimedia.org/T281160 (10jeena) [21:44:13] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments, 10User-jeena: 1.37.0-wmf.19 deployment blockers - https://phabricator.wikimedia.org/T281160 (10jeena) [21:44:25] (03PS3) 10Brennen Bearnes: WIP: add buster-apache2, log errors to stdio [releng/dev-images] - 10https://gerrit.wikimedia.org/r/709831 (https://phabricator.wikimedia.org/T283416) [21:44:34] addshore: Thanks! will take a look [21:52:45] (03CR) 10Ahmon Dancy: Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [21:54:22] (03PS4) 10Brennen Bearnes: WIP: add buster-apache2, log errors to stdio [releng/dev-images] - 10https://gerrit.wikimedia.org/r/709831 (https://phabricator.wikimedia.org/T283416) [21:57:02] (03CR) 10Ahmon Dancy: Incremental mediawiki container image build process (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [22:01:02] (03PS5) 10Brennen Bearnes: WIP: add buster-apache2, log errors to stdio [releng/dev-images] - 10https://gerrit.wikimedia.org/r/709831 (https://phabricator.wikimedia.org/T283416) [22:03:21] (03PS6) 10Brennen Bearnes: WIP: add buster-apache2, log errors to stdio [releng/dev-images] - 10https://gerrit.wikimedia.org/r/709831 (https://phabricator.wikimedia.org/T283416) [22:13:53] 10Release-Engineering-Team (Doing): ReleaseNotesBot no longer posting deploy notes - https://phabricator.wikimedia.org/T287627 (10Krinkle) > The loop is kinda superfluous, but was there before... Previously the loop was iterating over "pages", where each page had a token in its array. Now, the loop is iterati... [22:14:23] (03PS52) 10Ahmon Dancy: Incremental mediawiki container image build process [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) [22:14:39] Reedy: ;-) [22:14:49] not sure if you realized that already, sounded like you hadn't yet [22:15:32] Krinkle: Second pair of eyes is often helpful :P [22:15:46] (03CR) 10Ahmon Dancy: Incremental mediawiki container image build process (034 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [22:15:47] Krinkle: Though... https://phabricator.wikimedia.org/T287627#7244306 [22:15:49] >return $x['query']['tokens']['csrftoken'] ?? ''; [22:15:57] I guess I'd kinda got it, without realising :P [22:16:20] right, that alternative definitely works [22:16:44] surpressing the error might be better not to though [22:16:58] not sure if that works across the retry [22:17:01] if it does then great [22:17:11] yeah, the ?? '' isn't necessarily needed [22:19:50] (03PS1) 10TrainBranchBot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709838 [22:19:52] (03CR) 10TrainBranchBot: [C: 03+2] Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709838 (owner: 10TrainBranchBot) [22:20:56] (03Merged) 10jenkins-bot: Update state/train-versions.json [tools/release] - 10https://gerrit.wikimedia.org/r/709838 (owner: 10TrainBranchBot) [22:21:57] (03PS3) 10Reedy: Fix make-deploy-notes token fetching [tools/release] - 10https://gerrit.wikimedia.org/r/709792 (https://phabricator.wikimedia.org/T287627) [22:23:27] (03CR) 10Reedy: [C: 03+2] Fix make-deploy-notes token fetching [tools/release] - 10https://gerrit.wikimedia.org/r/709792 (https://phabricator.wikimedia.org/T287627) (owner: 10Reedy) [22:24:10] (03Merged) 10jenkins-bot: Fix make-deploy-notes token fetching [tools/release] - 10https://gerrit.wikimedia.org/r/709792 (https://phabricator.wikimedia.org/T287627) (owner: 10Reedy) [22:27:36] (03PS3) 10Reedy: Fix botclasses.php whitespace [tools/release] - 10https://gerrit.wikimedia.org/r/709793 [22:27:43] (03CR) 10Reedy: [C: 03+2] Fix botclasses.php whitespace [tools/release] - 10https://gerrit.wikimedia.org/r/709793 (owner: 10Reedy) [22:28:29] (03Merged) 10jenkins-bot: Fix botclasses.php whitespace [tools/release] - 10https://gerrit.wikimedia.org/r/709793 (owner: 10Reedy) [22:33:14] 10Release-Engineering-Team (Doing), 10Patch-For-Review: ReleaseNotesBot no longer posting deploy notes - https://phabricator.wikimedia.org/T287627 (10Reedy) 05Open→03Resolved a:03Reedy [22:39:09] 10Release-Engineering-Team (Doing), 10Release, 10Train Deployments: 1.37.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T281158 (10dduvall) [22:39:42] 10Release-Engineering-Team (Radar), 10Performance-Team, 10Wikimedia-Rdbms, 10MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), and 2 others: PHP Warning: Class __PHP_Incomplete_Class has no unserializer - https://phabricator.wikimedia.org/T287988 (10dduvall) 05Open→03Resolved a:03dduvall I'm no longer seein... [22:43:13] 10Release-Engineering-Team (Radar), 10Performance-Team, 10Wikimedia-Rdbms, 10MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), and 2 others: PHP Warning: Class __PHP_Incomplete_Class has no unserializer - https://phabricator.wikimedia.org/T287988 (10Krinkle) [22:43:30] 10Release-Engineering-Team (Radar), 10Performance-Team, 10Wikimedia-Rdbms, 10MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), and 2 others: PHP Warning: Class __PHP_Incomplete_Class has no unserializer - https://phabricator.wikimedia.org/T287988 (10Krinkle) {meme, src="opcache-was-here"} [22:46:48] (03CR) 10Dduvall: [C: 03+2] Incremental mediawiki container image build process [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [22:47:48] (03Merged) 10jenkins-bot: Incremental mediawiki container image build process [tools/release] - 10https://gerrit.wikimedia.org/r/705003 (https://phabricator.wikimedia.org/T286505) (owner: 10Ahmon Dancy) [23:01:17] (03PS1) 10Krinkle: make-deploy-notes: Convert botclasses.php to use format=json [tools/release] - 10https://gerrit.wikimedia.org/r/709847 [23:02:20] (03CR) 10Krinkle: "I've not tested this, but given recent changes I imagine Reedy has a test case at hand." [tools/release] - 10https://gerrit.wikimedia.org/r/709847 (owner: 10Krinkle) [23:02:32] Reedy: what's a simple use for it that I can try? [23:02:50] I used to run it locally... But releng run it somewhere else [23:05:55] 10Release-Engineering-Team (Doing), 10Wikidata, 10Wikidata-Query-Service, 10Discovery-Search (Current work), and 2 others: PipelineBot for flink-rdf-streaming-updater does not generate proper deployment-chart patches - https://phabricator.wikimedia.org/T287374 (10jeena) >>! In T287374#7248050, @dcausse wro... [23:07:42] (03PS2) 10Krinkle: make-deploy-notes: Convert botclasses.php to use format=json [tools/release] - 10https://gerrit.wikimedia.org/r/709847 [23:07:45] ok, figured out a test plan [23:07:46] works [23:07:51] after fixing stdclass/array [23:08:23] (03CR) 10Legoktm: make-deploy-notes: Convert botclasses.php to use format=json (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/709847 (owner: 10Krinkle) [23:08:47] heh, timing :) [23:09:11] (03CR) 10Krinkle: make-deploy-notes: Convert botclasses.php to use format=json (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/709847 (owner: 10Krinkle) [23:10:00] (03CR) 10Legoktm: [C: 03+1] make-deploy-notes: Convert botclasses.php to use format=json [tools/release] - 10https://gerrit.wikimedia.org/r/709847 (owner: 10Krinkle) [23:36:21] heh