[01:02:53] 10Continuous-Integration-Infrastructure, 10Infrastructure-Foundations, 10Puppet: Puppet failure on integration-puppetmaster-02.integration.eqiad1.wikimedia.cloud - https://phabricator.wikimedia.org/T290422 (10Andrew) Strange -- after I made my changes last week I doublechecked that puppet was working properl... [01:15:45] TimStarling: legoktm : regarding phpunit wrappers/alternatives, this exists and seems to be accumulating a reasonable amount of tractor https://github.com/pestphp/pest [01:16:24] the name though [01:16:38] * TimStarling is not a fan of self-deprecating names [01:16:44] https://pestphp.com/docs/writing-tests#api-reference [01:17:31] right, mocha style [01:18:10] mocha is a good name, they could have used that as a theme couldn't they? [01:18:31] It's a little too magical for my taste, but it does support phpunit underneath so if it's runner is any good could have a future [01:20:03] Fwiw mocha is afaik part of the larger Java/caffeine theme around JavaScripts origins. [01:21:19] right, drink-related names are more or less done to death in the java world [01:22:13] Mocha was the original code name for Netscript's thing, released as LiveScript, then rebranded JavaScript. [01:23:21] And there's Chai JS for example, which I think think was a reference to Mocha JS originally not sure which came first [01:23:53] I didn't know it was common in the Java world but I'm not surprised. I guess I know Jet Beans but that's about it [01:25:06] You remember we had a Java applet media player for a while? Cortado. [01:25:36] (a shot of espresso with a little milk if memory serves) [01:35:55] it's a little bit too close to PHPUnit to really be called an alternative -- its runner is a subclass of PHPUnit\TextUI\Command just like MediaWiki's phpunit.php [01:57:31] 10Continuous-Integration-Infrastructure, 10Infrastructure-Foundations, 10Puppet: Puppet failure on integration-puppetmaster-02.integration.eqiad1.wikimedia.cloud - https://phabricator.wikimedia.org/T290422 (10Andrew) 05Openβ†’03Resolved a:03Andrew I still don't know what this was but I regenerated all th... [02:01:57] TimStarling: ah, I hadn't looked that closely yet. It advertises some parallism [02:03:28] TimStarling: btw, currently looking at fixing https://phabricator.wikimedia.org/T247332 whicih currently makes the inline profile percentages all whacked up in prod. [02:03:53] My approach was going to be to add an optoin to wgProfiler / ProfileXhprof along the lines of 'running' => true, that would skip the enable call. [02:04:08] given we already enable it early on. [02:04:17] any thoughts on that approach and/or the name? [02:04:59] long task... [02:05:42] well, the TLDR is that if you call tideways_enable twice, where one of them is deeper or elsewhere in the stack than the first one, stuff goes wrong [02:06:28] the last comment captures it all, but basically we need to somehow not do that. [02:06:52] upstream went a bit back and forth, but it looks like maybe they're going to support this and properly ignore subsequent enable calls [02:07:03] They have a PR for that, but they're not exactly the most active of maintainers [02:10:37] ok, makes sense, yes add that config option [02:11:37] we don't really want nested profiling, right? Really we want xhprof_is_enabled() so that we can skip the second call without having to keep track ourselves [02:13:29] ack, yeah, we don't need to consumer it twice or anything like that. [04:45:05] the MediaWiki bundling checklist has an item called "Voting CI structure tests". What does that mean exactly? [04:59:00] (found the answer at https://phabricator.wikimedia.org/T257180#6280644 ) [05:06:32] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Epic, 10MW-1.37-release: Expand the set of bundled extensions and skins in MediaWiki 1.37 - https://phabricator.wikimedia.org/T279842 (10Tgr) [05:06:37] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group, 10Tracking-Neverending: Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349 (10Tgr) [06:46:35] (03PS3) 10Robert Vogel: Add inter-extension dependencies for `BlueSpiceDistributionConnector` [integration/config] - 10https://gerrit.wikimedia.org/r/719108 [10:22:38] 10Diffusion, 10Release-Engineering-Team (Seen), 10Developer Productivity: Reduce task notification noise/frequency of changes to associated open patchsets - https://phabricator.wikimedia.org/T143162 (10Aklapper) p:05Mediumβ†’03Low [10:24:50] 10Project-Admins, 10AutoWikiBrowser: Convert AWB tracker tasks to Phabricator project tags - https://phabricator.wikimedia.org/T282945 (10Aklapper) @Reedy, @Rjwilmsi: ping - any comments? Or anyone else who maintains AWB nowadays? Thanks. [14:25:48] 10Continuous-Integration-Infrastructure, 10Performance-Team, 10Patch-For-Review: Provide one or more Qemu agents in CI that use a newer version than 2.x - https://phabricator.wikimedia.org/T284774 (10Krinkle) Signing back over to @dpifke. The [integration-agent-qemu-1002](https://openstack-browser.toolforge.... [14:54:06] tgr: ack, the section lower down the same page also describes that [14:58:54] * Krinkle edited the page to explain "Voting" [15:06:00] twentyafterfour: The age distribution links don't seem to work correctly, e.g. at https://phabricator.wikimedia.org/project/reports/1212/ the "5 weeks" link points to a more or less global search of all projects and inclusing closed tasks. I can file a task but just checking in case it's intended differently or if it's already known. [15:14:44] dduvall: It's clearly too early in the morning but can you ping me when you're awake & available? [15:21:38] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10SRE Observability, 10Wikimedia-Logstash, 10observability, 10User-brennen: Experiment with automating error log triage - https://phabricator.wikimedia.org/T290267 (10lmata) Hi @brennen there is a lot to unpack here. Maybe we can have a quick chat between team... [15:41:47] what happened to https://www.mediawiki.org/wiki/MediaWiki_1.37/wmf.22/Changelog [15:41:55] there are like 2000 patches for wikibase [15:43:56] andrewbogott: awake, alive, alert, enthusiastic [15:44:59] dduvall: good morning! [15:45:17] good morning! [15:45:20] I'm trying to get blubber to generate a docker file that vaguely resembles the existing dockerfile we're using for test/dev [15:46:14] I assume that it's on purpose that blubber doesn't have 1:1 functions for things that docker does, but is there a way to specify an arbitrary shell command to run during start? Similar to docker's RUN? [15:46:38] (Right now I'm trying to create a user) [15:47:17] during start? [15:47:31] ah, to create a user. there's isn't [15:47:49] zabe: They pulled in four of their libraries, including the git history of them since they were started. (Hence why gerrit can't find the git hashes.) [15:48:00] um.... actually I guess dockerfile things happen during creation and not during start [15:48:05] * andrewbogott slightly confused by docker [15:48:53] for what it's worth, here is the dockerfile I'm looking at https://github.com/wikimedia/analytics-quarry-web/blob/master/Dockerfile [15:49:13] dduvall: does that mean the next thing I should do is add user management to blubber? [15:50:29] right. `RUN` executes during build, and each build step is basically 1) start container with previous intermediate image and mount an overlayfs lower/upper dir with previous/new fs; 2) do step thing (e.g. run command); 3) take filesystem diff and create layer [15:50:43] andrewbogott: haha. you could? [15:50:58] we still follow a pretty strict pattern in blubber that was intended for services [15:51:31] ok, so the answer isn't so much "blubber doesn't do that" as "don't do that" [15:51:47] So I guess everything that runs in a pipeline service runs with a standardized service user name? [15:53:40] James_F: ok, thanks for explaining [15:54:07] zabe: Ideally we'd filter them out, but… [15:54:22] blubber assumes you're application can get away with having 3 users in the image. 1) root for privileged things like system package installation; 2) a "somebody" user that owns application files and does vendor package installation; 3) a "runuser" that executes the runtime [15:55:06] andrewbogott: ^ you can specify the name and/or uid of those 2 additional users but you can't add arbitrary users to the image really [15:55:22] * dduvall takes a loot at the dockerfile [15:55:44] oh! That's just fine, I should just rename runuser to quarry [15:55:49] I think that's exactly what I need [15:56:02] andrewbogott: hmm, yeah doesn't look too complicated! [15:56:25] Is there a config ref for blubber? I looked but did not find [15:56:26] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’): Investigate password store options - https://phabricator.wikimedia.org/T290337 (10hashar) [15:57:09] andrewbogott: was just looking for it. sadly https://wikitech.wikimedia.org/wiki/Blubber/User_Guide seems to be very out of date [15:57:14] and misnamed as a user guide [15:57:37] your best bet is probably the openapi spec output [15:58:39] andrewbogott: `curl https://blubberoid.wikimedia.org/?spec` [15:59:08] dduvall: that's a good start, thanks [15:59:22] np [16:01:15] hm, the word 'user' does not appear anywhere :( [16:01:48] andrewbogott: it's `runs: { as: "quarry" }` [16:02:21] because grammatical readability is more important than discovery? :) [16:02:26] * dduvall regrets such choices [16:03:01] the format seems fine, just need some captions explaining what the keys do [16:03:17] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’): Investigate password store options - https://phabricator.wikimedia.org/T290337 (10hashar) I have spend a good chunk of Tuesday setting up [[ https://www.vaultproject.io/docs/what-is-vault | HashiCorp Vault ]]. It is a full features system for managed various secrets b... [16:06:55] (03CR) 10Jforrester: "I didn't switch these as those images don't build (because they're still based on a special PHP72 image that doesn't work any more). Am wo" [integration/config] - 10https://gerrit.wikimedia.org/r/719138 (owner: 10Daimona Eaytoy) [16:08:45] (03PS4) 10Jforrester: Zuul: [mediawiki/extensions/BlueSpiceDistributionConnector] Add 4 dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/719108 (owner: 10Robert Vogel) [16:10:26] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/BlueSpiceDistributionConnector] Add 4 dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/719108 (owner: 10Robert Vogel) [16:13:20] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/BlueSpiceDistributionConnector] Add 4 dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/719108 (owner: 10Robert Vogel) [16:19:36] !log Zuul: [mediawiki/extensions/BlueSpiceDistributionConnector] Add 4 dependencies [16:19:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:20:12] (03CR) 10Jforrester: [C: 03+2] dockerfiles: Provide node12-test-browser-php{72,80}-composer images [integration/config] - 10https://gerrit.wikimedia.org/r/715556 (owner: 10Jforrester) [16:22:06] (03Merged) 10jenkins-bot: dockerfiles: Provide node12-test-browser-php{72,80}-composer images [integration/config] - 10https://gerrit.wikimedia.org/r/715556 (owner: 10Jforrester) [16:22:18] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity: SonarQube is unhelpfully suggesting ES6 feautures in ES5 code - https://phabricator.wikimedia.org/T289957 (10Jrbranaa) > @Jrbranaa perhaps the for-of loop rule should just be disabled. Yeah... [16:23:18] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity: SonarQube is unhelpfully suggesting ES6 feautures in ES5 code - https://phabricator.wikimedia.org/T289957 (10Jrbranaa) a:03Jrbranaa [16:23:38] dduvall: I failed to bookmark last week and now I'm finding several different tutorials, none of which are the one you linked me to on Friday. Can I get that link again? [16:24:03] sure thing [16:24:11] pipelinelib tutorials/docs are https://wikitech.wikimedia.org/wiki/PipelineLib [16:24:25] blubber tutorials https://wikitech.wikimedia.org/wiki/Blubber [16:24:58] and i think the one jeena linked to was https://wikitech.wikimedia.org/wiki/Deployment_pipeline/Migration/Tutorial [16:25:04] thx [16:25:26] !log Docker: Publishing node12-test-browser-php{72,80}-composer images [16:25:26] np [16:25:28] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:35:42] dduvall: here's what I have so far https://gerrit.wikimedia.org/r/c/analytics/quarry/web/+/719300/2/.pipeline/blubber.yaml [16:36:04] When I build/start quarry-dev it seems to start quarry rather than running tox [16:36:13] so I assume I have something messed up with the entry point [16:37:13] andrewbogott: i don't see a quarry-dev variant [16:37:17] do you mean quarry-test? [16:37:20] yes [16:37:31] and also I just realized I built with the wrong dockerfile, so... stand by :) [16:37:58] ok, now the build is failing which is more like what I expected :) [16:38:12] k :) [16:38:22] i love a good failure [16:40:07] andrewbogott: i'm curious what the dockerfile output looks like since you're using both the `python` directives and `builder` with `pip install` [16:40:35] i suspect there might be some duplication in there but maybe not since you're using `poetry`? [16:41:00] https://www.irccloud.com/pastebin/pZN43CGu/ [16:41:46] I have never used poetry and am trying to not add another unknown to this process, though that might be a mistake [16:42:52] i don't know much about it either. bd808 implemented the poetry support iirc [16:43:01] (03CR) 10Daimona Eaytoy: jjb: Switch OOJS jobs using php-ast to images with ast 1.0.14 (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/719138 (owner: 10Daimona Eaytoy) [16:43:50] I'm getting a dependency failure but pip seems to be at least trying to install requirements.txt [16:44:48] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10Scap: scap sync-file --force warns "sudo: no tty present and no askpass program specified" - https://phabricator.wikimedia.org/T290038 (10dancy) Reproducible using: ` env SSH_AUTH_SOCK=/run/keyholder/proxy.sock ssh -i/etc/keyholder.d/mwdeploy.pub mwdeploy@mw2278.c... [16:45:27] andrewbogott: typically the `python` directive should include some `requirements` as well which will have it write out `pip install` commands [16:45:43] however, if you're using poetry it may skip that [16:45:48] i'm not 100% sure [16:46:02] can python requirements refer to requirements.txt or does it need to enumerate all packages? [16:49:53] it refers to requirements.txt file(s) [16:50:13] all the `requirements` fields specify files that are needed by the builder command [16:50:51] and in the case of python and node, they are also the files that declare dependencies [16:51:04] I would like to delete the WMCS instance 'gitlab' in the project gitlab-test due to quota limits. The instance is stopped since 1 week. Is anyone still using the instance? Please let me know. [16:54:15] andrewbogott: see if this works for you [16:54:20] https://www.irccloud.com/pastebin/DoYEiE3h/ [16:56:05] brennen: ^ re j.elto [16:57:17] greg-g: thanks - yeah, j.elto and i discussed, just getting a quick check here. [16:57:31] above cc: thcipriani [16:57:38] dduvall: that seems to still be doing things :) [16:58:36] brennen: ack, sounds good to me if you two discussed <3 [16:59:25] andrewbogott: hmm, i get `#5 4.786 redis : Depends: redis-server (>= 5:5.0.3-3~bpo9+2) but 3:3.2.6-3+deb9u7 is to be installed` when trying to build but that may be because i changed the base image to `docker-registry.wikimedia.org/python3` [16:59:40] because i didn't see the base image that you'd specified in our registry [16:59:41] I changed it too [16:59:44] seems to build for me? [16:59:46] ah ok [17:00:01] although when I start it it doesn't seen to stay running (maybe correct because it stops when tox exits?) [17:00:48] that's correct if tox is the entrypoint [17:00:50] zabe: interesting. re:2000 changes to wikibase. There are a ton of commits between wmf/1.37.0-wmf.21 -> wmf/1.37.0-wmf.22: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+log/wmf/1.37.0-wmf.21..wmf/1.37.0-wmf.22 some very old...maybe a merge gone awry? [17:00:56] log is [17:00:57] https://www.irccloud.com/pastebin/Tgxv7hj2/ [17:01:01] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10SRE Observability, 10Wikimedia-Logstash, 10observability, 10User-brennen: Experiment with automating error log triage - https://phabricator.wikimedia.org/T290267 (10brennen) @lmata - yeah, would be great to have a chat. The task description here mostly just... [17:01:07] which is promising I think? It's at least trying to start tox [17:01:20] you may want `runs.insecurely` there [17:01:40] since the tests will likely need to write to the application dir [17:02:06] *definitely* need to write [17:12:12] dduvall: now the issue is that tox is failing to install its deps. Maybe that's by design, since installing packages at runtime seems weird... [17:12:29] https://www.irccloud.com/pastebin/YpmS3BwC/ [17:12:53] latest blubber.yaml is https://gerrit.wikimedia.org/r/c/analytics/quarry/web/+/719300/4/.pipeline/blubber.yaml [17:13:25] (and I need to eat lunch! But will be back soon) [17:15:22] andrewbogott: it's not really runtime but docker build time (once the image is built, running the image doesn't result in those commands being run again). the command is run to produce an additional image layer [17:15:30] i'll take a look at ps4! [17:19:39] dduvall: I mean depedencies in tox.ini. /that/ happens at runtime doesn't it? [17:20:40] oh, interesting. right [17:21:45] the python directive disables remote fetching after it's creating the wheels and done pip install, so you may need to create an additional requirements files that satisfies everything needed for your tox command [17:26:35] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10Scap: scap sync-file --force warns "sudo: no tty present and no askpass program specified" - https://phabricator.wikimedia.org/T290038 (10dancy) [17:26:38] 10Release-Engineering-Team (Radar), 10Scap, 10Patch-For-Review, 10User-jijiki: Update Scap to perform rolling restart for all MW deploy - https://phabricator.wikimedia.org/T266055 (10dancy) [17:33:23] andrewbogott: when you're back, try ps5 https://gerrit.wikimedia.org/r/c/analytics/quarry/web/+/719300/4..5 [17:34:57] sorry, shuffled a couple things around in the blubber.yaml too but the important bit was creating a `test-requirements.txt` with flake8, pytest, etc. and added that file to the `python.requirements` for the quarry-test variant [17:36:49] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10Scap, 10Patch-For-Review: scap sync-file --force warns "sudo: no tty present and no askpass program specified" - https://phabricator.wikimedia.org/T290038 (10dancy) [17:44:32] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10Scap, 10Patch-For-Review: scap sync-file --force warns "sudo: no tty present and no askpass program specified" - https://phabricator.wikimedia.org/T290038 (10dancy) p:05Triageβ†’03Medium a:03dancy [17:47:51] dduvall: py37-flake8: commands succeeded [17:47:51] py37-pytest: commands succeeded [17:47:51] congratulations :) [17:47:54] thank you! [17:49:56] andrewbogott: np! [17:50:48] dduvall: does the associated .pipeline/config.yaml look right to you? Seems pretty straightforward [17:51:36] andrewbogott: i think you want `build: quarry-test` since that's the name of your variant [17:51:58] 'k [17:52:13] and technically you could just say `- name: quarry-test` since the default shorthand is to build a variant by the same name and run it [17:52:30] but maybe you want it to be more explicit [17:52:34] up to you [18:00:26] (03PS1) 10Andrew Bogott: Configure pipeline for analytics-quarry-web [integration/config] - 10https://gerrit.wikimedia.org/r/719311 (https://phabricator.wikimedia.org/T210359) [18:01:32] dduvall: next half-baked patch: https://gerrit.wikimedia.org/r/c/integration/config/+/719311 [18:01:40] (03CR) 10jerkins-bot: [V: 04-1] Configure pipeline for analytics-quarry-web [integration/config] - 10https://gerrit.wikimedia.org/r/719311 (https://phabricator.wikimedia.org/T210359) (owner: 10Andrew Bogott) [18:02:30] hmmmm seems like something is missing from that tutorial [18:04:01] (03CR) 10Dduvall: [C: 04-1] Configure pipeline for analytics-quarry-web (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/719311 (https://phabricator.wikimedia.org/T210359) (owner: 10Andrew Bogott) [18:04:23] do I need an entry in 'jobs' for trigger-analytics-quarry-web-test ? [18:04:50] the job is created by the project template, but it's trigger-analytics-quarry-web-pipeline-test not trigger-analytics-quarry-web-test [18:04:55] left a comment [18:05:43] (03PS2) 10Andrew Bogott: Configure pipeline for analytics-quarry-web [integration/config] - 10https://gerrit.wikimedia.org/r/719311 (https://phabricator.wikimedia.org/T210359) [18:07:34] andrewbogott: do you want that merged before or after your project patch? the benefit to before is that you can fully vet your first draft blubber and pipeline config. the benefit to after is that you don't block other merges before those configs are valid and merged [18:11:02] !log creating 2 new jenkins jobs for deployment of https://gerrit.wikimedia.org/r/c/integration/config/+/719311 [18:11:05] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:12:20] (03CR) 10Dduvall: [C: 03+1] "Created 2 new jobs:" [integration/config] - 10https://gerrit.wikimedia.org/r/719311 (https://phabricator.wikimedia.org/T210359) (owner: 10Andrew Bogott) [18:13:16] (03CR) 10Dduvall: [C: 03+2] Configure pipeline for analytics-quarry-web [integration/config] - 10https://gerrit.wikimedia.org/r/719311 (https://phabricator.wikimedia.org/T210359) (owner: 10Andrew Bogott) [18:13:26] andrewbogott: too late. i'll just merge/deploy it [18:13:29] :) [18:14:27] (03Merged) 10jenkins-bot: Configure pipeline for analytics-quarry-web [integration/config] - 10https://gerrit.wikimedia.org/r/719311 (https://phabricator.wikimedia.org/T210359) (owner: 10Andrew Bogott) [18:14:30] ok, so now I just need to recheck the project pass... [18:14:52] hold on. still deploying... [18:14:57] ok [18:15:05] * andrewbogott can never remember if it's 'recheck' or 'retest' [18:15:08] it's a two stage deploy. one for the jenkins config and another for zuul [18:15:13] it's `recheck` [18:15:39] now I know until the next time I need it and can't remember :) [18:16:01] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/c/integration/config/+/719311 [18:16:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:16:04] andrewbogott: haha, yeah [18:16:35] alrighty. deployed [18:16:46] (03CR) 10Dduvall: "Deployed zuul layout changes." [integration/config] - 10https://gerrit.wikimedia.org/r/719311 (https://phabricator.wikimedia.org/T210359) (owner: 10Andrew Bogott) [18:18:08] andrewbogott: seems to be running https://integration.wikimedia.org/ci/blue/organizations/jenkins/analytics-quarry-web-pipeline-test/detail/analytics-quarry-web-pipeline-test/1/pipeline [18:18:43] nice! I guess it'll take a while the first time [18:20:04] it's weird that 'recheck' doesn't de-verify [18:20:06] yeah, since no layers are cached [18:20:59] success! [18:22:11] are you testing another thing? [18:22:49] andrewbogott: aw, i did a recheck to see if it would land on the same jenkins node and benefit from the cached layers but it landed on a fresh one [18:23:07] just warming up more caches :) [18:23:50] wait, no it ran on the same node. strange [18:24:07] the real test will be if I can rebase https://gerrit.wikimedia.org/r/c/analytics/quarry/web/+/716558 and get a pass [18:24:14] and why did it land on contint1001. that should only happen if there's a publish config [18:25:35] any reason for me not to merge that now? [18:27:53] * andrewbogott merges [18:34:37] (03PS1) 10Jeena Huneidi: WIP add patch author as reviewer to promote patch [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/719319 (https://phabricator.wikimedia.org/T281392) [18:35:31] (03CR) 10jerkins-bot: [V: 04-1] WIP add patch author as reviewer to promote patch [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/719319 (https://phabricator.wikimedia.org/T281392) (owner: 10Jeena Huneidi) [19:10:50] (03PS1) 10Dduvall: Provide JSON schema for use in config validation [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/719332 (https://phabricator.wikimedia.org/T225335) [19:39:01] are there shared / generic gitlab runners now? [19:39:29] oh ya, thats a big old yes! :D [19:39:42] *disables shared runners for the mwcli project* [19:56:03] (03PS1) 10Dduvall: dockerfiles: Provide ajv image for JSON schema based validation [integration/config] - 10https://gerrit.wikimedia.org/r/719350 (https://phabricator.wikimedia.org/T225335) [20:10:04] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [150.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [20:15:50] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [90.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10&fullscreen&orgId=1 [20:18:22] "Access to the releng group was granted" I sense someone is trying to nerd-snipe me with GitLab. ;-) [20:27:13] (03PS1) 10Andrew Bogott: Quarry: remove old tests now that we're using the pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/719355 [20:27:49] dduvall: I think I also need https://gerrit.wikimedia.org/r/c/integration/config/+/719355 [20:28:06] or at least part of that (depending on w/not I want node12-docker) [20:43:18] (03CR) 10Jforrester: "Looks good." [integration/config] - 10https://gerrit.wikimedia.org/r/719350 (https://phabricator.wikimedia.org/T225335) (owner: 10Dduvall) [20:46:02] !log migrating dev-images to https://gitlab.wikimedia.org/releng/dev-images and deactivating on gerrit [20:46:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:46:13] brennen: oooooo [20:46:17] :D [20:46:38] jeena: we should deactivate mwcli on gerrit! (If it is still unarchived etc) [20:46:43] Very oooh. [20:47:10] addshore: Do you mean https://gerrit.wikimedia.org/r/admin/repos/mediawiki/tools/cli ? [20:47:24] yup [20:47:33] Has that moved? [20:47:45] yup https://gitlab.wikimedia.org/releng/cli [20:47:46] Ah, it's https://gitlab.wikimedia.org/releng/cli ? [20:48:21] Done. It's now read-only on gerrit. [20:48:26] <3 [20:48:39] Maybe I should log that… [20:49:21] !log Marked https://gerrit.wikimedia.org/g/mediawiki/tools/cli as read-only and pointed users to GitLab. [20:49:23] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:52:34] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10GitLab, 10dev-images, 10User-brennen: Migrate releng/dev-images to GitLab - https://phabricator.wikimedia.org/T290259 (10brennen) [20:57:02] oh nice - projects in phab have a field for source repo. i don't think i'd realized that before. [21:05:58] (03Abandoned) 10Brennen Bearnes: Added image for civiproxy [releng/dev-images] - 10https://gerrit.wikimedia.org/r/664919 (https://phabricator.wikimedia.org/T268683) (owner: 10Jgleeson) [21:06:43] "Your configuration specifies to merge with the ref 'refs/heads/master' from the remote, but no such ref was fetched." Yeah, indeed. :-) [21:07:19] (03Abandoned) 10Brennen Bearnes: Provide buster versions of the main MW local dev images [releng/dev-images] - 10https://gerrit.wikimedia.org/r/704354 (https://phabricator.wikimedia.org/T273100) (owner: 10Jforrester) [21:08:32] (03CR) 10Brennen Bearnes: [V: 04-1 C: 04-1] "Unclear on the general state of this; abandoning as dev-images is moving to https://gitlab.wikimedia.org/releng/dev-images - please feel f" [releng/dev-images] - 10https://gerrit.wikimedia.org/r/610194 (https://phabricator.wikimedia.org/T257378) (owner: 10Dbarratt) [21:08:43] (03Abandoned) 10Brennen Bearnes: Add --verbose flag to eventlogging image [releng/dev-images] - 10https://gerrit.wikimedia.org/r/610194 (https://phabricator.wikimedia.org/T257378) (owner: 10Dbarratt) [21:09:16] (03Abandoned) 10Brennen Bearnes: Route requests to /rest.php to the rest.php entry point. [releng/dev-images] - 10https://gerrit.wikimedia.org/r/621896 (https://phabricator.wikimedia.org/T261051) (owner: 10Dbarratt) [21:17:07] * James_F pushes a modification to brennen's MR mostly to show that he can: https://gitlab.wikimedia.org/releng/dev-images/-/merge_requests/1 [21:22:51] (03CR) 10Andrew Bogott: Quarry: remove old tests now that we're using the pipeline (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/719355 (owner: 10Andrew Bogott) [21:24:06] James_F: i see your gerrit .git/hooks/commit-msg is still in place... [21:24:14] Yeah. :-( [21:24:47] * brennen makes a list of things to tweak when migrating repos [21:25:12] And of course it won't let me amend. [21:25:33] (` ! [rejected] brennen/update-docs -> brennen/update-docs (non-fast-forward)`) [21:25:40] hrm [21:27:16] does -f work? [21:27:54] Ah, yes. [21:28:40] ok, cool. i think that's the expected workflow for something like that. otherwise it can be tidied when squashed on merging. [21:28:42] But it won't let me diff the change, AFAICS. [21:28:44] Ack. [21:28:54] i _thought_ that existed... [21:28:56] * brennen looks [21:29:20] There's https://gitlab.wikimedia.org/releng/dev-images/-/merge_requests/1/diffs?diff_id=242&start_sha=23bbbea374fb6bbb4de52a8c74fe0f686ae8ecfe but it's only show the file diff, not the commit message diff. [21:29:27] Small loss, in the end. [21:29:36] yeah, it may not track diffs between messages. [21:30:23] treating commit message as part of the review is definitely something i'm gonna miss. [21:43:44] (03CR) 10Ahmon Dancy: [C: 03+1] dockerfiles: Provide ajv image for JSON schema based validation [integration/config] - 10https://gerrit.wikimedia.org/r/719350 (https://phabricator.wikimedia.org/T225335) (owner: 10Dduvall) [21:50:00] oh man, that's a very sad loss. [21:50:09] Cancel gitlab! [21:57:16] thanks for fixing the cli gerrit repo James_F ! [22:06:26] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10MediaWiki-Docker, 10dev-images, 10mwcli, 10User-brennen: Create a PHP 8 dev image for use with mediawiki-docker-dev - https://phabricator.wikimedia.org/T283426 (10brennen) [22:18:45] 10Deployments, 10Release-Engineering-Team, 10Developer Productivity: Train changelog no longer excludes libraryupgrader - https://phabricator.wikimedia.org/T290530 (10Krinkle) [22:19:17] (03PS1) 10Krinkle: make-deploy-notes: Update and harden libraryupgrader check [tools/release] - 10https://gerrit.wikimedia.org/r/719374 (https://phabricator.wikimedia.org/T290530) [22:27:21] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10MediaWiki-Docker, 10dev-images: Remove unused stretch image definitions from dev-images - https://phabricator.wikimedia.org/T290532 (10brennen) [22:30:38] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10MediaWiki-Docker, 10dev-images: Remove unused stretch image definitions from dev-images - https://phabricator.wikimedia.org/T290532 (10brennen) MR: https://gitlab.wikimedia.org/releng/dev-images/-/merge_requests/2 [22:31:00] It'd be really nice if wikibugs reported GitLab changes already. [22:34:39] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10MediaWiki-Docker, 10dev-images: Remove unused stretch image definitions from dev-images - https://phabricator.wikimedia.org/T290532 (10Jdforrester-WMF) > Open question: Can / should these be deleted from the Docker registry? My understanding is that they'll sto... [22:37:56] (03PS1) 10Krinkle: make-deploy-notes: Document how to run it locally [tools/release] - 10https://gerrit.wikimedia.org/r/719379 (https://phabricator.wikimedia.org/T290530) [22:41:37] 10Release-Engineering-Team (Next), 10GitLab, 10serviceops, 10User-brennen: GitLab major version upgrade: 14.x - https://phabricator.wikimedia.org/T289802 (10brennen) > I've uploaded 14.0.10, we can bump the import hook after the initial update is complete. Thanks - today got away from me, planning to run... [22:42:59] James_F: it being a Yak Shaving Week, i might have some time to poke at T288381. [22:42:59] T288381: Connect WikiBugs IRC bot to Wikimedia GitLab - https://phabricator.wikimedia.org/T288381 [22:44:15] brennen: That'd be much appreciated. It sounded like Merlijn had made some progress? [22:45:17] looks that way. i'll make a point of digesting the comments on that task tomorrow. [22:45:26] Enjoy. [22:45:33] * James_F will be around, of course. [22:45:37] some phab integration is also on the list. [22:46:17] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10MediaWiki-Docker, 10dev-images: Remove unused stretch image definitions from dev-images - https://phabricator.wikimedia.org/T290532 (10brennen) > My understanding is that they'll stop being listed now (because we dropped them from git) Hmm - this is possible, b... [22:47:15] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10MediaWiki-Docker, 10dev-images: Remove unused stretch image definitions from dev-images - https://phabricator.wikimedia.org/T290532 (10Jdforrester-WMF) >>! In T290532#7338195, @brennen wrote: >> My understanding is that they'll stop being listed now (because we... [22:50:23] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10MediaWiki-Docker, 10dev-images: Remove unused stretch image definitions from dev-images - https://phabricator.wikimedia.org/T290532 (10brennen) Oh, interesting - I'll follow up on that if doesn't take effect here. [22:50:52] brennen: If I could remember even vaguely who did it or when I'd give more pointers, but it's all hazy. [22:51:06] 10Deployments, 10Release-Engineering-Team (Seen), 10Developer Productivity, 10User-Majavah: Train changelog: Omit empty sections - https://phabricator.wikimedia.org/T249553 (10Krinkle) I thnk something went wrong in the logic for "No changes" because it is listing all extensions seemingly, including those... [22:53:40] yeah, no worries. i'll dig a bit. [22:53:46] * brennen disappears into the ether. [22:53:57] (Γ¦ther?) [22:54:02] Yes. ;-) [22:54:24] But people look at you funnily if you ask for an Γ†thernet cable. [22:54:33] haha [23:01:58] There is some really dark magic going on in this python script [23:02:17] Krinkle: Which? make-release-notes? [23:02:45] changes = [] if change: print(heading) print(changes) else: NO_CHANGES.add() [23:03:06] upon the first run, it prints a heading *and* adds to NO_CHANGES [23:03:25] upon second run, it correctly goes into the else branch only [23:03:49] seems the delay from the http request the first time has some effect, maybe? but like how? [23:15:20] (03PS1) 10Dduvall: WIP: Perform validation using JSON schema and ajv-cli [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/719382 (https://phabricator.wikimedia.org/T225335) [23:16:28] (03CR) 10jerkins-bot: [V: 04-1] WIP: Perform validation using JSON schema and ajv-cli [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/719382 (https://phabricator.wikimedia.org/T225335) (owner: 10Dduvall) [23:27:29] (03CR) 10Jforrester: [C: 03+2] make-deploy-notes: Update and harden libraryupgrader check [tools/release] - 10https://gerrit.wikimedia.org/r/719374 (https://phabricator.wikimedia.org/T290530) (owner: 10Krinkle) [23:27:33] (03CR) 10Jforrester: [C: 03+2] make-deploy-notes: Document how to run it locally [tools/release] - 10https://gerrit.wikimedia.org/r/719379 (https://phabricator.wikimedia.org/T290530) (owner: 10Krinkle) [23:28:30] (03Merged) 10jenkins-bot: make-deploy-notes: Update and harden libraryupgrader check [tools/release] - 10https://gerrit.wikimedia.org/r/719374 (https://phabricator.wikimedia.org/T290530) (owner: 10Krinkle) [23:28:55] (03Merged) 10jenkins-bot: make-deploy-notes: Document how to run it locally [tools/release] - 10https://gerrit.wikimedia.org/r/719379 (https://phabricator.wikimedia.org/T290530) (owner: 10Krinkle)