[00:53:37] Project beta-scap-sync-world build #22350: 04FAILURE in 16 min: https://integration.wikimedia.org/ci/job/beta-scap-sync-world/22350/ [00:59:16] Yippee, build fixed! [00:59:16] Project beta-scap-sync-world build #22351: 09FIXED in 4 min 3 sec: https://integration.wikimedia.org/ci/job/beta-scap-sync-world/22351/ [09:31:33] 10Continuous-Integration-Infrastructure, 10DC-Ops, 10ops-codfw: Flapping codfw management alarm ( contint2001.mgmt/SSH is CRITICAL ) - https://phabricator.wikimedia.org/T283582 (10hashar) Clearing a few projects. @ayounsi mentioned at T283582#7111164 that it is most probably an issue with an unmanaged switc... [09:52:36] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: Migrate Zuul alerting to Grafana / AlertManager - https://phabricator.wikimedia.org/T292284 (10hashar) [09:53:11] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Zuul: Migrate Zuul alerting to Grafana / AlertManager - https://phabricator.wikimedia.org/T292284 (10hashar) [10:06:15] I just got pinged by another spam account that wants to be deleted: https://phabricator.wikimedia.org/p/Lionelparsons1212/ [10:07:46] again account disabled, but needs a full admin to delete [10:17:25] Thiemo_WMDE: isn't it a valid comment? [10:17:57] I am looking at https://phabricator.wikimedia.org/T271825#7394205 [10:18:22] majavah: ^ [10:18:45] OH [10:18:47] clever [10:18:53] I have just noticed the URL bah [10:19:39] comment deleted [10:19:56] and some PhanBanBot got rid of the account [10:20:21] I cant delete the user though [10:20:57] PhabBanBot is https://phab-ban.toolforge.org/ [10:23:13] so I can use that instead of my own account [10:23:15] great [10:30:49] (03CR) 10Kosta Harlan: [C: 03+1] fix: accuracy of deployment window names [tools/release] - 10https://gerrit.wikimedia.org/r/720826 (https://phabricator.wikimedia.org/T290859) (owner: 10Thcipriani) [10:40:37] 10Continuous-Integration-Infrastructure, 10DC-Ops, 10netops, 10ops-codfw: Flapping codfw management alarm ( contint2001.mgmt/SSH is CRITICAL ) - https://phabricator.wikimedia.org/T283582 (10cmooney) a:03cmooney Thanks @hashar. I would agree with @ayounsi's analysis, if considering contint2001.mgmt **in... [10:50:45] (03CR) 10Hashar: [C: 03+1] "I find the 'UTC-0' and 'UTC-7' keys to be misleading until I realized they are just arbitrary keys in deployment-calendar.json:" [tools/release] - 10https://gerrit.wikimedia.org/r/720826 (https://phabricator.wikimedia.org/T290859) (owner: 10Thcipriani) [11:25:50] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Zuul: Migrate Zuul alerting to Grafana / AlertManager - https://phabricator.wikimedia.org/T292284 (10hashar) 05Open→03Stalled The alert defined in Grafana should now emit to alert manager and result in a notification on IRC. Once tha... [11:27:41] 10Continuous-Integration-Infrastructure, 10DC-Ops, 10netops, 10ops-codfw: Flapping codfw management alarm ( contint2001.mgmt/SSH is CRITICAL ) - https://phabricator.wikimedia.org/T283582 (10hashar) That is quite an epic diagnostic @cmooney ! It is definitely not trivial to end up root causing some specific... [11:30:36] 10Continuous-Integration-Config, 10MediaWiki-extensions-Examples: Add examples extension to the CI gate - https://phabricator.wikimedia.org/T292288 (10Inductiveload) [11:30:42] 10Continuous-Integration-Config, 10MediaWiki-extensions-Examples: Add examples extension to the CI gate - https://phabricator.wikimedia.org/T292288 (10Inductiveload) [11:30:46] 10Continuous-Integration-Config, 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10Epic, 10Patch-For-Review: Have all Wikimedia production extensions and skins in the CI gate - https://phabricator.wikimedia.org/T249674 (10Inductiveload) [12:18:17] 10Release-Engineering-Team, 10serviceops, 10GitLab (Infrastructure), 10Patch-For-Review, 10User-brennen: GitLab minor release: 14.3.1 - https://phabricator.wikimedia.org/T292256 (10Jelto) I prepared the version bump to for gitlab-ce and gitlab-runner to 14.3 in https://gerrit.wikimedia.org/r/725303. @bre... [12:24:20] (03PS1) 10Inductiveload: Add examples extension to the CI gate [integration/config] - 10https://gerrit.wikimedia.org/r/725304 (https://phabricator.wikimedia.org/T292288) [12:24:58] (03CR) 10Inductiveload: "Note that this will not actually work until https://phabricator.wikimedia.org/T292287 is resolved." [integration/config] - 10https://gerrit.wikimedia.org/r/725304 (https://phabricator.wikimedia.org/T292288) (owner: 10Inductiveload) [13:32:09] 10Continuous-Integration-Infrastructure, 10DC-Ops, 10netops, 10ops-codfw: Flapping codfw management alarm ( contint2001.mgmt/SSH is CRITICAL ) - https://phabricator.wikimedia.org/T283582 (10hashar) I went to fetch the IRC log from https://wm-bot.wmflabs.org/libera_logs/%23wikimedia-operations/ which are fr... [13:48:17] 10Release-Engineering-Team (Doing), 10Scap, 10serviceops, 10Patch-For-Review: scap's canary check gives confusing logstash link - https://phabricator.wikimedia.org/T291870 (10hashar) [13:48:28] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Doing), 10Zuul: Migrate Zuul alerting to Grafana / AlertManager - https://phabricator.wikimedia.org/T292284 (10hashar) [13:48:33] 10Release-Engineering-Team (Next), 10serviceops, 10GitLab (Infrastructure), 10Patch-For-Review, 10User-brennen: GitLab minor release: 14.3.1 - https://phabricator.wikimedia.org/T292256 (10hashar) [13:48:38] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Doing), 10Zuul: Migrate Zuul alerting to Grafana / AlertManager - https://phabricator.wikimedia.org/T292284 (10hashar) p:05Triage→03Medium a:03hashar [13:48:53] 10Continuous-Integration-Config, 10Release-Engineering-Team (Doing), 10Developer Productivity, 10Patch-For-Review, 10Regression: Quibble jobs for PHPUnit are missing log artefacts - https://phabricator.wikimedia.org/T291227 (10hashar) [15:13:03] (03CR) 10Thcipriani: [C: 03+2] "Should see this in action starting the week of Oct 11th" [tools/release] - 10https://gerrit.wikimedia.org/r/720826 (https://phabricator.wikimedia.org/T290859) (owner: 10Thcipriani) [15:13:28] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Voice & Tone: Rename backport & deployment windows - https://phabricator.wikimedia.org/T290859 (10thcipriani) 05Open→03Resolved [15:13:41] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Voice & Tone: Rename backport & deployment windows - https://phabricator.wikimedia.org/T290859 (10thcipriani) [15:15:10] (03Merged) 10jenkins-bot: fix: accuracy of deployment window names [tools/release] - 10https://gerrit.wikimedia.org/r/720826 (https://phabricator.wikimedia.org/T290859) (owner: 10Thcipriani) [15:26:28] (03PS1) 10Ahmon Dancy: fix: template.py Python 3 fallout (part 2) [tools/scap] - 10https://gerrit.wikimedia.org/r/725333 [15:27:04] (03CR) 10Ahmon Dancy: fix: template.py Python 3 fallout (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/724527 (https://phabricator.wikimedia.org/T291990) (owner: 10Ahmon Dancy) [15:28:28] (03CR) 10Ahmon Dancy: fix: template.py Python 3 fallout (part 2) (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/725333 (owner: 10Ahmon Dancy) [15:43:57] 10Release-Engineering-Team (Doing), 10Scap, 10serviceops: Deploy Scap version 4.0.1 - https://phabricator.wikimedia.org/T291095 (10dancy) >>! In T291095#7390898, @jijiki wrote: > @dancy it would be lovely if we can speed this up, right now we have `deploy1002` and `maps*` on version 3.17.1, and the rest on... [15:56:05] (03CR) 10Thcipriani: [C: 04-1] "Looking good, one minor problem and this should be good to go" [tools/scap] - 10https://gerrit.wikimedia.org/r/725333 (owner: 10Ahmon Dancy) [15:57:28] 10Release-Engineering-Team (Next), 10serviceops, 10GitLab (Infrastructure), 10Patch-For-Review, 10User-brennen: GitLab minor release: 14.3.1 - https://phabricator.wikimedia.org/T292256 (10brennen) > @brennen did you plan to upgrade the runners as well? Otherwise I can remove them from the change. Yeah,... [15:58:16] (03PS2) 10Ahmon Dancy: fix: template.py Python 3 fallout (part 2) [tools/scap] - 10https://gerrit.wikimedia.org/r/725333 [15:59:17] (03CR) 10Ahmon Dancy: fix: template.py Python 3 fallout (part 2) (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/725333 (owner: 10Ahmon Dancy) [16:00:06] (03CR) 10Thcipriani: [C: 03+2] fix: template.py Python 3 fallout (part 2) [tools/scap] - 10https://gerrit.wikimedia.org/r/725333 (owner: 10Ahmon Dancy) [16:00:54] (03Merged) 10jenkins-bot: fix: template.py Python 3 fallout (part 2) [tools/scap] - 10https://gerrit.wikimedia.org/r/725333 (owner: 10Ahmon Dancy) [16:13:44] (03PS1) 10Ahmon Dancy: Release 4.0.2-1 [tools/scap] - 10https://gerrit.wikimedia.org/r/725338 [16:14:28] (03CR) 10Ahmon Dancy: [C: 03+2] Release 4.0.2-1 [tools/scap] - 10https://gerrit.wikimedia.org/r/725338 (owner: 10Ahmon Dancy) [16:15:08] (03Merged) 10jenkins-bot: Release 4.0.2-1 [tools/scap] - 10https://gerrit.wikimedia.org/r/725338 (owner: 10Ahmon Dancy) [16:44:46] 10Release-Engineering-Team (Doing), 10Scap, 10serviceops: Deploy Scap version 4.0.2 - https://phabricator.wikimedia.org/T291095 (10dancy) 05Stalled→03Open [16:45:01] 10Release-Engineering-Team (Doing), 10Scap, 10serviceops: Deploy Scap version 4.0.2 - https://phabricator.wikimedia.org/T291095 (10dancy) @jijiki 4.0.2 is tagged and ready for a retry. [17:11:45] 10Release-Engineering-Team (Doing), 10Voice & Tone: Rename backport & deployment windows - https://phabricator.wikimedia.org/T290859 (10greg) Thank you for undoing my bad naming. <3 [17:24:50] Reedy: when will extensions supplement come [17:26:00] When it's written [17:26:19] It's not me that does them usually [19:03:46] (03PS1) 10Subramanya Sastry: Tweak dewiki cite css [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/725356 [19:20:00] 10Project-Admins: Create project tag for MediaWiki-Metrics - https://phabricator.wikimedia.org/T292311 (10colewhite) [19:20:26] 10Project-Admins: Create project tag for MediaWiki-Metrics - https://phabricator.wikimedia.org/T292311 (10colewhite) [19:22:16] 10Project-Admins: Create project tag for MediaWiki-Metrics - https://phabricator.wikimedia.org/T292311 (10colewhite) [19:38:49] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments: 1.38.0-wmf.2 deployment blockers - https://phabricator.wikimedia.org/T281166 (10jeena) 05Open→03Resolved [20:17:18] 10Continuous-Integration-Config, 10Release-Engineering-Team (Doing), 10Developer Productivity, 10Patch-For-Review, 10Regression: Quibble jobs for PHPUnit are missing log artefacts - https://phabricator.wikimedia.org/T291227 (10hashar) I have adjusted my patch to inject $wgDebugLog and $wgDebugLogGroup wh... [20:27:45] (03CR) 10Arlolra: [C: 03+2] Tweak dewiki cite css [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/725356 (owner: 10Subramanya Sastry) [21:38:50] (03PS2) 10Subramanya Sastry: Tweak dewiki cite css [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/725356 [21:38:52] (03PS1) 10Subramanya Sastry: Don't strip about-id span wrappers with lang attributes [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/725375 [21:58:15] (03CR) 10Subramanya Sastry: "Can we get this in please? :-)" [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/724158 (owner: 10Subramanya Sastry) [22:05:52] Daimona: (This is really important..) I wonder if it'd be at all feasible for the phan sec tests to have their expected output actually inside the PHP file inlined somehow. That would make review a lot easier :D, but probably not trivial to do. Just an idea :) [22:06:04] really unimportant* darn, that was not right [22:06:18] You mean like e.g. the php interpreter tests? [22:07:16] In that case, it'd probably be possible, yes, but it would need a custom parser for that. Also, sometimes a test might need multiple files (for readability), and I'm not sure how we'd do in that case [22:07:46] Lately I've been trying to include code comments so it's easier to match the output, but yeah, I recognize it's still far from being perfect :-/ [22:07:55] I was thinking even further, like basically line 2: // phan says X for line 3, line 3: this is line 3. [22:08:38] we have something hacky like that for the eslint tests. basically we set inline comments that disable eslint, and we verify that it passes with 0 redundant silences [22:08:59] but we want to assert more than just the rule name [22:09:05] so would be non-trivial [22:09:19] Yeah, the inline comments have been very helpful [22:10:57] Yeah, we can't do that due to the "caused-by part" [22:15:32] 10Project-Admins: Create project tag for MediaWiki-libs-Metrics - https://phabricator.wikimedia.org/T292311 (10Krinkle) [22:20:12] 10Project-Admins: Create project tag for MediaWiki-libs-Metrics - https://phabricator.wikimedia.org/T292311 (10Krinkle) In a nut shell, the phrase "MediaWiki" used in PHP packages or PHP namespaces generally means "MediaWiki-specific", which libraries are not, so we vendor libraries as being "from Wikimedia". On... [22:21:34] 10Project-Admins: Create project tag for Web2Cit - https://phabricator.wikimedia.org/T292323 (10diegodlh) [22:21:58] 10Project-Admins, 10MediaWiki-libs-Metrics: Create project tag for MediaWiki-libs-Metrics - https://phabricator.wikimedia.org/T292311 (10Krinkle) Done, and added to the list on #mediawiki-general. [22:22:03] 10Project-Admins, 10MediaWiki-libs-Metrics: Create project tag for MediaWiki-libs-Metrics - https://phabricator.wikimedia.org/T292311 (10Krinkle) 05Open→03Resolved a:03Krinkle [22:25:30] 10Release-Engineering-Team (Done by Wed 06 Oct), 10Security-Team, 10GitLab (CI & Job Runners), 10Patch-For-Review, and 2 others: Limit GitLab shared runners to images from Wikimedia Docker registry - https://phabricator.wikimedia.org/T291978 (10brennen) Thanks everyone for the thoughtful input. I'm going... [22:29:01] (03PS1) 10Subramanya Sastry: Add kowiki custom counter styles [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/725387