[02:52:55] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: docker-reporter-releng-images => docker registry: status=3/NOTIMPLEMENTED - https://phabricator.wikimedia.org/T292485 (10Legoktm) The job passes now: > Oct 06 01:32:54 deneb systemd[1]: docker-reporter-releng-images.service: Succeeded. I'm n... [05:23:06] 10Release-Engineering-Team (Doing), 10Scap, 10serviceops: Deploy Scap version 4.0.2 - https://phabricator.wikimedia.org/T291095 (10jijiki) 05Open→03Resolved a:03jijiki [07:30:57] > Content Security Policy: The page’s settings observed the loading of a resource at inline (“script-src”). A CSP report is being sent. [07:31:13] and I have learned about Content-Security-Policy analyzer: https://cspscanner.com/?q=gitlab-replica.wikimedia.org [07:31:18] jelto: ^ ;) [07:39:50] (03PS2) 10Kosta Harlan: Add support for phpbench [integration/quibble] - 10https://gerrit.wikimedia.org/r/726681 (https://phabricator.wikimedia.org/T291549) [07:50:45] (03PS3) 10Kosta Harlan: Add support for phpbench [integration/quibble] - 10https://gerrit.wikimedia.org/r/726681 (https://phabricator.wikimedia.org/T291549) [07:58:27] jelto: and food for later: we probably want to move Gitlab web server behind the ATS cache infrastructure so we can benefit from all its feature ;) [07:58:37] E_TOO_MANY_STUFF [08:29:27] (03CR) 10Hashar: [C: 03+2] "Straightforward. For most of the CI jobs we will probably want to skip php-bench to avoid running multiple times. But that is to be figur" [integration/quibble] - 10https://gerrit.wikimedia.org/r/726681 (https://phabricator.wikimedia.org/T291549) (owner: 10Kosta Harlan) [08:48:30] (03Merged) 10jenkins-bot: Add support for phpbench [integration/quibble] - 10https://gerrit.wikimedia.org/r/726681 (https://phabricator.wikimedia.org/T291549) (owner: 10Kosta Harlan) [08:51:17] hashar: cheers [08:51:52] hashar: Comment va la vie? [08:52:39] kostajh: we will want to adjust the `--skip` parameters in the CI jobs to avoid running phpbench too many time. But that should not be too complicated ;) [08:52:53] I'm working with Joseph, Tajh and Olja on cleaning up our Gobblin fork. We've started on Github, but we're mostly ready to move to gerrit. [08:53:15] s/gerrit/GitLab ;) [08:53:26] Any chance you could create a repo for us? named "analytics/gobblin-wmf" [08:53:44] Happy to move to gitlab if we already have CI running in there. [08:57:50] that's probably a bit more complicated to answer, I guess it depends on your needs (and I defer to Antoine) [08:58:39] there are some projects using runners, but I don't know how officially supported that is currently [08:59:23] 10Release-Engineering-Team (Done by Wed 06 Oct), 10Security-Team, 10ContentSecurityPolicy, 10GitLab (Administration, Settings & Policy), and 4 others: Define a Content Security Policy for GitLab - https://phabricator.wikimedia.org/T285363 (10hashar) I have amended the Ansible based patch again https://gerr... [08:59:34] (03PS1) 10Kosta Harlan: Release: Quibble 1.1.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/726856 [09:00:29] there is a green check next to "build puppetized CI runners" on https://www.mediawiki.org/wiki/GitLab/Roadmap, though [09:01:36] This is a Java project, and there is non trivial integration. It's probably easier to migrate all those projects at the same time. [09:01:52] yeah [09:01:56] gehel: doing it [09:02:04] hashar: thanks ! [09:02:36] I'll try to add it to CI as well, but I'll need your help to review and merge [09:02:46] gehel: I recommending doing a git clone --mirror of the github repository then git push --mirror to gerrit [09:02:51] so you will be able to keep all references [09:03:06] that needs some extra permissions on https://gerrit.wikimedia.org/r/admin/repos/analytics/gobblin-wmf,access [09:03:13] like push/forge author identity [09:03:26] That would have been my next question ;) [09:03:39] doc at https://www.mediawiki.org/wiki/Git/Creating_new_repositories#Importing_from_an_existing_repository [09:03:49] Thanks ! [09:03:51] you will need to add the following permissions: Push, Forge Author Identity, Forge Committer Identity on refs/* [09:04:03] There will be an error about refs/meta/config which holds the Gerrit repository configuration and can not be overwritten. [09:04:08] and the doc has the actual git commands to use [09:04:22] that should also replicate all the push/merge references from github [09:04:38] but not the reviews/issues since well they are not stored in git by github (unlike gerrit) [09:05:56] gehel: and you are not a member of the Analytics group [09:05:59] I'll try that and get back to you this afternoon [09:07:53] gehel: apparently we can now directly add a user, so I have made you an owner https://gerrit.wikimedia.org/r/admin/repos/analytics/gobblin-wmf,access ;) [09:08:01] should let you add the required permissions [09:08:07] I am off for groceries shopping [09:11:21] hashar: thanks! [09:18:39] (03PS1) 10Kosta Harlan: dockerfiles: Quibble 1.1.0 [integration/config] - 10https://gerrit.wikimedia.org/r/726859 [09:19:31] (03PS2) 10Kosta Harlan: dockerfiles: Quibble 1.1.0 [integration/config] - 10https://gerrit.wikimedia.org/r/726859 [09:21:45] (03CR) 10jerkins-bot: [V: 04-1] dockerfiles: Quibble 1.1.0 [integration/config] - 10https://gerrit.wikimedia.org/r/726859 (owner: 10Kosta Harlan) [09:25:18] (03PS3) 10Kosta Harlan: dockerfiles: Quibble 1.1.0 [integration/config] - 10https://gerrit.wikimedia.org/r/726859 [10:48:00] kostajh: the 1.1.0 release should not have an entry for master in the changelog.md, otherwise good to go [10:53:41] amending and cutting release [10:58:11] (03PS2) 10Hashar: Release: Quibble 1.1.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/726856 (owner: 10Kosta Harlan) [10:58:13] (03PS1) 10Hashar: changelog: begin new 1.1.1 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/726869 [10:59:19] (03CR) 10Hashar: [C: 03+2] "Thanks!" [integration/quibble] - 10https://gerrit.wikimedia.org/r/726856 (owner: 10Kosta Harlan) [10:59:23] (03CR) 10Hashar: [C: 03+2] changelog: begin new 1.1.1 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/726869 (owner: 10Hashar) [11:07:47] hashar: thanks. I started a patch to update the jobs but then got confused because some already use version 1.1.0 [11:12:38] head -n 1 dockerfiles/quibble*/changelog [11:12:46] quibble-buster-php73-coverage (1.1.1-s2) wikimedia; urgency=high [11:12:50] yeah that one is a typo [11:13:46] because of https://gerrit.wikimedia.org/r/c/integration/config/+/709744/4/dockerfiles/quibble-buster-php73-coverage/changelog [11:15:14] I guess you can change the version of that image to 1.1.0 and append something like -s0 [11:15:35] or `1.1.0-s0` leaving a note in the change log that it is really Quibble 1.1.0 [11:15:59] as long as the version has never been used, no image exists and thus it will be build with the 1.1.0 quibble [11:16:42] * hashar commutes folks around the place [11:17:37] (03Merged) 10jenkins-bot: Release: Quibble 1.1.0 [integration/quibble] - 10https://gerrit.wikimedia.org/r/726856 (owner: 10Kosta Harlan) [11:17:39] (03Merged) 10jenkins-bot: changelog: begin new 1.1.1 version cycle [integration/quibble] - 10https://gerrit.wikimedia.org/r/726869 (owner: 10Hashar) [11:19:45] !log Tag Quibble 1.1.0 @ 3dabcab [11:19:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:19:56] done [11:20:04] will look at the CI stuff later this afternoon [11:45:05] hmm [11:47:33] (03PS4) 10Hashar: dockerfiles: Quibble 1.1.0 [integration/config] - 10https://gerrit.wikimedia.org/r/726859 (owner: 10Kosta Harlan) [11:48:34] (03CR) 10Hashar: "quibble-buster-php73-coverage erroneously got bumped to 1.1.0 in https://gerrit.wikimedia.org/r/c/integration/config/+/709744/4/dockerfile" [integration/config] - 10https://gerrit.wikimedia.org/r/726859 (owner: 10Kosta Harlan) [11:48:55] kostajh: I have added quibble-buster-php73-coverage as 1.1.0-s0 [11:49:08] if you could verify, I will then build the images [11:49:39] (03CR) 10Kosta Harlan: [C: 03+1] dockerfiles: Quibble 1.1.0 [integration/config] - 10https://gerrit.wikimedia.org/r/726859 (owner: 10Kosta Harlan) [11:49:47] :D [11:49:57] (03CR) 10Hashar: [C: 03+2] dockerfiles: Quibble 1.1.0 [integration/config] - 10https://gerrit.wikimedia.org/r/726859 (owner: 10Kosta Harlan) [11:50:04] that was a good catch, I would definitely have missed it [11:50:05] hashar: making a patch to update the jobs now [11:50:34] `./utils/docker-updates | grep quibble` should help [11:51:34] (03PS1) 10Kosta Harlan: jjb: Bump Quibble jobs to 1.1.0 [integration/config] - 10https://gerrit.wikimedia.org/r/726880 [11:51:39] Hopefully I do not break all of MediaWiki CI again [11:52:28] (03Merged) 10jenkins-bot: dockerfiles: Quibble 1.1.0 [integration/config] - 10https://gerrit.wikimedia.org/r/726859 (owner: 10Kosta Harlan) [11:54:58] I reviewed the full diff 1.0.1..1.1.0 , I am more concerned about the setuptools related change :D [11:55:20] and of course by whatever new package that get refreshed by apt [11:55:24] hashar: idle thought, maybe there could be a way for "check experimental" to run quibble on master for a particular core/extension/skin patch. That could help catch issues before doing the full release cycle [12:00:00] can add that to integration/quibble for sure [12:01:31] probably reuse the fullrun job and get utils/ci-fullrun.sh to accept some argument/option like --extension FOO [12:01:45] it targets mediawiki/core @ master [12:21:31] (03CR) 10Hashar: [C: 03+2] "Fresh now has node 12 and 14 versions, it hasn't phased out node 10 (there is still a fresh-node10 and it is still referred to by tests)." [integration/config] - 10https://gerrit.wikimedia.org/r/720153 (owner: 10Jforrester) [12:22:26] (03Abandoned) 10Hashar: test [integration/gearman-java] - 10https://gerrit.wikimedia.org/r/724980 (owner: 10Rajeshjntu) [12:27:32] (03CR) 10Hashar: "Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster-php74:1.1.0" [integration/config] - 10https://gerrit.wikimedia.org/r/726859 (owner: 10Kosta Harlan) [12:30:07] hashar: yeah, I think worst case is that 'phpbench' doesn't execute properly as I'd expect. I tried testing locally and got far enough that I think it would work, but running quibble locally is still a challenge on my machine :\ [12:30:19] jelto: I have refreshed the gitlab ansible patch for CSP if you don't mind redeploying it to the gitlab-replica ;) https://gerrit.wikimedia.org/r/c/operations/gitlab-ansible/+/725900 [12:30:28] jelto: I found a few more tweaks this morning [12:30:49] kostajh: well we can surely pair on finding a way for you to run [12:30:51] 10Beta-Cluster-Infrastructure, 10SRE, 10Traffic, 10Patch-For-Review: Figure out why deployment-cache-text06 keeps crashing - https://phabricator.wikimedia.org/T286502 (10ema) 05Open→03Resolved a:03ema After lowering the amount of memory used for the ATS backend ram cache, there's now some more availa... [12:30:58] pretty sure there might be glitches worth fixing in quibble itself [12:31:34] I wuld eventually want to get rid of `--skip-deps` and `--skip-zuul` [12:31:38] and convert those to stages [12:32:27] then for CI purposes, it works fine as is so I don't have an incentive to enhance that :-\ [12:34:59] hashar: I'm currently testing the puppetised ansible code from https://gerrit.wikimedia.org/r/c/operations/puppet/+/724430 on gitlab-replica. So in the best case there will be no more ansible deployment and we can merge the puppet change tomorrow/friday. I will ping you on the task as soon as the puppetisation of all ansible logic was successful. [12:37:21] OH [12:37:37] jelto: that has been fast! I synced the puppet patch with the latest updates from the ansible one [12:38:05] this time with trailing commas :] [12:39:58] also learned the hard way that the uBlock firefox extension blocks emission of csp reports :-\ [13:39:29] (03PS1) 10Gehel: Initial configuration of the new analytics/gobblin-wmf project. [integration/config] - 10https://gerrit.wikimedia.org/r/726907 [13:42:10] hashar: I've imported my code into https://gerrit.wikimedia.org/r/admin/repos/analytics/gobblin-wmf and the above CR is trying to activate CI. It's probably missing something (at least I don't see where the mapping of project name to repository is). [13:51:57] 10Release-Engineering-Team (Radar), 10Infrastructure-Foundations, 10GitLab (Infrastructure), 10Patch-For-Review, and 3 others: Puppetise gitlab-ansible playbook - https://phabricator.wikimedia.org/T283076 (10Jelto) I rolled out the puppetised changes to `gitlab2001` (gitlab-replica). Apart from a [minor ss... [14:38:44] 10Release-Engineering-Team (Doing), 10Scap, 10serviceops: Deploy Scap version 4.0.2 - https://phabricator.wikimedia.org/T291095 (10dancy) Yay! thanks @jijiki ! [14:47:10] 10Release-Engineering-Team (Doing), 10Scap, 10serviceops: Deploy Scap version 4.0.2 - https://phabricator.wikimedia.org/T291095 (10dancy) [14:47:16] 10Scap, 10serviceops: Scap error when deploying kartotherian - https://phabricator.wikimedia.org/T291990 (10dancy) 05Open→03Resolved a:03dancy @Jgiannelos Scap 4.0.2 has been deployed everywhere. It has fixes for the problem you reported in this ticket. Let me know if you have any further issues. [14:53:28] 10Release-Engineering-Team, 10Scap: Bad behavior when "scap backport --list" is control-c'd - https://phabricator.wikimedia.org/T292638 (10dancy) [14:55:04] 10Release-Engineering-Team, 10Scap: Bad behavior when "scap backport --list" is control-c'd - https://phabricator.wikimedia.org/T292638 (10dancy) [15:52:14] 10Release-Engineering-Team, 10SRE: Reduce latency of new Scap releases - https://phabricator.wikimedia.org/T292646 (10dancy) [15:55:59] hashar, kostajh: Did the quibble upgrade work? It'll have accidentally bumped the composer version to 2.x ahead of my patch (https://gerrit.wikimedia.org/r/c/integration/config/+/726039 which I was going to deploy tonight). If it does, I guess I can deploy faster rather than waiting for no-one to be writing code. :-) [15:56:19] Oh, right, it's not deployed yet. [15:56:58] I can deploy both if that would help? [15:58:40] (03PS2) 10Dduvall: Replace simple git server with Gerrit [tools/train-dev] - 10https://gerrit.wikimedia.org/r/726714 [16:01:42] (03CR) 10Joal: "My very low understanding tells me that the template used should pick up the correct repo and do some magic, but that's as much as I under" [integration/config] - 10https://gerrit.wikimedia.org/r/726907 (owner: 10Gehel) [16:11:55] oh [16:12:17] James_F: composer v2 is unattended, I guess we install it from integration/composer @ master isn't it ? [16:12:28] the intent was to rebuild for quibble 1.1.0 [16:16:11] 10Phabricator: Cover dashboards and panels in weekly Phab changes email - https://phabricator.wikimedia.org/T292062 (10Aklapper) Not to myself: Does not seem to require expanding DB `GRANT USAGE / SELECT` in https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/modules/role/tem... [16:21:03] James_F: go ahead with the composer 2 update [16:21:28] I can do the 1.1.0 switch tomorrow with kosta, the sole feature that brings is the ability to detect and run "composer phpbench" [16:22:40] (03CR) 10Hashar: [C: 03+1] "Please do :) We can do the Quibble 1.1.0 upgrade tomorrow" [integration/config] - 10https://gerrit.wikimedia.org/r/726039 (https://phabricator.wikimedia.org/T279857) (owner: 10Jforrester) [16:26:30] James_F: oops, I didn't realize that. Yeah if you want to deploy your patch I can redo mine tomorrow [16:27:07] Or you could switch the quibble versions to 1.1.0 in your patch and do them together, but maybe that is overcomplicating things (and making more work for you) in case something goes wrong [16:27:35] though quibble 1.1.0 *should* be pretty safe 🤞 [16:29:09] 10Release-Engineering-Team (Priority Backlog 🔥), 10MW-on-K8s, 10Release Pipeline, 10User-brennen: Scap backport change_url command - https://phabricator.wikimedia.org/T287042 (10dduvall) [16:29:18] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Doing), 10Zuul: Migrate Zuul alerting to Grafana / AlertManager - https://phabricator.wikimedia.org/T292284 (10hashar) 05Stalled→03Resolved It is theoretically solved, will reopen if it is not breaking. [16:29:24] I'll do them apart just in case my change (or yours) breaks the world. :-) [16:29:53] 10Release-Engineering-Team (Done by Wed 06 Oct), 10Security-Team, 10ContentSecurityPolicy, 10GitLab (Administration, Settings & Policy), and 4 others: Define a Content Security Policy for GitLab - https://phabricator.wikimedia.org/T285363 (10hashar) 05Open→03In progress [16:30:35] 10Phabricator: Cover dashboards and panels in weekly Phab changes email - https://phabricator.wikimedia.org/T292062 (10Aklapper) Looks like I wrote that already (heh!) but there is a typo in the SQL query so result set has always been incorrectly empty. Also, probably not worth to list dashboards but only list p... [16:31:20] 10Phabricator: Fix Panel changes listing in weekly Phab changes email - https://phabricator.wikimedia.org/T292062 (10Aklapper) [16:32:39] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Priority Backlog 🔥), 10Elasticsearch: Set up data storage to collect loosely structured data from CI - https://phabricator.wikimedia.org/T211904 (10mmodell) [16:37:14] (03CR) 1020after4: [V: 03+2 C: 03+2] Remove "Find normalized_message in Logstash" link [releng/phatality] - 10https://gerrit.wikimedia.org/r/713675 (owner: 10Krinkle) [16:37:56] James_F: yeah probably better to roll them apart indeed [16:38:08] I have zero clue about composer v2 [16:38:31] the quibble one for phpbench I can do it tomorrow. It is 99.99% going to be a noop anyway [16:42:24] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.38.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T281167 (10brennen) [16:42:33] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.38.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T281167 (10brennen) [16:56:53] hashar: Cool. [17:05:58] (03PS3) 10Dduvall: Replace simple git server with Gerrit [tools/train-dev] - 10https://gerrit.wikimedia.org/r/726714 [17:21:33] 10Continuous-Integration-Config: CI should validate that the pecl tarball contains all the necessary files to build the extension - https://phabricator.wikimedia.org/T276417 (10hashar) `pecl install [channel/]` defaults to pecl.php.net channel and its configuration. For directories: ` $ pecl config-show... [17:32:21] 10Continuous-Integration-Config: CI should validate that the pecl tarball contains all the necessary files to build the extension - https://phabricator.wikimedia.org/T276417 (10Legoktm) >>! In T276417#7381588, @hashar wrote: > Al the php*compile Docker images had to be rebuild due to {T291425}. > > I haven't up... [17:36:53] legoktm: no worries :] [19:03:36] (03CR) 10Ahmon Dancy: [C: 04-1] "First round of comments after reading the code. I did not try running it yet." [tools/train-dev] - 10https://gerrit.wikimedia.org/r/726714 (owner: 10Dduvall) [19:08:33] (03CR) 10Gehel: [C: 04-1] Initial configuration of the new analytics/gobblin-wmf project. (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/726907 (owner: 10Gehel) [19:08:43] (03CR) 10Hashar: "On peut pairer ça jeudi après midi ;)" [integration/config] - 10https://gerrit.wikimedia.org/r/726907 (owner: 10Gehel) [19:11:45] (03CR) 10Jforrester: [C: 03+2] "Deployed. All seems OK so far. 🤞" [integration/config] - 10https://gerrit.wikimedia.org/r/726039 (https://phabricator.wikimedia.org/T279857) (owner: 10Jforrester) [19:13:30] (03Merged) 10jenkins-bot: jjb: Switch everything to images using composer 2.x not 1.x [integration/config] - 10https://gerrit.wikimedia.org/r/726039 (https://phabricator.wikimedia.org/T279857) (owner: 10Jforrester) [19:14:29] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Re-build CI containers with Composer 2.x - https://phabricator.wikimedia.org/T279857 (10Jdforrester-WMF) 05In progress→03Resolved a:03Jdforrester-WMF [19:19:04] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.38.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T281167 (10brennen) [19:27:00] 10Release-Engineering-Team (Done by Wed 06 Oct), 10Security-Team, 10GitLab (CI & Job Runners), 10Patch-For-Review, and 2 others: Limit GitLab shared runners to images from Wikimedia Docker registry - https://phabricator.wikimedia.org/T291978 (10dduvall) It does seem like some additional security modeling c... [20:32:24] James_F: thx! I will do the quibble 1.1.0 one tomorrow (and maybe rebase if needed) [20:36:55] Sure. [21:06:05] 10Continuous-Integration-Infrastructure, 10DC-Ops, 10netops, 10ops-codfw: Flapping codfw management alarm ( contint2001.mgmt/SSH is CRITICAL ) - https://phabricator.wikimedia.org/T283582 (10Papaul) We are seeing this issue because all those hosts are running an old firmware version for the IDRAC. Upgrading... [21:15:05] James_F: any idea on https://phabricator.wikimedia.org/T292676 [21:18:47] You made a composer change [21:19:03] It's so far the only change I can see in the right timeline [21:21:01] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10Composer, and 2 others: ProofreadPage\Page\PageSlotDiffRendererTest::testGetDif makes CI fail with 'Failed asserting that two strings are identical.' - https://phabricator.wikimedia.org/T292676 (10RhinosF1) https://github.com/wikim... [21:25:54] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10Composer, and 2 others: ProofreadPage\Page\PageSlotDiffRendererTest::testGetDif makes CI fail with 'Failed asserting that two strings are identical.' - https://phabricator.wikimedia.org/T292676 (10Zabe) Btw. there is a second failu... [21:26:51] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10Composer, and 2 others: ProofreadPage\Page\PageSlotDiffRendererTest::testGetDiff makes CI fail with 'Failed asserting that two strings are identical.' - https://phabricator.wikimedia.org/T292676 (10Krinkle) [21:28:07] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10Composer, and 2 others: ProofreadPage\Page\PageSlotDiffRendererTest::testGetDiff makes CI fail with 'Failed asserting that two strings are identical.' - https://phabricator.wikimedia.org/T292676 (10Krinkle) Another failure at https... [21:30:52] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10Composer, and 2 others: ProofreadPage\Page\PageSlotDiffRendererTest::testGetDiff makes CI fail with 'Failed asserting that two strings are identical.' - https://phabricator.wikimedia.org/T292676 (10Krinkle) The most likely cause is... [21:34:48] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10Composer, and 2 others: ProofreadPage\Page\PageSlotDiffRendererTest::testGetDiff makes CI fail with 'Failed asserting that two strings are identical.' - https://phabricator.wikimedia.org/T292676 (10Krinkle) I think in this case it'... [22:03:48] RhinosF1: Hmm, yeah, that might be my fault. [22:06:13] (Or rather, might be caused by a new version of wikidiff that would have been auto-bundled with any change to these images, and I bit the bullet first, whoops.) [22:08:39] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10Composer, and 2 others: ProofreadPage\Page\PageSlotDiffRendererTest::testGetDiff makes CI fail with 'Failed asserting that two strings are identical.' - https://phabricator.wikimedia.org/T292676 (10Jdlrobson) Another failure on htt... [22:14:43] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10wikidiff2, and 3 others: New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff as it's doing an exact string match - https://phabricator.wikimedia.org/T292676 (10Jdforrester-WMF) [22:21:51] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10wikidiff2, and 4 others: New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff as it's doing an exact string match - https://phabricator.wikimedia.org/T292676 (10Jdforrester-WMF) Hmm, yes, MW's own... [22:27:54] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10wikidiff2, and 4 others: New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff as it's doing an exact string match - https://phabricator.wikimedia.org/T292676 (10xSavitar) NOTE: Fails on this patch... [22:33:34] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10wikidiff2, and 4 others: New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff as it's doing an exact string match - https://phabricator.wikimedia.org/T292676 (10Jdforrester-WMF) >>! In T292676#7407... [22:34:12] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10wikidiff2, and 4 others: New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff and MW's REST API DiffCompare test - https://phabricator.wikimedia.org/T292676 (10Jdforrester-WMF) [22:58:55] 10Release-Engineering-Team (Deployment Training Requests): Deployment training request for **CBlanton** - https://phabricator.wikimedia.org/T292679 (10CBlanton) [23:03:06] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10wikidiff2, and 4 others: New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff and MW's REST API DiffCompare test - https://phabricator.wikimedia.org/T292676 (10Jdforrester-WMF) 05Open→03Resolved... [23:05:09] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10ProofreadPage, 10wikidiff2, and 4 others: New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff and MW's REST API DiffCompare test - https://phabricator.wikimedia.org/T292676 (10MusikAnimal) >>! In T292676#7406942,... [23:10:50] (03CR) 10Dduvall: "Just one question. Other than that, looks good to me." [tools/train-dev] - 10https://gerrit.wikimedia.org/r/724168 (owner: 10Ahmon Dancy) [23:15:22] 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.38.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T281167 (10brennen) End-of-workday status: Logs generally quiet, with the exception of T292667, which has a patch and reviewers. I e... [23:24:03] (03CR) 10Dduvall: Replace simple git server with Gerrit (0312 comments) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/726714 (owner: 10Dduvall) [23:25:48] (03CR) 10Dduvall: Replace simple git server with Gerrit (031 comment) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/726714 (owner: 10Dduvall) [23:36:57] (03PS4) 10Dduvall: Replace simple git server with Gerrit [tools/train-dev] - 10https://gerrit.wikimedia.org/r/726714 [23:39:48] (03PS5) 10Dduvall: Replace simple git server with Gerrit [tools/train-dev] - 10https://gerrit.wikimedia.org/r/726714