[00:12:13] (03CR) 1020after4: [C: 03+2] bump dashboards version to 1.2.0 [releng/phatality] - 10https://gerrit.wikimedia.org/r/759293 (https://phabricator.wikimedia.org/T299168) (owner: 10Cwhite) [00:37:10] 10GitLab: Gerritlab - https://phabricator.wikimedia.org/T300819 (10TheDJ) [00:50:56] 10GitLab, 10Release-Engineering-Team: Gerritlab - https://phabricator.wikimedia.org/T300819 (10brennen) [07:23:40] PROBLEM - Check systemd state on doc1001 is CRITICAL: CRITICAL - degraded: The following units failed: rsync-doc-doc1002.eqiad.wmnet.service https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state [07:43:59] 10GitLab, 10Release-Engineering-Team: Gerritlab - https://phabricator.wikimedia.org/T300819 (10Aklapper) [08:18:58] RECOVERY - Check systemd state on doc1001 is OK: OK - running: The system is fully operational https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state [08:25:12] 10Release-Engineering-Team (Next), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.38.0-wmf.20 deployment blockers - https://phabricator.wikimedia.org/T293961 (10Raymond) [09:15:04] hashar: when live-hacking wmcs puppetmasters, can I ask you to cherry-pick those commits on top of the checked out branch instead of checking out the commit itself? otherwise the puppet repository update script is going to get confused and send annoying alerts [09:43:46] 10Release-Engineering-Team (Next), 10Patch-For-Review, 10Release, 10Train Deployments, 10User-brennen: 1.38.0-wmf.20 deployment blockers - https://phabricator.wikimedia.org/T293961 (10kostajh) {T300831} doesn't seem worth blocking the train over, but just noting it here. There are 5 reports in Logstash i... [09:48:24] 10Phabricator: Lost permissions to manage project descriptions - https://phabricator.wikimedia.org/T300841 (10awight) [10:04:45] 10Phabricator: Cannot manage Phab project description: "You do not have access to any forms which are enabled and marked as edit forms." - https://phabricator.wikimedia.org/T300841 (10Aklapper) [10:05:02] 10Phabricator: Cannot manage Phab project description: "You do not have access to any forms which are enabled and marked as edit forms." - https://phabricator.wikimedia.org/T300841 (10Aklapper) Interesting, as you are listed as a member of #Trusted-Contributors (which was my first thought) [10:07:32] 10Phabricator: Cannot manage Phab project description: "You do not have access to any forms which are enabled and marked as edit forms." - https://phabricator.wikimedia.org/T300841 (10Aklapper) Ah, the "Edit Form: Sprint Project" in https://phabricator.wikimedia.org/transactions/editengine/projects.project/view/... [10:34:25] 10Release-Engineering-Team (Doing): sal.toolforge.org results cannot be paged - https://phabricator.wikimedia.org/T300846 (10Tgr) [12:10:19] taavi: ohhh hmm [12:11:27] I do a fetch && cherry-pick [12:12:04] and apparently on the integration puppet master it is in detached state for some reason [12:12:25] the local production branch is from September .. [12:13:06] with some abandonned patch https://gerrit.wikimedia.org/r/c/operations/puppet/+/717732 [12:13:12] I will fix out (checkout production) [12:13:23] reset it to origin/production [12:13:31] and cherry pick my patch on top of it. That should do it [12:13:33] sorry for the noise! [12:54:36] (03PS1) 10Hashar: jjb: adjust qemu-run.bash to use a qcow2 image [integration/config] - 10https://gerrit.wikimedia.org/r/759499 (https://phabricator.wikimedia.org/T284774) [13:10:41] 10Project-Admins: Lingua Libre Sign It - https://phabricator.wikimedia.org/T246993 (10Aklapper) @0x010C, @Eavqwiki: It looks like this project tag was never used. Is it still active and wanted, or can it be archived? https://phabricator.wikimedia.org/maniphest/query/klXZE2ZHVGPh/#R [13:14:08] 10Project-Admins: InstantReply - https://phabricator.wikimedia.org/T254237 (10Aklapper) @FNDE: It looks like this project tag was never used - is it still wanted/needed, or can it be archived? https://phabricator.wikimedia.org/maniphest/query/TnE8z.jhnap9/#R https://gitlab.com/FNDE/instantreply/-/commits/master [13:24:10] 10Project-Admins, 10Data-Engineering: Archive Analytics tag - https://phabricator.wikimedia.org/T298671 (10Aklapper) I assume that #Analytics-Features is also a candidate to be archived (and removed from Herald rules)? https://phabricator.wikimedia.org/maniphest/query/osi8Qpfc0NpQ/#R [13:51:27] !log Tag Quibble 1.4.0 @ 4231bc2832395d94e29a332fe8d863301a0cd441 # T300340 T291549 T225730 [13:51:32] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:51:32] T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 [13:51:32] T291549: Evaluate phpbench for benchmarking and guarding against performance regressions - https://phabricator.wikimedia.org/T291549 [13:51:33] T300340: Use Memcached with Quibble - https://phabricator.wikimedia.org/T300340 [13:58:56] nicee [13:59:19] then you need a change to integration/config [13:59:27] err [13:59:33] that is done in #wikimedia-quibble [14:09:21] (03PS1) 10Kosta Harlan: [WIP] dockerfiles: update to Quibble 1.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/759502 [14:11:06] (03CR) 10jerkins-bot: [V: 04-1] [WIP] dockerfiles: update to Quibble 1.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/759502 (owner: 10Kosta Harlan) [14:12:24] (03PS2) 10Kosta Harlan: dockerfiles: update to Quibble 1.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/759502 [14:41:52] (03PS3) 10Hashar: dockerfiles: update to Quibble 1.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/759502 (owner: 10Kosta Harlan) [14:42:20] (03CR) 10Hashar: [C: 03+2] dockerfiles: update to Quibble 1.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/759502 (owner: 10Kosta Harlan) [14:44:08] (03Merged) 10jenkins-bot: dockerfiles: update to Quibble 1.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/759502 (owner: 10Kosta Harlan) [14:53:35] !log Building Docker images for Quibble 1.4.0 (prepared by kostajh) [14:53:37] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:19:12] 10Phabricator, 10Release-Engineering-Team, 10User-brennen: Phabricator admin knowledge transfer - https://phabricator.wikimedia.org/T300693 (10brennen) [15:24:01] 10Continuous-Integration-Infrastructure, 10Performance-Team, 10Patch-For-Review: Provide one or more Qemu agents in CI that use a newer version than 2.x - https://phabricator.wikimedia.org/T284774 (10hashar) I have cherry picked https://gerrit.wikimedia.org/r/c/operations/puppet/+/758514/ on integration-pup... [15:41:33] (03CR) 10Ahmon Dancy: [C: 04-1] "the other reporter's need to be updated to support the add_in_flight method." [tools/scap] - 10https://gerrit.wikimedia.org/r/759326 (owner: 10Ahmon Dancy) [15:43:57] 10Continuous-Integration-Infrastructure, 10Performance-Team, 10Patch-For-Review: Provide one or more Qemu agents in CI that use a newer version than 2.x - https://phabricator.wikimedia.org/T284774 (10hashar) When booting in the grub rescue boot: ` Welcome to GRUB! error: unknown filesystem. grub rescue> ls... [15:49:44] 10Continuous-Integration-Infrastructure, 10Performance-Team, 10Patch-For-Review: Provide one or more Qemu agents in CI that use a newer version than 2.x - https://phabricator.wikimedia.org/T284774 (10hashar) I have put integration-agent-qemu-1003 offline and 1001 back online. Will have to find out what is w... [15:51:24] 10Release-Engineering-Team, 10Infrastructure-Foundations, 10Puppet, 10User-brennen: logspam-watch: sorting by message (column 6) appears broken - https://phabricator.wikimedia.org/T300298 (10dancy) 05Open→03Resolved a:03dancy [16:05:19] (03CR) 10Hashar: "Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster-php74:1.4.0" [integration/config] - 10https://gerrit.wikimedia.org/r/759502 (owner: 10Kosta Harlan) [16:06:32] so I got defeated by grub refusing to boot after the vm Linux partition gets moved from sda1 to sda3 :/ [16:06:35] I give up for now [16:17:30] ooh interesting. [16:18:00] dancy: I have dumped a few bits of today debugging on the task :D [16:18:23] I am confident that virt-resize renaming sda1 to sda3 causes grub to be confused somehow [16:18:38] then who knows really :] I never quite understood how grub works [16:21:45] btw, what command are you using to start the vm? [16:21:57] let me look it up [16:22:18] qemu-system-x86_64 -device virtio-net,netdev=user.0 -netdev user,id=user.0,hostfwd=tcp::4293-:22 -m 4096 -nographic vm.qcow2 [16:22:49] taken from the integration/config jjb/qemu-run.bash script [16:23:57] thx [16:24:25] I have been trying it directly on integration-agent-qemu-1003.integration.eqiad1.wikimedia.cloud [16:24:46] I copied the /srv/vm-images/delta.qcow2 to my home dir [16:25:58] maybe I need grub to be reinstalled [16:30:08] (03PS1) 10Kosta Harlan: jjb: Switch integration-quibble-fullrun to 1.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/759523 (https://phabricator.wikimedia.org/T299492) [16:31:43] oh yeah [16:32:57] dancy: virt-customize --run-command 'grub-install /dev/sda' -a vm.qcow2 [16:33:11] I am going to amend the puppet patch, wipe the images and run puppet [16:33:23] 👍🏾 Glad you figured it out [16:33:36] I would expect update-grub to do the magic [16:42:43] btw, there's no password for the 'root' user in that image. [16:43:02] I assume that it doesn't allow root login via ssh but that should be checked. [16:43:27] oh the ssh key is passwordless and '--ssh-inject' "root:file:$ssh_key.pub" [16:43:36] so you get passwordless root from the console or via ssh [16:43:46] though I haven't looked at how it was previously configured [16:44:46] yeah that is how it was setup [16:44:50] passwordless ssh key [16:44:59] and add it to /root/.ssh/authorized_keys [16:45:56] so the test commands are run as root inside the vm :/ [16:46:31] looks like there is room for improvement [16:48:48] (03PS2) 10Hashar: jjb: adjust qemu-run.bash to use a qcow2 image [integration/config] - 10https://gerrit.wikimedia.org/r/759499 (https://phabricator.wikimedia.org/T284774) [16:49:45] (03CR) 10Hashar: [C: 03+2] jjb: Switch integration-quibble-fullrun to 1.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/759523 (https://phabricator.wikimedia.org/T299492) (owner: 10Kosta Harlan) [16:51:35] (03Merged) 10jenkins-bot: jjb: Switch integration-quibble-fullrun to 1.4.0 [integration/config] - 10https://gerrit.wikimedia.org/r/759523 (https://phabricator.wikimedia.org/T299492) (owner: 10Kosta Harlan) [16:56:45] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Doing), 10Release Pipeline, 10Patch-For-Review: Pipeline lib still leaks containers on contint1001 / contint2001 - https://phabricator.wikimedia.org/T290608 (10dancy) 05Open→03Resolved [17:12:13] 10Continuous-Integration-Infrastructure, 10Performance-Team, 10Patch-For-Review: Provide one or more Qemu agents in CI that use a newer version than 2.x - https://phabricator.wikimedia.org/T284774 (10hashar) I have found the fix! Grub has to be reinstalled thus I have added: ` virt-customize --run-command 'g... [17:12:17] and the qcow disk is too slow apparently so I rolled back [17:12:21] to be continued later! :] [17:12:26] 👋 [17:15:01] nod.. qcow is pretty slow.. and doesn't really seem to be necessary for your situation. [17:20:03] (03PS2) 10Ahmon Dancy: ProgressReporter: Report number of in-flight operations [tools/scap] - 10https://gerrit.wikimedia.org/r/759326 [17:25:34] (03PS1) 10Kosta Harlan: jjb: Switch integration-quibble-fullrun-extensions to use Apache backend [integration/config] - 10https://gerrit.wikimedia.org/r/759542 (https://phabricator.wikimedia.org/T299492) [17:27:55] (03CR) 10jerkins-bot: [V: 04-1] jjb: Switch integration-quibble-fullrun-extensions to use Apache backend [integration/config] - 10https://gerrit.wikimedia.org/r/759542 (https://phabricator.wikimedia.org/T299492) (owner: 10Kosta Harlan) [17:30:04] (03CR) 10Kosta Harlan: "An alternative is Ib5329eea9a2773a7e6f531c4bb8336bfeba261e7 which should skip the failing Selenium test in GrowthExperiments." [integration/config] - 10https://gerrit.wikimedia.org/r/759542 (https://phabricator.wikimedia.org/T299492) (owner: 10Kosta Harlan) [17:31:18] (03PS2) 10Kosta Harlan: jjb: Switch integration-quibble-fullrun-extensions to use Apache backend [integration/config] - 10https://gerrit.wikimedia.org/r/759542 (https://phabricator.wikimedia.org/T299492) [17:33:41] https://tysonandre.github.io/php-rfc-demo/deque/ [17:34:14] This is a web page showing an unmerged pull request to php-src, compiled to WASM and executed in a web browser, to share how a proposed pull request to C code will behave. [17:57:14] (03PS1) 10Ahmon Dancy: exp/files/www/restart-php7.2-fpm: use kill -USR2 to restart php-fpm [tools/train-dev] - 10https://gerrit.wikimedia.org/r/759550 [17:58:05] (03CR) 10jerkins-bot: [V: 04-1] exp/files/www/restart-php7.2-fpm: use kill -USR2 to restart php-fpm [tools/train-dev] - 10https://gerrit.wikimedia.org/r/759550 (owner: 10Ahmon Dancy) [17:58:34] (03PS2) 10Ahmon Dancy: exp/files/www/restart-php7.2-fpm: use kill -USR2 to restart php-fpm [tools/train-dev] - 10https://gerrit.wikimedia.org/r/759550 [18:03:44] Hmm. Is there a way to add PHPUnit coverage thresholds to extensions? I know how to do it standalone but I can't see how MW's system would pick up a local phpunit.xml.dist file from each extension? [18:23:37] (03CR) 10Ahmon Dancy: [C: 03+2] exp/files/www/restart-php7.2-fpm: use kill -USR2 to restart php-fpm [tools/train-dev] - 10https://gerrit.wikimedia.org/r/759550 (owner: 10Ahmon Dancy) [18:24:02] (03Merged) 10jenkins-bot: exp/files/www/restart-php7.2-fpm: use kill -USR2 to restart php-fpm [tools/train-dev] - 10https://gerrit.wikimedia.org/r/759550 (owner: 10Ahmon Dancy) [18:37:05] dancy: heads up that I'm going to update deployment-cache-text mappings to route api traffic to deployment-mediawiki11 to hopefully reduce the load on single server [18:37:22] 👍🏾 [18:37:26] no lvs or other load balancing there, but at least that is possible to do in a non-hacky way [18:41:31] !log deployment-prep: route /w/api.php to deployment-mediawiki11, trying to reduce load on a single server [18:41:33] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:54:41] 10Release-Engineering-Team (Yak Shaving 🐃🪒): Dev/maintainers add common reviewers - https://phabricator.wikimedia.org/T290334 (10Aklapper) @thcipriani: https://reviewers.toolforge.org/ exists. (And dreams like {T155851}...) However, I'm wondering which underlying problem this task is supposed to solve and if thi... [19:07:10] 10Release-Engineering-Team (Yak Shaving 🐃🪒): Dev/maintainers add common reviewers in Gerrit - https://phabricator.wikimedia.org/T290334 (10Aklapper) [19:23:10] James_F: you could define some threshold for the SonarQube check pretty easily, but it is not voting, and it also only counts unit, not unit + integration [20:04:50] dancy: I don't know if you want to consider T300831 a train blocker or not. tl;dr THanks doesn't work with Flow pages [20:04:51] T300831: Cannot thank a Flow post on mediawiki.org: "Uncaught TypeError: elem is undefined" - https://phabricator.wikimedia.org/T300831 [20:05:42] I planned to go on your advice and proceed [20:05:51] s/advice/possibly mild suggestion/ [20:06:10] proceed with reverting? or moving the train forward? [20:06:14] moving forward [20:06:36] I think that's fine, but we should probably backport the revert to wmf.20 afterwards. [20:07:51] Sounds good to me. [20:07:56] Starting the group2 rollout now. [20:31:22] kostajh: Yeah. :-( Thanks, will file a task. [20:37:44] 10Continuous-Integration-Config, 10Librarization, 10Test-Coverage: Run a phpunit coverage job pre-merge for libraries - https://phabricator.wikimedia.org/T147093 (10Jdforrester-WMF) It's been a while since this task was filed. :-) Nowadays we do coverage validation pre-merge as a standard step (using [[http... [20:42:22] 10Continuous-Integration-Config, 10Test-Coverage: Provide a way for MediaWiki core and extensions to require PHP code coverage of a certain level as a voting part of CI - https://phabricator.wikimedia.org/T300925 (10Jdforrester-WMF) [22:13:43] phabricator>Woe! This request had its journey cut short by unexpected circumstances (Can Not Connect to MySQL). [22:13:54] went away after 2min [22:21:22] hmm [22:24:24] There was a spike in queries [22:24:24] https://grafana.wikimedia.org/d/000000273/mysql?orgId=1&var-job=All&var-server=db1107&var-port=9104&from=now-1h&to=now [22:24:30] reminds me of T298369 [22:24:31] T298369: Phabricator can not connect to MySQL - https://phabricator.wikimedia.org/T298369 [22:26:40] ew [22:27:07] (03PS1) 10Krinkle: node12,node14: Add npx command to the shell PATH [integration/config] - 10https://gerrit.wikimedia.org/r/759622 (https://phabricator.wikimedia.org/T300930) [22:39:33] 10Release-Engineering-Team (Radar), 10Scap, 10Patch-For-Review, 10User-jijiki: Update Scap to perform rolling restart for all MW deploy - https://phabricator.wikimedia.org/T266055 (10dancy) [22:40:08] (03CR) 10Krinkle: [C: 03+2] "Rolling out for fresh to use." [integration/config] - 10https://gerrit.wikimedia.org/r/759622 (https://phabricator.wikimedia.org/T300930) (owner: 10Krinkle) [22:41:18] zabe: looks similar [22:41:21] 10Release-Engineering-Team (Radar), 10Scap, 10Patch-For-Review, 10User-jijiki: Update Scap to perform rolling restart for all MW deploy - https://phabricator.wikimedia.org/T266055 (10dancy) [22:41:29] If you can see bad traffic, someone could ban them [22:41:32] 10Release-Engineering-Team (Radar), 10Scap, 10Patch-For-Review, 10User-jijiki: Update Scap to perform rolling restart for all MW deploy - https://phabricator.wikimedia.org/T266055 (10dancy) Hi @Joe . Can you update the description of this report with the remaining areas of work? [22:41:36] but meh if it happens once [22:42:13] (03Merged) 10jenkins-bot: node12,node14: Add npx command to the shell PATH [integration/config] - 10https://gerrit.wikimedia.org/r/759622 (https://phabricator.wikimedia.org/T300930) (owner: 10Krinkle) [22:51:51] 10GitLab (Project Migration), 10Release-Engineering-Team (Doing), 10User-brennen: Create new GitLab project group: Generated Data Platform - https://phabricator.wikimedia.org/T296381 (10brennen) > Could you help me understand how repos and people namespaces differ from each other operationally? Groups in `/... [23:05:41] 10GitLab (Project Migration), 10Release-Engineering-Team (Doing), 10User-brennen: Create new GitLab project group: Generated Data Platform - https://phabricator.wikimedia.org/T296381 (10brennen) 05In progress→03Resolved I went ahead and transferred the project, which seems to work for admins: https://git... [23:15:47] 10GitLab (Auth & Access), 10Release-Engineering-Team, 10User-brennen: Investigate what's required to allow a user to fork or transfer a project to a group - https://phabricator.wikimedia.org/T300935 (10brennen) [23:16:03] 10GitLab (Auth & Access), 10Release-Engineering-Team, 10User-brennen: Investigate what's required to allow a user to fork or transfer a project to a group - https://phabricator.wikimedia.org/T300935 (10brennen) p:05Triage→03Medium [23:43:53] 10GitLab, 10Release-Engineering-Team, 10Upstream, 10User-brennen: GitLab group permissions are not inherited by sub-groups for groups of users invited to the parent repo - https://phabricator.wikimedia.org/T300939 (10brennen) [23:44:36] 10GitLab (Project Migration), 10Release-Engineering-Team (Done by Wed 24 Nov 🧟), 10User-brennen, 10cloud-services-team (Kanban): Create top level 'cloud' group on Gitlab - https://phabricator.wikimedia.org/T293741 (10brennen) 05In progress→03Resolved > I'll need to dig into this a bit more. Filed T300...