[08:55:30] hi hashar: in context of this comment https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/786861/14#message-f18826e268e4df478ddd2c60e47b1d24dfea8493, how could I most easily set up the phpbench patch job to only clone/enable GrowthExperiments and not all other skins/extensions? [08:56:34] kostajh: I am guessing you would need another job [08:56:53] which uses ci-src-setup to clone just that repo then invoke composer run phpbench [08:57:15] or maybe that can be inserted in the existing `composer test` target [08:57:22] well, we need the quibble command because --phpbench-aggregate does some extra steps [08:58:11] I was thinking a CLI argument to quibble could also make sense, with extensions/skins to enable. then the job could be set to pass only ZUUL_PROJECT [08:58:35] although you'd need something to handle enabling dependencies (GrowthExperiments doesn't have any hard dependencies) [09:01:07] oh it is broken because HEAD^1 is not compatible with other extensions [09:01:08] nice [09:02:06] anyway [09:03:12] the dependencies are injected by zuul/parameter_functions.py which adds a parameter EXT_DEPENDENCIES to the job [09:03:25] that is then recognized by Quibble to clone the other extensions/skins [09:03:56] but the mediawiki-phpbench-patch-docker job does not have those injected [09:04:16] what do you mean about HEAD^1 not being compatible? [09:04:38] maybe phpbench should not be run in quibble-vendor-mysql-php72-noselenium-docker ? [09:04:45] eg add `--skip phpbench` [09:04:58] since phpbench is run in a standalone job mediawiki-phpbench-patch-docker [09:05:11] btw, there are two problems here: 1) the database / bootstrap error when we start to run tests and 2) maybe we don't need all other extensions/skins in place when phpbench is run [09:05:34] hashar: yeah, we can remove phpbench from the defaults, I think. IMO it makes sense to run only in "aggregate" mode which is a standalone job [09:05:46] so the database / bootstrap error that might be an issue with HEAD~1 which is not fixed and breaks with other extension [09:05:59] and for 2 if you don't need other extensions/skins we can drop phpbench from the main job [09:06:17] then phpbench will be broken if a benchmark on another repo does require dependencies to be injected [09:06:19] :\ [09:06:28] right [10:00:39] * hashar lunches [12:55:41] !log Migrated Castor service from integration-castor03 to integration-castor05 # T252071 [12:55:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:55:44] T252071: Move all Wikimedia CI (WMCS integration project) instances from stretch to buster/bullseye - https://phabricator.wikimedia.org/T252071 [13:11:29] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Seen), 10Cloud-VPS (Debian Stretch Deprecation), 10Patch-For-Review: Move all Wikimedia CI (WMCS integration project) instances from stretch to buster/bullseye - https://phabricator.wikimedia.org/T252071 (10hashar) [13:12:14] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Doing), 10Patch-For-Review, 10ci-test-error (WMF-deployed Build Failure): TAR_ENTRY_ERROR ENOSPC: no space left on device - https://phabricator.wikimedia.org/T292729 (10hashar) [13:12:38] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Seen), 10Cloud-VPS (Debian Stretch Deprecation), 10Patch-For-Review: Move all Wikimedia CI (WMCS integration project) instances from stretch to buster/bullseye - https://phabricator.wikimedia.org/T252071 (10hashar) 05Openβ†’03Resolved A... [13:19:25] (03CR) 10Hashar: [C: 03+1] "Seems good and can be improved in future changes I guess :]" [tools/code-utils] - 10https://gerrit.wikimedia.org/r/788384 (owner: 10Daniel Kinzler) [13:20:08] kostajh: duesen's phpcs precommit git hook looks good enough to me :) I think it is fine to +2 it now ( https://gerrit.wikimedia.org/r/c/mediawiki/tools/code-utils/+/788384 ) [13:20:20] and I guess users will iterate improvements [13:20:52] (03CR) 10Kosta Harlan: [C: 03+1] Add pre-commit hook for automatically fixing code style issues. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/788384 (owner: 10Daniel Kinzler) [13:21:06] hashar: sure :) I haven't tested it so feel free to +2, and yes we can always iterate on it. [13:25:32] (03CR) 10Hashar: [C: 03+2] "Lets fly :)" [tools/code-utils] - 10https://gerrit.wikimedia.org/r/788384 (owner: 10Daniel Kinzler) [13:25:46] this way duesen doesn't have to carry that work over the week-end :D [13:25:48] thx! [13:25:52] oh [13:25:58] and of course there is no CI on that repo bah [13:26:21] who needs CI anyway [13:27:02] (03CR) 10Hashar: [V: 03+2 C: 03+2] Add pre-commit hook for automatically fixing code style issues. [tools/code-utils] - 10https://gerrit.wikimedia.org/r/788384 (owner: 10Daniel Kinzler) [13:27:22] done [13:36:21] 10Release-Engineering-Team, 10Gerrit (Gerrit 3.4): Zuul Depends-On footer processing missing from Gerrit UI after 3.4.4 upgrade - https://phabricator.wikimedia.org/T307621 (10hashar) [13:40:57] 10Release-Engineering-Team, 10Gerrit (Gerrit 3.4): Zuul Depends-On footer processing missing from Gerrit UI after 3.4.4 upgrade - https://phabricator.wikimedia.org/T307621 (10hashar) I haven't touched anything, maybe some cached filed had to be invalidated. Regardless the change we need for plugins/zuul is ht... [13:42:54] 10Release-Engineering-Team, 10Gerrit (Gerrit 3.4): Zuul Depends-On footer processing missing from Gerrit UI after 3.4.4 upgrade - https://phabricator.wikimedia.org/T307621 (10hashar) a:03hashar [13:59:24] 10Gerrit, 10Release-Engineering-Team, 10Patch-For-Review: Gerrit replication after a restart takes roughly 5 hours - https://phabricator.wikimedia.org/T307137 (10hashar) a:03hashar [14:00:02] 10Release-Engineering-Team (Doing), 10Gerrit (Gerrit 3.4): Zuul Depends-On footer processing missing from Gerrit UI after 3.4.4 upgrade - https://phabricator.wikimedia.org/T307621 (10hashar) [14:00:45] 10Gerrit, 10Release-Engineering-Team (Doing), 10Patch-For-Review: Gerrit replication after a restart takes roughly 5 hours - https://phabricator.wikimedia.org/T307137 (10hashar) [14:00:55] 10Release-Engineering-Team (Doing), 10Scap: scap: Bad interaction between multiprocessing.Pool and Lock() context manager - https://phabricator.wikimedia.org/T307242 (10hashar) [14:00:58] 10Release-Engineering-Team (Next), 10Gerrit (Gerrit 3.5): Upgrade to Gerrit 3.5 - https://phabricator.wikimedia.org/T307334 (10hashar) [14:01:47] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team (Next): Upgrade Jenkins to the next LTS, 2.332.2 - https://phabricator.wikimedia.org/T307339 (10hashar) [14:07:52] (03CR) 10Hashar: [C: 03+2] mirror-repos.sh: fix subprocess error handling (031 comment) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/789281 (https://phabricator.wikimedia.org/T307495) (owner: 10Ahmon Dancy) [14:08:18] (03Merged) 10jenkins-bot: mirror-repos.sh: fix subprocess error handling [tools/train-dev] - 10https://gerrit.wikimedia.org/r/789281 (https://phabricator.wikimedia.org/T307495) (owner: 10Ahmon Dancy) [14:09:59] dancy: bash 3 fix merged :) ^ [14:21:15] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Cloud-VPS (Debian Stretch Deprecation): Cloud VPS "integration" project Stretch deprecation - https://phabricator.wikimedia.org/T306078 (10hashar) The last Stretch instance got removed from the `integration` project, done via T252071 ;) Thank yo... [14:31:33] (03CR) 10Tchanders: "Jdforrester - Any idea if we need to do anything else before getting this merged? (T304631#7907944 seems to imply that it can go before th" [tools/release] - 10https://gerrit.wikimedia.org/r/789248 (https://phabricator.wikimedia.org/T306909) (owner: 10Tchanders) [14:55:52] hashar: Thanks! [15:05:02] we need a polyfill bash package [15:16:20] 10Release-Engineering-Team (Doing), 10Scap: scap: Bad interaction between multiprocessing.Pool and Lock() context manager - https://phabricator.wikimedia.org/T307242 (10dancy) 05Openβ†’03Resolved [15:25:28] hashar: Another idea I had last night is to take advantage of the fact that docker is a train-dev requirement, so the mirror-repos.sh script could run in a container that has a modern version of bash (or perhaps Python3, if we rewrite the script). However I think that will have poor performance on Mac OS. [15:27:13] good ideas [15:27:43] python3 might be the way to go indeed, it seems anytime we have more than a few dozens of bash lines it is worth porting them to python [15:34:27] Nod. However in this case performance is the overriding concern. [15:35:39] (especially the first time it is run) [16:09:02] dancy, hashar: Using `#!/usr/bin/env bash` and telling macos folks to install a better bash than the crappy one that Apple ships because they are avoiding GPLv3 would work too. :) [16:10:28] someone should find an even more catastrophic version of shellshock in bash 3, maybe that’ll motivate them to stop shipping a decades old version? ;) [16:20:37] 10GitLab, 10Release-Engineering-Team (GitLab-a-thon 🦊): Investigate alternatives to docker-in-docker for container image creation in GitLab - https://phabricator.wikimedia.org/T307599 (10dduvall) [17:20:53] 10GitLab, 10Release-Engineering-Team (GitLab-a-thon 🦊): Investigate buildkitd instances as image builders for GitLab - https://phabricator.wikimedia.org/T307810 (10dduvall) [17:21:16] 10GitLab, 10Release-Engineering-Team (GitLab-a-thon 🦊): Investigate buildkitd instances as image builders for GitLab - https://phabricator.wikimedia.org/T307810 (10dduvall) 05Openβ†’03In progress [17:21:22] 10GitLab, 10Release-Engineering-Team (GitLab-a-thon 🦊): Investigate alternatives to docker-in-docker for container image creation in GitLab - https://phabricator.wikimedia.org/T307599 (10dduvall) [17:21:25] 10GitLab, 10Release-Engineering-Team (GitLab-a-thon 🦊): Investigate buildkitd instances as image builders for GitLab - https://phabricator.wikimedia.org/T307810 (10dduvall) p:05Triageβ†’03Medium [17:59:49] 10Continuous-Integration-Infrastructure, 10SRE, 10serviceops: contint: puppet - Could not find group deployment - https://phabricator.wikimedia.org/T307740 (10Dzahn) on releases1002: ` Error: Could not find group deployment Error: /Stage[main]/Helm/File[/var/cache/helm]/group: change from 'wikidev' to 'dep... [18:00:05] 10Continuous-Integration-Infrastructure, 10SRE, 10serviceops: contint/releases/etc: puppet - Could not find group deployment - https://phabricator.wikimedia.org/T307740 (10Dzahn) [18:00:56] 10Continuous-Integration-Infrastructure, 10SRE, 10serviceops: contint/releases/hosts with helm installed: puppet - Could not find group deployment - https://phabricator.wikimedia.org/T307740 (10Dzahn) [19:47:07] (03PS6) 10SBassett: Add new permissions for supplemental security tasks [tools/release] - 10https://gerrit.wikimedia.org/r/787110 (https://phabricator.wikimedia.org/T307036) [21:32:31] 10Continuous-Integration-Config, 10Toolhub, 10Documentation, 10User-Slst2020: Publish docs on doc.wikimedia.org - https://phabricator.wikimedia.org/T305914 (10dduvall) >>! In T305914#7903277, @hashar wrote: > All that logic is intended for FreeStyle jobs and it is not reusable in the PipelineLib jobs. The... [21:41:01] 10Continuous-Integration-Config, 10Toolhub, 10Documentation, 10User-Slst2020: Publish docs on doc.wikimedia.org - https://phabricator.wikimedia.org/T305914 (10dduvall) Another option I just thought of: Since we do indeed support archiving files from a stage's container into Jenkins's default artifact store... [23:03:28] 10Beta-Cluster-Infrastructure, 10Abstract Wikipedia team, 10Patch-For-Review: Create a Beta Cluster version of Wikifunctions.org - https://phabricator.wikimedia.org/T284162 (10Jdforrester-WMF) Being able to use `latest` is going to be provided by SRE in https://gerrit.wikimedia.org/r/c/operations/puppet/+/78... [23:23:25] 10GitLab, 10Release-Engineering-Team (GitLab-a-thon 🦊): Investigate buildkitd instances as image builders for GitLab - https://phabricator.wikimedia.org/T307810 (10dduvall) I was able to get a buildkitd cluster working in conjunction with a k8s gitlab runner on Digital Ocean today. Here's the TL;DR. I will upd...