[00:36:18] (03PS3) 10Jack Phoenix: Whitelist Perryprog for CI [integration/config] - 10https://gerrit.wikimedia.org/r/808109 [06:33:00] (03CR) 10Hashar: [C: 03+2] Whitelist Perryprog for CI [integration/config] - 10https://gerrit.wikimedia.org/r/808109 (owner: 10Jack Phoenix) [06:34:53] (03Merged) 10jenkins-bot: Whitelist Perryprog for CI [integration/config] - 10https://gerrit.wikimedia.org/r/808109 (owner: 10Jack Phoenix) [08:48:49] (03CR) 10Jeena Huneidi: [C: 03+1] "I see we only display synced entries at the moment. Is there a plan to offer the user to view unsynced entries as well? Should we display " [tools/scap] - 10https://gerrit.wikimedia.org/r/805496 (https://phabricator.wikimedia.org/T287045) (owner: 10Dduvall) [08:53:13] (03CR) 10Jeena Huneidi: "Oh, I thought we had discussed adding the change numbers for commits that were synced to the history so that rollback can pass them to sca" [tools/scap] - 10https://gerrit.wikimedia.org/r/805496 (https://phabricator.wikimedia.org/T287045) (owner: 10Dduvall) [09:08:51] 10Continuous-Integration-Config, 10MediaWiki-Releasing: Have at least one job running REL1_XX with it's appropriate vendor repo - https://phabricator.wikimedia.org/T295175 (10Reedy) {T309377} was another I caught by checking git logs.. [09:08:56] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10MediaWiki-Vendor: Ensure with test that composer.json matches between mediawiki/vendor and mediawiki/core - https://phabricator.wikimedia.org/T113360 (10Reedy) >>! In T113360#6889415, @Jdforrester-WMF wrote: > Surely we implicitly test this, because... [09:52:58] 10Project-Admins: Please add new tag "Ganeti" - https://phabricator.wikimedia.org/T310683 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public project #Ganeti has been created: https://phabricator.wikimedia.org/project/view/5999/ (In case you need to edit the project or project workboard itself at... [10:08:07] (03CR) 10Hashar: "Very nice, I am not sure why a permission change pushed to refs/meta/config is not taken in account. Maybe the Gerrit instance doesn't do " [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808085 (owner: 10Ahmon Dancy) [10:18:44] (03CR) 10Hashar: [C: 04-1] "An extra comment about the user group being defined with a "user/" prefix which is intended for per user groups dynamically generated by G" [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808085 (owner: 10Ahmon Dancy) [11:51:17] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10MediaWiki-Vendor: Ensure with test that composer.json matches between mediawiki/vendor and mediawiki/core for release branches (where we don't test with vendor) - https://phabricator.wikimedia.org/T113360 (10Jdforrester-WMF) [12:15:48] 10Project-Admins: Create component for product infrastructure orphaned project tickets - https://phabricator.wikimedia.org/T311246 (10SLopes-WMF) If I understand you correctly, @Aklapper your solution does makes sense but, in practice, would lead to those tickets being forever neglected. The addition of this tag... [12:23:46] 10Project-Admins: Create component for product infrastructure orphaned project tickets - https://phabricator.wikimedia.org/T311246 (10Aklapper) > but, in practice, would lead to those tickets being forever neglected. Hmm, how would creating a new tag influence or change that? :) > keep an eye on them without ha... [12:30:33] 10Release-Engineering-Team, 10Cloud-VPS (Quota-requests): Request increased quota for devtools Cloud VPS project - https://phabricator.wikimedia.org/T311302 (10hashar) [12:31:48] 10Release-Engineering-Team, 10Cloud-VPS (Quota-requests): Request increased quota for devtools Cloud VPS project - https://phabricator.wikimedia.org/T311302 (10hashar) [12:40:42] 10Release-Engineering-Team, 10Cloud-VPS (Quota-requests), 10cloud-services-team (Kanban): Request increased quota for devtools Cloud VPS project - https://phabricator.wikimedia.org/T311302 (10bd808) [12:41:02] 10Release-Engineering-Team, 10Cloud-VPS (Quota-requests), 10cloud-services-team (Kanban): Request increased quota for devtools Cloud VPS project - https://phabricator.wikimedia.org/T311302 (10bd808) +1 [12:41:40] 10Release-Engineering-Team, 10Cloud-VPS (Quota-requests), 10cloud-services-team (Kanban): Request increased quota for devtools Cloud VPS project - https://phabricator.wikimedia.org/T311302 (10taavi) a:03taavi [12:42:17] when bd808 does `+1` for breakfast [12:44:05] 10Release-Engineering-Team, 10Cloud-VPS (Quota-requests), 10cloud-services-team (Kanban): Request increased quota for devtools Cloud VPS project - https://phabricator.wikimedia.org/T311302 (10taavi) 05Open→03Resolved Done! [13:44:55] hashar: did it while waiting for my covid test to tell me if I could join the offsite today :) [13:58:42] hashar: do you need a hand with deploy1004 [14:14:00] * dancy sees hashar hacking [14:14:41] jbond: I think I completely screwed up the puppet DB config and the magic ssl certificates :D [14:14:56] it might be faster to start again from scratch [14:14:59] hashar: cann i jjust delete the puppetdb and start again [14:15:02] :) [14:15:23] the thing is that when running puppet agent from the puppetdb instance, it tries to reach out the cloudinfra puppetmaster [14:15:33] so yeah hmm I guess everything can be removed [14:15:48] ack deleteing [14:16:44] there might be some mix up when using a local puppet master [14:16:55] I have once again been defeated by SSL :-\ [14:17:04] hashar where yuo following https://wikitech.wikimedia.org/wiki/Help:Standalone_puppetmaster/PuppetDB [14:17:13] yes! [14:17:22] t.aavi pointed me to that doc [14:17:47] which worked all fine including the postgresql thing [14:18:37] where did you put puppetdb::password::replication [14:18:41] I have done some tiny edits due to a class being renamed `role::puppetmaster::puppetdb` became `role::puppetdb` and there was a typo in a fqdn clouds > cloud (singular) [14:18:41] https://wikitech.wikimedia.org/w/index.php?title=Help:Standalone_puppetmaster/PuppetDB&type=revision&diff=1991442&oldid=1915803&diffmode=source [14:18:52] the password did not work when using secret or private [14:19:04] and I found out it defaults to `puppetdb` [14:19:19] or maybe the password got partially applied [14:19:59] acxk ok give me ~15 mins to see if i can get things sorted [14:25:18] đŸĻ„ [14:34:41] (03CR) 10Ahmon Dancy: Add trainbranchbot Gerrit account (038 comments) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808085 (owner: 10Ahmon Dancy) [14:34:59] (03PS3) 10Ahmon Dancy: Add trainbranchbot Gerrit account [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808085 [14:35:42] hashar: We can discuss ^^ further if needed. I'm taking a "it works, don't mess with it" stance [14:36:01] dancy: +3 [14:36:34] (03CR) 10Ahmon Dancy: Add trainbranchbot Gerrit account (031 comment) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808085 (owner: 10Ahmon Dancy) [14:36:54] dancy: I wondered why pushing to refs/meta/config would not change anything in the config cause I assumed "update-repos" to well update the repos config rather than initializing [14:37:21] That would be nice but it doesn't do that yet. [14:37:29] Maybe you can take that. :-) [14:37:40] * dancy attempts to snipe [14:38:54] (03CR) 10Hashar: Add trainbranchbot Gerrit account (032 comments) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808085 (owner: 10Ahmon Dancy) [14:39:10] let me +2 it [14:39:39] (03CR) 10Hashar: [C: 03+2] "Nice work and thanks for clearing up my random thoughts :]" [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808085 (owner: 10Ahmon Dancy) [14:40:07] (03Merged) 10jenkins-bot: Add trainbranchbot Gerrit account [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808085 (owner: 10Ahmon Dancy) [14:40:53] one less change in the queue [14:41:20] (03CR) 10Ahmon Dancy: Add trainbranchbot Gerrit account (031 comment) [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808085 (owner: 10Ahmon Dancy) [14:41:39] Thanks Antoie [14:41:42] *Antoine! [14:45:09] hashar: all good now. puppetdb is devtools-puppetdb1001.devtools.eqiad1.wikimedia.cloud [14:45:28] so far devtools-puppetdb1001.devtools.eqiad1.wikimedia.cloud and deploy-1004.devtools.eqiad1.wikimedia.cloud are using the standalone puppetmaster [14:46:12] OH MY [14:46:28] lesson learned, next time I ask The Pros [14:47:13] yes not sure what went wrong but thge process is a bit fragile and if things dont get done in the right order can get things in a funny state [14:47:30] there was something screwed up with certificates [14:47:44] so that the puppet master could not reach the puppet db over https due to a wrong cert [14:47:59] so I guess I have cleared the puppet cert on the agent and on the master [14:48:11] but then well who knows, it was considered revoked when doing the http query [14:48:24] my gut feeling is that you configured the puppetmaster to use the new puppetdb before you configuered puppetdb to us the standalone puppetmaster [14:48:44] hmm possibly [14:49:00] the first puppet run on the puppetdb did apply both the standalone puppet master config and the puppet db [14:49:09] and I had to remove the /var/lib/puppet/ssl due to a cert mismatch [14:49:24] then i think stuff may have got rolled back (this could have been me) but the routs.yamlo file still existsed which is why the pupeytmastetr tried sending tstuff to puppet [14:49:46] either way its done now [14:50:21] I wasn't aware of that routes.yaml file :] [14:50:21] yto move clients shold be as easy as 1) update puppetmaster hiera config; `rm -rf /var/lib/puppet/ssl; puppet agent -t` [14:50:38] took me a while to find the routs file as well :) [14:50:47] I am super happy it is fixed, that was the last instance causing an email notification due to puppet being broken [14:50:59] will make our inbox slightly quieter [14:51:03] +1 [14:51:55] cool, ok i have removed my self from the project now [14:56:19] Thanks jbond! [14:58:30] 10Project-Admins: Create project tag for MediaWiki-extensions-Shibboleth - https://phabricator.wikimedia.org/T309719 (10Aklapper) @DaAwesomeP / @N0rthway: ping [15:01:25] (03CR) 10Ahmon Dancy: get_keyholder_key: Return private key path instead of public key (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/808087 (owner: 10Ahmon Dancy) [15:02:57] np :) [15:05:21] (03PS3) 10Ahmon Dancy: get_keyholder_key: Return private key path instead of public key [tools/scap] - 10https://gerrit.wikimedia.org/r/808087 [15:12:11] (03CR) 10Ahmon Dancy: Support a different user for Gerrit ssh interactions (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/805462 (https://phabricator.wikimedia.org/T306425) (owner: 10Hashar) [15:13:15] hashar: Still around? [15:13:20] yeah [15:13:27] I am trying to understand your latest change to scap [15:13:38] ok good. That's what I was going to nag you about. :-) [15:13:40] is it that train-dev uses ssh-agent rather than the keyholder? [15:13:45] Yes. [15:13:51] ah [15:14:09] keyholder is deceiving people into thinking that passing a public key in is correct. [15:14:20] I know nothing about ssh aagent [15:14:43] maybe ssh says, I want to connect solely with the identiy represented by /etc/keyholder.d/thatprivatekey even if I can not read it maybe you can [15:14:55] nod.. that is the impression I get. [15:15:01] then the ssh-agent verify the given file, lookup whether its fingerprint is loaded and then process [15:15:02] the IdentityFile name is passed over to the agent [15:15:21] so one would not even need to have read access to it as long as the agent does [15:15:23] well [15:15:31] yeah that is purely an intuition :] [15:15:37] That's correct. [15:15:52] and it works on train-dev right? [15:16:05] we can test it on production if you want by trying a deploy of /srv/deployment/integration/docroot [15:16:11] Yes. Works in train-dev and prod. [15:16:32] ok, I'm game.. [15:16:39] * dancy sets up [15:17:24] (03CR) 10Hashar: [C: 03+2] "That got tested on train-dev, got verified on production as well." [tools/scap] - 10https://gerrit.wikimedia.org/r/808087 (owner: 10Ahmon Dancy) [15:17:38] going to grab a glass of water and a small snack [15:18:24] `dancy@deploy1002:/srv/deployment/integration/docroot$ ~/devel-scap deploy` succeeded. [15:20:07] ahah [15:20:10] so well ssh works :] [15:20:39] I think ssh-add complains when one tries to load a pub key [15:21:04] I'm prepared to retest https://gerrit.wikimedia.org/r/c/mediawiki/tools/scap/+/805462 once the merge completes and you have rebased [15:21:19] and I expect success. [15:22:08] thanks for doing the extra mile of testing with train-dev [15:23:46] I also wonder why the issue does not appear when scap does other ssh commands [15:24:50] or [15:24:59] the git push does not have the ssh auth sock set [15:25:22] ends up running something like 'ssh -i /etc/keyholder.d/trainbranchbot.pub' and fails cause it is not the proper format [15:27:17] dancy: yeah I think my patch is broken [15:27:55] or not oh well I am tired [15:29:55] Your patch works for me (after the the change to access the private key) [15:30:35] (03Merged) 10jenkins-bot: get_keyholder_key: Return private key path instead of public key [tools/scap] - 10https://gerrit.wikimedia.org/r/808087 (owner: 10Ahmon Dancy) [15:31:27] great [15:31:30] hashar: I'll do some verification to see if the agent is really being accessed [15:31:52] there might be some mix up between scap setting SSH_AUTH_SOCK to the keyholder [15:32:07] and the user running the command having os.environ["SSH_AUTH_SOCK"] set [15:33:49] rebasing [15:37:06] ahh scap itself sets SSH_AUTH_SOCK [15:38:20] dancy: I am dding a test [15:38:27] ok [15:38:51] It does look like the agent is not being contacted in my test. [15:44:44] (03PS11) 10Hashar: Support a different user for Gerrit ssh interactions [tools/scap] - 10https://gerrit.wikimedia.org/r/805462 (https://phabricator.wikimedia.org/T306425) [15:44:57] yeah I wasn't sure [15:45:11] my environment might be in a weird state. Still investigating [15:45:17] turns out that when scap config "ssh_auth_sock" is configured, the cli._setup_environ() inject it as SSH_AUTH_SOCK [15:45:27] so by default the commands run with the keyholder configured [15:45:28] nod. [15:45:39] and thus can push back as trainbranchbotuser [15:45:53] that does not explain at all the failure you add to load the pub key [15:46:15] I think that _does_ explain it [15:46:25] well, no.. because it works for sshing as mwdeploy [15:46:44] or maybe it didn't.. cuz we weren't using the agent prior to yesterday [15:46:52] too many changes. :-) [15:46:57] (03CR) 10Hashar: Support a different user for Gerrit ssh interactions (032 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/805462 (https://phabricator.wikimedia.org/T306425) (owner: 10Hashar) [15:47:00] the delta https://gerrit.wikimedia.org/r/c/mediawiki/tools/scap/+/805462/10..11 [15:47:18] I have renamed a variable while at it cause that confused me [15:47:40] (03CR) 10Ahmon Dancy: Support a different user for Gerrit ssh interactions (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/805462 (https://phabricator.wikimedia.org/T306425) (owner: 10Hashar) [15:47:57] that is always the same [15:48:24] we need a linter of some sort to ensure a function renamed get its internal variables aligned with the new semantic [15:48:27] the semantic linter! [15:49:00] Soon the AI's will do this for us [15:51:38] well I guess that is all for today [15:52:03] maybe we can try that patch next week with the next deploy-promote [15:52:06] I hope to +2 your changes shortly. Gotta make sure everything is being tested properly [15:52:14] I hope so! [15:52:22] Thanks for all your help! [15:52:28] then train-dev is all happy about it so that gives a lot of confidence [15:52:33] fun fact [15:52:55] when jnuche and I talked about PS1 I was like "yeah I think we can test it directly to prod, it is simple enough" [15:53:51] I am wrapping up merry week-end [15:54:02] You too. Have a good one! [15:54:08] will do some more java on monday, I really have to complete that other side project [15:55:00] (03PS1) 10Ahmon Dancy: Add docker-compose subcommand to train-dev [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808265 [15:55:22] (03CR) 10Ahmon Dancy: [C: 03+2] Add docker-compose subcommand to train-dev [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808265 (owner: 10Ahmon Dancy) [15:57:58] (03Merged) 10jenkins-bot: Add docker-compose subcommand to train-dev [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808265 (owner: 10Ahmon Dancy) [16:03:25] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [400.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/d/000000322/zuul-gearman?orgId=1&viewPanel=10 [16:15:15] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [200.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/d/000000322/zuul-gearman?orgId=1&viewPanel=10 [16:19:44] (Queue (Jenkins jobs + Zuul functions) alert) firing: Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [16:25:22] (03PS1) 10Ahmon Dancy: Arm ssh-agent with the trainbranchbot key too [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808272 [16:25:54] (03CR) 10Ahmon Dancy: [C: 03+2] Arm ssh-agent with the trainbranchbot key too [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808272 (owner: 10Ahmon Dancy) [16:26:33] (03Merged) 10jenkins-bot: Arm ssh-agent with the trainbranchbot key too [tools/train-dev] - 10https://gerrit.wikimedia.org/r/808272 (owner: 10Ahmon Dancy) [16:29:10] (03CR) 10Ahmon Dancy: [C: 03+2] Support a different user for Gerrit ssh interactions [tools/scap] - 10https://gerrit.wikimedia.org/r/805462 (https://phabricator.wikimedia.org/T306425) (owner: 10Hashar) [16:29:21] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [400.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/d/000000322/zuul-gearman?orgId=1&viewPanel=10 [16:29:44] (Queue (Jenkins jobs + Zuul functions) alert) firing: (2) Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [16:35:54] Do we need both alerts anymore? [16:40:49] (03Merged) 10jenkins-bot: Support a different user for Gerrit ssh interactions [tools/scap] - 10https://gerrit.wikimedia.org/r/805462 (https://phabricator.wikimedia.org/T306425) (owner: 10Hashar) [16:45:42] (03CR) 10Ahmon Dancy: [C: 03+2] history: Mark latest history entry as synced following any sync command [tools/scap] - 10https://gerrit.wikimedia.org/r/805496 (https://phabricator.wikimedia.org/T287045) (owner: 10Dduvall) [16:52:37] (03Merged) 10jenkins-bot: history: Mark latest history entry as synced following any sync command [tools/scap] - 10https://gerrit.wikimedia.org/r/805496 (https://phabricator.wikimedia.org/T287045) (owner: 10Dduvall) [17:47:02] (03PS1) 10Ahmon Dancy: Revert "startup: warn user if not running from a Python virtual environment" [tools/scap] - 10https://gerrit.wikimedia.org/r/808119 [17:47:23] (03CR) 10Ahmon Dancy: [C: 03+2] Revert "startup: warn user if not running from a Python virtual environment" [tools/scap] - 10https://gerrit.wikimedia.org/r/808119 (owner: 10Ahmon Dancy) [17:50:33] (03CR) 10Ahmon Dancy: [C: 03+2] "Beautiful" [tools/scap] - 10https://gerrit.wikimedia.org/r/808086 (https://phabricator.wikimedia.org/T287045) (owner: 10Dduvall) [17:56:48] (03Merged) 10jenkins-bot: Revert "startup: warn user if not running from a Python virtual environment" [tools/scap] - 10https://gerrit.wikimedia.org/r/808119 (owner: 10Ahmon Dancy) [17:59:31] 10Release-Engineering-Team (Deployment Autopilot 🛩ī¸), 10MW-on-K8s, 10Release Pipeline, 10User-brennen: scap backport change_url: Deploy to mwdebug - https://phabricator.wikimedia.org/T308476 (10dancy) 05In progress→03Resolved [17:59:33] 10Release-Engineering-Team (Doing), 10MW-on-K8s, 10Release Pipeline, 10User-brennen: Scap backport change_url command - https://phabricator.wikimedia.org/T287042 (10dancy) [18:06:54] (03Merged) 10jenkins-bot: rollback: Provide rollback subcommand for quick history replay and sync [tools/scap] - 10https://gerrit.wikimedia.org/r/808086 (https://phabricator.wikimedia.org/T287045) (owner: 10Dduvall) [18:39:16] (03PS1) 10Ahmon Dancy: Use docker-registry.wikimedia.org/mediawiki-httpd:0.1.4 for webserver image [tools/release] - 10https://gerrit.wikimedia.org/r/808299 (https://phabricator.wikimedia.org/T309358) [18:41:17] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [200.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/d/000000322/zuul-gearman?orgId=1&viewPanel=10 [18:43:51] (03CR) 10Ahmon Dancy: [C: 03+2] "Tested in train-dev." [tools/release] - 10https://gerrit.wikimedia.org/r/808299 (https://phabricator.wikimedia.org/T309358) (owner: 10Ahmon Dancy) [18:45:25] (03Merged) 10jenkins-bot: Use docker-registry.wikimedia.org/mediawiki-httpd:0.1.4 for webserver image [tools/release] - 10https://gerrit.wikimedia.org/r/808299 (https://phabricator.wikimedia.org/T309358) (owner: 10Ahmon Dancy) [18:49:28] (03PS1) 10Ahmon Dancy: Use docker-registry.wikimedia.org/mediawiki-httpd:0.1.4 for webserver image (v2) [tools/release] - 10https://gerrit.wikimedia.org/r/808302 (https://phabricator.wikimedia.org/T309358) [18:49:44] (Queue (Jenkins jobs + Zuul functions) alert) resolved: Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [18:59:36] (03CR) 10Ahmon Dancy: [C: 03+2] Use docker-registry.wikimedia.org/mediawiki-httpd:0.1.4 for webserver image (v2) [tools/release] - 10https://gerrit.wikimedia.org/r/808302 (https://phabricator.wikimedia.org/T309358) (owner: 10Ahmon Dancy) [19:00:51] (03Merged) 10jenkins-bot: Use docker-registry.wikimedia.org/mediawiki-httpd:0.1.4 for webserver image (v2) [tools/release] - 10https://gerrit.wikimedia.org/r/808302 (https://phabricator.wikimedia.org/T309358) (owner: 10Ahmon Dancy) [19:19:44] 10Scap: Avoid spammy scap warning when running on train-dev - https://phabricator.wikimedia.org/T310858 (10dancy) While something is worked out, I reverted the commit: https://gerrit.wikimedia.org/r/c/mediawiki/tools/scap/+/808119 [20:10:07] (03CR) 10Ahmon Dancy: "Only did static analysis so far." [tools/scap] - 10https://gerrit.wikimedia.org/r/806352 (https://phabricator.wikimedia.org/T287046) (owner: 10Jeena Huneidi) [20:16:22] (03PS24) 10Jeena Huneidi: scap backport: add revert option [tools/scap] - 10https://gerrit.wikimedia.org/r/806352 (https://phabricator.wikimedia.org/T287046) [20:22:00] (03CR) 10Ahmon Dancy: scap backport: add revert option (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/806352 (https://phabricator.wikimedia.org/T287046) (owner: 10Jeena Huneidi) [20:51:22] Hello team, I get the following error when doing 'scap pull' in a WMCS instance: https://phabricator.wikimedia.org/P30243 [20:51:22] The 'rsync' daemon is running on both machines and I can ping the instance that 'scap' is trying to connect to (deployment-deploy03.deployment-prep.eqiad1.wikimedia.cloud). I couldn't find any relevant kernel logs about the 'rsync' daemon. [20:51:22] Do you know what could be causing this issue? [21:12:24] ^ we keep talking in -cloud. The main issue is that the test instance is not in deployment_prep but it tries to use by default the deployment_server in deployment_prep [21:18:13] 10Beta-Cluster-Infrastructure, 10Inuka-Team (Kanban), 10MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), 10Wikistories (MVP): Call to undefined method ForeignDBFile::getExtendedMetadata() - https://phabricator.wikimedia.org/T309668 (10EUdoh-WMF) **Testing** This shows up correctly. {F35272831} [21:20:29] (03PS1) 10Hashar: Makefile: remove 'clear' target which does nothing [tools/scap] - 10https://gerrit.wikimedia.org/r/808319 [21:20:31] (03PS1) 10Hashar: Rewrite "running tests" section in README.md [tools/scap] - 10https://gerrit.wikimedia.org/r/808320 [21:38:40] (03CR) 10Ahmon Dancy: Makefile: remove 'clear' target which does nothing (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/808319 (owner: 10Hashar) [21:55:44] (03CR) 10Ahmon Dancy: "Thanks Antoine!" [tools/scap] - 10https://gerrit.wikimedia.org/r/808320 (owner: 10Hashar) [22:24:18] (03PS1) 10Hashar: Generate pytest test coverage report [tools/scap] - 10https://gerrit.wikimedia.org/r/808328 [22:25:28] (03CR) 10Hashar: [C: 04-1] "When running "make test" that causes a coverage report to be generated for each OS. If I define a new "coverage" target, that means the te" [tools/scap] - 10https://gerrit.wikimedia.org/r/808328 (owner: 10Hashar) [22:26:42] (03PS2) 10Hashar: Makefile: remove 'clean' target which does nothing [tools/scap] - 10https://gerrit.wikimedia.org/r/808319 [22:26:47] (03CR) 10Hashar: Makefile: remove 'clean' target which does nothing (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/808319 (owner: 10Hashar) [22:27:08] dancy: feel free to amend https://gerrit.wikimedia.org/r/c/mediawiki/tools/scap/+/808320/1 :] [22:27:21] else I will follow up on Monday. It is past midnight I should sleep really [22:27:27] happy hackings! [22:28:19] I'm at the end of my day too so we'll resume on Monday. Have a great weekend! [22:28:51] (03CR) 10Ahmon Dancy: [C: 03+2] Makefile: remove 'clean' target which does nothing [tools/scap] - 10https://gerrit.wikimedia.org/r/808319 (owner: 10Hashar) [22:33:34] (03Merged) 10jenkins-bot: Makefile: remove 'clean' target which does nothing [tools/scap] - 10https://gerrit.wikimedia.org/r/808319 (owner: 10Hashar) [22:51:07] (03PS25) 10Jeena Huneidi: scap backport: add revert option [tools/scap] - 10https://gerrit.wikimedia.org/r/806352 (https://phabricator.wikimedia.org/T287046) [22:51:56] (03CR) 10Jeena Huneidi: scap backport: add revert option (039 comments) [tools/scap] - 10https://gerrit.wikimedia.org/r/806352 (https://phabricator.wikimedia.org/T287046) (owner: 10Jeena Huneidi) [22:52:57] (03CR) 10Jeena Huneidi: scap backport: add revert option (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/806352 (https://phabricator.wikimedia.org/T287046) (owner: 10Jeena Huneidi)