[00:48:22] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity: SonarQube is unhelpfully suggesting ES6 features in ES5 code - https://phabricator.wikimedia.org/T289957 (10matmarex) [00:49:23] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity: SonarQube is unhelpfully suggesting ES6 features in ES5 code - https://phabricator.wikimedia.org/T289957 (10matmarex) [00:51:32] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity: SonarQube is unhelpfully suggesting ES6 features in ES5 code - https://phabricator.wikimedia.org/T289957 (10matmarex) I've originally triaged my duplicate as "Unbreak Now", before finding t... [08:24:08] 10Phabricator: Username Change Request - https://phabricator.wikimedia.org/T311575 (10Aklapper) 05Open→03Stalled Hi, please see https://www.mediawiki.org/wiki/Phabricator/Help#Creating_your_account for name restrictions [09:24:19] (03PS1) 10Hashar: dockerfiles: force color output for bazel [integration/config] - 10https://gerrit.wikimedia.org/r/809542 [09:24:35] (03CR) 10Hashar: [C: 03+2] "Already deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/809305 (https://phabricator.wikimedia.org/T304947) (owner: 10Hashar) [09:27:45] (03Merged) 10jenkins-bot: Run bazel test on jsonschemagenerator [integration/config] - 10https://gerrit.wikimedia.org/r/809305 (https://phabricator.wikimedia.org/T304947) (owner: 10Hashar) [09:32:32] (03CR) 10Hashar: [C: 03+2] dockerfiles: force color output for bazel [integration/config] - 10https://gerrit.wikimedia.org/r/809542 (owner: 10Hashar) [09:34:33] (03Merged) 10jenkins-bot: dockerfiles: force color output for bazel [integration/config] - 10https://gerrit.wikimedia.org/r/809542 (owner: 10Hashar) [09:38:36] (03PS1) 10Hashar: jjb: update bazel image to force coloring output [integration/config] - 10https://gerrit.wikimedia.org/r/809545 [10:01:29] 10Phabricator: Herald_rule_for_#serviceops-collab - https://phabricator.wikimedia.org/T311605 (10LSobanski) [10:04:01] 10Phabricator: Herald rule for #serviceops-collab - https://phabricator.wikimedia.org/T311605 (10Peachey88) [10:35:06] 10Continuous-Integration-Config, 10Project-Admins, 10mediawiki-extensions-MultiMail: Publish MultiMail extension - https://phabricator.wikimedia.org/T311542 (10Aklapper) [10:36:15] hashar: the ORES replication dance is a mess, always has been [10:36:39] twentyafterfour, paladox and myself have been trying to fix it ever since :) [10:40:27] (03CR) 10Hashar: [C: 03+2] "Bah:" [integration/config] - 10https://gerrit.wikimedia.org/r/809542 (owner: 10Hashar) [10:42:53] Okay so ORES GitHub and ORES Phab are in sync [10:42:59] Phab is watching correctly [10:43:06] the issue is with Phab-To-Gerrit [10:44:40] 10Beta-Cluster-Infrastructure, 10Infrastructure-Foundations, 10Product-Infrastructure-Team-Backlog, 10VPS-Projects, 10Puppet: Puppet failures on deployment-docker-changeprop01, deployment-docker-cpjobqueue01, deployment-push-notifications01, deployment-docker-mob... - https://phabricator.wikimedia.org/T259812 [10:45:13] (03PS1) 10Hashar: dockerfiles: update Bazel gpg key [integration/config] - 10https://gerrit.wikimedia.org/r/809570 [10:46:46] 10Phabricator, 10Release-Engineering-Team, 10Machine-Learning-Team (Active Tasks): Github's wikimedia/ores not mirroring to Gerrit's scoring/ores/ores - https://phabricator.wikimedia.org/T311390 (10MarcoAurelio) >>! In T311390#8032285, @hashar wrote: > The Phabricator replication from GitHub to Gerrit has be... [10:46:51] 10Beta-Cluster-Infrastructure, 10Product-Infrastructure-Team-Backlog: deployment-maps-master01 puppet failures - https://phabricator.wikimedia.org/T311609 (10taavi) [10:49:59] (03PS2) 10Hashar: jjb: update bazel images to force coloring output [integration/config] - 10https://gerrit.wikimedia.org/r/809545 [10:50:27] 10Project-Admins: Create component for product infrastructure orphaned project tickets - https://phabricator.wikimedia.org/T311246 (10Aklapper) Also, in case this link helps, you may want to triage open team tickets which have no other codebase projects assigned: https://phabricator.wikimedia.org/maniphest/?ids=... [10:52:39] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity: SonarQube is unhelpfully suggesting ES6 features in ES5 code - https://phabricator.wikimedia.org/T289957 (10Daimona) >>! In T289957#8035641, @matmarex wrote: > I've originally triaged my du... [10:53:25] hashar: I need temp. access to a restricted K object on Phab to set the correct URI credentials [10:56:53] hauskatze: hi, what is the context? :) [10:57:00] can I PM hashar ? [10:57:04] yeah [10:57:08] ty [11:02:40] Project beta-code-update-eqiad build #397935: 15ABORTED in 1 min 21 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/397935/ [11:04:59] (03CR) 10Hashar: [C: 03+2] "I have build the images and updated the jobs" [integration/config] - 10https://gerrit.wikimedia.org/r/809545 (owner: 10Hashar) [11:06:58] (03Merged) 10jenkins-bot: jjb: update bazel images to force coloring output [integration/config] - 10https://gerrit.wikimedia.org/r/809545 (owner: 10Hashar) [11:08:44] 10Phabricator, 10Release-Engineering-Team, 10Machine-Learning-Team (Active Tasks): Github's wikimedia/ores not mirroring to Gerrit's scoring/ores/ores - https://phabricator.wikimedia.org/T311390 (10hashar) The `phab` user in Gerrit (id 7252) does not have any ssh key. We have two credentials in Phabricator... [11:08:48] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity: SonarQube is unhelpfully suggesting ES6 features in ES5 code - https://phabricator.wikimedia.org/T289957 (10kostajh) >>! In T289957#8036525, @Daimona wrote: >>>! In T289957#8035641, @matmar... [11:17:02] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity: SonarQube is unhelpfully suggesting ES6 features in ES5 code - https://phabricator.wikimedia.org/T289957 (10kostajh) Also, per {T48148}, I think that [sonarqubebot](https://github.com/wikim... [11:20:28] 10Phabricator, 10Release-Engineering-Team, 10Machine-Learning-Team (Active Tasks): Github's wikimedia/ores not mirroring to Gerrit's scoring/ores/ores - https://phabricator.wikimedia.org/T311390 (10MarcoAurelio) Just so we don't get lost: * The only account able to mirror changes (push) from Phabricator to... [11:26:43] 10Beta-Cluster-Infrastructure, 10Wikidata, 10Wikidata-Termbox, 10wdwb-tech, and 4 others: Move Termbox SSR for Beta Wikidata into deployment-prep project - https://phabricator.wikimedia.org/T304328 (10ItamarWMDE) **Status update** - [x] Update [wmf-config](https://gerrit.wikimedia.org/g/operations/mediawi... [11:27:04] 10Phabricator, 10Release-Engineering-Team, 10Machine-Learning-Team (Active Tasks): Github's wikimedia/ores not mirroring to Gerrit's scoring/ores/ores - https://phabricator.wikimedia.org/T311390 (10hashar) After @MarcoAurelio change to use https and the `phab` user, I have triggered the replication: ` name=/... [11:29:55] 10Phabricator, 10Release-Engineering-Team, 10Machine-Learning-Team (Active Tasks): Github's wikimedia/ores not mirroring to Gerrit's scoring/ores/ores - https://phabricator.wikimedia.org/T311390 (10MarcoAurelio) Fixed with the help of @hashar by doing the following: * Created a new URI to push via HTTPS: ht... [11:33:03] 10Phabricator, 10Release-Engineering-Team, 10Machine-Learning-Team (Active Tasks), 10User-MarcoAurelio: Github's wikimedia/ores not mirroring to Gerrit's scoring/ores/ores - https://phabricator.wikimedia.org/T311390 (10hashar) a:03MarcoAurelio Thank you @MarcoAurelio ! @elukey there are surely other rep... [11:37:04] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity, 10Patch-For-Review: SonarQube is unhelpfully suggesting ES6 features in ES5 code - https://phabricator.wikimedia.org/T289957 (10kostajh) >>! In T289957#8036582, @kostajh wrote: >>>! In T2... [12:23:18] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity, 10Patch-For-Review: SonarQube is unhelpfully suggesting ES6 features in ES5 code - https://phabricator.wikimedia.org/T289957 (10kostajh) OK, it looks like the new rules take effect (https... [12:24:42] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity, 10Patch-For-Review: SonarQube is unhelpfully suggesting ES6 features in ES5 code - https://phabricator.wikimedia.org/T289957 (10kostajh) ` Expected a for-of loop instead of a for loop wit... [13:05:58] 10Phabricator, 10Release-Engineering-Team, 10Machine-Learning-Team (Active Tasks), 10User-MarcoAurelio: Github's wikimedia/ores not mirroring to Gerrit's scoring/ores/ores - https://phabricator.wikimedia.org/T311390 (10elukey) @MarcoAurelio and @hashar thanks you so much! [13:13:15] 10Phabricator, 10Release-Engineering-Team, 10Machine-Learning-Team (Active Tasks), 10User-MarcoAurelio: Github's wikimedia/ores not mirroring to Gerrit's scoring/ores/ores - https://phabricator.wikimedia.org/T311390 (10MarcoAurelio) I've filed a private Task at T311624 with some follow-ups regarding this P... [13:15:09] 10Phabricator, 10Release-Engineering-Team, 10Machine-Learning-Team (Active Tasks), 10User-MarcoAurelio: Github's wikimedia/ores not mirroring to Gerrit's scoring/ores/ores - https://phabricator.wikimedia.org/T311390 (10MarcoAurelio) 05Open→03Resolved [13:39:09] !log clearing stuck beta deployment jobs, watching to ensure they catch up :'_ [13:39:10] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:39:16] damn. meant `:')` [13:41:31] nobody reads the logs TheresNoTime , don't worry :P [13:43:44] just edit the wiki page ;) [13:48:50] 10Beta-Cluster-Infrastructure, 10Wikidata, 10Wikidata-Termbox, 10wdwb-tech, and 4 others: Move Termbox SSR for Beta Wikidata into deployment-prep project - https://phabricator.wikimedia.org/T304328 (10ItamarWMDE) 05Open→03Resolved [14:33:34] 10Phabricator: Username Change Request - https://phabricator.wikimedia.org/T311575 (10Chansey) @Aklapper how about Vincent_Vega? It is OK for me. [14:48:46] !log Clearing data from incomplete migration on Wikifunctionswiki via sql.php [14:48:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:55:24] hashar: I just noticed that an mwext-doxygen-plubish job ran for a WikibaseLexeme REL1_35 backport [15:55:39] the job failed because we only added doxygen config to WikibaseLexeme relatively recently [15:55:52] is that worth fixing in the CI config? or is it okay to ignore the post-merge build failure? :) [15:56:05] (I’m assuming there won’t be too many further WikibaseLexeme REL1_35 backports either way…) [15:56:23] mainly pinging you in case that makes some dashboard of yours glow red or whatever :P [15:56:49] Lucas_WMDE: ah cause we publish doc for each of the release branches [15:58:32] so yeah ignore it I guess [15:58:38] alright [15:58:41] but we can probably skip that job for this repo and the old REL branches [15:58:51] pretty sure Zuul has support to add such a skip filter on a per job basis [16:20:29] (03CR) 10Dduvall: [C: 03+2] Revert "Revert "feature: build-time arguments for lives & runs user config"" [blubber] - 10https://gerrit.wikimedia.org/r/789950 (https://phabricator.wikimedia.org/T296046) (owner: 10BryanDavis) [16:27:01] (03Merged) 10jenkins-bot: Revert "Revert "feature: build-time arguments for lives & runs user config"" [blubber] - 10https://gerrit.wikimedia.org/r/789950 (https://phabricator.wikimedia.org/T296046) (owner: 10BryanDavis) [16:30:25] bd808: hopping in our team meeting but i will deploy ^ as soon as we're done [16:34:04] 10Phabricator: Username Change Request - https://phabricator.wikimedia.org/T311575 (10Aklapper) 05Stalled→03Resolved a:03Aklapper Yes! :) Done. [16:49:34] (03PS5) 10Dduvall: Archive directories as tar.gz when `copy.archive` is true [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/792695 (https://phabricator.wikimedia.org/T308591) [16:49:58] (03CR) 10Dduvall: Archive directories as tar.gz when `copy.archive` is true (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/792695 (https://phabricator.wikimedia.org/T308591) (owner: 10Dduvall) [16:57:34] thcipriani: hello, got a minute? [16:59:43] hauskatze: sure, depending on the length of a minute :) What's up? [17:00:39] thcipriani: I think the credentials at K19 are no longer working and we have some stale repos as a result [17:01:00] * thcipriani checks logs [17:01:37] hashar and I managed to refresh one of these by https://phabricator.wikimedia.org/T311390#8036664 [17:01:37] hauskatze: what's an example repo? [17:02:05] which is switching to use HTTP push instead of SSH but I'd say you all prefer SSH right? [17:02:08] let me check [17:02:49] thcipriani: example repo: https://phabricator.wikimedia.org/T311624#8037115 [17:13:51] K19 isn't listed as "active" at https://phabricator.wikimedia.org/passphrase/query/active/. I feel like ssh stopped working for the toolforge-push account quite a while ago (like years). [17:14:34] I guess I should check out the actual repo rather than grepping gerrit logs [17:15:20] but my memory was there was something about timeouts with the size of these repos [17:16:20] bd808: thanks. I can't see K19 (as opposed to K18) :) [17:16:30] thcipriani: for some reason, HTTP push did work [17:16:55] I can't see K19 either. somebody has it really locked down [17:17:36] Yup [17:18:03] fwiw, I can see this repo has a push url to gerrit using k19. So phab should be trying at least. [17:18:56] thcipriani: hashar mentioned that LDAP phab user has no SSH keys attached right now [17:19:14] so obviously it won't work :) [17:19:45] can you make K19 viewable at least by acl*repository-administrators (the object, not the actual settings; same as K18) -- if you can :) [17:20:54] My feeling is that `phab` needs a new keypair, and the private key and passphrase updated at K19 [17:22:11] I have a very vague memory of working on this exact things with twentyafterfour ... a while ago. I wonder if I have the credentials for the phab user stashed in our secrets. /me digs [17:29:17] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (GitLab-a-thon 🦊), 10Patch-For-Review, 10User-brennen: Deploy buildkitd to trusted GitLab runners - https://phabricator.wikimedia.org/T308271 (10dduvall) [17:29:26] 10GitLab (CI & Job Runners), 10serviceops-collab: DNS/networking not working on Trusted Runners - https://phabricator.wikimedia.org/T311241 (10dduvall) 05Resolved→03Open I ran into this issue again today while attempting to build an image via buildkitd. See https://gitlab.wikimedia.org/repos/releng/gitlab... [17:45:24] 10Release-Engineering-Team (Deployment Autopilot 🛩️), 10MW-on-K8s, 10Release Pipeline, 10User-brennen: scap backport --revert command - https://phabricator.wikimedia.org/T287046 (10dancy) 05Open→03Resolved [17:45:28] 10Release-Engineering-Team (Doing), 10MW-on-K8s, 10Release Pipeline, 10Patch-For-Review, 10User-brennen: Design m8s deployment workflows and tooling - https://phabricator.wikimedia.org/T279322 (10dancy) [17:56:50] 10GitLab, 10Release-Engineering-Team: A new maintainer needs access to the generated-data-platform group - https://phabricator.wikimedia.org/T311657 (10gmodena) [18:07:22] (03Abandoned) 10Ahmon Dancy: Set author on commits created by deploy-promote and apply-patches [tools/scap] - 10https://gerrit.wikimedia.org/r/809222 (owner: 10Ahmon Dancy) [18:07:35] (03CR) 10Ahmon Dancy: [C: 03+2] Clean up ProcessPoolExecutor after using it [tools/scap] - 10https://gerrit.wikimedia.org/r/809202 (owner: 10Ahmon Dancy) [18:11:54] (03Merged) 10jenkins-bot: Clean up ProcessPoolExecutor after using it [tools/scap] - 10https://gerrit.wikimedia.org/r/809202 (owner: 10Ahmon Dancy) [18:13:50] 10Release-Engineering-Team (Radar), 10Security-Team, 10Security: Security Issue Access Request for Demon - https://phabricator.wikimedia.org/T311660 (10thcipriani) [18:19:49] 10Release-Engineering-Team (Radar), 10LDAP-Access-Requests, 10SRE: Grant Access to wmf for demon - https://phabricator.wikimedia.org/T311661 (10thcipriani) [18:47:30] 10Release-Engineering-Team (Radar), 10Security-Team, 10SecTeam-Processed, 10Security: Security Issue Access Request for Demon - https://phabricator.wikimedia.org/T311660 (10sbassett) 05Open→03Resolved a:03sbassett Hey @thcipriani - Just added them to [[ https://phabricator.wikimedia.org/project/memb... [18:52:47] whee, ^demon is back :) [18:58:37] 10GitLab, 10Release-Engineering-Team: A new maintainer needs access to the generated-data-platform group - https://phabricator.wikimedia.org/T311657 (10XCollazo-WMF) 05Open→03Resolved a:03XCollazo-WMF Thanks for creating this @gmodena. @Eevans took care of it. Closing. [20:17:23] 10Release-Engineering-Team (Radar), 10LDAP-Access-Requests, 10SRE: Grant Access to wmf for demon - https://phabricator.wikimedia.org/T311661 (10Dzahn) 05Open→03Resolved a:03Dzahn done. Chad is already in shell access group so there is no puppet code change needed for this. added to wmf [20:20:19] 10GitLab (CI & Job Runners), 10serviceops-collab, 10Patch-For-Review: DNS/networking not working on Trusted Runners - https://phabricator.wikimedia.org/T311241 (10Dzahn) deployed the latest change, restarted docker on gitlab-runner2004, restarted the job and got a "Job succeeded". (just that it also succeed... [20:20:52] 10Phabricator (Upstream), 10Release-Engineering-Team, 10Upstream, 10User-brennen: Uploaded files via the drag-and-drop are defaulting to private-access - https://phabricator.wikimedia.org/T310833 (10matmarex) I documented it: https://www.mediawiki.org/w/index.php?title=Phabricator/Help&diff=5314372&oldid=5... [20:27:21] 10Phabricator (Upstream), 10Release-Engineering-Team, 10Upstream, 10User-brennen: Uploaded files via the drag-and-drop are defaulting to private-access - https://phabricator.wikimedia.org/T310833 (10MBinder_WMF) Thanks, @matmarex . If I'm understanding correctly, restoring the original functionality is no... [20:44:41] 10Phabricator (Upstream), 10Release-Engineering-Team, 10Upstream, 10User-brennen: Uploaded files via the drag-and-drop are defaulting to private-access - https://phabricator.wikimedia.org/T310833 (10matmarex) The original functionality has been mostly restored now, as long as you don't do something //craaa... [20:49:11] 10Phabricator (Upstream), 10Release-Engineering-Team, 10Upstream, 10User-brennen: Uploaded files via the drag-and-drop are defaulting to private-access - https://phabricator.wikimedia.org/T310833 (10MBinder_WMF) Ah, OK, great, thanks for the clarification. I'll keep an eye out. > copy-pasting plain te... [20:56:43] 10GitLab, 10Release-Engineering-Team: Add XCollazo-WMF maintainer to generated-data-platform GitLab group - https://phabricator.wikimedia.org/T311657 (10Aklapper) [21:04:30] 10Phabricator (Upstream), 10Release-Engineering-Team, 10Upstream, 10User-brennen: Uploaded files via the drag-and-drop are defaulting to private-access - https://phabricator.wikimedia.org/T310833 (10matmarex) Yes (although I should have said "//cut// and pasting", because this only occurs if you remove it... [21:07:03] (03CR) 10Jeena Huneidi: [C: 03+2] Archive directories as tar.gz when `copy.archive` is true [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/792695 (https://phabricator.wikimedia.org/T308591) (owner: 10Dduvall) [21:08:50] 10Continuous-Integration-Config, 10Quality-and-Test-Engineering-Team (QTE), 10Sonarqubebot, 10Developer Productivity: SonarQube is unhelpfully suggesting ES6 features in ES5 code - https://phabricator.wikimedia.org/T289957 (10matmarex) Thanks @kostajh! I think this can be resolved, then? [21:08:56] (03Merged) 10jenkins-bot: Archive directories as tar.gz when `copy.archive` is true [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/792695 (https://phabricator.wikimedia.org/T308591) (owner: 10Dduvall) [21:09:14] (03PS1) 10BryanDavis: calendar: add Thursday 10:00 SF slot for Technical Engagement [tools/release] - 10https://gerrit.wikimedia.org/r/809684 [21:53:05] (03PS1) 10Ahmon Dancy: scap prep: Ensure umask is 002 before running [tools/scap] - 10https://gerrit.wikimedia.org/r/809708 [22:45:34] (03PS2) 10Thcipriani: calendar: add Thursday 10:00 SF slot for Technical Engagement [tools/release] - 10https://gerrit.wikimedia.org/r/809684 (owner: 10BryanDavis) [22:46:19] (03PS1) 10Ahmon Dancy: scap stage-train: Set umask to 002 [tools/scap] - 10https://gerrit.wikimedia.org/r/809713 [22:49:42] (03PS3) 10Thcipriani: calendar: add Thursday 10:00 SF slot for Technical Engagement [tools/release] - 10https://gerrit.wikimedia.org/r/809684 (owner: 10BryanDavis) [22:50:02] 10GitLab (CI & Job Runners), 10Security Team AppSec, 10Security-Team, 10SecTeam-Processed, and 2 others: Re-implement semgrep ci includes - https://phabricator.wikimedia.org/T307962 (10sbassett) **fake-gitlab-bot:** - Initial commit for repo, mostly app structure - https://gitlab.wikimedia.org/repos/securi... [22:50:26] (03CR) 10Thcipriani: [C: 03+2] calendar: add Thursday 10:00 SF slot for Technical Engagement [tools/release] - 10https://gerrit.wikimedia.org/r/809684 (owner: 10BryanDavis) [22:51:11] (03Merged) 10jenkins-bot: calendar: add Thursday 10:00 SF slot for Technical Engagement [tools/release] - 10https://gerrit.wikimedia.org/r/809684 (owner: 10BryanDavis) [22:52:13] thanks thcipriani :) [22:56:11] slow +2s on small patches are a speciality of mine :) [22:57:58] yet another moment where I second-guess my attempt to get away from a pure wikitext template that makes people put wikitext in yaml. But here we are. [23:04:41] thcipriani: my eye twitched a lot when I saw that your config file is using YAML flow style (json compat format) too. ;) [23:06:32] yaml: for when you meant json [23:12:47] it was json! [23:13:23] the trick was: that meant it was also yaml :D [23:13:35] and that's how they get you. [23:14:32] I only found out a little while ago that there's a json standard which allows comments? 🤷 science has gone too far [23:19:22] TIL [23:22:37] TheresNoTime: you mean the mess that Facebook coded into Hack or something else? [23:23:15] bd808: `jsonc`? though looking again it might just be a vs code thing :s [23:24:58] "JSONC is a superset of JSON which supports comments" but the more I look, the more it looks like less a standard and more a "yeah why not." https://github.com/muhammadmuzzammil1998/jsonc [23:25:11] I think there are several implementations. Facebook had a very fun multi-hour site outage caused by engineers being used to that in hack but making config that was processed by a normal json parser :) [23:25:59] oh that's beautiful :') [23:28:29] yeah, jsonc is one of those bad ideas that sounds good until you start thinking about how many json parsers your files might interact with [23:29:00] it's really a better idea to use @keys or just use yaml if you have to