[02:49:03] 10Release-Engineering-Team (Radar), 10Scap, 10MediaWiki-Internationalization, 10Performance-Team: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Krinkle) [05:54:13] 10Release-Engineering-Team (Priority Backlog 📥), 10Release, 10Train Deployments: 1.39.0-wmf.23 deployment blockers - https://phabricator.wikimedia.org/T308076 (10ssastry) I merged a change that reverts this change. So, this should not be an issue anymore. [08:52:04] 10Release-Engineering-Team (Priority Backlog 📥), 10Release, 10Train Deployments: 1.39.0-wmf.23 deployment blockers - https://phabricator.wikimedia.org/T308076 (10daniel) >>! In T308076#8117681, @ssastry wrote: > I merged a change that reverts this change. So, this should not be an issue anymore. To clarify:... [22:38:25] It seems phpcs.xml exclude isn't working in wmf-config for some reason. I've noticed this a few times now in recent weeks. eg. https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/818623/ / https://integration.wikimedia.org/ci/job/operations-mw-config-php72-composer-test-docker/19600/console [22:38:33] FILE: tests/InitialiseSettingsTest.php [22:38:33] ---------------------------------------------------------------------- [22:38:33] FOUND 2 ERRORS AFFECTING 2 LINES [22:38:33] ---------------------------------------------------------------------- [22:38:33] 13 | ERROR | Missing class property doc comment [22:38:34] | | (MediaWiki.Commenting.PropertyDocumentation.MissingDocumentationPrivate) [22:38:42] despite [22:38:42] */tests/* [22:38:45] it passes fine locally [22:38:58] and similar exclude rules exist in mw core that works fine as well [22:44:38] I've jiggled some stuff around which seems to make it pass.. https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/818625/1