[00:41:46] 10Phabricator, 10Release-Engineering-Team (Bonus Level ๐Ÿ•น๏ธ), 10serviceops, 10serviceops-collab, 10Patch-For-Review: Deprecate git-ssh service on phabricator.wikimedia.org - https://phabricator.wikimedia.org/T296022 (10Hawkeye7) Something has gone wrong. My attempt to do a git push results in fatal: unable... [01:19:59] 10Phabricator, 10Release-Engineering-Team (Bonus Level ๐Ÿ•น๏ธ), 10serviceops, 10serviceops-collab, 10Patch-For-Review: Deprecate git-ssh service on phabricator.wikimedia.org - https://phabricator.wikimedia.org/T296022 (10JJMC89) >>! In T296022#8296545, @Hawkeye7 wrote: > Something has gone wrong. My attempt... [01:26:42] 10Project-Admins: Create project tag for fast-ec - https://phabricator.wikimedia.org/T320218 (10Enterprisey) [01:27:28] 10Phabricator, 10Release-Engineering-Team (Bonus Level ๐Ÿ•น๏ธ), 10serviceops, 10serviceops-collab, 10Patch-For-Review: Deprecate git-ssh service on phabricator.wikimedia.org - https://phabricator.wikimedia.org/T296022 (10Dzahn) Yep, what you can expect to happen soon _for this task_ would be for git-ssh.wiki... [01:29:20] 10Project-Admins: Create project tag for fast-ec - https://phabricator.wikimedia.org/T320218 (10Legoktm) 05Openโ†’03Resolved a:03Legoktm #fast-ec (you probably want to watch it) [01:39:57] 10GitLab (Project Migration), 10Release-Engineering-Team, 10serviceops, 10serviceops-collab: Create new GitLab project group: wm-juniors-il - https://phabricator.wikimedia.org/T313750 (10Dzahn) a:05Dzahnโ†’03Matanya [03:26:40] 10Continuous-Integration-Config, 10LibUp, 10phan, 10Composer: Run phan as part of composer test, rather than in bespoke CI jobs - https://phabricator.wikimedia.org/T280990 (10Legoktm) [04:16:45] James_F, Krinkle: I'm confused, are we supposed to be on npm7 or 8? libup is using 8 because that's what's in the node16 package, but fresh is still using 7 [04:22:53] it's amazing, npm8 dropped `--only=dev` [06:33:38] 10Phabricator, 10Release-Engineering-Team (Bonus Level ๐Ÿ•น๏ธ), 10serviceops, 10serviceops-collab, 10Patch-For-Review: Deprecate git-ssh service on phabricator.wikimedia.org - https://phabricator.wikimedia.org/T296022 (10Hawkeye7) Yes, it has moved to Gitlab so now I cannot upload to it. :( [07:01:55] 10Project-Admins: Create project tag for fast-ec - https://phabricator.wikimedia.org/T320218 (10Aklapper) For the records, in Phab I made this a subproject of #Tools [07:40:45] 10Phabricator, 10Release-Engineering-Team (Bonus Level ๐Ÿ•น๏ธ), 10serviceops, 10serviceops-collab, 10Patch-For-Review: Deprecate git-ssh service on phabricator.wikimedia.org - https://phabricator.wikimedia.org/T296022 (10Aklapper) @Hawkeye7: Again, **this is unrelated**. It's off-topic for this task. See T32... [07:43:13] 10GitLab (Auth & Access), 10Striker: Unable to use git push - 403 error - https://phabricator.wikimedia.org/T320216 (10taavi) I don't see yourself as a maintainer of https://toolsadmin.wikimedia.org/tools/id/milhistbot, which explains why you weren't granted access when the GitLab repository was originally cre... [09:09:41] (Queue (Jenkins jobs + Zuul functions) alert) firing: Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [09:14:41] (Queue (Jenkins jobs + Zuul functions) alert) firing: (2) Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [09:34:41] (Queue (Jenkins jobs + Zuul functions) alert) resolved: Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [09:35:09] (03CR) 10Jaime Nuche: perform-release: Fix old version handling (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/838941 (owner: 10Ahmon Dancy) [09:37:07] 10GitLab (Auth & Access), 10Striker: Unable to use git push - 403 error - https://phabricator.wikimedia.org/T320216 (10Hawkeye7) I am there as Ross Mallett, but that is not my gitlab account, Hawkeye7 is. [09:42:51] 10GitLab (Auth & Access), 10Striker: Unable to use git push - 403 error - https://phabricator.wikimedia.org/T320216 (10Hawkeye7) I can apparently log in as Ross Mallett. No idea why that account was used. [09:50:43] 10GitLab (Auth & Access), 10Striker: Unable to use git push - 403 error - https://phabricator.wikimedia.org/T320216 (10Hawkeye7) It clearly shows Ross Mallett and Hawkey7 are the same acco8unt [10:20:14] 10Phabricator, 10Release-Engineering-Team (Bonus Level ๐Ÿ•น๏ธ), 10serviceops, 10serviceops-collab, 10Patch-For-Review: Deprecate git-ssh service on phabricator.wikimedia.org - https://phabricator.wikimedia.org/T296022 (10Hawkeye7) Does the move to gitlab mean that we can use ssh again instead of https? [10:23:45] 10GitLab (Auth & Access), 10Striker: Unable to use git push - 403 error - https://phabricator.wikimedia.org/T320216 (10Hawkeye7) I guess this means that this can be closed, as I have a workaround of using the Ross Mallett account. [10:25:45] 10Phabricator: Request to change username - https://phabricator.wikimedia.org/T320237 (10AAssaf-WMF) [11:23:38] 10Phabricator, 10Release-Engineering-Team (Bonus Level ๐Ÿ•น๏ธ), 10serviceops, 10serviceops-collab, 10Patch-For-Review: Deprecate git-ssh service on phabricator.wikimedia.org - https://phabricator.wikimedia.org/T296022 (10Aklapper) See https://www.mediawiki.org/wiki/GitLab/Workflows [11:29:41] 10Phabricator: Rename Phabricator account "AAssaf-WMF" to "AAssaf" - https://phabricator.wikimedia.org/T320237 (10Aklapper) [11:30:29] 10Phabricator: Rename Phabricator account "AAssaf-WMF" to "AAssaf" - https://phabricator.wikimedia.org/T320237 (10Aklapper) 05Openโ†’03Resolved a:03Aklapper Sure, I've renamed the account! (@dr0ptp4kt: Mixing volunteer and WMF accounts is problematic and decreases transparency. Assuming this was a WMF-role... [12:16:01] (03CR) 10Hashar: Json schema from Gerrit Java event classes (032 comments) [software/gerrit/plugins/events-wikimedia] - 10https://gerrit.wikimedia.org/r/830654 (https://phabricator.wikimedia.org/T304947) (owner: 10Hashar) [12:37:25] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10MediaWiki-Core-Tests: Consider enforcing usage of MediaWiki(Unit|Integration)TestCase in MW PHPUnit Test - https://phabricator.wikimedia.org/T319536 (10kostajh) Thanks for making this task! Let's check with Wikibase engineers (adding a few as subscr... [12:54:12] legoktm: We're still using npm 7 with node 16 (I can't remember off-hand, but something was wonky upstream when I made the images). https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/refs/heads/master/dockerfiles/node16/Dockerfile.template#21 Also CI is running node14 not node16 jobs generally. [13:02:12] (03PS2) 10Hashar: Json schema from Gerrit Java event classes [software/gerrit/plugins/events-wikimedia] - 10https://gerrit.wikimedia.org/r/830654 (https://phabricator.wikimedia.org/T304947) [13:02:40] (03CR) 10CI reject: [V: 04-1] Json schema from Gerrit Java event classes [software/gerrit/plugins/events-wikimedia] - 10https://gerrit.wikimedia.org/r/830654 (https://phabricator.wikimedia.org/T304947) (owner: 10Hashar) [13:04:13] (03CR) 10Hashar: "recheck" [software/gerrit/plugins/events-wikimedia] - 10https://gerrit.wikimedia.org/r/830654 (https://phabricator.wikimedia.org/T304947) (owner: 10Hashar) [13:06:58] 10MediaWiki-Releasing, 10serviceops, 10MW-1.40-notes (1.40.0-wmf.4; 2022-10-03): Drop PHP 7.2 & 7.3 support from MediaWiki master branch, once Wikimedia production is on 7.4 - https://phabricator.wikimedia.org/T261872 (10Jdforrester-WMF) [13:07:12] (03CR) 10Hashar: Json schema from Gerrit Java event classes (031 comment) [software/gerrit/plugins/events-wikimedia] - 10https://gerrit.wikimedia.org/r/830654 (https://phabricator.wikimedia.org/T304947) (owner: 10Hashar) [13:07:26] (03PS3) 10Hashar: Json schema from Gerrit Java event classes [software/gerrit/plugins/events-wikimedia] - 10https://gerrit.wikimedia.org/r/830654 (https://phabricator.wikimedia.org/T304947) [13:16:18] (03PS6) 10Hashar: Implement REST API and Ssh commands [software/gerrit/plugins/events-wikimedia] - 10https://gerrit.wikimedia.org/r/814725 (https://phabricator.wikimedia.org/T304947) [13:16:59] (03CR) 10CI reject: [V: 04-1] Implement REST API and Ssh commands [software/gerrit/plugins/events-wikimedia] - 10https://gerrit.wikimedia.org/r/814725 (https://phabricator.wikimedia.org/T304947) (owner: 10Hashar) [13:21:12] (03PS1) 10Jforrester: Zuul: Add two former contractors to the CI allowlist [integration/config] - 10https://gerrit.wikimedia.org/r/840126 [13:24:55] (03CR) 10Jforrester: [C: 03+2] Zuul: Add two former contractors to the CI allowlist [integration/config] - 10https://gerrit.wikimedia.org/r/840126 (owner: 10Jforrester) [13:25:22] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10MediaWiki-Core-Tests: Consider enforcing usage of MediaWiki(Unit|Integration)TestCase in MW PHPUnit Test - https://phabricator.wikimedia.org/T319536 (10Daimona) As another exampe: we're currently in the process of upgrading to PHPUnit 9. This versio... [13:27:30] (03Merged) 10jenkins-bot: Zuul: Add two former contractors to the CI allowlist [integration/config] - 10https://gerrit.wikimedia.org/r/840126 (owner: 10Jforrester) [13:27:37] !log Zuul: Add two former contractors to the CI allowlist [13:27:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:33:42] 10Continuous-Integration-Config, 10ci-test-error: Bazel build fails to log dir due to directory missing write permission - https://phabricator.wikimedia.org/T320251 (10hashar) [13:35:45] 10Continuous-Integration-Config, 10ci-test-error: Bazel build fails to log dir due to directory missing write permission - https://phabricator.wikimedia.org/T320251 (10hashar) [13:43:13] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10MediaWiki-Core-Tests: Consider enforcing usage of MediaWiki(Unit|Integration)TestCase in MW PHPUnit Test - https://phabricator.wikimedia.org/T319536 (10Lucas_Werkmeister_WMDE) > Presently, there are many test classes extending PHPUnit\Framework\Test... [13:47:40] (03CR) 10Hashar: "recheck" [software/gerrit/plugins/events-wikimedia] - 10https://gerrit.wikimedia.org/r/814725 (https://phabricator.wikimedia.org/T304947) (owner: 10Hashar) [13:51:08] 10Phabricator: Rename Phabricator account "AAssaf-WMF" to "AAssaf" - https://phabricator.wikimedia.org/T320237 (10AAssaf-WMF) Thank you! [13:54:44] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10MediaWiki-Core-Tests: Consider enforcing usage of MediaWiki(Unit|Integration)TestCase in MW PHPUnit Test - https://phabricator.wikimedia.org/T319536 (10Daimona) >>! In T319536#8300250, @Lucas_Werkmeister_WMDE wrote: >> Presently, there are many test... [14:23:04] (03PS1) 10Hashar: jjb: ensure /log files are writable for deletion [integration/config] - 10https://gerrit.wikimedia.org/r/840136 (https://phabricator.wikimedia.org/T320251) [14:24:19] (03CR) 10Hashar: [C: 04-1] "I am hitting that constantly on operations/software/gerrit/plugins/events-wikimedia . I have already deployed the job, will merge this cha" [integration/config] - 10https://gerrit.wikimedia.org/r/840136 (https://phabricator.wikimedia.org/T320251) (owner: 10Hashar) [14:50:20] (03CR) 10Ahmon Dancy: perform-release: Fix old version handling (031 comment) [tools/scap] - 10https://gerrit.wikimedia.org/r/838941 (owner: 10Ahmon Dancy) [14:53:25] 10Continuous-Integration-Config, 10Patch-For-Review, 10ci-test-error: Bazel build fails to log dir due to directory missing write permission - https://phabricator.wikimedia.org/T320251 (10hashar) a:03hashar [15:44:45] (03CR) 10Ahmon Dancy: [C: 03+1] "Looks good to me. I do not have an M1 mac to test with." [blubber] - 10https://gerrit.wikimedia.org/r/836307 (https://phabricator.wikimedia.org/T318866) (owner: 10Dduvall) [15:46:38] (03CR) 10Ahmon Dancy: [C: 03+1] "Can't test myself." [blubber] - 10https://gerrit.wikimedia.org/r/836264 (https://phabricator.wikimedia.org/T318866) (owner: 10Dduvall) [15:56:13] (03CR) 10Dduvall: buildkit: Support target platform in Makefile (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/836264 (https://phabricator.wikimedia.org/T318866) (owner: 10Dduvall) [16:09:37] (03CR) 10Dduvall: buildkit: Support target platform in Makefile (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/836264 (https://phabricator.wikimedia.org/T318866) (owner: 10Dduvall) [16:33:26] James_F: hmmm. should I downgrade LibUp then to node14/npm7? Or should we move CI to node16/npm8? [16:38:02] 10Gerrit, 10Projects-Cleanup: Drop Gerrit repositories related to Wikimedia CH (they migrated to GitLab) - https://phabricator.wikimedia.org/T319534 (10hashar) [16:38:18] 10Phabricator: Rename Phabricator account "AAssaf-WMF" to "AAssaf" - https://phabricator.wikimedia.org/T320237 (10dr0ptp4kt) Thank you @Aklapper ! [16:46:43] 10GitLab (Auth & Access), 10Striker: Unable to use git push - 403 error - https://phabricator.wikimedia.org/T320216 (10bd808) >>! In T320216#8299723, @Hawkeye7 wrote: > I can apparently log in as Ross Mallett. No idea why that account was used. Per https://toolsadmin.wikimedia.org/tools/id/milhistbot, the [[... [16:47:24] 10Gerrit, 10GitLab (Project Migration), 10Projects-Cleanup: Drop Gerrit repositories related to Wikimedia CH (they migrated to GitLab) - https://phabricator.wikimedia.org/T319534 (10hashar) Lack of the ability to create a project is definitely a shortfall in Gerrit, then as you said it is more for the Enterp... [17:16:46] 10Release-Engineering-Team (Priority Backlog ๐Ÿ“ฅ), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T314193 (10brennen) [17:43:08] 10Release-Engineering-Team (Priority Backlog ๐Ÿ“ฅ), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T314193 (10brennen) [18:01:09] 10Phabricator, 10Release-Engineering-Team (Bonus Level ๐Ÿ•น๏ธ), 10serviceops, 10serviceops-collab, 10Patch-For-Review: Deprecate git-ssh service on phabricator.wikimedia.org - https://phabricator.wikimedia.org/T296022 (10Dzahn) You can use either ssh or https with either Gerrit or Gitlab. What's going away... [18:07:01] Sooooo the PHPUnit upgrade is gonna have a little delay because my cat jumped on the keyboard and ran git clean in the MW directory. Naughty pet! [18:08:17] o_00 [18:29:53] http://www.bitboost.com/pawsense/index.html [18:30:55] http://www.webuyanycat.com/ [18:33:08] Meow! [18:33:28] :) [18:39:43] Daimona: That's impressive. [18:40:11] I'm guessing up a few times and enter... :P [18:40:50] Yeah, I trained my kitty to behave like a programmer [18:41:16] TBF I have a local `nuke` alias which is a very aggressive set of git commands including clean, and use it all the timeโ€ฆ [18:42:27] Nope, it's just that I'm used to a different setup where I have two copies of core, one in version control and one for the local wiki. I can safely git clean there. [18:42:37] s/I'm/my cat is/ [18:46:51] hmm. somehow converting a silent failure (which then causes an error when null is used on something that doesn't take null as a parameter) to raise an error makes the test errors on T320221 go away.. I really don't understand why that works at all [18:46:51] T320221: OpenStackManager test failures on PHP 8.0 via LdapAuthentication - https://phabricator.wikimedia.org/T320221 [18:50:57] taavi: It failed only on PHP 8.0 due to new language rules. [18:51:27] taavi: I imagine it'll still fail on the new run, but let's see. [18:51:47] James_F: yes, but if the code path used by the test is now always raising an exception, shouldn't it start failing always? [18:53:38] taavi: The failure before was a php lint error (`TypeError: ldap_bind(): Argument #1 ($ldap) must be of type resource, null given`) in the static ldap_bind() method, which is before the new failures in the connect() method, I think. [18:54:22] Hmm, but indeed it passed now. [18:54:36] * James_F shrugs. [18:54:42] Maybe OSM has a try/catch for this? [18:55:10] Given it's all semi-abandonware I'm happy to pretend I didn't see this if you are. :-) [18:55:12] the error comes from LdapAuthenticationPlugin::bindAs(), which is called right after LdapAuthenticationPlugin::connect() in OpenStackNovaUser::connectToLdap() [18:55:41] Most odd. [18:55:42] as long as my change doesn't cause a train blocker task next week, I think that's the best option we have [18:55:45] :/ [18:55:51] Aye. [21:15:10] 10Release-Engineering-Team (Priority Backlog ๐Ÿ“ฅ), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T314193 (10brennen) 05Openโ†’03Resolved [21:55:37] Daimona: https://www.etsy.com/listing/1017671943/cat-keyboard-cover-keep-typing-while [21:56:33] I explained why the LdapAuth/OSM test failured fixed itself on the task [21:56:36] Lol [22:02:47] 10MediaWiki-Releasing, 10MW-1.39-notes, 10MW-1.39-release: Write release announcement for 1.39.0-rc.1 - https://phabricator.wikimedia.org/T313929 (10Reedy) [22:14:24] 10MediaWiki-Releasing, 10MW-1.39-notes, 10MW-1.39-release: Write release announcement for 1.39.0-rc.1 - https://phabricator.wikimedia.org/T313929 (10Reedy) 05Openโ†’03Resolved a:03Reedy [22:14:28] 10MediaWiki-Releasing, 10MW-1.39-notes, 10MW-1.39-release: Release 1.39.0-rc.1 - https://phabricator.wikimedia.org/T313927 (10Reedy) [22:14:34] 10MediaWiki-Releasing, 10MW-1.39-notes, 10MW-1.39-release: Release MW 1.39.0 - https://phabricator.wikimedia.org/T313916 (10Reedy) [22:14:42] 10MediaWiki-Releasing, 10MW-1.39-notes, 10MW-1.39-release: Release 1.39.0-rc.1 - https://phabricator.wikimedia.org/T313927 (10Reedy) 05Openโ†’03Resolved a:03Reedy