[00:01:37] 10GitLab (Integrations), 10Phabricator, 10Release-Engineering-Team (GitLab III: GitLab in LA πŸͺƒ), 10User-brennen: Sandbox task for gitlab-phabricator comment integration - https://phabricator.wikimedia.org/T324164 (10brennen) brennen closed https://gitlab.wikimedia.org/brennen/test/-/merge_requests/4 [00:01:45] 10GitLab (Integrations), 10Phabricator, 10Release-Engineering-Team (GitLab III: GitLab in LA πŸͺƒ), 10User-brennen: Sandbox task for gitlab-phabricator comment integration - https://phabricator.wikimedia.org/T324164 (10brennen) brennen reopened https://gitlab.wikimedia.org/brennen/test/-/merge_requests/4 [00:02:05] 10GitLab (Integrations), 10Phabricator, 10Release-Engineering-Team (GitLab III: GitLab in LA πŸͺƒ), 10User-brennen: Sandbox task for gitlab-phabricator comment integration - https://phabricator.wikimedia.org/T324164 (10brennen) Commit [[https://gitlab.wikimedia.org/brennen/test/-/commit/436323ecac8910c1252f51... [00:02:13] 10GitLab (Integrations), 10Phabricator, 10Release-Engineering-Team (GitLab III: GitLab in LA πŸͺƒ), 10User-brennen: Sandbox task for gitlab-phabricator comment integration - https://phabricator.wikimedia.org/T324164 (10brennen) brennen merged https://gitlab.wikimedia.org/brennen/test/-/merge_requests/4 [00:16:14] ^ sorry for botspam; testing some gitlab β†’ phabricator integration stuff [03:01:09] 10Project-Admins: Create project tag for VueTest - https://phabricator.wikimedia.org/T324531 (10Catrope) [04:36:58] 10Project-Admins: Create project tag for VueTest - https://phabricator.wikimedia.org/T324531 (10Usererror838) a:03Usererror838 Submit [07:40:06] hashar: would it be possible for RelEng to discuss T321790? [07:40:07] T321790: Allow tools to use phabricator webhooks - https://phabricator.wikimedia.org/T321790 [07:40:15] (also, bonjour) [07:58:45] 10Gerrit, 10Sustainability (Incident Followup), 10Upstream: Investigate Gerrit h2 cache being way too large - https://phabricator.wikimedia.org/T323754 (10hashar) [08:07:04] (03PS1) 10QChris: Allow β€œGerrit Managers” to import history [extensions/RealMe] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/865021 [08:07:06] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow β€œGerrit Managers” to import history [extensions/RealMe] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/865021 (owner: 10QChris) [08:07:12] (03PS1) 10QChris: Import done. Revoke import grants [extensions/RealMe] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/865022 [08:07:14] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [extensions/RealMe] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/865022 (owner: 10QChris) [08:18:29] 10Gerrit, 10Patch-For-Review, 10Sustainability (Incident Followup), 10Upstream: Investigate Gerrit h2 cache being way too large - https://phabricator.wikimedia.org/T323754 (10hashar) a:03hashar [08:26:09] 10Project-Admins: Create project tag for VueTest - https://phabricator.wikimedia.org/T324531 (10Aklapper) a:05Usererror838β†’03Aklapper [08:27:56] 10Project-Admins: Create project tag for VueTest - https://phabricator.wikimedia.org/T324531 (10Aklapper) 05Openβ†’03Resolved Requested public project #VueTest has been created: https://phabricator.wikimedia.org/project/view/6287/ Interested people are welcome to join the project as {icon users} members, and... [08:28:27] (03PS1) 10Majavah: zuul: rename RelMe -> RealMe [integration/config] - 10https://gerrit.wikimedia.org/r/865026 [08:28:41] (03CR) 10Majavah: [C: 03+2] zuul: rename RelMe -> RealMe [integration/config] - 10https://gerrit.wikimedia.org/r/865026 (owner: 10Majavah) [08:30:34] (03Merged) 10jenkins-bot: zuul: rename RelMe -> RealMe [integration/config] - 10https://gerrit.wikimedia.org/r/865026 (owner: 10Majavah) [08:30:59] !log reloading zuul for 865026 [08:31:01] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:15:42] (Queue (Jenkins jobs + Zuul functions) alert) firing: Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [09:16:47] (03CR) 10Hashar: "I too would prefer the Change-Id to be at the end rather than something such as:" [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/863238 (https://phabricator.wikimedia.org/T324316) (owner: 10David Caro) [09:20:42] (Queue (Jenkins jobs + Zuul functions) alert) firing: (2) Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [09:25:00] PROBLEM - Work requests waiting in Zuul Gearman server on contint2001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [400.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/d/000000322/zuul-gearman?orgId=1&viewPanel=10 [09:27:45] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10hashar) > The way the current commit hook works (the one downloaded from gerrit, and specified in the docs in gerrit) puts the change-id on top of it, so you have to... [09:29:35] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10hashar) As for the order of headers, I commented on https://gerrit.wikimedia.org/r/c/integration/commit-message-validator/+/863238/ . I think instead of enforcing `B... [09:31:22] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10dcaro) This only affects the first time you add the header right? Once the header is there, it will just not add it, maybe the way to go could be to change that scri... [09:32:27] (03CR) 10Hashar: Use Blubber BuildKit frontend instead of blubberoid (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/842543 (https://phabricator.wikimedia.org/T318290) (owner: 10Dduvall) [09:33:15] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10dcaro) > This only affects the first time you add the header right? Once the header is there, it will just not add it Not really, it seems to add it anyhow: ` dcar... [09:35:42] (Queue (Jenkins jobs + Zuul functions) alert) resolved: Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [09:37:29] hashar: o/ [09:41:39] (Queue (Jenkins jobs + Zuul functions) alert) firing: Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [09:42:05] duesen: oops, sorry missed it :( [09:42:37] hashar: let's skip, i'm busy too [09:43:00] yeah probably better this way ;) [09:46:39] (Queue (Jenkins jobs + Zuul functions) alert) firing: (2) Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [09:52:25] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10dcaro) hmm, I think that the issue might be the signed-off header, maybe at some point I pull commits without it but with change-id, then I amend the commit, so it a... [09:59:14] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10dcaro) Yep, now it becomes a battle every time I amend a commit, signed-off will add a duplicated signed-off-by header, and then change-id will put itself at the end... [10:06:39] (Queue (Jenkins jobs + Zuul functions) alert) resolved: Queue (Jenkins jobs + Zuul functions) alert - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [10:23:05] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10hashar) Nice finding, it is indeed an issue with handling of `Signed-off-by`: ` $ printf 'Summary of commit\n\nSigned-off-by: foo '|git interpret-trai... [10:24:21] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10hashar) Or we enforce Signed-Off-By to be the last header :) I am not sure how `git commit -s` recognizes whether one already has put their signature in a commit, m... [10:56:43] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10dcaro) > maybe it expects them all to be the last ones Hmm... looking at git's code it seems that the functionality for not duplicating anywhere in the commit is th... [10:59:08] RECOVERY - Work requests waiting in Zuul Gearman server on contint2001 is OK: OK: Less than 100.00% above the threshold [200.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/d/000000322/zuul-gearman?orgId=1&viewPanel=10 [11:03:58] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10dcaro) It seems to have been added, and never used (10 years ago) [[ https://github.com/git/git/commit/bab4d1097c8be7d688a53b992232063dbf300fd4 | here ]] [11:06:15] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10dcaro) Oh, it's used only for `log_tree.c` [[ https://github.com/git/git/blob/36f8e7ed7d72d2ac73743c3c2226cceb29b32156/log-tree.c#L784 | here ]] [11:13:45] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10dcaro) It's only used for the `format-patch --signoff`! ` 12:11 PM ~/Work/wikimedia/operations-cookbooks2 (wmcs|βœ”) dcaro@vulcanus$ git log -1 commit ac452c06c65113... [11:26:13] 10Beta-Cluster-Infrastructure, 10Cassandra, 10Beta-Cluster-reproducible, 10User-zeljkofilipin: Can not log in, log out, or save edits to the beta cluster (session failures) - https://phabricator.wikimedia.org/T324128 (10zeljkofilipin) 05Resolvedβ†’03Open This is happening again. [13:02:11] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.13 deployment blockers - https://phabricator.wikimedia.org/T320518 (10kostajh) Not sure if {T323542} should have been a train blocker, but if it was, it no longer is: the revert is merged into wm... [13:14:41] (03CR) 10Daniel Kinzler: Support Needed-By as a backlink to Depends-On (031 comment) [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/862233 (owner: 10Daniel Kinzler) [14:09:08] 10Continuous-Integration-Config, 10Wikidata, 10wdwb-tech, 10wmde-wikidata-tech: Run CI tests daily on master for ungated extensions - https://phabricator.wikimedia.org/T285049 (10Lucas_Werkmeister_WMDE) [14:14:41] 10Continuous-Integration-Config, 10Wikidata, 10wdwb-tech, 10wmde-wikidata-tech: Run CI tests daily on master for ungated extensions - https://phabricator.wikimedia.org/T285049 (10Michael) **Prio Notes**: - Does not affect Users / Production systems - Affects development efforts (if we notice late that so... [14:44:58] (03CR) 10Krinkle: Boilerplate for QUnit testing (031 comment) [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/861486 (owner: 10Hashar) [15:05:06] Krinkle: I have made some good progress and I am quite happy about QUnit. I did not want to bother you synchronously about that javascript gerrit plugin since well it is merely a stretch/pet project ; [15:05:07] ) [15:10:32] 10Release-Engineering-Team, 10Scap: Treat K8s deployment errors as soft errors in scap - https://phabricator.wikimedia.org/T324574 (10jnuche) [15:10:49] 10Release-Engineering-Team, 10Scap: Treat K8s deployment errors as soft errors in scap - https://phabricator.wikimedia.org/T324574 (10jnuche) [15:10:51] 10Release-Engineering-Team, 10Scap, 10MW-on-K8s: Scap Mediawiki K8s deployments - https://phabricator.wikimedia.org/T318536 (10jnuche) [15:18:52] (03CR) 10Hashar: Boilerplate for QUnit testing (031 comment) [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/861486 (owner: 10Hashar) [15:40:08] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.13 deployment blockers - https://phabricator.wikimedia.org/T320518 (10Jdlrobson) [16:11:08] hashar: yeah, arrow functions are quite a different thing. They also change create an implicit return value, much like python/ruby lamdas. E.g. ['foo', 'bar'].map(function (x) { return x.length; }) is shortened as ['foo', 'bar'].map(x => x.length); [16:11:41] although when you use a { block } this behaviour is naturally not applied. [16:12:58] the lack of a 'this' binding can also work in a good way. For example, if you have a file with QUnit code and you want to use 'this', but you are inside a map() callback, then under ES5 you would have to do something like 'var outerThis = this;' in order to access it inside the map function because every function has its own 'this'. With arrow functions you don't have to worry about that because it will not have its own 'this' so [16:12:58] 'this' in an arrow function always refers to the outer one. Only 'function' functions get their own 'this'. [16:13:17] So no more .bind(this) or 'var that = this;' needed when you use arrow functions in places where you normally had to do that. [16:13:50] Of course, if you do need a 'this' value (such as DOM context, QUnit context, Window, class method etc) then you dont' want arrow functions [16:14:08] e.g. MyRobot.prototype.walk = function () { this.step(5).forward(); } [16:14:18] e.g. MyRobot.prototype.walk = () => { this.step(5).forward(); } // boom, 'this' is undefined [16:14:24] [16:14:26] :) [16:28:12] (03CR) 10Ahmon Dancy: [C: 03+2] Use Blubber BuildKit frontend instead of blubberoid (031 comment) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/842543 (https://phabricator.wikimedia.org/T318290) (owner: 10Dduvall) [16:31:33] (03CR) 10Hashar: Use Blubber BuildKit frontend instead of blubberoid (032 comments) [integration/pipelinelib] - 10https://gerrit.wikimedia.org/r/842543 (https://phabricator.wikimedia.org/T318290) (owner: 10Dduvall) [17:53:57] (03PS2) 10Jforrester: Zuul: Add a PHP 8.2 version of mediawiki-php-library [integration/config] - 10https://gerrit.wikimedia.org/r/861934 [17:54:35] hey ^demon I see you are train conductor today? Is it possible to make https://gerrit.wikimedia.org/r/865128 go out with the train? [17:59:21] (03PS3) 10Jforrester: Zuul: Add a PHP 8.2 version of mediawiki-php-library [integration/config] - 10https://gerrit.wikimedia.org/r/861934 [17:59:29] (03CR) 10Jforrester: [C: 03+2] Zuul: Add a PHP 8.2 version of mediawiki-php-library [integration/config] - 10https://gerrit.wikimedia.org/r/861934 (owner: 10Jforrester) [18:00:19] (03PS1) 10Majavah: Review access change [wikitech-static] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/865129 [18:01:14] (03CR) 10Andrew Bogott: [V: 03+2 C: 03+2] Review access change [wikitech-static] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/865129 (owner: 10Majavah) [18:01:18] (03Merged) 10jenkins-bot: Zuul: Add a PHP 8.2 version of mediawiki-php-library [integration/config] - 10https://gerrit.wikimedia.org/r/861934 (owner: 10Jforrester) [18:08:45] 10Phabricator, 10SRE, 10decommission-hardware, 10ops-eqiad, 10serviceops-collab: decommission phab1001.eqiad.wmnet - https://phabricator.wikimedia.org/T323418 (10Dzahn) @marostegui as part of "decom of host phab1001" we can remove any mysql GRANTS for users coming from its former IP 10.64.16.8. I made a... [18:09:26] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Stretch Deprecation): Cloud VPS "deployment-prep" project Stretch deprecation - https://phabricator.wikimedia.org/T306068 (10Andrew) [18:10:54] 10Beta-Cluster-Infrastructure, 10Math, 10Mathoid, 10Platform Engineering: Upgrade deployment-docker-mathoid01 host to Buster - https://phabricator.wikimedia.org/T306051 (10Andrew) 05Openβ†’03Resolved a:03Andrew This seems done; all I see now is deployment-docker-mathoid02, running Bullseye [18:10:57] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar): Migrate deployment-prep away from Debian Stretch to Buster/Bullseye - https://phabricator.wikimedia.org/T278641 (10Andrew) [18:11:22] 10Beta-Cluster-Infrastructure, 10Cloud-VPS (Debian Stretch Deprecation): Cloud VPS "deployment-prep" project Stretch deprecation - https://phabricator.wikimedia.org/T306068 (10Andrew) [18:11:32] 10Beta-Cluster-Infrastructure, 10CX-cxserver: Upgrade deployment-docker-cxserver01 host to Buster - https://phabricator.wikimedia.org/T306050 (10Andrew) 05Openβ†’03Resolved a:03Andrew this seems done, I see deployment-docker-cxserver02 now running Bullseye. [18:11:34] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar): Migrate deployment-prep away from Debian Stretch to Buster/Bullseye - https://phabricator.wikimedia.org/T278641 (10Andrew) [18:12:01] 10Beta-Cluster-Infrastructure, 10Citoid, 10Editing-team: Upgrade deployment-docker-citoid01 host to Buster - https://phabricator.wikimedia.org/T306049 (10Andrew) 05Openβ†’03Resolved a:03Andrew I see deployment-docker-citoid02 running Bullseye now. [18:12:03] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar): Migrate deployment-prep away from Debian Stretch to Buster/Bullseye - https://phabricator.wikimedia.org/T278641 (10Andrew) [18:13:12] 10Beta-Cluster-Infrastructure, 10Wikifeeds: Upgrade deployment-wikifeeds01 host to Buster - https://phabricator.wikimedia.org/T306055 (10Andrew) deployment-wikifeeds02 (bullseye) is now up and running, and deployment-wikifeeds01 shutdown. I'll delete it soon if no one tells me not to. [18:13:49] 10Beta-Cluster-Infrastructure, 10Performance-Team: Upgrade deployment-mdb01 to Buster/Bullseye - https://phabricator.wikimedia.org/T301637 (10Andrew) deployment-mdb02 now exists and is running Bullseye. deployment-mdb01 is shutdown and will be deleted soon. [18:15:15] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar): Migrate deployment-prep away from Debian Stretch to Buster/Bullseye - https://phabricator.wikimedia.org/T278641 (10Jdforrester-WMF) [18:15:36] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar): Migrate deployment-prep away from Debian Stretch to Buster/Bullseye - https://phabricator.wikimedia.org/T278641 (10Andrew) [18:15:41] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Doing), 10Patch-For-Review: Replace deployment-imagescaler03 (stretch) with deployment-imagescaler04 (buster) - https://phabricator.wikimedia.org/T294148 (10Andrew) 05Declinedβ†’03Open deployment-imagescaler03.deployment-prep.eqiad.wmflabs is runni... [18:15:44] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar): Migrate deployment-prep away from Debian Stretch to Buster/Bullseye - https://phabricator.wikimedia.org/T278641 (10Jdforrester-WMF) [18:33:12] 10Gerrit, 10commit-message-validator, 10Patch-For-Review: Avoid enforcing arbitrary header order - https://phabricator.wikimedia.org/T324316 (10dcaro) Sent a PR to fix it upstream https://github.com/gitgitgadget/git/pull/1438 [18:49:15] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Radar): Migrate deployment-prep away from Debian Stretch to Buster/Bullseye - https://phabricator.wikimedia.org/T278641 (10Jdforrester-WMF) [18:53:21] (03PS3) 10Jforrester: Zuul: [avro-php] Use lib template (add doxygen and coverage) [integration/config] - 10https://gerrit.wikimedia.org/r/860061 [18:54:40] 10Continuous-Integration-Infrastructure, 10phpunit-patch-coverage, 10ci-test-error: Syntax error in PHP test coverage CI job due to outdated dependency of phpunit-patch-coverage - https://phabricator.wikimedia.org/T322864 (10Reedy) [19:08:00] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.13 deployment blockers - https://phabricator.wikimedia.org/T320518 (10Jdlrobson) FYI https://gerrit.wikimedia.org/r/865128 will need to be merged before the train can continue. [19:09:28] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.13 deployment blockers - https://phabricator.wikimedia.org/T320518 (10Ladsgroup) I take care of it. [19:34:47] 10Beta-Cluster-Infrastructure, 10Cassandra, 10Beta-Cluster-reproducible, 10User-zeljkofilipin: Can not log in, log out, or save edits to the beta cluster (session failures) - https://phabricator.wikimedia.org/T324128 (10Eevans) Cassandra was down, OOM-killed by the kernel. I've resized the VM (from 2G to... [19:35:00] 10Beta-Cluster-Infrastructure, 10Cassandra, 10Beta-Cluster-reproducible, 10User-zeljkofilipin: Can not log in, log out, or save edits to the beta cluster (session failures) - https://phabricator.wikimedia.org/T324128 (10Eevans) p:05Triageβ†’03High [21:23:02] 10Release-Engineering-Team, 10Fundraising-Backlog, 10Projects-Cleanup, 10Wikimedia-Fundraising-CiviCRM, 10Fundraising Sprint W 2022: Decommission Fundraising's crm/civicrm git repo - https://phabricator.wikimedia.org/T314995 (10XenoRyet) [21:25:29] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: Request access to deployment-prep - https://phabricator.wikimedia.org/T320974 (10Jrbranaa) Approved [21:31:16] Krinkle: ahah well done thank you that made everything clearer. I stepped on those `this` landmines previously :] [21:33:22] hashar: yw :) by the way, the reason it silently worked (instead of failing on undefined) is that the file wasn't in strict mode ("use strict";).. Then it would have failed in a more obcious way [21:34:19] Krinkle: but it does not fail??! [21:35:02] I will polish it up tomorrow and set the `use strict` [21:35:26] there is another oddity I have is the plugin has access to a `Gerrit` variable [21:35:54] and it is not present in QUnit, so I went to use `window.Gerrit` inside the plugin [21:35:59] I should dig a bit in that [21:36:35] there is also the NodeJS module.export which are there solely for nodejs/Qunit to be able to import or require the file [21:36:57] I will dig a bit more ;) [21:37:56] hashar: without 'use strict', there is a global 'this' for the 'globals' global variable. [21:38:12] which means even though it is totally by accident, your test will pass most likely so long as there is no conflict [21:38:22] but only because every this.foo became a global 'foo'. [21:38:42] when this is global, then this.foo=1 is the same as $GLOBALS['foo']=1 [21:39:00] in strict mode, there is no `this` unless you make one by having a regular function context. [21:39:12] which makes the mistake almost impossible and thus your test would have failed. [21:39:24] it's not QUnit related, but javascript in general [21:39:57] ahhhhh [21:40:27] I felt at some point QUnit had a special `this` [21:42:16] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.13 deployment blockers - https://phabricator.wikimedia.org/T320518 (10Jdlrobson) [22:19:03] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Blocking 🧱): Request access to deployment-prep - https://phabricator.wikimedia.org/T320974 (10thcipriani) a:03thcipriani What's your wikitech account name @GMikesell-WMF ? I didn't see anything searching for `gmikesell` in ldap πŸ” [22:19:11] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Blocking 🧱): Request access to deployment-prep - https://phabricator.wikimedia.org/T320974 (10thcipriani) p:05Triageβ†’03Medium [22:20:03] 10Release-Engineering-Team (Radar), 10MediaWiki-Debug-Logger, 10MediaWiki-Maintenance-system: Maintenance scripts should consistently log errors - https://phabricator.wikimedia.org/T307402 (10thcipriani) [22:20:17] 10Release-Engineering-Team (GitLab III: GitLab in LA πŸͺƒ): Add Gitlab JWT support to Reggie - https://phabricator.wikimedia.org/T323394 (10dancy) [22:21:25] 10Release-Engineering-Team (GitLab III: GitLab in LA πŸͺƒ): Add Gitlab JWT support to Reggie - https://phabricator.wikimedia.org/T323394 (10dancy) [22:35:50] today I have learned about monochronic and polychronic cultures https://en.wikipedia.org/wiki/Chronemics#Predictable_patterns_between_cultures_with_differing_time_systems [22:36:01] suddenly I have a good excuse for being late :-] [22:41:08] /away [22:54:22] 10Phabricator: Custom task form for #Wikimedia Enterprise (pre-filled template) - https://phabricator.wikimedia.org/T322167 (10AnnaMikla) Hi Andre! Thank you so much for your help. Looks like I figured out how to edit the form via the link you provided. I also created a link in the menu to make it handy. We'll s... [23:27:33] 10GitLab (Project Migration), 10Release-Engineering-Team: Create new GitLab project group: abstract-wiki - https://phabricator.wikimedia.org/T323957 (10Jdforrester-WMF) >>! In T323957#8444137, @brennen wrote: > Created group at https://gitlab.wikimedia.org/admin/groups/repos/abstract-wiki - added folks from te... [23:30:18] 10GitLab (Project Migration), 10Release-Engineering-Team: Create new GitLab project group: abstract-wiki - https://phabricator.wikimedia.org/T323957 (10brennen) > https://gitlab.wikimedia.org/repos/abstract-wiki for not-super-priv'ed users. ;-) Whoops - yep. I //tried// to copy the right URL here, I really did. [23:38:00] 10GitLab (Integrations), 10Phabricator, 10Release-Engineering-Team (GitLab III: GitLab in LA πŸͺƒ), 10User-brennen: Comment on Phabricator tasks for new, merged, and abandoned changes on GitLab - https://phabricator.wikimedia.org/T324150 (10dancy) [23:49:05] 10Release-Engineering-Team (GitLab III: GitLab in LA πŸͺƒ): Add Gitlab JWT support to Reggie - https://phabricator.wikimedia.org/T323394 (10thcipriani) a:03demon [23:49:34] 10Release-Engineering-Team (GitLab III: GitLab in LA πŸͺƒ): Add Gitlab JWT support to Reggie - https://phabricator.wikimedia.org/T323394 (10thcipriani) p:05Triageβ†’03Medium