[00:23:41] (03CR) 10Krinkle: [C: 04-1] "As-is this will no-op when deployed as at least a changelog entry is needed to trigger a rebuild of the php* images. However, that would s" [integration/config] - 10https://gerrit.wikimedia.org/r/875443 (https://phabricator.wikimedia.org/T291015) (owner: 10Tim Starling) [02:20:48] (03PS2) 10Tim Starling: Add Excimer packages to PHP 7.4+ dockerfiles [integration/config] - 10https://gerrit.wikimedia.org/r/875443 (https://phabricator.wikimedia.org/T291015) [02:24:29] (03CR) 10Tim Starling: "I built the following images and tested them with `php -m | grep excimer`:" [integration/config] - 10https://gerrit.wikimedia.org/r/875443 (https://phabricator.wikimedia.org/T291015) (owner: 10Tim Starling) [04:33:13] (03CR) 10Tim Starling: Add Excimer packages to PHP 7.4+ dockerfiles (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/875443 (https://phabricator.wikimedia.org/T291015) (owner: 10Tim Starling) [04:57:35] (03PS3) 10Tim Starling: Add Excimer packages to PHP 7.4+ dockerfiles [integration/config] - 10https://gerrit.wikimedia.org/r/875443 (https://phabricator.wikimedia.org/T291015) [07:44:37] (03PS1) 10Giuseppe Lavagetto: webserver: use the latest base image [tools/release] - 10https://gerrit.wikimedia.org/r/875466 [08:16:36] 10GitLab, 10serviceops, 10serviceops-collab, 10Kubernetes: Trusted gitlab runner containers need access to staging k8s cluster - https://phabricator.wikimedia.org/T325385 (10Jelto) >>! In T325385#8500212, @dancy wrote: > I verified today that trusted runners can now complete a network connection to kubesta... [08:21:49] (03PS1) 10PleaseStand: Remove check-vars.php [tools/code-utils] - 10https://gerrit.wikimedia.org/r/875802 (https://phabricator.wikimedia.org/T326932) [08:22:40] (03PS2) 10PleaseStand: Remove check-vars.php [tools/code-utils] - 10https://gerrit.wikimedia.org/r/875802 (https://phabricator.wikimedia.org/T326292) [08:24:44] 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T325580 (10AmandaNP) [08:40:05] (03CR) 10Hashar: "Nice thank you ;)" [integration/docroot] - 10https://gerrit.wikimedia.org/r/875445 (owner: 10Krinkle) [09:13:47] (03CR) 10Hashar: [C: 03+2] "Thanks for the review and typo fix in the commit message ;)" [integration/config] - 10https://gerrit.wikimedia.org/r/874780 (https://phabricator.wikimedia.org/T321536) (owner: 10Hashar) [09:14:36] (03CR) 10Hashar: [C: 03+2] "Sorry it took so long :(" [integration/config] - 10https://gerrit.wikimedia.org/r/868193 (https://phabricator.wikimedia.org/T145430) (owner: 10Dreamy Jazz) [09:15:18] (03Merged) 10jenkins-bot: Speed up integration-config-shellcheck-docker [integration/config] - 10https://gerrit.wikimedia.org/r/874780 (https://phabricator.wikimedia.org/T321536) (owner: 10Hashar) [09:15:45] (03Merged) 10jenkins-bot: Make CentralAuth a clone dependency for MassMessage [integration/config] - 10https://gerrit.wikimedia.org/r/868193 (https://phabricator.wikimedia.org/T145430) (owner: 10Dreamy Jazz) [09:18:09] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Patch-For-Review: Speed up integration-config-shellcheck-docker job - https://phabricator.wikimedia.org/T321536 (10hashar) 05Open→03Resolved [09:18:32] !log Reloaded Zuul for https://gerrit.wikimedia.org/r/c/integration/config/+/868193 | Make CentralAuth a clone dependency for MassMessage | T145430 [09:18:34] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:18:35] T145430: Sending a MassMessage to sites where you have no account should create an account to ensure signatures are blue linked to your global user page - https://phabricator.wikimedia.org/T145430 [09:34:06] (03CR) 10Clément Goubert: [C: 03+1] webserver: use the latest base image [tools/release] - 10https://gerrit.wikimedia.org/r/875466 (owner: 10Giuseppe Lavagetto) [11:17:36] (03CR) 10Hashar: [C: 03+2] wm-checks-api: add support for Puppet Catalogue Compiler [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/868424 (owner: 10Hashar) [11:18:24] (03Merged) 10jenkins-bot: wm-checks-api: add support for Puppet Catalogue Compiler [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/868424 (owner: 10Hashar) [12:37:43] 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T325580 (10Ladsgroup) [12:39:16] (03PS1) 10Hashar: wm-checks-api: fix PCC handling of empty messages [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/875877 [12:39:38] 10Release-Engineering-Team (Seen), 10Gerrit (Gerrit 3.6): Upgrade to Gerrit 3.6 - https://phabricator.wikimedia.org/T309870 (10hashar) The script has completed with: ` Labels copied for 2790 project(s) have impacted 19506 change(s) ` I ran it a second time: ` Labels copied for 2790 project(s) have impacted 0... [12:40:29] 10Release-Engineering-Team (Seen), 10Gerrit (Gerrit 3.6): Upgrade to Gerrit 3.6 - https://phabricator.wikimedia.org/T309870 (10hashar) [12:40:37] 10Release-Engineering-Team (Seen), 10Gerrit (Gerrit 3.6): Upgrade to Gerrit 3.6 - https://phabricator.wikimedia.org/T309870 (10hashar) a:03hashar [12:41:44] (03CR) 10Hashar: [C: 03+2] wm-checks-api: fix PCC handling of empty messages [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/875877 (owner: 10Hashar) [12:42:31] (03Merged) 10jenkins-bot: wm-checks-api: fix PCC handling of empty messages [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/875877 (owner: 10Hashar) [14:05:05] 10GitLab (Infrastructure), 10serviceops-collab: Align and refactor GitLab backup scripts - https://phabricator.wikimedia.org/T326315 (10Jelto) [14:50:02] (03PS2) 10Hashar: jjb: ensure /log files are writable for deletion [integration/config] - 10https://gerrit.wikimedia.org/r/840136 (https://phabricator.wikimedia.org/T320251) [14:51:10] (03CR) 10Hashar: [C: 03+2] "I had it deployed and that fixed the gerrit-events-wikimedia-bazel-docker job at the time." [integration/config] - 10https://gerrit.wikimedia.org/r/840136 (https://phabricator.wikimedia.org/T320251) (owner: 10Hashar) [14:52:56] (03Merged) 10jenkins-bot: jjb: ensure /log files are writable for deletion [integration/config] - 10https://gerrit.wikimedia.org/r/840136 (https://phabricator.wikimedia.org/T320251) (owner: 10Hashar) [14:54:48] (03PS7) 10Subramanya Sastry: Add script-generated Cite CSS [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/869335 [14:57:15] 10Phabricator: Rename Phabricator account "Ddwaal-WMF" to "Ddwaal". - https://phabricator.wikimedia.org/T326329 (10Ddwaal-WMF) [15:36:44] 10Scap, 10Patch-For-Review: Undesired full mediawiki image build when rolling back from group2 to group1 - https://phabricator.wikimedia.org/T325576 (10dancy) 05Open→03Resolved [15:40:10] (03CR) 10Ahmon Dancy: [C: 03+2] webserver: use the latest base image [tools/release] - 10https://gerrit.wikimedia.org/r/875466 (owner: 10Giuseppe Lavagetto) [15:41:02] (03Merged) 10jenkins-bot: webserver: use the latest base image [tools/release] - 10https://gerrit.wikimedia.org/r/875466 (owner: 10Giuseppe Lavagetto) [15:55:45] 10GitLab, 10serviceops, 10serviceops-collab, 10Kubernetes: Trusted gitlab runner containers need access to staging k8s cluster - https://phabricator.wikimedia.org/T325385 (10dancy) OK. While I'm developing I'll use a project variable. [15:59:45] 10Continuous-Integration-Config: Update quibble jobs to run maintenance scripts via maintenance/run.php - https://phabricator.wikimedia.org/T326333 (10Umherirrender) [16:01:32] 10Continuous-Integration-Config: Update quibble jobs to run maintenance scripts via maintenance/run.php - https://phabricator.wikimedia.org/T326333 (10Umherirrender) [16:08:39] 10Continuous-Integration-Config, 10Quibble: Update quibble jobs to run maintenance scripts via maintenance/run.php - https://phabricator.wikimedia.org/T326333 (10Umherirrender) [16:32:33] (03CR) 10CI reject: [V: 04-1] logstash checker: port to python, magic task update [tools/release] - 10https://gerrit.wikimedia.org/r/870944 (owner: 10Thcipriani) [16:35:42] (03PS4) 10Thcipriani: logstash checker: port to python, magic task update [tools/release] - 10https://gerrit.wikimedia.org/r/870944 [16:37:39] (03PS5) 10Thcipriani: logstash checker: port to python, magic task update [tools/release] - 10https://gerrit.wikimedia.org/r/870944 [16:41:11] (03PS6) 10Hashar: logstash checker: port to python, magic task update [tools/release] - 10https://gerrit.wikimedia.org/r/870944 (owner: 10Thcipriani) [16:44:14] (03CR) 10CI reject: [V: 04-1] logstash checker: port to python, magic task update [tools/release] - 10https://gerrit.wikimedia.org/r/870944 (owner: 10Thcipriani) [16:45:44] (03CR) 10Hashar: logstash checker: port to python, magic task update (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/870944 (owner: 10Thcipriani) [16:46:04] 10Continuous-Integration-Config, 10Quibble: Update quibble jobs to run maintenance scripts via maintenance/run.php - https://phabricator.wikimedia.org/T326333 (10Ladsgroup) The biggest complexity is that run.php is not in older versions of mw. Maybe we should backport the chain? [17:34:54] 10Continuous-Integration-Config, 10Quibble: Update quibble jobs to run maintenance scripts via maintenance/run.php - https://phabricator.wikimedia.org/T326333 (10Jdforrester-WMF) >>! In T326333#8502138, @Ladsgroup wrote: > The biggest complexity is that run.php is not in older versions of mw. Maybe we should b... [17:39:18] 10Continuous-Integration-Config, 10Quibble: Update quibble jobs to run maintenance scripts via maintenance/run.php - https://phabricator.wikimedia.org/T326333 (10hashar) >>! In T326333#8502138, @Ladsgroup wrote: > The biggest complexity is that run.php is not in older versions of mw. Maybe we should backport t... [17:41:37] 10Continuous-Integration-Config, 10Quibble, 10Patch-For-Review: Update quibble jobs to run maintenance scripts via maintenance/run.php - https://phabricator.wikimedia.org/T326333 (10hashar) Additionally, `maintenance/run.php` could be made to hide the banner when `MW_QUIBBLE_CI` is defined (it is set by Quib... [17:42:01] 10Continuous-Integration-Config, 10Quibble, 10Patch-For-Review: Update quibble jobs to run maintenance scripts via maintenance/run.php - https://phabricator.wikimedia.org/T326333 (10Jdforrester-WMF) >>! In T326333#8502295, @hashar wrote: >>>! In T326333#8502138, @Ladsgroup wrote: >> The biggest complexity is... [17:47:53] (03CR) 10Jforrester: "check experimental" [integration/docroot] - 10https://gerrit.wikimedia.org/r/875445 (owner: 10Krinkle) [17:57:17] 10Continuous-Integration-Config, 10ci-test-error: Bazel build fails to log dir due to directory missing write permission - https://phabricator.wikimedia.org/T320251 (10hashar) 05Open→03Resolved [19:49:12] 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10Release, 10Train Deployments: 1.40.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T325580 (10taavi) [21:01:30] (03PS1) 10Ahmon Dancy: webserver-base-image: Pass http(s)_proxy to docker build [tools/release] - 10https://gerrit.wikimedia.org/r/875932 (https://phabricator.wikimedia.org/T326351) [21:03:59] (03PS1) 10Ejegg: WIP add test jobs for fundraising/REL1_39 [integration/config] - 10https://gerrit.wikimedia.org/r/876010 [21:13:31] hm, what's going on here https://phabricator.wikimedia.org/T325110 [21:22:15] dancy: remind me where the image are built (given neither mw-core nor wmf-config, I thought it was the latter in some cases) and does that process involve calling mutliversion/generate-php-wikiversions.php and such? Codesearch suggests no, but maybe it's not in codesearch. [21:22:39] reason being that I have a change to rename/change those local bin/ and not expecting calls in any prod code (only in documentation for local dev use). [21:23:34] Mediawiki image building happens when someone runs `scap sync-world` on the deploy server. [21:24:50] There are normal Dockerfileish parts of the image build process, but the interesting stuff still happens in scap which prepares /srv/mediawiki-staging which is then rsync'd into the final output image. [21:28:27] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/release/+/refs/heads/master/make-container-image/ has the stuff for building the multiversion image. Start w/ the Makefile if you want to explore. [21:29:30] It seems that repo isn't indexed. I didn't know that repo was called on by scap in prod. I thought those are mostly local dev utilities, low stakes, not much scrutiny in terms of ACL or CI/testing. [21:29:38] I see Scap isn't indexed anymore ither since it moved off to GitLab. [21:30:29] Is there something we need to do to ensure that repos moved to GitLab get processed by codesearch? [21:31:23] 10Scap: Add option to verbosely display k8s build/push output - https://phabricator.wikimedia.org/T326359 (10TheresNoTime) [21:33:57] dancy: yes. codesearch has a list of repos that it indexes. It discovers Gerrit repos automatically more or less from its API. For GitLab we could proably do what we do with GitHub third party repos for now, which is list them one-off given there's only one or two that we care about right now in terms of prod impact. [21:34:19] afaik it supports pretty much any HTTPS git url. [21:49:37] o/ wanting to hack on scap - for gitlab currently, are we using forks and PRs or creating a branch and PRing? [21:50:22] (I know for mwcli the CI runners wouldn't work if I PR'd from a fork, so I had to create a branch..) [21:51:38] TheresNoTime: I just did a branch, but then again I have merge rights on the repo and I don't think you can do it without that level of access? [21:52:31] TheresNoTime: I just added you as a developer for that repo. You can create branches for review now. [21:52:38] Thanks :) [21:57:10] dancy: is this the intended workflow or is it planned to change once the untrusted runners are in place? it doesn't seem particularly friendly for onboarding new contributors [21:57:57] Correct. We're working on making a batch of untrusted runners available to all users so that they develop and test in their own forks [23:53:19] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Fundraising Sprint Amazing grep: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Ejegg) [23:53:54] (03PS2) 10Ejegg: WIP add test jobs for fundraising/REL1_39 [integration/config] - 10https://gerrit.wikimedia.org/r/876010 (https://phabricator.wikimedia.org/T326372)