[07:05:51] 10GitLab (Pipeline Services Migration🐤), 10Release-Engineering-Team, 10MediaWiki-Docker, 10dev-images, and 3 others: MySQL/MariaDB images for development environments - https://phabricator.wikimedia.org/T238925 (10hashar) >>! In T238925#8996824, @kostajh wrote: >>>! In T238925#8956118, @hashar wrote: >> El... [07:20:11] 10Release-Engineering-Team, 10Scap: scap backport should remove code for removed submodules - https://phabricator.wikimedia.org/T341292 (10hashar) On pulling git gives `warning: unable to rmdir 'fonts': Directory not empty`, but that is easy to miss out. The leftover directory is tentatively cleanable via `gi... [07:24:28] (03PS1) 10Kevin Bazira: recommendation-api: add pipelines for recommendation-api-ng [integration/config] - 10https://gerrit.wikimedia.org/r/935880 (https://phabricator.wikimedia.org/T339890) [07:26:16] (03CR) 10CI reject: [V: 04-1] recommendation-api: add pipelines for recommendation-api-ng [integration/config] - 10https://gerrit.wikimedia.org/r/935880 (https://phabricator.wikimedia.org/T339890) (owner: 10Kevin Bazira) [07:34:12] (03PS1) 10Kevin Bazira: recommendation-api: add pipelines for recommendation-api-ng [integration/config] - 10https://gerrit.wikimedia.org/r/935881 (https://phabricator.wikimedia.org/T339890) [07:36:49] (03Abandoned) 10Kevin Bazira: recommendation-api: add pipelines for recommendation-api-ng [integration/config] - 10https://gerrit.wikimedia.org/r/935881 (https://phabricator.wikimedia.org/T339890) (owner: 10Kevin Bazira) [07:37:57] (03PS2) 10Kevin Bazira: recommendation-api: add pipelines for recommendation-api-ng [integration/config] - 10https://gerrit.wikimedia.org/r/935880 (https://phabricator.wikimedia.org/T339890) [07:49:29] 10Deployments, 10MW-on-K8s: Pushing mediawiki-multiversion Docker image from deploy server takes 4 minutes - https://phabricator.wikimedia.org/T341441 (10hashar) [07:50:13] 10Deployments, 10MW-on-K8s: Pushing mediawiki-multiversion Docker image from deploy server takes 4 minutes - https://phabricator.wikimedia.org/T341441 (10hashar) [07:57:38] (03CR) 10Elukey: "Looks good! Lemme first check on naming first (-ng vs ctx-) since it is not clear to me what folks prefer, then we can proceed (I hope to " [integration/config] - 10https://gerrit.wikimedia.org/r/935880 (https://phabricator.wikimedia.org/T339890) (owner: 10Kevin Bazira) [07:59:26] (03CR) 10Hashar: [C: 03+2] "Jobs created:" [integration/config] - 10https://gerrit.wikimedia.org/r/935880 (https://phabricator.wikimedia.org/T339890) (owner: 10Kevin Bazira) [08:01:01] (03Merged) 10jenkins-bot: recommendation-api: add pipelines for recommendation-api-ng [integration/config] - 10https://gerrit.wikimedia.org/r/935880 (https://phabricator.wikimedia.org/T339890) (owner: 10Kevin Bazira) [08:02:25] !log Reloaded Zuul for https://gerrit.wikimedia.org/r/935880 "recommendation-api: add pipelines for recommendation-api-ng" T339890 [08:02:28] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:02:29] T339890: Host the recommendation-api container on LiftWing - https://phabricator.wikimedia.org/T339890 [08:12:31] (03CR) 10Hashar: [C: 03+2] Zuul: [operations/debs/pdns-recursor] Add debian-glue CI [integration/config] - 10https://gerrit.wikimedia.org/r/936296 (owner: 10Ssingh) [08:14:17] (03Merged) 10jenkins-bot: Zuul: [operations/debs/pdns-recursor] Add debian-glue CI [integration/config] - 10https://gerrit.wikimedia.org/r/936296 (owner: 10Ssingh) [08:14:38] !log reloaded Zuul for https://gerrit.wikimedia.org/r/c/integration/config/+/936296/ [08:14:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:55:49] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Serve production traffic via Kubernetes - https://phabricator.wikimedia.org/T290536 (10Clement_Goubert) [10:43:46] (03PS1) 10Hashar: Review access change [dns] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/936423 [10:45:42] (03PS2) 10Hashar: Grant permission to ldap/dns-admins [dns] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/936423 (https://phabricator.wikimedia.org/T341440) [10:46:20] (03CR) 10Muehlenhoff: [C: 03+1] "Looks good, thanks!" [dns] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/936423 (https://phabricator.wikimedia.org/T341440) (owner: 10Hashar) [10:46:45] (03CR) 10Hashar: [V: 03+2 C: 03+2] Grant permission to ldap/dns-admins [dns] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/936423 (https://phabricator.wikimedia.org/T341440) (owner: 10Hashar) [11:14:53] 10Continuous-Integration-Infrastructure, 10SRE: Puppet package_builder module should have the apt cache auto cleaned - https://phabricator.wikimedia.org/T339251 (10hashar) Should be good now. I have previously removed all caches from the CI instances so it is unlikely we can check the result of this change the... [11:18:34] (03CR) 10Hashar: [C: 03+2] "I will rebuild the image then I guess have to test it before promoting the jobs" [integration/config] - 10https://gerrit.wikimedia.org/r/935410 (https://phabricator.wikimedia.org/T288396) (owner: 10Hashar) [11:19:49] (03Merged) 10jenkins-bot: dockerfiles: use extension base path for coverage report [integration/config] - 10https://gerrit.wikimedia.org/r/935410 (https://phabricator.wikimedia.org/T288396) (owner: 10Hashar) [11:24:21] (03CR) 10Hashar: [C: 03+2] "Successfully published image docker-registry.discovery.wmnet/releng/quibble-buster-php74-coverage:1.5.4-s2" [integration/config] - 10https://gerrit.wikimedia.org/r/935410 (https://phabricator.wikimedia.org/T288396) (owner: 10Hashar) [12:17:58] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 3 others: Direct 0.5% of all traffic to mw-on-k8s - https://phabricator.wikimedia.org/T341078 (10Clement_Goubert) 05In progress→03Resolved [12:18:08] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Serve production traffic via Kubernetes - https://phabricator.wikimedia.org/T290536 (10Clement_Goubert) [12:18:20] 10Phabricator, 10Release-Engineering-Team (Radar), 10SRE-Sprint-Week-Sustainability-March2023, 10collaboration-services, and 2 others: Phabricator: Unable to view tasks in DB read-only mode - https://phabricator.wikimedia.org/T313879 (10Aklapper) 05Stalled→03Open >>! In T313879#8531556, @LSobanski wrot... [12:19:13] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Direct 1% of all traffic to mw-on-k8s - https://phabricator.wikimedia.org/T341463 (10Clement_Goubert) [12:19:30] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Serve production traffic via Kubernetes - https://phabricator.wikimedia.org/T290536 (10Clement_Goubert) [12:19:40] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Direct 1% of all traffic to mw-on-k8s - https://phabricator.wikimedia.org/T341463 (10Clement_Goubert) 05Open→03In progress p:05Triage→03High [12:41:09] 10Phabricator, 10Voice & Tone: Rename "[Additional] Hashtags" to "Project Name Aliases" - https://phabricator.wikimedia.org/T288457 (10Aklapper) Brought up the bigger picture in https://we.phorge.it/T15546 [13:21:33] 10Release-Engineering-Team (Priority Backlog 📥), 10Release, 10Train Deployments: 1.41.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T340245 (10matmarex) [13:38:25] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10Aklapper) [13:38:40] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - operations/cookbooks - https://phabricator.wikimedia.org/T341474 (10Aklapper) [14:15:25] 10GitLab (Infrastructure), 10collaboration-services, 10Patch-For-Review: Create alerting for GitLab CI failures - https://phabricator.wikimedia.org/T339370 (10Jelto) [15:20:42] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - operations/cookbooks - https://phabricator.wikimedia.org/T341474 (10LSobanski) p:05Triage→03Medium [15:22:14] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10LSobanski) [15:35:28] 10Phabricator, 10Release-Engineering-Team (They Live 🕶️🧟), 10Wikimedia-Phabricator-Extensions, 10Developer Productivity, 10Patch-For-Review: Move line delta to after "Subject" column in Phabricator's Gerrit patch list - https://phabricator.wikimedia.org/T301025 (10CodeReviewBot) aklapper opened https://g... [15:42:43] 10Release-Engineering-Team (Priority Backlog 📥), 10Release, 10Train Deployments: 1.41.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T340245 (10Mabualruz) [15:47:48] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10User-brennen: Disallow adding Project Tags in the Subscribers field - https://phabricator.wikimedia.org/T303829 (10CodeReviewBot) aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests... [15:48:46] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10User-brennen: Disallow adding Project Tags in the Subscribers field - https://phabricator.wikimedia.org/T303829 (10Aklapper) a:03Aklapper [15:49:19] 10GitLab (Infrastructure), 10collaboration-services: Let's Encrypt certificate expiration notice for domain gitlab.devtools.wmcloud.org - https://phabricator.wikimedia.org/T335161 (10LSobanski) p:05Medium→03Low [15:49:29] 10Phabricator, 10Release-Engineering-Team (They Live 🕶️🧟), 10Patch-For-Review, 10User-brennen: Disallow adding Project Tags in the Subscribers field - https://phabricator.wikimedia.org/T303829 (10Aklapper) [16:06:59] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Serve production traffic via Kubernetes - https://phabricator.wikimedia.org/T290536 (10bd808) Is there any particular reason that the "[ ] Wikitech is ideal to dogfood mw-on-k8s, there are challenges though that we need to over... [16:11:06] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - operations/cookbooks - https://phabricator.wikimedia.org/T341474 (10LSobanski) [16:19:38] 10Phabricator (Upstream), 10Upstream: Milestone project tag URLs with alternative hashtag set but without a primary slug redirect to https://phabricator.wikimedia.org/tag// - https://phabricator.wikimedia.org/T186173 (10Aklapper) p:05Lowest→03Low * I can reproduce this in upstream. * Still an issue nowaday... [16:29:41] 10Phabricator (Upstream), 10Upstream: Milestone project tag URLs with alternative hashtag set but without a primary slug redirect to https://phabricator.wikimedia.org/tag// - https://phabricator.wikimedia.org/T186173 (10Aklapper) [16:32:03] 10Continuous-Integration-Config, 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, and 2 others: Re-start Wikibase test coverage reporting - https://phabricator.wikimedia.org/T288396 (10hashar) [16:32:11] 10Continuous-Integration-Config, 10Wikidata, 10wdwb-tech (Freezer 🥶): Wikibase post-merge builds are failing - https://phabricator.wikimedia.org/T242617 (10hashar) [16:42:07] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10akosiaris) [16:42:42] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10akosiaris) [16:43:56] (03PS1) 10Hashar: Add experimental coverage job for Wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/936768 (https://phabricator.wikimedia.org/T288396) [16:44:35] (03CR) 10Hashar: [C: 03+2] Add experimental coverage job for Wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/936768 (https://phabricator.wikimedia.org/T288396) (owner: 10Hashar) [16:45:05] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10Ladsgroup) What about operations/software? [16:46:04] (03Merged) 10jenkins-bot: Add experimental coverage job for Wikibase [integration/config] - 10https://gerrit.wikimedia.org/r/936768 (https://phabricator.wikimedia.org/T288396) (owner: 10Hashar) [16:49:13] !log Reloaded Zuul for https://gerrit.wikimedia.org/r/936768 [16:49:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:52:08] 00:00:04.958 Unable to find image 'docker-registry.discovery.wmnet/releng/quibble-buster-php74-coverage:1.5.4-s2' locally [16:52:08] 00:00:20.125 docker: Error response from daemon: Get "https://docker-registry.discovery.wmnet/v2/": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers). [16:52:13] grlblbl [16:54:03] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10Dzahn) >>! In T341468#9002336, @Ladsgroup wrote: > What about operations/software? It's in the list, as just "software". I think this one means having to go through each a... [16:54:23] (03PS1) 10Hashar: Use proper image name in mwext-phpunit-coverage-docker [integration/config] - 10https://gerrit.wikimedia.org/r/936771 [16:56:02] (03CR) 10Hashar: [C: 03+2] Use proper image name in mwext-phpunit-coverage-docker [integration/config] - 10https://gerrit.wikimedia.org/r/936771 (owner: 10Hashar) [16:56:41] (03CR) 10Hashar: [C: 03+2] Add experimental coverage job for Wikibase (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/936768 (https://phabricator.wikimedia.org/T288396) (owner: 10Hashar) [16:57:27] !log Rsyncing /var/lib/jenkins from contint2001 to contint2002 [16:57:28] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:57:32] ERRR [16:57:38] !log Rsyncing /srv/jenkins from contint2001 to contint2002 [16:57:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:57:48] (03Merged) 10jenkins-bot: Use proper image name in mwext-phpunit-coverage-docker [integration/config] - 10https://gerrit.wikimedia.org/r/936771 (owner: 10Hashar) [17:01:16] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10Ladsgroup) I have some stuff in software repo itself (under dbtools directory) I can migrate them but let's coordinate on it. [17:01:29] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10LSobanski) [17:16:08] PROBLEM - Check systemd state on doc2002 is CRITICAL: CRITICAL - degraded: The following units failed: rsync-doc-host-data-sync.service https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state [17:17:04] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10LSobanski) [17:18:19] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10LSobanski) [17:19:18] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10LSobanski) [17:28:12] 10GitLab (Pipeline Services Migration🐤), 10collaboration-services, 10Patch-For-Review: Move micro sites from Ganeti to Kubernetes and from Gerrit to GitLab - https://phabricator.wikimedia.org/T300171 (10Dzahn) [17:44:03] 10Release-Engineering-Team (Priority Backlog 📥), 10Release, 10Train Deployments: 1.41.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T340245 (10matmarex) [17:46:53] 10Phabricator, 10Release-Engineering-Team, 10collaboration-services, 10User-AKlapper: Establish a workflow that scales for requesting Phab 2FA resets - https://phabricator.wikimedia.org/T306708 (10sbassett) [18:13:40] RECOVERY - Check systemd state on doc2002 is OK: OK - running: The system is fully operational https://wikitech.wikimedia.org/wiki/Monitoring/check_systemd_state [18:28:32] 10Continuous-Integration-Config, 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, and 3 others: Re-start Wikibase test coverage reporting - https://phabricator.wikimedia.org/T288396 (10hashar) I gave it a try with a new job [[ https://integration.wikimedia.org/c... [19:23:12] 10Phabricator: Phabricator should not embed videos from Wikimedia Commons when the file is deleted - https://phabricator.wikimedia.org/T293139 (10Aklapper) If we did this, I'm afraid it would require calling and parsing the Commons API. Which would slow down things. ` diff --git a/src/infrastructure/markup/rule... [19:26:34] 10GitLab (Pipeline Services Migration🐤), 10collaboration-services, 10Patch-For-Review: Move micro sites from Ganeti to Kubernetes and from Gerrit to GitLab - https://phabricator.wikimedia.org/T300171 (10Dzahn) [19:27:05] 10GitLab (Pipeline Services Migration🐤), 10collaboration-services, 10Patch-For-Review: Move micro sites from Ganeti to Kubernetes and from Gerrit to GitLab - https://phabricator.wikimedia.org/T300171 (10Dzahn) https://dbtree.wikimedia.org and https://tendril.wikimedia.org succesfully moved to k8s today. (thi... [19:27:50] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - operations/software - https://phabricator.wikimedia.org/T341504 (10Aklapper) [19:46:57] 10Phabricator, 10Release-Engineering-Team (They Live 🕶️🧟), 10Wikimedia-Phabricator-Extensions, 10User-brennen: Custom Phab Reports: "Unhandled Exception ("RuntimeException") Division by zero" - https://phabricator.wikimedia.org/T324319 (10Aklapper) p:05Triage→03Low a:03Aklapper [20:15:30] 10GitLab (Pipeline Services Migration🐤), 10collaboration-services, 10Patch-For-Review: Move micro sites from Ganeti to Kubernetes and from Gerrit to GitLab - https://phabricator.wikimedia.org/T300171 (10Dzahn) [20:35:58] Getting ENOSPC errors on runner-1028.gitlab-runners.eqiad1.wikimedia.cloud :-( [20:37:44] 10GitLab (CI & Job Runners), 10Release-Engineering-Team: GitLab CI: "ENOSPC: no space left on device, mkdir" - https://phabricator.wikimedia.org/T340586 (10Jdforrester-WMF) Ran into this several times today on runner-1026.gitlab-runners.eqiad1.wikimedia.cloud and runner-1028.gitlab-runners.eqiad1.wikimedia.cloud. [21:06:32] 10Phabricator, 10Release-Engineering-Team (They Live 🕶️🧟), 10Wikimedia-Phabricator-Extensions, 10User-brennen: Custom Phab Reports: "Unhandled Exception ("RuntimeException") Division by zero" - https://phabricator.wikimedia.org/T324319 (10Aklapper) Could reproduce locally by creating a task older than 17 w... [21:43:33] 10Release-Engineering-Team (Priority Backlog 📥), 10Release, 10Train Deployments: 1.41.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T340245 (10Jdlrobson) [22:56:13] !log stopping buildkitd on runner-1029.gitlab-runners.eqiad1.wikimedia.org to debug buildkitd cache issues (T340887) [22:56:15] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:56:16] T340887: WMCS GitLab runners running frequently running out of disk space - https://phabricator.wikimedia.org/T340887 [23:28:56] Daimona: I think the lack of global scope may make the new phpunit setup appear more fragile than it really is. [23:29:16] For one, it uses the same workaround also to load Setup.php which similarly is generally thought of as requiring global scope [23:30:01] It might make it more fragile... But I was hoping that this may not be a concern given the config-related changes in... 1.38? [23:30:13] LocalSettingsLoader etc., that is [23:31:01] I remember lots of changes towards the eventual goal of not requiring global scope in Setup.php, and while that work isn't complete, it seems to work mostly fine at this point [23:31:44] LocalSettingsLoader isn't used afaik [23:32:06] There is non-trivial overhead and unused infra that has unclear purpose/future at this point [23:32:10] No, but some changes were made to make it work with the previous expectations of global scope [23:32:13] Last I can find is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/764411 [23:32:50] I'm not aware of a problem existing that would be solved by loading LocalSettings any other way. But indeed having the ability to load it in phpunit by non-global means would be nice. [23:33:07] So what I mean is: LocalSettingsLoader might make this a non-issue, but even just the work that went into making LSLoader work resolved some tech debt related to things expecting to be in the global scope [23:33:13] but I think it'd be a major back-compat break for long tail of LocalSettings customizations, older extensions, wiki farms, wmf-config, multiversion etc. [23:33:40] so I don't see it becoming the default, but if might work well enough for this purpose indeed. [23:33:45] Yup, I can see your point. I don't have opinions about LSLoader, mostly because I've never really looked into it. [23:34:09] But the thing is, IF LSLoader is used, then config is not declared in the global scope [23:34:27] Which means the code calling LSLoader need to account for that, and this part of the work was done last year AFAICS [23:35:04] I remember our last attempt to eliminate phpunit.php before the LSLoader work, and it just failed miserably precisely because lots of things were expecting to be in the global scope [23:35:31] This seems to no longer be the case, except maybe for edge cases like Wikibase's config [23:35:36] Looking at it now, it seems LocalSettingsLoader feeds the (techniclaly local) variables it finds from the require'd LS.php file to wpSettings->overrideConfigValues() which stashes them somewhere, but does not afaik set them in GlobalVarConfig [23:35:50] so I'm guessing there is some distance between there and when they are really set [23:36:20] in Setup.php that happens in $wgSettings->apply(); which is right after that function returns, so effectively zero distance [23:36:45] Yeah, there are numerous calls to $wgSettings->apply() throughout Setup.php [23:37:48] Which I guess are to account for all the places where global variables can be set/changed (so not just LS.php, but also MW_SETUP_CALLBACK, MW_FINAL_SETUP_CALLBACK, etc.) [23:43:48] I would summarise my thoughts as: yes, it's still possible that some edge case will break things. But I think we're at a point where trying to ditch phpunit.php has a sufficiently good probability of working, and the advantages of trying it and fixing any issues that may arise outweigh the disadvantages of not doing it just because something //might// break [23:53:40] Daimona: Yeah, agreed. Those would be core bugs for LSLoader general too, not just phpunit, if limited to LS.php working [23:53:48] I'm still looking at that autoloader variable not working [23:53:56] I suspect something is different there that doesn't need to be different [23:56:46] Yeah, what it does differently is that TestsAutoLoader tries to read a global variable defined in Setup.php //before// the end of Setup.php. In fact, I believe this can be the only ultimate cause for all the edge cases we might see [23:57:20] TestSetup::requireOnceInGlobalScope() has a hack for pushing all variables into the global scope, but that only runs after the whole file's been loaded [23:59:22] The other thing that is different is that wgAutoloadClasses is not a configuration variable, meaning it isn't caught by the hack at lines 184-193 [23:59:44] That is, https://gerrit.wikimedia.org/g/mediawiki/core/+/f6a789e2749555918a2f4eaf2452f48b823f6106/includes/Setup.php#185