[05:14:22] 10Project-Admins: Create project tag for JWTAuth - https://phabricator.wikimedia.org/T341537 (10JeffreyWang) It's an existing MediaWiki extension that @cicalese recommended I port over to WMF source control for various reasons. [06:54:32] (Queue (Jenkins jobs + Zuul functions) alert) firing: - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [07:05:51] PROBLEM - Work requests waiting in Zuul Gearman server on contint2002 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [400.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/d/000000322/zuul-gearman?orgId=1&viewPanel=10 [07:14:32] (Queue (Jenkins jobs + Zuul functions) alert) resolved: - https://alerts.wikimedia.org/?q=alertname%3DQueue+%28Jenkins+jobs+%2B+Zuul+functions%29+alert [08:02:37] RECOVERY - Work requests waiting in Zuul Gearman server on contint2002 is OK: OK: Less than 100.00% above the threshold [200.0] https://www.mediawiki.org/wiki/Continuous_integration/Zuul https://grafana.wikimedia.org/d/000000322/zuul-gearman?orgId=1&viewPanel=10 [08:07:45] It appears based on the Zuul page, that theres alot of jobs that have queued for over an hour for seemingly no reason? [08:10:54] Nevermind, it seems to have magically fixed itself *shrugs* [08:33:32] 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T340245 (10LucasWerkmeister) [09:00:41] 10GitLab (Infrastructure), 10Release-Engineering-Team, 10collaboration-services, 10Patch-For-Review: Upgrade GitLab to major version 16 - https://phabricator.wikimedia.org/T338460 (10Jelto) [09:04:45] 10Phabricator: Change "Edit Policy" of {older | newer} existing projects from {"All Users" | "Trusted-Contributors"} to ACL tags {Trusted-Contributors | acl*phabricator | acl*Project-Admins | WMF-NDA} - https://phabricator.wikimedia.org/T341604 (10Aklapper) [09:05:14] 10Phabricator: Change "Edit Policy" of {older | newer} existing projects from {"All Users" | "Trusted-Contributors"} to ACL tags {Trusted-Contributors | acl*phabricator | acl*Project-Admins | WMF-NDA} - https://phabricator.wikimedia.org/T341604 (10Aklapper) 05Open→03In progress [09:05:20] 10Phabricator: Make sure anti-vandalism features are up to snuff - https://phabricator.wikimedia.org/T84 (10Aklapper) [09:05:41] Hi, Growth has some issues with releng's sonar-scanner docker image (namely, running `apt update` fails with "public key is not available"). This prevents us from merging patches to `research/mwaddlink`. Any ideas why this might be happening and how to fix this please? 🙂 [09:06:39] Zppix: re Zuul alert, I should probably revisit that alarm. It is pretty much a false alarm in most cases [09:07:39] though surely having 4k jobs enqueued in Zuul is a concern of some sort [09:07:47] 10Phabricator: Change "Edit Policy" of {older | newer} existing projects from {"All Users" | "Trusted-Contributors"} to ACL tags {Trusted-Contributors | acl*phabricator | acl*Project-Admins | WMF-NDA} - https://phabricator.wikimedia.org/T341604 (10Aklapper) [09:08:31] hashar: i mean it wasnt entirely false, there was about 30ish jobs that were queued for ~1h, if anything it probably recovered before it actually should of [09:19:38] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - operations/software - https://phabricator.wikimedia.org/T341504 (10LSobanski) p:05Triage→03Medium [09:45:05] 10GitLab (Infrastructure), 10Release-Engineering-Team, 10collaboration-services: Upgrade GitLab to major version 16 - https://phabricator.wikimedia.org/T338460 (10Jelto) [10:45:54] 10Phabricator: Change "Edit Policy" of {older | newer} existing projects from {"All Users" | "Trusted-Contributors"} to ACL tags {Trusted-Contributors | acl*phabricator | acl*Project-Admins | WMF-NDA} - https://phabricator.wikimedia.org/T341604 (10Aklapper) [11:35:34] 10Beta-Cluster-Infrastructure, 10serviceops, 10wikidiff2, 10Better-Diffs-2023, 10Community-Tech (CommTech-Kanban): Install wikidiff2 1.14.1 deb on deployment-prep & test - https://phabricator.wikimedia.org/T340542 (10dom_walden) @GMikesell-WMF and I have finished our testing here. We have not found any m... [11:41:38] 10Phabricator: Change "Edit Policy" of {older | newer} existing projects from {"All Users" | "Trusted-Contributors"} to ACL tags {Trusted-Contributors | acl*phabricator | acl*Project-Admins | WMF-NDA} - https://phabricator.wikimedia.org/T341604 (10Aklapper) [11:43:22] 10Beta-Cluster-Infrastructure, 10serviceops, 10wikidiff2, 10Better-Diffs-2023, 10Community-Tech (CommTech-Kanban): Install wikidiff2 1.14.1 deb on deployment-prep & test - https://phabricator.wikimedia.org/T340542 (10TheresNoTime) 05In progress→03Resolved Thank you! Work continues at {T340087} [11:47:07] !log Adding new column for the CampaignEvents extension in beta wikishared # T341642 [11:47:09] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:47:09] T341642: Add the campaign_events.event_answers_status column in beta DB - https://phabricator.wikimedia.org/T341642 [13:24:33] 10Release-Engineering-Team (Radar), 10Diffusion-Repository-Administrators, 10User-Tgr: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540 (10Aklapper) For the records, there was another deletion in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SmiteSpam/+/937... [13:37:42] 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T340245 (10Lucas_Werkmeister_WMDE) [14:14:16] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10LSobanski) [14:19:08] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10LSobanski) [14:19:10] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team: Jenkins plugins security advisory - 2023-07-12 - https://phabricator.wikimedia.org/T341584 (10MoritzMuehlenhoff) p:05Triage→03High [14:23:01] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - operations/software - https://phabricator.wikimedia.org/T341504 (10LSobanski) [14:23:37] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10jbond) for puppet i think we really need to have some work flow for [[ https://phabricator.wikimedia.org/T300819 | stacked pull requests ]], ideally cross repo so we can hav... [14:24:18] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10jbond) > operations/debs This is also a folder with many repos below it [14:28:24] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team: Jenkins plugins security advisory - 2023-07-12 - https://phabricator.wikimedia.org/T341584 (10jnuche) Releases Jenkins uses two of the affected plugins: * external-monitor-job * rebuild At the moment there is no fix for the `r... [14:32:13] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team: Jenkins plugins security advisory - 2023-07-12 - https://phabricator.wikimedia.org/T341584 (10hashar) For the CI Jenkins: > **Rebuilder 1.34** > > CSRF vulnerability (no fix available) > No fixes for these issues are available.... [14:36:44] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team: Jenkins plugins security advisory - 2023-07-12 - https://phabricator.wikimedia.org/T341584 (10hashar) For the CI Jenkins: > **Rebuilder 1.34** > > CSRF vulnerability (no fix available) > No fixes for these issues are available.... [14:45:19] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team: Jenkins plugins security advisory - 2023-07-12 - https://phabricator.wikimedia.org/T341584 (10jnuche) Plugin version with the fix for external-monitor-job hasn't been published yet: https://plugins.jenkins.io/external-monitor-job... [14:49:31] 10GitLab (Integrations), 10Release-Engineering-Team (Priority Backlog 📥), 10Code-Health, 10Developer Productivity, 10User-brennen: Investigate whether we can/should integrate Git/Reviewers with GitLab - https://phabricator.wikimedia.org/T289712 (10bd808) Adding "Gerrit Reviewer Bot" here so that maybe I... [14:51:32] 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T340245 (10LucasWerkmeister) [14:56:00] 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T340245 (10MohammadHijjawi) [15:06:04] 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T340245 (10MohammadHijjawi) [15:14:24] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team: Jenkins plugins security advisory - 2023-07-12 - https://phabricator.wikimedia.org/T341584 (10hashar) For the rebuild plugin I tried a job without any parameters: If I head to a job page that has no build, clicking {nav Rebuild... [16:00:45] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Release-Engineering-Team: Jenkins plugins security advisory - 2023-07-12 - https://phabricator.wikimedia.org/T341584 (10thcipriani) >>! In T341584#9009320, @jnuche wrote: > Plugin version with the fix for external-monitor-job hasn't been published yet: ht... [16:22:32] 10GitLab (CI & Job Runners), 10collaboration-services: Disable unprivileged userns on GitLab Runners - https://phabricator.wikimedia.org/T341334 (10dancy) Agreed. [16:43:43] 10GitLab (Integrations), 10Release-Engineering-Team (Priority Backlog 📥), 10Code-Health, 10Developer Productivity, 10User-brennen: Investigate whether we can/should integrate Git/Reviewers with GitLab - https://phabricator.wikimedia.org/T289712 (10valhallasw) See T288381 for the related discussion from t... [17:15:16] 10GitLab: ignoring extra bitmap file warning when fetching from gitlab - https://phabricator.wikimedia.org/T341712 (10dancy) [17:33:25] 10GitLab: ignoring extra bitmap file warning when fetching from gitlab - https://phabricator.wikimedia.org/T341712 (10hashar) The issue referred to a merge request which leads me to the documentation about object pools at https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/object_pools.md > While it's not an... [17:46:06] 10Gitlab-Application-Security-Pipeline, 10Security Team AppSec, 10Security-Team, 10SecTeam-Processed, 10Security: Address issues within certain Gitlab CI security templates - https://phabricator.wikimedia.org/T338034 (10CodeReviewBot) mmartorana merged https://gitlab.wikimedia.org/repos/security/gitlab-c... [18:27:19] 10Release-Engineering-Team (Priority Backlog 📥), 10Scap, 10Research, 10Patch-For-Review: article-recommender: clean up git-fat removal - https://phabricator.wikimedia.org/T317212 (10leila) p:05Triage→03Medium [18:28:15] 10Release-Engineering-Team (Priority Backlog 📥), 10Scap, 10Research, 10Patch-For-Review: article-recommender: clean up git-fat removal - https://phabricator.wikimedia.org/T317212 (10fkaelin) a:03fkaelin [18:29:01] 10Phabricator: Change "Edit Policy" of {older | newer} existing projects from {"All Users" | "Trusted-Contributors"} to ACL tags {Trusted-Contributors | acl*phabricator | acl*Project-Admins | WMF-NDA} - https://phabricator.wikimedia.org/T341604 (10Aklapper) [18:29:23] 10GitLab (Administration, Settings & Policy), 10Release-Engineering-Team (Radar), 10Research: GitLab Issues experiment with Research - https://phabricator.wikimedia.org/T304614 (10leila) a:03fkaelin [18:30:56] 10Phabricator: Make sure anti-vandalism features are up to snuff - https://phabricator.wikimedia.org/T84 (10Aklapper) [18:31:09] 10Phabricator, 10Release-Engineering-Team (They Live 🕶️🧟), 10Developer-Advocacy (Jul-Sep 2023): Change "Edit Policy" of {older | newer} existing projects from {"All Users" | "Trusted-Contributors"} to ACL tags {Trusted-Contributors | acl*phabricator | acl*Project-Adm... - https://phabricator.wikimedia.org/T341604 [18:35:15] 10Phabricator: Make sure anti-vandalism features are up to snuff - https://phabricator.wikimedia.org/T84 (10Aklapper) [18:37:12] 10Phabricator: Make sure anti-vandalism features are up to snuff - https://phabricator.wikimedia.org/T84 (10Aklapper) [18:42:24] 10Phabricator: Make sure anti-vandalism features are up to snuff - https://phabricator.wikimedia.org/T84 (10Aklapper) [18:44:44] 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.17 deployment blockers - https://phabricator.wikimedia.org/T340245 (10dduvall) [19:02:31] 10Continuous-Integration-Config, 10VPS-project-Extdist, 10ci-test-error: Tests failing due to python3.4 not found - https://phabricator.wikimedia.org/T341718 (10Reedy) [19:10:45] 10Continuous-Integration-Config, 10VPS-project-Extdist, 10ci-test-error: Tests failing due to python3.4 not found - https://phabricator.wikimedia.org/T341718 (10Reedy) 05Open→03Resolved a:03Reedy [19:40:01] Daimona: I added two suggestions to the pad as alternate lines/paragraph for easy comparison. https://etherpad.wikimedia.org/p/xwyjuyWchr6kC_31OjsN [19:41:17] Oh, thanks for the review, I didn't notice! Let me take a look [19:42:54] One thing: we're not really using LocalSettingsLoader. We're still using the old config loading mechanism, but taking advantages of changes that were made to support LocalSettingsLoader [19:46:00] I'd also like to rephrase the last bit, adding explicit `global` shouldn't be needed for LocalSettings, but it might be needed in additional config files (I wrote it with Wikibase in mind, see https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/6c7b5380e733b455d6d8070c20390a37ed21acd6/Wikibase.php) [19:49:23] Krinkle: I've added a third version for that paragraph, based on the previous two with some clarifications. Do feel free to make any adjustments, and once that LGTY, I will send out the email. [19:50:44] Daimona: hm.. I thought it'susing LSLoader, given that all we do is include Setup.php, we don't have our own way fo loading LS anymore right? [19:50:56] and Setup.php uses LSLoader when in nonglobal scope? [19:51:10] ah no it's behind the MW_USE_LOCAL_SETTINGS_LOADER flag [19:51:37] Yup, was gonna say, it's behind an env var [19:52:01] Hm.. so just a quick check: What's making this not break someting like $wgMyVar = $wgDefaultVar; [19:54:16] 10Phabricator (phabricator-next), 10Security: Streamline process for uploading private files to public tasks - https://phabricator.wikimedia.org/T181317 (10Aklapper) [19:54:41] I'll check in a moment, but it seems like the TEstSetup require global logic would not even put most config vars in scope, so even the StyleDirectory override in Setupphp wouldn't be visible there without something making it global again [19:54:57] ah no, I think the wgScopeTest block woudl take care of that [19:55:12] so we're making use of *that* as a new thing, not LSLoader. [19:55:29] 10Phabricator (phabricator-next): Less restrictive l image policy for drag and drop images for users or anons - https://phabricator.wikimedia.org/T333213 (10Aklapper) I assume T181317#7978111 should solve this once we upgrade to Phorge [19:56:15] Yes, the hack in the wgScopeTest conditional is what makes the whole thing work [19:56:27] For context, before the LSLoader work, that conditional branch would just throw an error [19:57:05] (Let me find it) [19:58:42] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/764410/10/includes/Setup.php [19:59:29] And of course the issue wasn't really the fact that it was throwing an error (which we tried to work around by making wgScopeTest explicitly global in the bootstrap), but rather the underlying assumption that the file was always included in the global scope [20:00:26] Daimona: ack, LGTM. and the subject? [20:01:18] Right, as for the subject: I just copied mine from a previous email :-) [20:01:19] I changed the grammar to be from the configuring developer, e.g. "you have code" suggests code in LS that reads the config var, which is possible, but more likely it's existing code in (someone's) extension. [20:01:29] But one thing to note is that composer phpunit:entrypoint is not new [20:01:39] changed it to "your config variable is read during …" [20:01:45] We introduced it last year to ease the transition from update.php to composer [20:02:01] In theory, people should already be using it. In practice, I guess it may still sound new to many [20:02:11] Thanks! [20:02:14] yeah, I'd consider this the proper launch of it. [20:02:21] that way it stands out when scanning headlines [20:02:47] SGTM, let's go with yours and not with the copypasta [20:04:14] So, if you think the current version of the email looks good I'll go ahead [20:05:30] LGTM [20:06:23] dduvall: if you have a moment, I'm trying to do a docker build with blubber and running into a very basic problem, Bryan thought you might have answers. [20:06:26] https://www.irccloud.com/pastebin/RUpVdg2I/ [20:07:16] This is on my laptop so I could easily believe that need more setup for that #syntax= line to work but it seems like Docker is ignoring it entirely [20:07:45] 10Phabricator (phabricator-next), 10Upstream: Give transparent embedded image files in Phabricator a checkered background - https://phabricator.wikimedia.org/T78644 (10Aklapper) [20:08:17] 10Phabricator: Make sure anti-vandalism features are up to snuff - https://phabricator.wikimedia.org/T84 (10Aklapper) [20:12:23] 10Phabricator (Search), 10Release-Engineering-Team (Seen), 10observability, 10Browser-Tests, 10User-MModell: Develop tests for phabricator search to detect regressions / search quality issues - https://phabricator.wikimedia.org/T182160 (10Aklapper) [20:16:16] (03CR) 10Samtar: [C: 03+1] "working mouse" [integration/config] - 10https://gerrit.wikimedia.org/r/904488 (https://phabricator.wikimedia.org/T333534) (owner: 10Kosta Harlan) [20:19:29] (03PS4) 10Majavah: zuul: Add PageTriage to gatedextensions [integration/config] - 10https://gerrit.wikimedia.org/r/904488 (https://phabricator.wikimedia.org/T333534) (owner: 10Kosta Harlan) [20:20:41] 10Phabricator Antivandalism Extension, 10Release-Engineering-Team (They Live 🕶️🧟), 10Developer-Advocacy (Jul-Sep 2023): antivandalism.age-factor-decay throws Exception: Unknown configuration option type "text" - https://phabricator.wikimedia.org/T338970 (10Aklapper) 05Open→03Resolved a:03Aklapper Confi... [20:20:44] 10Phabricator Antivandalism Extension, 10Release-Engineering-Team (They Live 🕶️🧟), 10Developer-Advocacy (Jul-Sep 2023): antivandalism.age-factor-decay throws Exception: Unknown configuration option type "text" - https://phabricator.wikimedia.org/T338970 (10Aklapper) [20:21:08] (03CR) 10Majavah: [C: 03+2] "deploying" [integration/config] - 10https://gerrit.wikimedia.org/r/904488 (https://phabricator.wikimedia.org/T333534) (owner: 10Kosta Harlan) [20:22:17] (03Merged) 10jenkins-bot: zuul: Add PageTriage to gatedextensions [integration/config] - 10https://gerrit.wikimedia.org/r/904488 (https://phabricator.wikimedia.org/T333534) (owner: 10Kosta Harlan) [20:23:16] !log reloading zuul for 904488 [20:23:17] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:25:07] 10Phabricator, 10Voice & Tone: Rename "[Additional] Hashtags" to "Project Name Aliases" - https://phabricator.wikimedia.org/T288457 (10Aklapper) 05Open→03Declined p:05Triage→03Low Declining for the time being, per feedback in upstream. [20:30:14] 10Phabricator, 10Voice & Tone: Error message when trying to archive a Phabricator project without permissions only talks about creating projects - https://phabricator.wikimedia.org/T256103 (10Aklapper) As this is a downstream thingy (see T250910#6095787) fixing this should be a simple `translation.override` in... [20:31:56] (03PS1) 10Majavah: Revert "zuul: Add PageTriage to gatedextensions" [integration/config] - 10https://gerrit.wikimedia.org/r/937479 [20:32:02] (03CR) 10Majavah: [C: 03+2] Revert "zuul: Add PageTriage to gatedextensions" [integration/config] - 10https://gerrit.wikimedia.org/r/937479 (owner: 10Majavah) [20:32:29] I think I broke core CI for a second, reverting, sorry about that [20:32:43] I think we may have our first PHPUnit failure in CentralAuth, but let me see [20:33:06] Daimona: yep that's probably me, will be fixed when the integration/config patch merges [20:33:13] taavi: It might also be caused by the PHPUnit change we just made (I even wrote my message before seeing your lol) [20:33:16] (03Merged) 10jenkins-bot: Revert "zuul: Add PageTriage to gatedextensions" [integration/config] - 10https://gerrit.wikimedia.org/r/937479 (owner: 10Majavah) [20:33:20] Hmmmmm :D [20:33:47] Daimona: we'll I'll revert my patch, so we only have one suspicious thing to look at, instead of two [20:33:57] !log zuul: revert 904488 just in case [20:33:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:34:45] Daimona: the centralauth database issue could definitely be caused by your patch. CA has a hack somewhere that configures it to use $wgDBname if the magic Jenkins variable is sett [20:35:09] but I also got a "Message 'wikilove' required by 'ext.pageTriage.views.toolbar' must exist", which is probably caused by my CI config change instead [20:35:34] Yeah, I'm updating my local CA config to verify [20:35:50] One thing's for sure -- CA tests are accessing the database in a dataprovider, which is suuuuuuuper unsafe [20:36:17] what do you except from CA :D [20:37:30] Yeah :D Although it looks like it's happening indirectly from ApiStructureTest [20:37:47] 10Continuous-Integration-Config, 10Moderator-Tools-Team, 10PageTriage, 10Growth-Team (Current Sprint): Add PageTriage to gated extensions - https://phabricator.wikimedia.org/T333534 (10taavi) I've had to revert the above patch. There are two separate issues I was seeing, one was with CA that we believe was... [20:37:49] I'm looking at the CA source now [20:38:37] (The data provider specified for ApiStructureTest::testParameters is invalid. `Wikimedia\Rdbms\DBQueryError: Error 1044: Access denied for user 'wikiuser'@'localhost' to database 'centralauth'` is the thing I'm looking at, just to be sure we're talking about the same issue) [20:38:50] As weird as it may sound, I think CentralAuth isn't doing anything wrong... [20:38:55] Ah yes [20:39:01] Let's say there are two issues [20:39:13] The first one is that this code should NOT run in a dataprovider because it involves a DB query [20:39:22] !bash As weird as it may sound, I think CentralAuth isn't doing anything wrong... [20:39:23] taavi: Stored quip at https://bash.toolforge.org/quip/rBXUS4kBhuQtenzvd46M [20:39:44] Second issue is the fact that the query doesn't work, but I'm not even looking into that yet [20:39:48] 10Phabricator, 10Release-Engineering-Team, 10Wikimedia-Phabricator-Extensions: Custom Phab Reports: "Unhandled Exception ("RuntimeException") count(): Parameter must be an array or an object that implements Countable" - https://phabricator.wikimedia.org/T324320 (10Aklapper) Stacktrace confirms that this is a... [20:40:03] 10Phabricator, 10Release-Engineering-Team, 10Wikimedia-Phabricator-Extensions: Custom Phab Reports: "Unhandled Exception ("RuntimeException") count(): Parameter must be an array or an object that implements Countable" - https://phabricator.wikimedia.org/T324320 (10Aklapper) [20:40:07] In fact, there are good chances that moving the call outside of the data provider might fix the query/config issue as well [20:40:22] 10Phabricator, 10Release-Engineering-Team (They Live 🕶️🧟), 10Patch-For-Review: Reports: RuntimeException due to wrong assumption that boards have more columns than default Backlog - https://phabricator.wikimedia.org/T336105 (10Aklapper) [20:40:23] Yeah, that was surprising, I know :D [20:40:57] I've spent way too much time on CA so pretty much every time some issue mentions CA I automatically assume it's at fault [20:41:14] In fact, my first guess at an explanation is the following [20:41:15] the reason why the query fails is that this code is not having an effect anymore: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralAuth/+/refs/heads/master/includes/CentralAuthHooks.php#107 [20:41:49] andrewbogott: it does seem that way, that the syntax line is being ignored [20:41:50] 1) That test has always accessed the DB in a data provider 2) The issue has been hidden so far because phpunit.php did its global scope magic 3) Now that the magic is gone, the issue is discovered [20:41:57] what version of docker? [20:42:18] https://www.irccloud.com/pastebin/Kq8ZrhOA/ [20:42:20] andrewbogott: try `DOCKER_BUILDKIT=1 docker build ...` [20:42:47] dduvall: that is doing something different! [20:43:07] ah "BuildKit is the default builder for users on Docker Desktop, and Docker Engine as of version 23.0" [20:43:43] So likely this would happen to anyone building on a VM? [20:43:49] so yeah, you need to define that env var locally if you want blubber to work directly [20:44:03] depends on their version of docker really [20:44:25] Daimona: do you know off-hand if getAllowedParams() is called on any API request or just the ones hitting that specific endpoint? because if it's the former I'm wondering if the correct answer would be to remove the DB call from it [20:44:43] 10Phabricator, 10Release-Engineering-Team (They Live 🕶️🧟), 10Patch-For-Review: Uninstall Packages (Phabricator application) - https://phabricator.wikimedia.org/T336906 (10Aklapper) [20:44:53] blubber is now implemented as a buildkit frontend so that requires docker to be using buildkit as the backend builder, which is the default starting with version 23 it seems [20:44:55] 10Phabricator, 10Release-Engineering-Team (They Live 🕶️🧟), 10Patch-For-Review: Uninstall Multimeter (Phabricator application) - https://phabricator.wikimedia.org/T337650 (10Aklapper) [20:45:04] thank you dduvall! I'm sure I'll have more questions but not until I sort out "ERROR: Failed to build one or more wheels" [20:45:16] np! [20:45:16] Ok, for $wgWikimediaJenkinsCI not being read, that's indeed my fault. It's read in the extension registration callback, so early enough. I'll look into this later [20:45:41] seems to be due to 'fatal error: lber.h: No such file or directory' [20:46:23] taavi: Re getAllowedParams I think it's definitely called in more than just hits to that endpoint (for instance, ApiHelp, ApiSandbox). But maybe not for any API request. I'll investigate though [20:46:47] 10Phabricator (phabricator-next), 10Upstream: "Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool" when viewing old Herald Transcript - https://phabricator.wikimedia.org/T294860 (10Aklapper) [20:47:18] Y'know, just a few minutes ago I was thinking, what better way to spend the next 4 hours than fixing CentralAuth :P [20:47:19] andrewbogott: missing dev apt package dependency perhaps? [20:47:39] yeah, ldap-dev I think. I'm sure there will be more missing packages where that came from [20:48:06] andrewbogott: sounds like you're missing the wheel package? or does horizon depend on something that doesn't have manylinux wheels available? [20:48:10] that ol' building from source loop :) [20:48:47] Daimona: do you need any help from me or do you think you got it? [20:49:20] I'll need help from high above... [20:49:21] aaaand now my drive is full [20:49:29] :/ [20:49:34] But yeah, let me investigate a bit and I'll report back [20:49:55] 10Phabricator, 10DBA, 10Data-Persistence-Backup, 10collaboration-services, 10Patch-For-Review: phabricator->phorge migration - database handling - https://phabricator.wikimedia.org/T335080 (10Dzahn) a:05Dzahn→03brennen [20:50:13] ok. I'm probably around for an hour or two today in case you need anything [20:53:20] 10Phabricator, 10DBA, 10Data-Persistence-Backup, 10collaboration-services, 10Patch-For-Review: phabricator->phorge migration - database handling - https://phabricator.wikimedia.org/T335080 (10Dzahn) - copied .sql files from the "before dump" from cumin100 over to phab-test1001 so that Brennen has access... [20:55:11] I've filed https://phabricator.wikimedia.org/T341731 and will post updates there [20:59:55] dduvall: next question (after deleting some repos), what will be the /fully/qualified/path to the python3 binary in my new container? [21:03:26] hm, the answer seems to be '/usr/bin/python3' which I should've expected :) [21:03:30] andrewbogott: blubber doesn't install python install. it just assumes you have it available in the base image, so that will depend on your base image [21:03:42] doesn't install python *itself [21:03:56] yeah, I'm using a python base [21:04:21] * dduvall nods [21:08:55] 10Phabricator, 10Wikimedia-Phabricator-Extensions: Train blocker task has wrong navigation to previous train - https://phabricator.wikimedia.org/T336686 (10Aklapper) p:05Triage→03Low `phabricator/extensions/src/customfields/ReleaseDetailsCustomField.php` in GitLab: // dirty manual query of the custom f... [21:17:36] (03PS1) 10Jbond: operations-puppet-catalog-compiler: add support for GERRIT_PRIVATE_CHANGE_NUMBER [integration/config] - 10https://gerrit.wikimedia.org/r/937532 (https://phabricator.wikimedia.org/T265633) [21:19:27] taavi: I've pushed fixes for both issues, I believe they should work but I'm unable to test them locally because the CentralAuth setup I have on this machine is incomplete/not working [21:19:45] thanks! looking [21:24:15] And the cool thing is, if my fixes do work, then CentralAuth **really** wasn't at fault [21:29:17] Daimona: not sure if caused by your patch or not, but when I had InstantCommons enabled I was getting these errors: https://phabricator.wikimedia.org/P49558 [21:30:04] 10Project-Admins: Create project tag for JWTAuth - https://phabricator.wikimedia.org/T341537 (10Aklapper) 05Open→03Resolved a:03Aklapper Requested public project #JWTAuth has been created: https://phabricator.wikimedia.org/project/view/6646/ (In case you need to edit the project or project workboard itsel... [21:32:32] I get that on master too, and even when using phpunit.php [21:32:45] If InstantCommons is enabled, that is [21:33:44] I think it's just an overarching issue in ApiStructureTest, which assumes that modules won't do anything weird when listing parameters etc., but they can in fact do all sorts of things there [21:33:49] Daimona: +2'd both of your patches, since they seem to be working as expected. the tests still fail for me, but that's expected as I don't have the magic jenkins variable enabled and I temporarily commented out the CA database config from my LS. and it's a test failure and not a data provider failure [21:33:57] 10GitLab: Enable GitLab's support for OAuth application integrations - https://phabricator.wikimedia.org/T341738 (10bd808) [21:34:33] Setting the jenkins variable to true in your local is a game changer when you get unexplicable failures [21:34:37] Related: https://bash.toolforge.org/quip/AWZYhzBIfM03vZ1oSYM9 [21:35:48] for a bit I was confused to why the tests were still passing, but that was solved by commenting out my `$wgCentralAuthDatabase` setting [21:38:02] Filed https://phabricator.wikimedia.org/T341739 for the new failure [21:40:51] 10Phabricator, 10Release-Engineering-Team, 10User-brennen: Temporarily replace the Phabricator logo for Pride Month - https://phabricator.wikimedia.org/T337964 (10brennen) 05In progress→03Resolved [22:06:03] 10GitLab (Account Approval): Requesting GitLab account activation for bennylin - https://phabricator.wikimedia.org/T341423 (10brennen) 05Open→03Resolved a:03brennen [22:22:25] (03PS2) 10Jbond: operations-puppet-catalog-compiler: add support for GERRIT_PRIVATE_CHANGE_NUMBER [integration/config] - 10https://gerrit.wikimedia.org/r/937532 (https://phabricator.wikimedia.org/T265633) [22:23:38] (03CR) 10CI reject: [V: 04-1] operations-puppet-catalog-compiler: add support for GERRIT_PRIVATE_CHANGE_NUMBER [integration/config] - 10https://gerrit.wikimedia.org/r/937532 (https://phabricator.wikimedia.org/T265633) (owner: 10Jbond) [22:25:02] (03PS3) 10Jbond: operations-puppet-catalog-compiler: add support for GERRIT_PRIVATE_CHANGE_NUMBER [integration/config] - 10https://gerrit.wikimedia.org/r/937532 (https://phabricator.wikimedia.org/T265633) [22:37:16] Daimona: Seems that global is depecated in favour of getenv('MW_QUIBBLE_CI'). If we switch usage, we can remove that hack from core :) [22:37:47] there is also a php-defined constant, but that seems fragile as it doesnt' work before setup and won't work in composer phpunit [22:37:49] Ohhh that would help, yes! [22:38:06] (LocalSettings.php-defined) [22:42:22] My biggest question now is how to handle loading extensions in the unit tests config file [22:42:40] To avoid https://phabricator.wikimedia.org/T90875#7990627 [22:43:28] I think I might have to monkeypatch some config loading code, include Setup and LocalSettings, but then discard everything but the list of extensions to load. I'm not even sure if it's possible tho [23:20:23] 10Release-Engineering-Team (Radar), 10SRE, 10SRE-Access-Requests: Requesting access to release-engineering for aklapper - https://phabricator.wikimedia.org/T341749 (10thcipriani)