[03:50:27] paladox: I have just realized it happens on a change from year 2016 :D [03:51:28] and that is https://phabricator.wikimedia.org/T328484 [04:05:35] (03PS3) 10Hashar: wm-checks-api: check undefined real_author [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/938318 (https://phabricator.wikimedia.org/T328484) (owner: 10Paladox) [04:07:16] (03CR) 10Hashar: [C: 03+2] "Thank you Paladox, that got noticed by Timo as well on T328484 and only happens on old changes. I have slightly amended the commit messag" [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/938318 (https://phabricator.wikimedia.org/T328484) (owner: 10Paladox) [04:07:48] (03Merged) 10jenkins-bot: wm-checks-api: check undefined real_author [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/938318 (https://phabricator.wikimedia.org/T328484) (owner: 10Paladox) [04:30:40] (03PS1) 10Hashar: wm-checks-api: check undefined real_author (2) [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/938472 (https://phabricator.wikimedia.org/T328484) [04:32:07] (03CR) 10Hashar: [C: 03+2] wm-checks-api: check undefined real_author (2) [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/938472 (https://phabricator.wikimedia.org/T328484) (owner: 10Hashar) [04:32:37] (03Merged) 10jenkins-bot: wm-checks-api: check undefined real_author (2) [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/938472 (https://phabricator.wikimedia.org/T328484) (owner: 10Hashar) [04:34:40] 10Gerrit, 10Patch-For-Review: [wm-checks-api] error: changeMessage.real_author is undefined - https://phabricator.wikimedia.org/T328484 (10hashar) 05Open→03Resolved a:05hashar→03Paladox [05:00:47] 10Phabricator, 10DBA, 10Data-Persistence-Backup, 10collaboration-services, 10Patch-For-Review: phabricator->phorge migration - database handling - https://phabricator.wikimedia.org/T335080 (10Marostegui) Done. And for what is worth, these are the coordinates where I reseted it: ` root@db1118.eqiad.wmnet[... [05:56:49] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/HTMLTemplates] Add tests [integration/config] - 10https://gerrit.wikimedia.org/r/938408 (owner: 10Umherirrender) [05:56:50] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/ImageMapEdit] Add tests [integration/config] - 10https://gerrit.wikimedia.org/r/938409 (owner: 10Umherirrender) [05:56:53] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/WarnNotRecentlyUpdated] Add tests [integration/config] - 10https://gerrit.wikimedia.org/r/938410 (owner: 10Umherirrender) [05:57:26] 10Phabricator (Upstream), 10Browser-Support-Internet-Explorer, 10TestMe, 10Upstream: Upper horizontal scrollbar of the Workboard pages acting funny in Internet Explorer - https://phabricator.wikimedia.org/T190597 (10gh87) This task is IE-related, and IE is no longer supported. You can close this as invalid... [05:58:01] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/HTMLTemplates] Add tests [integration/config] - 10https://gerrit.wikimedia.org/r/938408 (owner: 10Umherirrender) [05:58:04] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/ImageMapEdit] Add tests [integration/config] - 10https://gerrit.wikimedia.org/r/938409 (owner: 10Umherirrender) [05:58:06] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/WarnNotRecentlyUpdated] Add tests [integration/config] - 10https://gerrit.wikimedia.org/r/938410 (owner: 10Umherirrender) [05:58:40] !log Reloaded Zuul to enable CI on HTMLTemplates, ImageMapEdit and WarnNotRecentlyUpdated MediaWiki extensions [05:58:41] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:51:14] 10Project-Admins: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10Maryann-Onyinye) Hi, Technical Community Programs manager in PMO and need to keep creating projects for Developer Outreach Programs (Hackathons, CTA etc). Could you please add me? Th... [08:23:59] 10GitLab (Auth & Access), 10Release-Engineering-Team (They Live 🕶️🧟), 10CAS-SSO, 10Infrastructure-Foundations, and 4 others: migrate gitlab away from the CAS protocol - https://phabricator.wikimedia.org/T320390 (10Jelto) Last Friday we've done some troubleshooting and tested a lot of different configuratio... [08:49:02] 10Phabricator (Upstream), 10Upstream: Scrolling a Workboard page in various browsers - https://phabricator.wikimedia.org/T190604 (10Aklapper) [08:49:04] 10Phabricator (Upstream), 10Browser-Support-Internet-Explorer, 10TestMe, 10Upstream: Upper horizontal scrollbar of the Workboard pages acting funny in Internet Explorer - https://phabricator.wikimedia.org/T190597 (10Aklapper) 05Stalled→03Declined Thanks for the additional info. I'm going to decline thi... [08:49:38] 10Phabricator (Upstream), 10Upstream: Scrolling a Workboard page in various browsers - https://phabricator.wikimedia.org/T190604 (10Aklapper) 05Stalled→03Resolved Closing per T190597#9018428 [08:53:16] 10Phabricator (Upstream), 10Upstream: Can't preview new titles and/or changes to task titles on the Phabricator - https://phabricator.wikimedia.org/T190610 (10Aklapper) 05Open→03Declined Boldly declining this request as I have not seen others expressing their surprise or confusion about custom markup not w... [09:01:57] 10Phabricator: Phab feature request: When tagging tasks from one board to another, automatically restore tasks to the same columns - https://phabricator.wikimedia.org/T253897 (10Aklapper) I guess implementing this would require changes in `src/applications/maniphest/storage/ManiphestTransaction.php` when `case M... [09:08:51] 10Phabricator: Uninstall Drydock (Phabricator application) - https://phabricator.wikimedia.org/T337308 (10Aklapper) [09:15:10] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥): Uninstall Drydock (Phabricator application) - https://phabricator.wikimedia.org/T337308 (10Aklapper) Adding #Release-Engineering-Team per the application's funny config settings (I just changed "Can Use Application", "Default Blueprint Edit Policy... [09:26:33] (03PS1) 10Pwangai: Zuul: [mediawiki/extensions/Scribunto] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938808 (https://phabricator.wikimedia.org/T321837) [09:31:01] (03PS1) 10Pwangai: Zuul: [mediawiki/extensions/SecureLinkFixer] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938809 (https://phabricator.wikimedia.org/T321837) [09:37:38] (03PS1) 10Pwangai: Zuul: [mediawiki/extensions/CodeEditor] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938811 (https://phabricator.wikimedia.org/T321837) [09:39:11] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/CodeEditor] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938811 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [09:39:16] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/Scribunto] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938808 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [09:39:25] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/SecureLinkFixer] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938809 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [09:40:22] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/CodeEditor] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938811 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [09:40:28] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/Scribunto] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938808 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [09:40:30] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/SecureLinkFixer] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938809 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [09:41:06] !log Reloaded Zuul to enable codehealth on MediaWiki extensions CodeEditor, Scribunto and SecureLinkFixer | T321837 [09:41:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:41:08] T321837: Repositories integrated into Codehealth Pipeline (Production) - https://phabricator.wikimedia.org/T321837 [09:46:35] (03PS1) 10Pwangai: Zuul: [mediawiki/extensions/ImageMap] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938813 (https://phabricator.wikimedia.org/T321837) [09:53:06] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/ImageMap] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938813 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [09:54:10] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/ImageMap] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/938813 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [09:55:01] !log Reloaded Zuul to enable codehealth on MediaWiki extension ImageMap | T321837 [09:55:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:55:03] T321837: Repositories integrated into Codehealth Pipeline (Production) - https://phabricator.wikimedia.org/T321837 [09:56:33] andre: good morning, are you seeking a review/approval of some sort to uninstall the Phabricator Drydock application? [09:58:04] looking at https://phabricator.wikimedia.org/drydock/blueprint/ the few creates dates from 2016 and looks related to Phabricator Harbormaster CI system [09:58:11] hashar: hej hej! I think a "RelEng has not used this for years so let's uninstall it and reduce complexity" confirmation comment is what I'm looking for [09:58:35] I mean I'm 99% sure but RelEng folks may offer that missing 1% [09:58:50] 100% sure I will +1 on the task with some historical perspective :] [09:58:56] heh, TIA [10:05:49] +1 ed [10:05:59] thank you for cleaning up obsolete apps [10:06:10] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥): Uninstall Drydock (Phabricator application) - https://phabricator.wikimedia.org/T337308 (10hashar) I don't know what Drydock is about, but it looks like a way to define a job unit which is then triggered by Harbormaster (the scheduler/CI system).... [10:06:28] there are also a bunch of credentials we can probably clear out ( https://phabricator.wikimedia.org/passphrase/ ) [10:09:43] hashar: uhm very true (I disabled/destroyed some obviously useless credentials 6weeks ago but there's likely more). Want to create a ticket, or shall I? [10:10:07] andre: please do :] [10:10:21] alright [10:10:22] and I guess as a security task, there is at least one that look suspicious [10:10:35] and I think there is at least one I should rotate :] [10:10:56] k k [10:11:05] unrelated: Also, wikibugs did not notify here about my https://phabricator.wikimedia.org/T307492#9018880 (my patch landed upstream). Meh! :P [10:12:22] yeah bots are sometime off [10:12:32] I am waiting for either systemd or ChatGPT to take over the world [10:14:44] You are not a member of the group tools.wikibugs. [10:14:45] :) [10:15:59] heh [11:05:31] 10GitLab: ignoring extra bitmap file warning when fetching from gitlab - https://phabricator.wikimedia.org/T341712 (10hashar) > Are we running a version in which the bug is solved? There is a comment from May 2020 (which is from before we have setup Gitlab) which seems to indicate [[ https://gitlab.com/gitlab-... [12:57:39] 10GitLab (Auth & Access), 10Release-Engineering-Team (They Live 🕶️🧟), 10CAS-SSO, 10Infrastructure-Foundations, and 4 others: migrate gitlab away from the CAS protocol - https://phabricator.wikimedia.org/T320390 (10Jelto) As requested, @jbond your two users on the replica and production dumped via API (`cur... [13:10:24] 10GitLab (Auth & Access), 10Release-Engineering-Team (They Live 🕶️🧟), 10CAS-SSO, 10Infrastructure-Foundations, and 4 others: migrate gitlab away from the CAS protocol - https://phabricator.wikimedia.org/T320390 (10jbond) I did some more testing today and can confirm that the required config is `cas.authn.o... [13:31:50] 10GitLab (Auth & Access), 10Release-Engineering-Team (They Live 🕶️🧟), 10CAS-SSO, 10Infrastructure-Foundations, and 4 others: migrate gitlab away from the CAS protocol - https://phabricator.wikimedia.org/T320390 (10jbond) > from our side we will need to check if cas.authn.oidc.id-token.include-id-token-clai... [13:32:11] 10Release-Engineering-Team (Radar), 10SRE, 10SRE-Access-Requests: Requesting access to release-engineering for aklapper - https://phabricator.wikimedia.org/T341749 (10Aklapper) > Feel free to try ssh to these hosts now. phab1004.eqiad.wmnet is prod phab, phab-test1001.eqiad.wmnet is the test machine, phab200... [13:37:17] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10LSobanski) [13:42:10] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10LSobanski) >>! In T341468#9009202, @jbond wrote: >> operations/debs > This is also a folder with many repos below it Thanks for pointing this out, I created {T341991} [13:48:49] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - https://phabricator.wikimedia.org/T341468 (10BTullis) Did you mean to exclude the following? * `operations/dns` * `operations/docker-images` and its children * `operations/dumps` and its children [13:54:53] 10GitLab (Auth & Access), 10Release-Engineering-Team (They Live 🕶️🧟), 10CAS-SSO, 10Infrastructure-Foundations, and 4 others: migrate gitlab away from the CAS protocol - https://phabricator.wikimedia.org/T320390 (10Jelto) Thanks for troubleshooting this more! I can confirm existing users have `cas3` in the... [14:17:41] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - operations/debs - https://phabricator.wikimedia.org/T341991 (10Aklapper) [14:39:41] 10GitLab (Infrastructure), 10collaboration-services, 10Patch-For-Review: GitLabCIPipelineErrors (tweak thresholds of new alert) - https://phabricator.wikimedia.org/T341927 (10Jelto) @LSobanski thanks for fixing the alert description! This is a new alert and we have to find the correct thresholds and include... [15:05:33] 10Release-Engineering-Team, 10Scap, 10MW-on-K8s, 10Patch-For-Review: Inform deployers of mw-debug deployment - https://phabricator.wikimedia.org/T341798 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/162 Mention k8s mw-debug deployment if --pause-after-tests... [15:13:27] 10GitLab (Project Migration), 10collaboration-services: Migrate SRE repositories to GitLab - operations/debs - https://phabricator.wikimedia.org/T341991 (10LSobanski) p:05Triage→03Medium [15:15:53] 10Phabricator, 10Release-Engineering-Team (They Live 🕶️🧟), 10Wikimedia-Phabricator-Extensions, 10PHP 7.4 support: Exception in PhutilMediaWikiAuthAdapter.php due to array offset access with curly braces - https://phabricator.wikimedia.org/T342007 (10Aklapper) p:05Triage→03Medium [15:19:41] 10Release-Engineering-Team, 10Scap, 10MW-on-K8s: Scap Mediawiki K8s deployments - https://phabricator.wikimedia.org/T318536 (10dancy) [15:19:43] 10Release-Engineering-Team, 10Scap, 10MW-on-K8s: Inform deployers of mw-debug deployment - https://phabricator.wikimedia.org/T341798 (10dancy) 05Open→03Resolved a:03dancy Scap 4.54.0 deployed. [15:19:45] 10Phabricator, 10Release-Engineering-Team (They Live 🕶️🧟), 10Wikimedia-Phabricator-Extensions, 10PHP 7.4 support, 10Patch-For-Review: Exception in PhutilMediaWikiAuthAdapter.php due to array offset access with curly braces - https://phabricator.wikimedia.org/T342007 (10CodeReviewBot) aklapper opened http... [15:21:07] 10GitLab (Infrastructure), 10collaboration-services: Let's Encrypt certificate expiration notice for domain gitlab.devtools.wmcloud.org - https://phabricator.wikimedia.org/T335161 (10LSobanski) a:05Jelto→03None [15:37:54] 10Continuous-Integration-Infrastructure: Add Python 3.9 to Wikimedia CI - https://phabricator.wikimedia.org/T289222 (10Xqt) 05Open→03Resolved [15:40:18] 10Release-Engineering-Team (Radar), 10Infrastructure-Foundations, 10Puppet CI, 10SRE, 10Puppet: Integrate the puppet compiler in the puppet CI pipeline - https://phabricator.wikimedia.org/T166066 (10jbond) [15:41:40] 10Release-Engineering-Team (Radar), 10Infrastructure-Foundations, 10Puppet CI, 10SRE, 10Puppet: Integrate the puppet compiler in the puppet CI pipeline - https://phabricator.wikimedia.org/T166066 (10jbond) 05Open→03Resolved a:03jbond im going to close this, I think with the `auto` keyword this is c... [15:47:20] 10Continuous-Integration-Config, 10Release-Engineering-Team (Seen): Upgrade all CI jobs for WMF-deployed projects from Node 12 to Node 14 LTS - https://phabricator.wikimedia.org/T267890 (10zeljkofilipin) [16:05:13] 10Phabricator (Upstream), 10Upstream: Some task notifications include a @mention entry in the X-Phabricator-Stamps mail header for no obvious reason - https://phabricator.wikimedia.org/T266328 (10Aklapper) [16:09:34] 10Continuous-Integration-Infrastructure: Add Python 3.10 to Wikimedia CI - https://phabricator.wikimedia.org/T342019 (10Xqt) [16:10:30] 10Continuous-Integration-Infrastructure: Add Python 3.10 to Wikimedia CI - https://phabricator.wikimedia.org/T342019 (10Xqt) [16:19:16] bd808 and/or dduvall, It's time for my first naive docker question of the day! In my build log at https://phabricator.wikimedia.org/P49566 you can see a step towards the end "#19 0.387 + touch /opt/lib/python/site-packages/KillroyWasHere." My question is: should I not then expect that file to be present in containers based on that image? Because when I shell into the container I can't find any evidence that installpanels.sh has [16:19:16] done anything at all. [16:20:01] 10Diffusion, 10Phabricator (Upstream), 10Upstream: Commits in a repository mirrored on Diffusion update unrelated tasks - https://phabricator.wikimedia.org/T260405 (10Aklapper) p:05Triage→03Low [16:20:15] (I thought I was beyond the 'establish basic cause and effect' part of this process but apparently not) [16:21:54] andrewbogott: are you explicitly copying /opt/lib/python/site-packages/* from the prep container to the production container? [16:22:11] I only see /srv/app being copied in that output [16:22:49] ok, that's probably what I'm missing! [16:23:02] * andrewbogott wonders how the striker build ever workd [16:23:27] so I just need to add... [16:23:30] https://www.irccloud.com/pastebin/Sm6N7swL/ [16:25:16] I'm not sure I would grab that much, but yeah. Striker does it's pip installs in the 'base-python' variant that is extended by the 'production' variant, so that's how it gets its python packages. [16:29:42] 10GitLab (Project Migration), 10Release-Engineering-Team (Priority Backlog 📥), 10API Platform, 10Anti-Harassment, and 19 others: Migrate PipelineLib repos to GitLab - https://phabricator.wikimedia.org/T332953 (10TBurmeister) [18:27:36] Can anyone remember the magic incantation to make new Beta Cluster (deployment-prep) nodes come up with the puppet master so I can shell into them? I've added deployment-docker-wikifunctions02.deployment-prep.eqiad1.wikimedia.cloud but it's refusing ssh. [18:29:00] James_F: I think this is what you want: https://wikitech.wikimedia.org/wiki/Help:Standalone_puppetmaster#Step_2:_Setup_a_puppet_client [18:29:26] andrewbogott: Yeah, sadly I'm stuck at step 2 (I did step 1 as normal). [18:30:12] ok, so you remove those files, then you run puppet and it says something or other about requesting a key, right? [18:30:29] I can't remove a file when I can't ssh in. [18:30:37] $ ssh deployment-docker-wikifunctions02.deployment-prep.eqiad1.wikimedia.cloud [18:30:37] Connection closed by UNKNOWN port 65535 [18:31:17] Maybe I should un-set the puppetmaster first, then re-set it? [18:31:36] that would be the easiest. I think something unusual is happening with that VM though. [18:31:50] Will give that a try. [18:31:58] It's a headache but the easiest way forward is to unset puppetmaster and recreate that VM [18:32:27] bd808: next easy one, would you expect the mount in this to work? [18:32:27] docker run -p 8080:8080 c4bc190f51bc --mount type=bind,source="/etc/openstack_dashboard/local_settings.py",target="/opt/lib/python/site-packages/openstack_dashboard/local/local_settings.py",readonly [18:32:45] andrewbogott: Ack. Thank you! [18:38:37] (03PS1) 10Umherirrender: Zuul: [mediawiki/extensions/HeaderFooter] Add tests [integration/config] - 10https://gerrit.wikimedia.org/r/938914 [19:01:58] andrewbogott: OK, I'm now fully in with the custom puppetmaster, but getting a puppet failure on run, but it's apparently also there for all docker::runner boxes (or at least the few I tried). Should I file a Phab task? [19:03:55] James_F: yes, although I'm not sure exactly who to assign it to. This is likely to fall into the 'no one is in responsible for deployment-prep' hole. [19:04:01] Ack. :-( [19:05:58] 10Beta-Cluster-Infrastructure, 10Puppet: Puppet failure on Beta Cluster role::beta::docker_services boxes - https://phabricator.wikimedia.org/T342038 (10Jdforrester-WMF) [19:06:31] 10Beta-Cluster-Infrastructure, 10Puppet: Puppet failure on Beta Cluster role::beta::docker_services boxes - https://phabricator.wikimedia.org/T342038 (10Jdforrester-WMF) [19:33:19] 10Release-Engineering-Team (Priority Backlog 📥), 10Security-Team: Determine a better way to track Wikimedia production security patches - https://phabricator.wikimedia.org/T295925 (10thcipriani) Circling back to this since we've had three trains fail in a row with security patch issues. What if we agreed on t... [19:38:51] 10Phabricator, 10Wikimedia-Phabricator-Extensions: Remove custom src/customfields/DifferentialApplyPatchWithOnlyGitField.php - https://phabricator.wikimedia.org/T342041 (10Aklapper) 05Open→03Stalled p:05Triage→03Low [19:39:19] 10Phabricator, 10Wikimedia-Phabricator-Extensions: Remove custom src/customfields/DifferentialApplyPatchWithOnlyGitField.php - https://phabricator.wikimedia.org/T342041 (10Aklapper) [19:39:21] 10Phabricator: Uninstall Differential (Phabricator application) - https://phabricator.wikimedia.org/T330797 (10Aklapper) [20:04:14] 10Release-Engineering-Team (Priority Backlog 📥), 10Security-Team: Determine a better way to track Wikimedia production security patches - https://phabricator.wikimedia.org/T295925 (10sbassett) >>! In T295925#9021230, @thcipriani wrote: > Proposal for when to skip applying a security patch: > 1. No `Bug` traile... [20:28:36] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (They Live 🕶️🧟), 10Patch-For-Review: buildkitd: Require use of the blubber frontend when running on trusted runners. - https://phabricator.wikimedia.org/T329220 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/buildkit/-/merge_re... [20:42:16] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (They Live 🕶️🧟), 10Patch-For-Review: buildkitd: Require use of the blubber frontend when running on trusted runners. - https://phabricator.wikimedia.org/T329220 (10CodeReviewBot) dancy opened https://gitlab.wikimedia.org/repos/releng/gitlab-cloud-runner... [20:42:32] 10GitLab (CI & Job Runners), 10Release-Engineering-Team (They Live 🕶️🧟), 10Patch-For-Review: buildkitd: Require use of the blubber frontend when running on trusted runners. - https://phabricator.wikimedia.org/T329220 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/gitlab-cloud-runner... [21:34:39] !log Deployed patch for T340221 [21:34:40] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:50:10] 10Continuous-Integration-Config, 10Moderator-Tools-Team, 10PageTriage, 10Growth-Team (Current Sprint): Add PageTriage to gated extensions - https://phabricator.wikimedia.org/T333534 (10Novem_Linguae) Looks like ResourcesTest::testMissingMessages is a test in core. https://gerrit.wikimedia.org/g/mediawiki/... [21:52:56] 10Continuous-Integration-Config, 10Moderator-Tools-Team, 10PageTriage, 10Growth-Team (Current Sprint): Add PageTriage to gated extensions - https://phabricator.wikimedia.org/T333534 (10taavi) Ideally the core test would pass without WikiLove installed, since it's now only an optional dependency. A short-te... [21:57:46] 10Continuous-Integration-Config, 10Growth-Team, 10WikiLove: Add WikiLove to gated extensions - https://phabricator.wikimedia.org/T342062 (10Novem_Linguae) [21:59:17] 10Continuous-Integration-Config, 10Moderator-Tools-Team, 10PageTriage, 10Growth-Team (Current Sprint): Add PageTriage to gated extensions - https://phabricator.wikimedia.org/T333534 (10Novem_Linguae) Sounds good to me. I created {T342062} to help get that process started. [22:42:26] Hey there, it looks like reviewers are not being added automatically to gerrit patches, despite being in Git/Reviewers. I had already noticed a few days ago but thought it might have been a one-off thing, but it looks like this is still the case. Anybody could confirm or suggest the tags to use for a bug report? [22:42:45] Oh and actually, https://gerrit-reviewer-bot.toolforge.org/ suggests that there are errors... [22:45:42] Looking more closely, it seems to be stuck on a patch for wikibugs2 where it couldn't find the account of a reviewer to add. I've removed the account from Git/Reviewers, let's see if this fixes it [22:48:07] Yay, it's working again now, and people are going to get notifications for who-knows-how-many changes submitted since the bot broke [22:48:44] thanks Daimona ! Happy you were able to rubber-duck fix it :) [22:49:18] Complaining about something in public is the best way to make you think of the obvious solution in the next 10 seconds :D [22:49:30] I'd still appreciate it if somebody knew how to tag the bug report I'm going to file [22:49:58] hrm, lemme see [22:52:19] doesn't look like folks in the past have been able to figure that out either: https://phabricator.wikimedia.org/T289712 https://phabricator.wikimedia.org/T267787 [22:53:06] I guess I'd say: tag "Developer Productivity" "Gerrit" mention "Gerrit Reviewer Bot" and maybe subscribe @valhallasw [22:53:47] 10Gerrit: gerrit-reviewer-bot got stuck due to non-existing account - https://phabricator.wikimedia.org/T342066 (10Daimona) [22:54:14] Done 3 out of 4 just before I saw your comment :D Let me add developer productivity as well [22:54:35] <3 [22:54:39] But yeah, thanks, I think adding valhallasw should get it to the right place [22:55:22] And apologies for flooding y'all's inboxes UwU [22:55:56] 10Gerrit, 10Developer Productivity: gerrit-reviewer-bot got stuck due to non-existing account - https://phabricator.wikimedia.org/T342066 (10Daimona) [22:56:31] Which I'm going to do again because it found another non-existing account, it seems [22:56:37] weee [22:59:29] 10Gerrit, 10Developer Productivity: gerrit-reviewer-bot got stuck due to non-existing account - https://phabricator.wikimedia.org/T342066 (10Daimona) And speaking of non-existing accounts, it looks like the bot should also trim the usernames, because it just failed on another one which had spaces around it ([[... [23:06:46] Should be all good now