[06:51:32] (03CR) 10Noa wmde: "I was struggling with exactly this yesterday, as I originally assumed the scripts are almost the same for both repositories, which is obvi" [integration/config] - 10https://gerrit.wikimedia.org/r/961109 (owner: 10Hashar) [07:59:32] 10Release-Engineering-Team (Deployment-Blockers), 10Reference Previews, 10WMDE-TechWish, 10Patch-For-Review, 10WMDE-TechWish-Maintenance-2023: ReferencePreviews: Final round of manual tests before full rollout - https://phabricator.wikimedia.org/T345833 (10thiemowmde) [09:08:00] 10GitLab (Pipeline Services Migration🐀), 10Metrics Platform Backlog, 10Data Products (Sprint 01), 10Patch-For-Review: Migrate metrics-platform repo to GitLab - https://phabricator.wikimedia.org/T344733 (10phuedx) [09:24:38] 10Release-Engineering-Team (Deployment-Blockers), 10Reference Previews, 10WMDE-TechWish, 10Patch-For-Review, 10WMDE-TechWish-Maintenance-2023: ReferencePreviews: Final round of manual tests before full rollout - https://phabricator.wikimedia.org/T345833 (10WMDE-Fisch) a:05WMDE-Fischβ†’03None [10:08:49] 10GitLab (Project Migration), 10Release-Engineering-Team: Create new GitLab project group: Growth - https://phabricator.wikimedia.org/T347467 (10Urbanecm_WMF) [10:25:17] 10GitLab, 10Release-Engineering-Team: Cannot access my gitlab account - https://phabricator.wikimedia.org/T347470 (10MarcoAurelio) [10:27:28] 10GitLab (Account Approval), 10Release-Engineering-Team (Priority Backlog πŸ“₯): Requesting GitLab account activation for MarcoAurelio - https://phabricator.wikimedia.org/T347294 (10MarcoAurelio) >>! In T347294#9201651, @dancy wrote: > I deleted the `maurelio1` gitlab account. Thanks @dancy. Unfortunately the s... [11:36:00] 10Diffusion, 10Phabricator, 10Release-Engineering-Team (Priority Backlog πŸ“₯): Set diffusion.allow-http-auth to false - https://phabricator.wikimedia.org/T347476 (10Aklapper) p:05Triageβ†’03Low [11:49:10] 10Diffusion, 10Phabricator, 10Release-Engineering-Team (Priority Backlog πŸ“₯): Set security.require-https to true - https://phabricator.wikimedia.org/T347476 (10Aklapper) [11:50:11] 10Diffusion, 10Phabricator, 10Release-Engineering-Team (Priority Backlog πŸ“₯): Set security.require-https to true - https://phabricator.wikimedia.org/T347476 (10Aklapper) **Edit:** Looks like I was completely wrong per https://we.phorge.it/book/phorge/article/diffusion_uris/ - `http` would still be offered aft... [12:12:21] 10Diffusion, 10Phabricator: Set new Diffusion repos URIs to No I/O by default - https://phabricator.wikimedia.org/T224753 (10Aklapper) p:05Mediumβ†’03Low If it is/was just about the order of dropdown items (and the pre-selected first dropdown item) when creating a new repo URI, these are defined in `getAvail... [12:12:38] 10Diffusion, 10Phabricator: Improve Diffusion URIs behaviour - https://phabricator.wikimedia.org/T244903 (10Aklapper) [12:15:29] 10Release-Engineering-Team (Deployment-Blockers), 10Reference Previews, 10WMDE-TechWish, 10Patch-For-Review, 10WMDE-TechWish-Maintenance-2023: ReferencePreviews: Final round of manual tests before full rollout - https://phabricator.wikimedia.org/T345833 (10Tobi_WMDE_SW) [12:19:25] 10Phabricator: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php - https://phabricator.wikimedia.org/T347483 (10Aklapper) p:05Triageβ†’03Low [12:37:33] 10Phabricator, 10Patch-For-Review: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php - https://phabricator.wikimedia.org/T347483 (10CodeReviewBot) aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/17 Add tem... [12:47:20] 10GitLab (CI & Job Runners), 10collaboration-services, 10serviceops: Create a staging apt repository for CI-based builds of Debian packages - https://phabricator.wikimedia.org/T347004 (10LSobanski) p:05Triageβ†’03High [12:58:50] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Migrate internal traffic to k8s - https://phabricator.wikimedia.org/T333120 (10Jdforrester-WMF) [12:59:24] 10Release-Engineering-Team (Seen), 10Abstract Wikipedia team, 10MW-on-K8s, 10SRE, and 4 others: Migrate functions-orchestrator service to mw-api-int - https://phabricator.wikimedia.org/T347397 (10Jdforrester-WMF) 05Openβ†’03In progress [13:01:08] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Zuul: Replace zuul-gearman.py by gearman-tools Debian package - https://phabricator.wikimedia.org/T339172 (10hashar) 05Openβ†’03Resolved ` name=puppet.log Sep 26 16:13:27 contint2002 puppet-agent[19375]: (/Stage[main]/Zuul::Server/File[... [13:07:30] 10GitLab (Infrastructure), 10Release-Engineering-Team (Radar), 10collaboration-services, 10User-brennen: Switchover gitlab-replica (gitlab2002 -> gitlab1003) - September 2023 - https://phabricator.wikimedia.org/T345590 (10LSobanski) [13:10:05] 10GitLab (Infrastructure), 10collaboration-services: Switchover gitlab (gitlab1004 -> gitlab2002) - September 2023 - https://phabricator.wikimedia.org/T345531 (10LSobanski) [13:11:11] 10GitLab (Infrastructure), 10Release-Engineering-Team (Radar), 10collaboration-services, 10User-brennen: Switchover gitlab-replica (gitlab2002 -> gitlab1003) - September 2023 - https://phabricator.wikimedia.org/T345590 (10LSobanski) [13:26:48] 10GitLab (Account Approval), 10Release-Engineering-Team: Requesting GitLab account activation for HakanIST - https://phabricator.wikimedia.org/T347489 (10Urbanecm) [13:27:18] 10GitLab (Account Approval), 10Release-Engineering-Team: Requesting GitLab account activation for HakanIST - https://phabricator.wikimedia.org/T347489 (10Urbanecm) By filling this task, I confirm https://ldap.toolforge.org/user/h2o belongs to @HakanIST, a Wikimedia Steward. Thanks! [13:30:16] Project beta-update-databases-eqiad build #70542: 04FAILURE in 10 min: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/70542/ [13:32:42] 10Release-Engineering-Team (Seen), 10Abstract Wikipedia team, 10MW-on-K8s, 10SRE, and 4 others: Migrate functions-orchestrator service to mw-api-int - https://phabricator.wikimedia.org/T347397 (10JMeybohm) a:03JMeybohm It took me a while to figure this out, sorry. Due to wikifunctions having more strict... [13:33:50] (03PS1) 10Driedmueller: Added integration config for BlueSpiceInterWikiSearch, VisualEditorPlus, SimpleTasks, AtMentions, DateTimeTools and SubnetCalc [integration/config] - 10https://gerrit.wikimedia.org/r/961392 [13:35:06] (03CR) 10CI reject: [V: 04-1] Added integration config for BlueSpiceInterWikiSearch, VisualEditorPlus, SimpleTasks, AtMentions, DateTimeTools and SubnetCalc [integration/config] - 10https://gerrit.wikimedia.org/r/961392 (owner: 10Driedmueller) [13:59:00] 10GitLab (Project Migration), 10Release-Engineering-Team: Create new GitLab project group: Growth - https://phabricator.wikimedia.org/T347467 (10Urbanecm_WMF) It seems I'll be able to self-service that once this is completed, but I'd like https://gitlab.wikimedia.org/urbanecm/community-configuration/ to be mov... [14:30:13] Yippee, build fixed! [14:30:13] Project beta-update-databases-eqiad build #70543: 09FIXED in 10 min: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/70543/ [14:38:44] 10Release-Engineering-Team, 10Scap, 10MW-on-K8s: Inform deployers of mw-debug deployment - https://phabricator.wikimedia.org/T341798 (10CodeReviewBot) dancy updated https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/177 scap: shorten 'synced to testservers' message [14:43:11] 10Release-Engineering-Team, 10Scap, 10MW-on-K8s: Inform deployers of mw-debug deployment - https://phabricator.wikimedia.org/T341798 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/177 scap: shorten 'synced to testservers' message [15:05:00] 10Release-Engineering-Team (Seen), 10MW-on-K8s, 10SRE, 10Traffic, and 2 others: Migrate internal traffic to k8s - https://phabricator.wikimedia.org/T333120 (10JMeybohm) [15:05:31] 10Release-Engineering-Team (Seen), 10Abstract Wikipedia team, 10MW-on-K8s, 10SRE, and 4 others: Migrate functions-orchestrator service to mw-api-int - https://phabricator.wikimedia.org/T347397 (10JMeybohm) 05In progressβ†’03Resolved Direct access to mw-api is forbidden now. wikifunctions still working [15:20:20] 10GitLab, 10Release-Engineering-Team: Cannot access my gitlab account - https://phabricator.wikimedia.org/T347470 (10dancy) 05Openβ†’03Resolved a:03dancy I fixed things up by doing the following: * Deleting the `maurelio1` account again. * Changing the primary email address on the `maurelio` account to be... [15:21:04] 10GitLab (Account Approval), 10Release-Engineering-Team (Priority Backlog πŸ“₯): Requesting GitLab account activation for MarcoAurelio - https://phabricator.wikimedia.org/T347294 (10dancy) I fixed things up by doing the following: * Deleting the maurelio1 account again. * Changing the primary email address on th... [16:05:42] 10GitLab (Account Approval), 10Release-Engineering-Team: Requesting GitLab account activation for HakanIST - https://phabricator.wikimedia.org/T347489 (10brennen) 05Openβ†’03Resolved a:03brennen [16:10:01] 10Diffusion, 10Phabricator: Improve setting/changing Diffusion URIs (changing I/O Type when observing; mass-editing all URIs' settings) - https://phabricator.wikimedia.org/T244903 (10Aklapper) [16:11:59] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.28 deployment blockers - https://phabricator.wikimedia.org/T345889 (10Reedy) [16:30:43] 10Release-Engineering-Team (Radar), 10collaboration-services, 10User-brennen: Agree on GitLab settings management guidelines - https://phabricator.wikimedia.org/T347399 (10thcipriani) Moving to our radar at the moment, discussed in a sync meeting with collaboration services about where scripts should run. [16:34:31] 10Release-Engineering-Team (Priority Backlog πŸ“₯): Automatically handle manual release notes for MediaWiki - https://phabricator.wikimedia.org/T347207 (10thcipriani) p:05Triageβ†’03Low This task needs some thinking about the automation we currently have + what pages need to be created (and when they're expected... [16:35:42] 10Release-Engineering-Team: logspam-watch doesn’t handle normalized exceptions well - https://phabricator.wikimedia.org/T347064 (10thcipriani) 05Openβ†’03Resolved a:03dancy We've dealt with this particular log message. Closing this one out now. [16:37:26] 10Release-Engineering-Team, 10Quibble, 10wikimedia-irc-libera: Phase out #wikimedia-quibble IRC channel in favor of #wikimedia-releng - https://phabricator.wikimedia.org/T346901 (10thcipriani) p:05Triageβ†’03Low a:03hashar Sounds like we need to contact folks still in the channel + IRC operators to close... [16:37:39] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Quibble, 10wikimedia-irc-libera: Phase out #wikimedia-quibble IRC channel in favor of #wikimedia-releng - https://phabricator.wikimedia.org/T346901 (10thcipriani) [16:39:21] 10Release-Engineering-Team (Seen): Replace Go templates with Common Expression Language expressions in the JWT authorizer - https://phabricator.wikimedia.org/T346331 (10thcipriani) p:05Triageβ†’03Low a:05jnucheβ†’03None [16:41:33] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Priority Backlog πŸ“₯): Move castor instance to 4xiops disk flavor - https://phabricator.wikimedia.org/T345924 (10thcipriani) p:05Triageβ†’03Low [16:43:01] 10GitLab (Infrastructure), 10Release-Engineering-Team (Radar), 10collaboration-services, 10User-brennen: Switchover gitlab-replica (gitlab2002 -> gitlab1003) - September 2023 - https://phabricator.wikimedia.org/T345590 (10Jelto) The failover between the two replicas took 3 hours and 10 minutes. We discusse... [16:44:33] 10Release-Engineering-Team (Seen), 10serviceops: Rethinking Code Review and Deployment of MediaWiki - https://phabricator.wikimedia.org/T345670 (10thcipriani) 05Openβ†’03Stalled We'll need to talk about this with serviceops following the MediaWiki on Kubernetes migration, tagging for their visibility. And ma... [16:45:26] 10GitLab (Project Migration), 10Release-Engineering-Team (Priority Backlog πŸ“₯): Create new GitLab project group: Growth - https://phabricator.wikimedia.org/T347467 (10thcipriani) a:03brennen [16:47:48] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Priority Backlog πŸ“₯): Move castor instance to 4xiops disk flavor - https://phabricator.wikimedia.org/T345924 (10hashar) Also have to update the Jenkins job: ` jjb/castor-load-sync.bash:19:CASTOR_HOST="${CASTOR_HOST:-integration-castor03.integr... [16:52:23] 10GitLab (Auth & Access), 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10cloud-services-team, 10collaboration-services, 10User-brennen: Consider enforcing 2FA for GitLab users with maintainer/owner permissions - https://phabricator.wikimedia.org/T347295 (10thcipriani) Things to confirm: - Every indiv... [16:54:15] 10GitLab (Infrastructure), 10Release-Engineering-Team (Radar), 10collaboration-services: GitLab email confirmation mail ends up in spam folder - https://phabricator.wikimedia.org/T346607 (10thcipriani) [16:54:38] 10Diffusion, 10Phabricator, 10Release-Engineering-Team (Seen): Replace dead git-ssh.wikimedia.org service in diffusion.ssh-host setting - https://phabricator.wikimedia.org/T347408 (10thcipriani) [17:00:52] 10GitLab (Infrastructure), 10collaboration-services: Switchover gitlab (gitlab1004 -> gitlab2002) - September 2023 - https://phabricator.wikimedia.org/T345531 (10thcipriani) Aside from announcing in IRC, we should probably also announce on Wikitech. [17:02:53] 10GitLab (Infrastructure), 10collaboration-services: Switchover gitlab (gitlab1004 -> gitlab2002) - September 2023 - https://phabricator.wikimedia.org/T345531 (10Jelto) >>! In T345531#9204242, @thcipriani wrote: > Aside from announcing in IRC, we should probably also announce on Wikitech. Please note that we... [17:38:52] 10GitLab, 10Release-Engineering-Team: Cannot access my gitlab account - https://phabricator.wikimedia.org/T347470 (10MarcoAurelio) Thank you for your assistance, @dancy. It seems everything's working as expected now. [18:17:05] 10GitLab (Auth & Access), 10Release-Engineering-Team: Cannot access my gitlab account - https://phabricator.wikimedia.org/T347470 (10brennen) [19:31:40] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.28 deployment blockers - https://phabricator.wikimedia.org/T345889 (10JJMC89) [19:52:48] 10Gerrit, 10GitLab (Misc), 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Wikimedia-GitHub, 10User-brennen: A tool for displaying the canonical location of all Wikimedia repositories and any known mirrors - https://phabricator.wikimedia.org/T330347 (10brennen) p:05Triageβ†’03Medium a:03brennen [20:22:32] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.28 deployment blockers - https://phabricator.wikimedia.org/T345889 (10matmarex) [20:28:04] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Patch-For-Review, 10Release, 10Train Deployments: 1.41.0-wmf.28 deployment blockers - https://phabricator.wikimedia.org/T345889 (10matmarex) [21:00:36] (03CR) 10Jforrester: [C: 03+2] jjb: refactor node jobs to use job templates [integration/config] - 10https://gerrit.wikimedia.org/r/961118 (owner: 10Hashar) [21:02:31] (03Merged) 10jenkins-bot: jjb: refactor node jobs to use job templates [integration/config] - 10https://gerrit.wikimedia.org/r/961118 (owner: 10Hashar) [23:01:43] Is is just me or is SonarCloud not reporting any code coverage for master branches of all extensions? [23:02:31] CheckUser has unit tests that should be reported there but https://sonarcloud.io/component_measures?metric=Coverage&id=mediawiki-extensions-CheckUser shows no coverage [23:02:58] Same with mediawiki core at https://sonarcloud.io/component_measures?metric=Coverage&id=mediawiki-core [23:04:28] The reason I mention is that it is working on REL1_XX branches [23:04:48] But any patch to the master branches reports zero coverage [23:05:15] I raise this as it's slightly annoying me as I see it as an indicator that I need to write more unit tests for a patch