[00:14:59] Daimona: https://doc.wikimedia.org/cover/mediawiki-core/includes/libs/index.html shows jsminplus.php as uncovered, yet https://gerrit.wikimedia.org/g/mediawiki/core/+/HEAD/tests/phpunit/unit/includes/libs/JsMinPlusTest.php exists and runs non-zero code. Maybe something got lost in the refactors there? [00:15:42] Hmmmmm let me see [00:16:18] Daimona: ah... this is case sensitive isn't it? [00:16:22] Looks like it's just a typo [00:16:32] Which part of it? [00:16:39] JsMinPlus -> JSMinPlus [00:16:42] I mean, the @covers tag seems right? [00:16:50] Ohhhhh [00:17:19] And that's why I should always double-check things when it's late ;) [00:17:30] I think that might be it, yes. Has it ever worked though? [00:19:03] Also, the CoversValidator test passes, but it should fail if we're not actually generating coverage [00:19:30] (Note, that test is not using the CoversValidator trait atm, I had to add it locally) [00:24:48] Daimona: ah, but it did pass? [00:24:50] that's interesting. [00:25:03] Yup, it definitely passes even when adding CoversValidator [00:25:17] Let me quickly see if it generates coverage locally [00:25:17] | includes/libs/jsminplus.php | 00.00 | 20.61 | [00:25:22] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/962732 [00:25:54] sorry for the false alarm :) [00:26:10] Might still be a bug for CoversValidator if indeed this doesnt' work under current casing [00:26:33] Indeed, we still need to fix that! [00:27:01] ^I don't know about coverage, but it successfully freezes PHPStorm [00:27:53] So I guess, let me first find out the umpteenth stupid way I found to break my test environment [00:39:31] It doesn't seem to be generating coverage locally, but fixing the @covers tag doesn't change that [00:40:02] I still don't know if it's a genuine issue with the test or just the next issue with my local config I have to fix [00:44:16] It seems to be a genuine issue, actually. Coverage is correctly generated for other test files [00:44:34] But then how does it work in CI?! [00:48:48] Ooooooh I have it! The @covers is actually case-insensitive [00:49:05] It's the fact that the test does not perform assertions. It seems to suppress code coverage generation altogether [00:50:54] I could not find any documentation of this behaviour in https://docs.phpunit.de/en/9.6/code-coverage-analysis.html [00:51:35] In your patch r962732, you added those test cases to a test that actually performs assertions, and that's why you get coverage [01:02:20] 10Phabricator: Custom task form for EditCheck - https://phabricator.wikimedia.org/T347912 (10VPuffetMichel) [01:02:48] 10Phabricator: Custom task form for EditCheck - https://phabricator.wikimedia.org/T347912 (10VPuffetMichel) [02:47:02] 10WikimediaDebug, 10MW-on-K8s, 10observability: Excimer UI profile lost when requested from mw-on-k8s - https://phabricator.wikimedia.org/T347926 (10Krinkle) [07:25:36] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/skins/Nostalgia] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/962604 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [07:25:40] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/ProofreadPage] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/962605 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [07:25:43] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/TwoColConflict] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/962607 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [07:25:45] (03CR) 10Hashar: [C: 03+2] Zuul: [mediawiki/extensions/UrlShortener] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/962606 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [07:27:15] (03Merged) 10jenkins-bot: Zuul: [mediawiki/skins/Nostalgia] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/962604 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [07:27:17] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/ProofreadPage] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/962605 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [07:27:25] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/TwoColConflict] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/962607 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [07:27:27] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/UrlShortener] Enable Sonar Codehealth [integration/config] - 10https://gerrit.wikimedia.org/r/962606 (https://phabricator.wikimedia.org/T321837) (owner: 10Pwangai) [07:28:03] !log Reloaded Zuul to enable SonarQube on Nostalgia, ProofreadPage, TwoColConflict and UrlShortener # T321837 [07:28:06] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:28:07] T321837: Repositories integrated into Codehealth Pipeline (Production) - https://phabricator.wikimedia.org/T321837 [07:49:47] 10Project-Admins, 10MediaWiki-extensions-MediaSpoiler: Create project tag for Extension:MediaSpoiler - https://phabricator.wikimedia.org/T339270 (10Dringsim) @Aklapper How can I get #trusted-contributors permission? Thanks! [07:51:09] !log Reloaded Zuul to enable SonarQube on Nostalgia, ProofreadPage, TwoColConflict and UrlShortener # T321837 [07:51:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:51:12] T321837: Repositories integrated into Codehealth Pipeline (Production) - https://phabricator.wikimedia.org/T321837 [07:51:15] hmm [07:51:21] wrong keyboard sequence :D [07:51:40] (03CR) 10Hashar: "I will split this change in smaller independent one :)" [integration/config] - 10https://gerrit.wikimedia.org/r/961392 (owner: 10Driedmueller) [07:53:56] 10Phabricator, 10TestMe: Phorge logs me out if accessing a task via URL - https://phabricator.wikimedia.org/T347570 (10Aklapper) 05Openโ†’03Stalled [07:58:24] 10Diffusion: Allow search engines to crawl code hosted by phabricator - https://phabricator.wikimedia.org/T76992 (10Aklapper) 05Openโ†’03Declined [08:00:31] (03PS3) 10Hashar: zuul: add mediawiki/extensions/AtMentions [integration/config] - 10https://gerrit.wikimedia.org/r/961392 (owner: 10Driedmueller) [08:00:33] (03PS1) 10Hashar: zuul: add mediawiki/extensions/BlueSpiceInterwikiSearch [integration/config] - 10https://gerrit.wikimedia.org/r/962993 [08:00:35] (03PS1) 10Hashar: zuul: add mediawiki/extensions/DateTimeTools [integration/config] - 10https://gerrit.wikimedia.org/r/962994 [08:00:37] (03PS1) 10Hashar: zuul: add mediawiki/extensions/SimpleTasks [integration/config] - 10https://gerrit.wikimedia.org/r/962995 [08:00:39] (03PS1) 10Hashar: zuul: add mediawiki/extensions/SubnetCalc [integration/config] - 10https://gerrit.wikimedia.org/r/962996 [08:00:41] (03PS1) 10Hashar: zuul: add mediawiki/extensions/VisualEditorPlus [integration/config] - 10https://gerrit.wikimedia.org/r/962997 [08:07:20] 10GitLab (Infrastructure), 10collaboration-services: Switchover gitlab (gitlab1004 -> gitlab2002) - October 2023 - https://phabricator.wikimedia.org/T345531 (10eoghan) [08:11:18] (03CR) 10Hashar: [C: 03+2] zuul: add mediawiki/extensions/AtMentions (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/961392 (owner: 10Driedmueller) [08:11:24] (03CR) 10Hashar: [C: 03+2] zuul: add mediawiki/extensions/BlueSpiceInterwikiSearch [integration/config] - 10https://gerrit.wikimedia.org/r/962993 (owner: 10Hashar) [08:11:44] (03CR) 10Hashar: [C: 03+2] zuul: add mediawiki/extensions/DateTimeTools [integration/config] - 10https://gerrit.wikimedia.org/r/962994 (owner: 10Hashar) [08:12:01] (03CR) 10Hashar: [C: 03+2] zuul: add mediawiki/extensions/SimpleTasks [integration/config] - 10https://gerrit.wikimedia.org/r/962995 (owner: 10Hashar) [08:12:05] (03CR) 10Hashar: [C: 03+2] zuul: add mediawiki/extensions/SubnetCalc [integration/config] - 10https://gerrit.wikimedia.org/r/962996 (owner: 10Hashar) [08:12:09] (03CR) 10Hashar: [C: 03+2] zuul: add mediawiki/extensions/VisualEditorPlus [integration/config] - 10https://gerrit.wikimedia.org/r/962997 (owner: 10Hashar) [08:12:29] (03Merged) 10jenkins-bot: zuul: add mediawiki/extensions/AtMentions [integration/config] - 10https://gerrit.wikimedia.org/r/961392 (owner: 10Driedmueller) [08:12:35] (03Merged) 10jenkins-bot: zuul: add mediawiki/extensions/BlueSpiceInterwikiSearch [integration/config] - 10https://gerrit.wikimedia.org/r/962993 (owner: 10Hashar) [08:12:52] (03Merged) 10jenkins-bot: zuul: add mediawiki/extensions/DateTimeTools [integration/config] - 10https://gerrit.wikimedia.org/r/962994 (owner: 10Hashar) [08:13:13] (03Merged) 10jenkins-bot: zuul: add mediawiki/extensions/SimpleTasks [integration/config] - 10https://gerrit.wikimedia.org/r/962995 (owner: 10Hashar) [08:13:19] (03Merged) 10jenkins-bot: zuul: add mediawiki/extensions/SubnetCalc [integration/config] - 10https://gerrit.wikimedia.org/r/962996 (owner: 10Hashar) [08:13:28] (03Merged) 10jenkins-bot: zuul: add mediawiki/extensions/VisualEditorPlus [integration/config] - 10https://gerrit.wikimedia.org/r/962997 (owner: 10Hashar) [08:14:06] !log Reloaded Zuul at 2d225e52cfb54df8fa349dc94ce39d38b0984c1f for a series of patches enabling Hallowelt extensions [08:14:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:33:30] 10Project-Admins, 10MediaWiki-extensions-MediaSpoiler: Create project tag for Extension:MediaSpoiler - https://phabricator.wikimedia.org/T339270 (10Aklapper) @Dringsim: Added you [08:39:10] (03CR) 10Hashar: [C: 03+2] "NOTE: all changes for SimpleTasks have been abandoned https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/SimpleTasks :)" [integration/config] - 10https://gerrit.wikimedia.org/r/962995 (owner: 10Hashar) [08:41:24] 10Project-Admins: Create milestone tag for Ultraviolet/RedWarn Compatibility - https://phabricator.wikimedia.org/T347760 (10Aklapper) 05Openโ†’03Resolved a:03Aklapper Requested public project has been created: https://phabricator.wikimedia.org/project/view/6788/ (In case you need to edit the project or proj... [09:06:45] 10Phabricator: Custom task form for EditCheck - https://phabricator.wikimedia.org/T347912 (10Aklapper) @VPuffetMichel: Hmm, given the rather small number of data items above, are there particular reasons I'm not aware of which made you think of using a form instead of [URL parameters](https://www.mediawiki.org/w... [09:15:15] (03CR) 10Hashar: "I have casted my CR+2 on patchset 1 which caused Gerrit to complain:" [integration/config] - 10https://gerrit.wikimedia.org/r/961109 (owner: 10Hashar) [09:16:47] (03Merged) 10jenkins-bot: jjb: use a job template for wikidata-query-*-build [integration/config] - 10https://gerrit.wikimedia.org/r/961109 (owner: 10Hashar) [09:25:02] 10Phabricator, 10Release-Engineering-Team (Priority Backlog ๐Ÿ“ฅ), 10collaboration-services: Stop logging Bugzilla to Phabricator redirector misses - https://phabricator.wikimedia.org/T344884 (10Aklapper) @Jelto: Thanks for merging this two weeks ago. Would you know when this would also get deployed (as it's in... [09:31:19] James_F: I have updated the CI language version policy for NodeJS https://www.mediawiki.org/w/index.php?title=Continuous_integration/Language_Versions_Policy&diff=prev&oldid=6135549 :) [09:31:40] well or direct link to the updated table: https://www.mediawiki.org/wiki/Continuous_integration/Language_Versions_Policy#NodeJS [10:04:55] 10Phabricator, 10Patch-For-Review: Activity pane on front page no longer shows New Tasks by default after Phorge migration - https://phabricator.wikimedia.org/T344835 (10CodeReviewBot) aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/19 Add temporary debug output for... [11:23:34] 10Phabricator, 10Outreach-Programs-Projects: Create a fake user as task assignee for outreach programs' microtasks to be claimed by several folks at the same time - https://phabricator.wikimedia.org/T347978 (10Aklapper) p:05Triageโ†’03High [11:33:31] 10Phabricator, 10Outreach-Programs-Projects: Create a fake user as task assignee for outreach programs' microtasks to be claimed by several folks at the same time - https://phabricator.wikimedia.org/T347978 (10Aklapper) 05Openโ†’03Resolved Done in https://phabricator.wikimedia.org/p/DO-NOT-CHANGE/ , set on a... [11:49:12] `scap update-interwiki-cache` is not making the patch anymore nor deploying. Only changes the interwiki file [11:50:59] 10Scap: scap update-interwiki-cache is broken - https://phabricator.wikimedia.org/T347982 (10Ladsgroup) [11:54:16] 10Phabricator: Allow acl*otrs-admins to access hidden OTRS Tasks - https://phabricator.wikimedia.org/T154133 (10Aklapper) >>! In T154133#6539680, @Urbanecm wrote: > A solution would be to introduce a herald rule, which would add #acl_otrs-admins as a subscriber to all restricted tasks tagging OTRS. For the reco... [12:06:54] (03PS1) 10Hashar: jjb: update Quibble jobs to 1.5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/963021 (https://phabricator.wikimedia.org/T342088) [12:07:32] !log Upgrading Quibble jobs to Quibble 1.5.6 [12:07:34] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:07:52] (03CR) 10Hashar: [C: 03+2] jjb: update Quibble jobs to 1.5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/963021 (https://phabricator.wikimedia.org/T342088) (owner: 10Hashar) [12:09:17] (03Merged) 10jenkins-bot: jjb: update Quibble jobs to 1.5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/963021 (https://phabricator.wikimedia.org/T342088) (owner: 10Hashar) [12:24:38] 10Release-Engineering-Team (Escape Goats๐Ÿ), 10Wikimedia-Phabricator-Extensions, 10collaboration-services, 10Patch-For-Review: Disable "Browse Gerrit Projects" on https://phabricator.wikimedia.org/r/ - https://phabricator.wikimedia.org/T228507 (10brennen) > brennen merged https://gitlab.wikimedia.org/repos/... [12:25:16] 10Release-Engineering-Team, 10Quibble: Run Quibble Mariadb server with innodb_print_all_deadlocks - https://phabricator.wikimedia.org/T342088 (10hashar) 05Openโ†’03Resolved I have updated all the Jenkins jobs to use Quibble 1.5.6 which now spawns MariaDB with `--innodb-print-all-deadlocks`. The log should be... [12:35:13] 10Phabricator, 10Patch-For-Review: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php - https://phabricator.wikimedia.org/T347483 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/17 Add temp... [12:44:22] (03CR) 10Hashar: "REL1_35 is end of line in a month :)" [integration/quibble] - 10https://gerrit.wikimedia.org/r/883885 (owner: 10Lucas Werkmeister (WMDE)) [12:46:57] 10Phabricator, 10Release-Engineering-Team (Escape Goats๐Ÿ), 10Patch-For-Review: Reports: RuntimeException due to wrong assumption that boards have more columns than default Backlog - https://phabricator.wikimedia.org/T336105 (10brennen) Tested here: https://phab.wmflabs.org/project/reports/73/ Seems to be wo... [12:47:28] 10Release-Engineering-Team (Escape Goats๐Ÿ), 10Wikimedia-Phabricator-Extensions, 10collaboration-services, 10Patch-For-Review: Disable "Browse Gerrit Projects" on https://phabricator.wikimedia.org/r/ - https://phabricator.wikimedia.org/T228507 (10Aklapper) I am fine with redirect breakage. Reducing maintena... [12:53:06] (03CR) 10Abijeet Patro: "This change is ready for review." [integration/config] - 10https://gerrit.wikimedia.org/r/963032 (https://phabricator.wikimedia.org/T345520) (owner: 10Abijeet Patro) [12:54:44] 10Phabricator, 10Release-Engineering-Team (Priority Backlog ๐Ÿ“ฅ), 10Wikimedia-Phabricator-Extensions, 10Patch-For-Review: Phabricator Project Reports have inaccurate counts for the age histogram - https://phabricator.wikimedia.org/T294998 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/ph... [12:54:52] 10Phabricator, 10Release-Engineering-Team (Escape Goats๐Ÿ), 10Patch-For-Review: Reports: Age histogram shows nonsensical additional bucket after "Older" for projects created in last days - https://phabricator.wikimedia.org/T336152 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator... [13:09:46] 10GitLab (Infrastructure), 10collaboration-services: Switchover gitlab (gitlab1004 -> gitlab2002) - October 2023 - https://phabricator.wikimedia.org/T345531 (10Trizek-WMF) This switchover wasn't part of {T345265}, so it wasn't announced the same way the Mediawiki switchover was covered. >>! In T345531#920424... [13:13:32] 10WikimediaDebug, 10MW-on-K8s, 10observability, 10Patch-For-Review: Excimer UI profile lost when requested from mw-on-k8s - https://phabricator.wikimedia.org/T347926 (10fgiunchedi) [13:29:32] (03CR) 10Jforrester: [C: 04-1] "Given that gerrit doesn't let you rename repos, presumably this is actually "drop WikiEdit gadget and add MiniEdit gadget CI"? In which ca" [integration/config] - 10https://gerrit.wikimedia.org/r/963032 (https://phabricator.wikimedia.org/T345520) (owner: 10Abijeet Patro) [13:32:27] ^ there is a plugin that can be installed to rename projects, not sure if we ever tried to install / use it [13:32:44] hauskater: Yes, we know, we've intentionally rejected it. [13:32:56] Just sayin' :) [13:33:10] Security reasons or something (and it only recently started properly working, and Zuul/Jenkins is legacy CI, andโ€ฆ). [13:33:15] Been kinda disconnected from dev things lately [13:33:45] No worries. [14:01:16] 10Phabricator, 10Patch-For-Review: Activity pane on front page no longer shows New Tasks by default after Phorge migration - https://phabricator.wikimedia.org/T344835 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/19 Add temporary debug output for... [14:17:12] 10Phabricator, 10Release-Engineering-Team, 10collaboration-services, 10User-brennen: Deploy Phabricator/Phorge 2023-10-03 - https://phabricator.wikimedia.org/T348007 (10brennen) [14:17:58] 10Phabricator, 10Release-Engineering-Team, 10collaboration-services, 10Patch-For-Review, 10User-brennen: Deploy Phabricator/Phorge 2023-10-03 - https://phabricator.wikimedia.org/T348007 (10CodeReviewBot) brennen opened https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/20 Phabric... [14:18:56] 10Phabricator, 10Patch-For-Review: Activity pane on front page no longer shows New Tasks by default after Phorge migration - https://phabricator.wikimedia.org/T344835 (10CodeReviewBot) brennen opened https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/20 Phabricator release 2023-10-03 [14:19:35] 10Phabricator, 10Release-Engineering-Team, 10collaboration-services, 10Patch-For-Review, 10User-brennen: Deploy Phabricator/Phorge 2023-10-03 - https://phabricator.wikimedia.org/T348007 (10brennen) 05Openโ†’03In progress p:05Triageโ†’03Medium a:03brennen [14:19:54] (03CR) 10Hashar: "I had a quick look at both repositories. MiniEdit had files copied from WikiEdit which loose all the git history :( I guess it should ins" [integration/config] - 10https://gerrit.wikimedia.org/r/963032 (https://phabricator.wikimedia.org/T345520) (owner: 10Abijeet Patro) [14:23:09] andre: rolling a few phab things out this morning during the collab services window - T348007 [14:23:10] T348007: Deploy Phabricator/Phorge 2023-10-03 - https://phabricator.wikimedia.org/T348007 [14:23:20] brennen: <3 [14:23:47] brennen: I'll update the tasks afterwards with the corresponding milestone [14:24:24] right on, thanks. i'll aim to actually follow the milestone process for next week. [14:24:39] np [14:36:17] brennen: any chance https://gitlab.wikimedia.org/repos/phabricator/arcanist/-/merge_requests/1 can be shipped in the next phab update? [14:42:13] hauskater: yeah, merging. [14:42:23] thanks brennen :-) [14:42:58] I guess we'll have to "re-fix" later since Arcanist upstream has modified that file [14:43:09] 10Phabricator, 10Patch-For-Review, 10User-Frostly, 10good first task: Wikimedia Phabricator emails display the "Phorge" name in the To field - https://phabricator.wikimedia.org/T345758 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator/arcanist/-/merge_requests/1 Define Phabri... [14:43:54] 10Phabricator, 10Patch-For-Review, 10User-Frostly, 10good first task: Wikimedia Phabricator emails display the "Phorge" name in the To field - https://phabricator.wikimedia.org/T345758 (10brennen) 05Openโ†’03Resolved For consistency with domain name and currently displayed title, we'll go with this for r... [14:58:58] 10WikimediaDebug, 10MW-on-K8s, 10observability, 10Patch-For-Review: Excimer UI profile lost when requested from mw-on-k8s - https://phabricator.wikimedia.org/T347926 (10fgiunchedi) I believe this is fixed with the redis egress rules [15:03:26] 10Phabricator, 10Patch-For-Review, 10User-Frostly, 10good first task: Wikimedia Phabricator emails display the "Phorge" name in the To field - https://phabricator.wikimedia.org/T345758 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/20 Phabricato... [15:03:35] 10Phabricator, 10Release-Engineering-Team, 10collaboration-services, 10Patch-For-Review, 10User-brennen: Deploy Phabricator/Phorge 2023-10-03 - https://phabricator.wikimedia.org/T348007 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/repos/phabricator/deployment/-/merge_requests/20 Phabric... [15:10:38] 10Phabricator, 10Release-Engineering-Team, 10collaboration-services, 10Patch-For-Review, 10User-brennen: Deploy Phabricator/Phorge 2023-10-03 - https://phabricator.wikimedia.org/T348007 (10brennen) 05In progressโ†’03Resolved [15:22:25] 10Phabricator (phabricator-next), 10Upstream: "Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool" when viewing old Herald Transcript - https://phabricator.wikimedia.org/T294860 (10Aklapper) [15:22:28] 10Phabricator (phabricator-next), 10Upstream: Add link to atom feed in each main blog page - https://phabricator.wikimedia.org/T205181 (10Aklapper) [15:22:30] 10Phabricator (phabricator-next), 10CSS, 10Upstream: Incorrect height of class "phui-oi-frame" - https://phabricator.wikimedia.org/T307492 (10Aklapper) [15:22:35] 10Phabricator (phabricator-next), 10CSS, 10Upstream: Upload popup overflows box with a long filename - https://phabricator.wikimedia.org/T316305 (10Aklapper) [15:22:39] 10Phabricator (phabricator-next), 10Upstream: Give transparent embedded image files in Phabricator a checkered background - https://phabricator.wikimedia.org/T78644 (10Aklapper) [15:22:59] 10Phabricator (phabricator-next), 10Upstream: Unhandled Exception ("RuntimeException"): Undefined offset: 5 when trying to access T16235 - https://phabricator.wikimedia.org/T284397 (10Aklapper) [15:23:36] 10Phabricator (2023-10-03), 10Release-Engineering-Team, 10collaboration-services, 10User-brennen: Deploy Phabricator/Phorge 2023-10-03 - https://phabricator.wikimedia.org/T348007 (10Aklapper) [15:23:52] 10Phabricator (2023-10-03), 10Release-Engineering-Team (Seen), 10User-Frostly: Remove a hyphen from "CC BY-SA" link text in Phabricator Footer - https://phabricator.wikimedia.org/T344965 (10Aklapper) [15:24:07] 10Phabricator (2023-10-03), 10Release-Engineering-Team: Clarify GPL 2.0 or later license on Phabricator - https://phabricator.wikimedia.org/T338762 (10Aklapper) [15:24:30] 10Phabricator: Activity pane on front page no longer shows New Tasks by default after Phorge migration - https://phabricator.wikimedia.org/T344835 (10Aklapper) [15:25:51] 10Phabricator (2023-10-03), 10Release-Engineering-Team (Escape Goats๐Ÿ): Reports: RuntimeException due to wrong assumption that boards have more columns than default Backlog - https://phabricator.wikimedia.org/T336105 (10brennen) 05Openโ†’03Resolved [15:26:07] 10Phabricator: Custom task form for EditCheck - https://phabricator.wikimedia.org/T347912 (10VPuffetMichel) @Aklapper: simple. I did not know that phabulous existed and I did not want to tinker with url parameters. [15:26:11] 10Phabricator (2023-10-03), 10Release-Engineering-Team (Escape Goats๐Ÿ): Reports: RuntimeException due to wrong assumption that boards have more columns than default Backlog - https://phabricator.wikimedia.org/T336105 (10Aklapper) a:05brennenโ†’03Aklapper [15:26:28] 10Phabricator: Custom task form for EditCheck - https://phabricator.wikimedia.org/T347912 (10VPuffetMichel) https://phabricator.wikimedia.org/maniphest/task/edit/form/1/?description=Steps%20to%20reproduce%3A%0D%0A%0D%0A%0D%0AObserved%20Result%3A%0D%0A%0D%0AExpected%20Result%3A%0D%0A%0D%0AScreenshot%2FScreen%20ca... [15:26:52] 10Phabricator (2023-10-03), 10Release-Engineering-Team (Escape Goats๐Ÿ): Reports: Age histogram shows nonsensical additional bucket after "Older" for projects created in last days - https://phabricator.wikimedia.org/T336152 (10Aklapper) 05Openโ†’03Resolved a:05brennenโ†’03Aklapper [15:27:23] 10Phabricator (2023-10-03), 10Release-Engineering-Team (Escape Goats๐Ÿ), 10User-brennen: Disallow adding Project Tags in the Subscribers field - https://phabricator.wikimedia.org/T303829 (10Aklapper) 05Openโ†’03Resolved [15:27:51] 10Phabricator: Custom task form for EditCheck - https://phabricator.wikimedia.org/T347912 (10VPuffetMichel) 05Openโ†’03Resolved [15:28:24] 10Phabricator (2023-10-03), 10Phabricator Antivandalism Extension, 10Release-Engineering-Team (Escape Goats๐Ÿ): AVA init-script.php code checks for non-existent libphutil - https://phabricator.wikimedia.org/T340633 (10Aklapper) 05Openโ†’03Resolved [15:31:41] 10Phabricator, 10Release-Engineering-Team (Priority Backlog ๐Ÿ“ฅ), 10Wikimedia-Phabricator-Extensions: Phabricator Project Reports have inaccurate counts for the age histogram - https://phabricator.wikimedia.org/T294998 (10Aklapper) a:05Aklapperโ†’03None I assume the fix got deployed today in the Phabricator... [15:34:37] 10Phabricator (2023-10-03), 10Voice & Tone: Improve error message about Edit Policy when creating objects when Edit Policy is hidden in form - https://phabricator.wikimedia.org/T333955 (10Aklapper) 05Openโ†’03Resolved I assume this got deployed in the 2023-10-03 deployment. (@brennen: Please correct me if I... [15:36:56] 10Phabricator (2023-10-03), 10Release-Engineering-Team (Escape Goats๐Ÿ): Uninstall Multimeter (Phabricator application) - https://phabricator.wikimedia.org/T337650 (10Aklapper) 05Openโ†’03Resolved [15:37:07] 10Phabricator (2023-10-03), 10Release-Engineering-Team (Escape Goats๐Ÿ): Uninstall Packages (Phabricator application) - https://phabricator.wikimedia.org/T336906 (10Aklapper) 05Openโ†’03Resolved [15:37:19] 10Phabricator (2023-10-03), 10Release-Engineering-Team (Escape Goats๐Ÿ): Uninstall Phrequent (Phabricator application) - https://phabricator.wikimedia.org/T337606 (10Aklapper) 05Openโ†’03Resolved [15:38:00] 10Phabricator (2023-10-03), 10Voice & Tone: Improve error message about Edit Policy when creating objects when Edit Policy is hidden in form - https://phabricator.wikimedia.org/T333955 (10brennen) I believe this went out 2023-09-26, but at any rate it is definitely live now. [15:40:17] 10Phabricator: Custom task form for EditCheck - https://phabricator.wikimedia.org/T347912 (10Aklapper) 05Resolvedโ†’03Declined Heh, nice. (In that case declining this task as no custom form was created.) @VPuffetMichel: Though, does "Editor:" refer to a [software](https://www.mediawiki.org/wiki/Editor) or to... [15:41:36] 10Phabricator, 10TestMe: Phorge logs me out if accessing a task via URL - https://phabricator.wikimedia.org/T347570 (10MarcoAurelio) [15:42:41] 10Phabricator: Custom task form for EditCheck - https://phabricator.wikimedia.org/T347912 (10VPuffetMichel) Good catch! I will adjust. I copy pasted from another bug report form.There are so many editors meaning one can pick from, especially dealing with the Editing team ;) [15:44:31] 10Phabricator (2023-10-03), 10User-Frostly, 10good first task: Wikimedia Phabricator emails display the "Phorge" name in the To field - https://phabricator.wikimedia.org/T345758 (10Aklapper) [15:48:19] 10Phabricator, 10TestMe: Phorge logs me out if accessing a task via URL - https://phabricator.wikimedia.org/T347570 (10Aklapper) I still cannot reproduce that using Chromium 117 with an "average" Phabricator account (no special permissions which would allow me to see a security task). [15:49:58] 10Phabricator (2023-10-03), 10Release-Engineering-Team, 10Dumps-Generation: Compress phabricator dump - https://phabricator.wikimedia.org/T262744 (10brennen) [15:50:16] 10Phabricator (2023-10-03), 10Release-Engineering-Team, 10Dumps-Generation: Compress phabricator dump - https://phabricator.wikimedia.org/T262744 (10brennen) 05Openโ†’03Resolved [15:50:59] 10Phabricator, 10TestMe: Phorge logs me out if accessing a task via URL - https://phabricator.wikimedia.org/T347570 (10MarcoAurelio) Minor correction: this happens to me for all tasks, no matter the Task visibility. Looking at the Firefox browser console, I see one warning (sorry, it's in Spanish): ` La cook... [16:00:43] 10Phabricator, 10TestMe: Phorge logs me out if accessing a task via URL - https://phabricator.wikimedia.org/T347570 (10Aklapper) Using Firefox 118.0 in a private window with my "average" account, accessing both this very task and trying the security one you linked, I get two times CSP stuff in the console, plu... [16:03:03] 10Phabricator, 10TestMe: Phorge logs me out if accessing a task via URL - https://phabricator.wikimedia.org/T347570 (10MarcoAurelio) >>! In T347570#9221103, @Aklapper wrote: > Using Firefox 118.0 in a private window with my "average" account, accessing both this very task and trying the security one you linked... [16:03:13] 10Scap: scap update-interwiki-cache is broken - https://phabricator.wikimedia.org/T347982 (10dancy) This behavior was removed from `scap update-interwiki-cache` in T247107. [16:48:16] 10Scap: scap update-interwiki-cache is broken - https://phabricator.wikimedia.org/T347982 (10Ladsgroup) Thanks for the pointer but this is adding a lot of toil to an already miserable process of creating new wikis. See [[https://wikitech.wikimedia.org/wiki/Add_a_wiki|one]], [[https://phabricator.wikimedia.org/T2... [16:53:53] 10Gitlab-Application-Security-Pipeline: Establish a more specific policy/best practices around security include failures - https://phabricator.wikimedia.org/T342469 (10sbassett) @mmartorana will merge the above, proposed addition to our documentation to https://www.mediawiki.org/wiki/Security/Application_Securit... [16:54:34] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10sbassett) [16:54:44] 10Gitlab-Application-Security-Pipeline, 10Security Team AppSec, 10Security-Team, 10Security: Implement an outdated modules check for golang - https://phabricator.wikimedia.org/T309997 (10sbassett) 05Openโ†’03In progress [16:58:19] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10user-sbassett: Craft more mediawiki-specific and php semgrep rule sets - https://phabricator.wikimedia.org/T342468 (10sbassett) 05Openโ†’03In progress p:05Triageโ†’03Medium a:03sbassett [16:58:21] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10sbassett) [17:00:23] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10user-sbassett: Craft more mediawiki-specific and php semgrep rule sets - https://phabricator.wikimedia.org/T342468 (10sbassett) [17:00:35] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10user-sbassett: Craft more mediawiki-specific and php semgrep rule sets - https://phabricator.wikimedia.org/T342468 (10sbassett) [17:01:22] 10Gitlab-Application-Security-Pipeline, 10Security Team AppSec, 10Security-Team, 10Security: Implement an outdated modules check for golang - https://phabricator.wikimedia.org/T309997 (10sbassett) [17:02:20] 10Gitlab-Application-Security-Pipeline, 10Security Team AppSec, 10Security-Team, 10SecTeam-Processed, 10Security: Address issues within certain Gitlab CI security templates - https://phabricator.wikimedia.org/T338034 (10sbassett) [17:02:53] 10Gitlab-Application-Security-Pipeline, 10Security, 10user-sbassett: Design AppSec Pipeline metrics approach - https://phabricator.wikimedia.org/T342467 (10sbassett) p:05Triageโ†’03Medium [17:03:22] 10Gitlab-Application-Security-Pipeline: Establish a more specific policy/best practices around security include failures - https://phabricator.wikimedia.org/T342469 (10sbassett) 05Openโ†’03In progress p:05Triageโ†’03Medium [17:03:24] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10sbassett) [17:04:26] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10sbassett) [17:04:36] 10Release-Engineering-Team (They Live ๐Ÿ•ถ๏ธ๐ŸงŸ), 10Anti-Harassment, 10Projects-Cleanup, 10Security-Team, 10iPoid-Service: Migrate mediawiki/services/ipoid to GitLab - https://phabricator.wikimedia.org/T337714 (10sbassett) [17:04:43] 10Release-Engineering-Team (Radar), 10Anti-Harassment, 10Security-Team, 10iPoid-Service: Use Gitlab Security Pipeline for ipoid - https://phabricator.wikimedia.org/T338238 (10sbassett) [17:05:19] 10Release-Engineering-Team (Radar), 10Anti-Harassment, 10Security-Team, 10iPoid-Service: Use Gitlab Security Pipeline for ipoid - https://phabricator.wikimedia.org/T338238 (10sbassett) 05Stalledโ†’03In progress p:05Triageโ†’03Medium a:05Mstylesโ†’03mmartorana [17:07:18] 10Gitlab-Application-Security-Pipeline, 10Security Team AppSec, 10Security-Team, 10SecTeam-Processed, 10Security: Implement a template for Shell scripting testing - https://phabricator.wikimedia.org/T346163 (10sbassett) a:05mmartoranaโ†’03None [17:08:10] 10Gitlab-Application-Security-Pipeline, 10Security, 10user-sbassett: Design AppSec Pipeline metrics approach - https://phabricator.wikimedia.org/T342467 (10sbassett) [18:30:20] Project beta-update-databases-eqiad build #70691: 04FAILURE in 10 min: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/70691/ [18:54:24] (03CR) 10Hashar: [C: 03+2] "I have updated the Quibble jobs to Quibble 1.5.6 earlier today and it seems everything is working fine." [integration/config] - 10https://gerrit.wikimedia.org/r/962173 (https://phabricator.wikimedia.org/T347360) (owner: 10Reedy) [18:55:23] hashar: Eh. [18:55:40] (03Merged) 10jenkins-bot: dockerfiles: [composer-scratch] Upgrade composer to 2.6.4 [integration/config] - 10https://gerrit.wikimedia.org/r/962173 (https://phabricator.wikimedia.org/T347360) (owner: 10Reedy) [18:55:42] hashar: For changed versions of composer I've been trying to make actual version bumps for php images. [18:55:47] So .1 rather than -s1. [18:58:10] * James_F shrugs. [19:09:26] 10Gitlab-Application-Security-Pipeline, 10Security Team AppSec, 10Security-Team, 10SecTeam-Processed, 10Security: Implement a template for Shell scripting testing - https://phabricator.wikimedia.org/T346163 (10hashar) SRE had an initiative on that front for their `operations/puppet.git` repository {T1484... [19:09:55] James_F: OH MY BAD :( [19:10:00] hashar: S'fine. [19:10:06] I verified the quibble images but not the others [19:10:36] I guess `docker-pkg` should be taught an option to make it bump the minor version instead of adding a security suffix [19:11:00] or add a test to cover the schema? (I think there is one for quibble images to ensure their version matches the installed quibble version) [19:12:26] also I have bumped the Jenkins jobs to Quibble 1.5.6 earlier today and apparently no complains so far :) [19:30:17] Yippee, build fixed! [19:30:17] Project beta-update-databases-eqiad build #70692: 09FIXED in 10 min: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/70692/ [19:37:17] (03CR) 10Hashar: [C: 03+2] "Successfully published image docker-registry.wikimedia.org/releng/mediawiki-phan-php74:0.2.2-s1" [integration/config] - 10https://gerrit.wikimedia.org/r/962173 (https://phabricator.wikimedia.org/T347360) (owner: 10Reedy) [19:38:16] 10Continuous-Integration-Config, 10MediaWiki-Vendor, 10Composer: Upgrade composer to > 2.5.1 - https://phabricator.wikimedia.org/T347360 (10hashar) The Docker images have been built and published: ` Successfully published image docker-registry.wikimedia.org/releng/mediawiki-phan-php74:0.2.2-s1 Successfully p... [19:38:54] Reedy: I have built the images for composer 2.6.4 but haven't switched the jobs, I guess that will be for tomorrow :) [19:40:03] I can do that, and rebuild vendor.git [19:40:51] ah yeah vendor [19:40:53] good catch [19:41:13] and I don't know what would be the effects on the autoloaders [19:41:30] It's fine, I've done this before. [19:42:47] <3 [19:54:05] I am off [21:01:16] (03PS1) 10Jforrester: jjb: Switch non-Quibble PHP jobs to images with Composer 2.6.4, up from 2.5.1 [integration/config] - 10https://gerrit.wikimedia.org/r/963155 (https://phabricator.wikimedia.org/T347360) [21:01:19] (03PS1) 10Jforrester: jjb: Switch Quibble jobs to images with Composer 2.6.4, up from 2.5.1 [integration/config] - 10https://gerrit.wikimedia.org/r/963156 (https://phabricator.wikimedia.org/T347360) [21:07:10] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/963155 (https://phabricator.wikimedia.org/T347360) (owner: 10Jforrester) [21:08:26] (03Merged) 10jenkins-bot: jjb: Switch non-Quibble PHP jobs to images with Composer 2.6.4, up from 2.5.1 [integration/config] - 10https://gerrit.wikimedia.org/r/963155 (https://phabricator.wikimedia.org/T347360) (owner: 10Jforrester) [21:14:00] (03CR) 10Jforrester: [C: 03+2] "Deployed." [integration/config] - 10https://gerrit.wikimedia.org/r/963156 (https://phabricator.wikimedia.org/T347360) (owner: 10Jforrester) [21:15:03] (03Merged) 10jenkins-bot: jjb: Switch Quibble jobs to images with Composer 2.6.4, up from 2.5.1 [integration/config] - 10https://gerrit.wikimedia.org/r/963156 (https://phabricator.wikimedia.org/T347360) (owner: 10Jforrester) [21:15:40] 10Continuous-Integration-Config, 10MediaWiki-Vendor, 10Composer, 10Patch-For-Review: Upgrade composer to > 2.5.1 - https://phabricator.wikimedia.org/T347360 (10Jdforrester-WMF) [21:23:21] 10Continuous-Integration-Config, 10MediaWiki-Vendor, 10Composer, 10Patch-For-Review: Upgrade composer to > 2.5.1 - https://phabricator.wikimedia.org/T347360 (10Jdforrester-WMF) [21:23:31] 10Continuous-Integration-Config, 10MediaWiki-Vendor, 10Composer, 10Patch-For-Review: Upgrade composer from 2.5.1 to 2.6.4 - https://phabricator.wikimedia.org/T347360 (10Jdforrester-WMF) [21:47:05] 10GitLab (Infrastructure), 10collaboration-services, 10Patch-For-Review: Switchover gitlab (gitlab1004 -> gitlab2002) - October 2023 - https://phabricator.wikimedia.org/T345531 (10CodeReviewBot) eoghan opened https://gitlab.wikimedia.org/repos/releng/gitlab-settings/-/merge_requests/46 [gitlab/switchover] U... [21:49:09] 10GitLab (Infrastructure), 10collaboration-services, 10Patch-For-Review: Switchover gitlab (gitlab1004 -> gitlab2002) - October 2023 - https://phabricator.wikimedia.org/T345531 (10eoghan)