[01:02:00] 10GitLab: Add a /repos/gadgets namespace in Wikimedia Gitlab - https://phabricator.wikimedia.org/T353491 (10Soda) [01:32:52] 10GitLab: Add a /repos/gadgets namespace in Wikimedia Gitlab - https://phabricator.wikimedia.org/T353491 (10Novem_Linguae) Currently this is over on GitHub, at https://github.com/wikimedia-gadgets/ As a member of wikimedia-gadgets, can't say that I'm super incentivized to move over yet. GitHub is industry stand... [01:37:00] (03Abandoned) 10Hashar: Edit Repo Config [analytics] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/975380 (owner: 10Fabio carrieri) [02:28:37] 10GitLab: Add a /repos/gadgets namespace in Wikimedia Gitlab - https://phabricator.wikimedia.org/T353491 (10Chlod) We already have some of our repos at #ultraviolet on GitLab, so I can answer a few of @Novem_Linguae's questions based on my experiences working on it. > Are there any GitHub Issues To Phabricator... [04:36:22] 10Phabricator (phabricator-next), 10Phabricator Antivandalism Extension, 10Release-Engineering-Team (Quid Pro Crow πŸ¦ƒ): phabricator antivandalism extension should ignore bot accounts - https://phabricator.wikimedia.org/T350245 (10Aklapper) It looks like this got not deployed two days ago [04:42:29] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Wikimedia-Phabricator-Extensions, 10Voice & Tone: MediaWiki Auth provider: Clarify which OAuth consumer registration to choose in MediaWiki - https://phabricator.wikimedia.org/T343577 (10Aklapper) This did not get deployed... [04:43:35] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Wikimedia-Phabricator-Extensions, 10Voice & Tone: MediaWiki OAuth provider: Update instructions to match MediaWiki strings - https://phabricator.wikimedia.org/T343579 (10Aklapper) This did not get deployed in #phabricator-... [04:44:23] 10Phabricator (2023-12-12): Revert rPHAB9f143f8321b9160e5f11810f2e82fd980840d36b - https://phabricator.wikimedia.org/T352943 (10Aklapper) 05Openβ†’03Resolved Deployed as part of #phabricator-2023-12-12 [04:44:28] 10Phabricator (2023-12-12): Revert unneeded changes in PhabricatorCalendarNotificationEngine::sendNotifications (rPHABcfd6daf92077d16d58f69230c1469db578067a64) - https://phabricator.wikimedia.org/T352822 (10Aklapper) 05Openβ†’03Resolved Deployed as part of #phabricator-2023-12-12 [04:44:32] 10Phabricator (2023-12-12), 10Release-Engineering-Team (Quid Pro Crow πŸ¦ƒ): Remove unused custom "Add more repository details to harbormaster build steps" - https://phabricator.wikimedia.org/T351958 (10Aklapper) 05Openβ†’03Resolved Deployed as part of #phabricator-2023-12-12 [04:44:34] 10Phabricator (2023-12-12), 10Release-Engineering-Team (Quid Pro Crow πŸ¦ƒ): Remove broken custom code in DifferentialRevisionSearchEngine.php - https://phabricator.wikimedia.org/T351957 (10Aklapper) 05Openβ†’03Resolved Deployed as part of #phabricator-2023-12-12 [04:44:39] 10Phabricator, 10Patch-For-Review: Remove unused code in Diffusion to handle closed almanac cluster services - https://phabricator.wikimedia.org/T352530 (10Aklapper) [04:44:41] 10Phabricator (2023-12-12), 10Release-Engineering-Team (Priority Backlog πŸ“₯): Reports: "Older" bar link in Histogram has wrong task query URL - https://phabricator.wikimedia.org/T336175 (10Aklapper) 05Openβ†’03Resolved a:05brennenβ†’03Aklapper Deployed as part of #phabricator-2023-12-12 [04:44:43] 10Phabricator (2023-12-12): Uninstall Almanac (Phabricator application) - https://phabricator.wikimedia.org/T351502 (10Aklapper) 05Openβ†’03Resolved Deployed as part of #phabricator-2023-12-12 [04:44:45] 10Phabricator (2023-12-12): Uninstall Ponder (Phabricator application) - https://phabricator.wikimedia.org/T351584 (10Aklapper) 05Openβ†’03Resolved Deployed as part of #phabricator-2023-12-12 [04:44:54] 10Phabricator (2023-12-12), 10Release-Engineering-Team (Priority Backlog πŸ“₯): Filter default Phabricator calendar view to show items tagged with #events only - https://phabricator.wikimedia.org/T343258 (10Aklapper) 05Openβ†’03Resolved Deployed as part of #phabricator-2023-12-12 [04:44:57] 10Phabricator (2023-12-12), 10Release-Engineering-Team (Priority Backlog πŸ“₯): Update custom allowlist in src/applications/phurl/storage/PhabricatorPhurlURL.php - https://phabricator.wikimedia.org/T343267 (10Aklapper) 05Openβ†’03Resolved Deployed as part of #phabricator-2023-12-12 [04:45:05] 10Phabricator (2023-12-12), 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Technical-Debt: Revert unused downstream Phab code to suppress triggering mail (predates silent batch-editing) - https://phabricator.wikimedia.org/T343264 (10Aklapper) 05Openβ†’03Resolved Deployed as part of #phabricator-2023-12-12 [04:47:51] 10Phabricator: Unused custom maniphest.project.task.transactions Conduit API has issues - https://phabricator.wikimedia.org/T353042 (10Aklapper) Since the #phabricator-2023-12-12 deployment, https://phabricator.wikimedia.org/conduit/method/maniphest.project.task.transactions/ 404s. This is intentional breakage t... [04:50:28] 10Phabricator (Upstream), 10Upstream: User preview cards do not work consistently - https://phabricator.wikimedia.org/T76906 (10Aklapper) Fixed in upstream https://we.phorge.it/rP2295bcda14e71948516752f8fbada6601b9f0bde / rPHAB2295bcda14e71948516752f8fbada6601b9f0bde [09:00:44] 10Release-Engineering-Team (Radar), 10Tech-Docs-Team, 10Documentation, 10Patch-For-Review: Create repository with configuration files for common CI use cases - https://phabricator.wikimedia.org/T352273 (10CodeReviewBot) kbach merged https://gitlab.wikimedia.org/repos/technical-documentation/deployment-pipe... [09:21:10] 10GitLab (Pipeline Services Migration🐀), 10Wikidata, 10Wikidata Query UI, 10collaboration-services, 10wmde-wikidata-tech: move commons-query.wikimedia.org and query.wikidata.org to kubernetes - https://phabricator.wikimedia.org/T350793 (10Lydia_Pintscher) [09:29:45] 10Release-Engineering-Team (Radar), 10Tech-Docs-Team, 10Documentation: Create repository with configuration files for common CI use cases - https://phabricator.wikimedia.org/T352273 (10KBach) >>! In T352273#9407604, @TBurmeister wrote: > I cloned the repo and was able to successfully run the tests and the sa... [09:42:57] 10Release-Engineering-Team (Radar), 10Tech-Docs-Team, 10Documentation: Create a high-level deployment pipeline overview - https://phabricator.wikimedia.org/T349799 (10KBach) First draft (two sections are still a work in progress) is available in my sandbox on mediawiki.org: https://www.mediawiki.org/wiki/Use... [09:57:14] (03CR) 10Hashar: [V: 04-1] Zuul: [mediawiki/extensions/WikEdDiff] Don't use selenium for tests [integration/config] - 10https://gerrit.wikimedia.org/r/975375 (https://phabricator.wikimedia.org/T250967) (owner: 10Zoranzoki21) [10:08:17] 10Release-Engineering-Team, 10Scap, 10Data-Platform-SRE: "scap deploy"'s config-deploy should check for broken symlinks - https://phabricator.wikimedia.org/T342162 (10Gehel) [10:53:41] (03PS1) 10Hashar: Add generated documentation for online publishing [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/983367 [11:10:07] (03PS1) 10Hashar: wm-pcc: only act on Puppet repositories [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/983377 (https://phabricator.wikimedia.org/T353181) [11:27:06] (03CR) 10Hashar: [C: 03+2] wm-pcc: only act on Puppet repositories [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/983377 (https://phabricator.wikimedia.org/T353181) (owner: 10Hashar) [11:27:41] (03Merged) 10jenkins-bot: wm-pcc: only act on Puppet repositories [software/gerrit] (deploy/wmf/stable-3.5) - 10https://gerrit.wikimedia.org/r/983377 (https://phabricator.wikimedia.org/T353181) (owner: 10Hashar) [11:31:11] 10Gerrit: Gerrit UI shows PCC data on non-puppet.git patches that had experimental builds - https://phabricator.wikimedia.org/T353181 (10hashar) 05Openβ†’03Resolved a:03hashar The plugin is a little too broad in processing Jenkins build URL and thus end up generating PCC results for builds that lack the requ... [12:02:18] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: Publish documentation for integration/tox-jenkins-override - https://phabricator.wikimedia.org/T353515 (10hashar) [12:04:34] (03PS1) 10Hashar: Publish job for integration/tox-jenkins-override [integration/config] - 10https://gerrit.wikimedia.org/r/983385 (https://phabricator.wikimedia.org/T353515) [12:05:04] (03PS2) 10Hashar: Add generated documentation for online publishing [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/983367 (https://phabricator.wikimedia.org/T353515) [12:08:19] (03PS1) 10Hashar: doc: add integration/tox-jenkins-override [integration/docroot] - 10https://gerrit.wikimedia.org/r/983386 (https://phabricator.wikimedia.org/T353515) [12:09:12] (03CR) 10CI reject: [V: 04-1] doc: add integration/tox-jenkins-override [integration/docroot] - 10https://gerrit.wikimedia.org/r/983386 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:10:42] (03PS2) 10Hashar: doc: add integration/tox-jenkins-override [integration/docroot] - 10https://gerrit.wikimedia.org/r/983386 (https://phabricator.wikimedia.org/T353515) [12:11:08] (03CR) 10Hashar: [C: 03+2] Publish job for integration/tox-jenkins-override [integration/config] - 10https://gerrit.wikimedia.org/r/983385 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:12:35] (03Merged) 10jenkins-bot: Publish job for integration/tox-jenkins-override [integration/config] - 10https://gerrit.wikimedia.org/r/983385 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:13:12] (03CR) 10Hashar: [C: 03+2] Add generated documentation for online publishing [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/983367 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:15:48] (03Merged) 10jenkins-bot: Add generated documentation for online publishing [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/983367 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:16:38] (03CR) 10Hashar: [C: 03+2] "Success https://doc.wikimedia.org/tox-jenkins-override/" [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/983367 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:16:43] (03CR) 10Hashar: [C: 03+2] doc: add integration/tox-jenkins-override [integration/docroot] - 10https://gerrit.wikimedia.org/r/983386 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:17:19] (03CR) 10CI reject: [V: 04-1] doc: add integration/tox-jenkins-override [integration/docroot] - 10https://gerrit.wikimedia.org/r/983386 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:20:06] (03CR) 10Hashar: "integration/docroot does not pass 8.2 / 8.3" [integration/config] - 10https://gerrit.wikimedia.org/r/982934 (owner: 10Jforrester) [12:20:59] (03PS1) 10Hashar: zuul: integration/docroot does not pass PHP 8.2/8.3 [integration/config] - 10https://gerrit.wikimedia.org/r/983388 [12:21:17] (03CR) 10Hashar: [C: 03+2] zuul: integration/docroot does not pass PHP 8.2/8.3 [integration/config] - 10https://gerrit.wikimedia.org/r/983388 (owner: 10Hashar) [12:22:29] (03Merged) 10jenkins-bot: zuul: integration/docroot does not pass PHP 8.2/8.3 [integration/config] - 10https://gerrit.wikimedia.org/r/983388 (owner: 10Hashar) [12:23:17] (03CR) 10Hashar: [C: 03+2] "Retrying after removing PHP 8.2 / 8.3 from CI ( https://gerrit.wikimedia.org/r/c/integration/config/+/983388 )" [integration/docroot] - 10https://gerrit.wikimedia.org/r/983386 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:23:53] (03Merged) 10jenkins-bot: doc: add integration/tox-jenkins-override [integration/docroot] - 10https://gerrit.wikimedia.org/r/983386 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:31:51] (03PS1) 10Hashar: Add link to online documentation [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/983390 (https://phabricator.wikimedia.org/T353515) [12:32:29] (03CR) 10Hashar: [C: 03+2] Add link to online documentation [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/983390 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:34:59] (03Merged) 10jenkins-bot: Add link to online documentation [integration/tox-jenkins-override] - 10https://gerrit.wikimedia.org/r/983390 (https://phabricator.wikimedia.org/T353515) (owner: 10Hashar) [12:36:41] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Patch-For-Review: Publish documentation for integration/tox-jenkins-override - https://phabricator.wikimedia.org/T353515 (10hashar) 05Openβ†’03Resolved a:03hashar https://doc.wikimedia.org/tox-jenkins-override/ [13:30:33] 10GitLab (Pipeline Services Migration🐀), 10Wikidata, 10Wikidata Query UI, 10collaboration-services, 10wmde-wikidata-tech: move commons-query.wikimedia.org and query.wikidata.org to kubernetes - https://phabricator.wikimedia.org/T350793 (10Gehel) I don't know much about the release process of the GUI (and... [16:21:17] 10Project-Admins, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog: More intuitive names for Phabricator tags "Wikipedia-Android-App-Backlog" and "Wikipedia-iOS-App-Backlog" - https://phabricator.wikimedia.org/T347364 (10Novem_Linguae) 05Openβ†’03Declined [16:59:33] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10phan-taint-check-plugin, 10Patch-For-Review, and 3 others: phan-taint-check gitlab ci security template should use its own image - https://phabricator.wikimedia.org/T352820 (10CodeReviewBot) sbassett merged https://gitlab.wikimedia.org/repos/securi... [16:59:55] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10sbassett) [17:00:59] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10phan-taint-check-plugin, 10Patch-For-Review, and 3 others: phan-taint-check gitlab ci security template should use its own image - https://phabricator.wikimedia.org/T352820 (10sbassett) 05In progressβ†’03Resolved [17:05:58] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: Refactor golang-gosec CI include - https://phabricator.wikimedia.org/T353534 (10sbassett) [17:09:34] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: Create rule-filtering functionality for semgrep-merge-tool rule repos - https://phabricator.wikimedia.org/T353536 (10sbassett) [17:26:48] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10Patch-For-Review, 10SecTeam-Processed, and 2 others: Refactor golang-gosec CI include - https://phabricator.wikimedia.org/T353534 (10CodeReviewBot) sbassett opened https://gitlab.wikimedia.org/repos/security/gitlab-ci-security-templates/-/merge_req... [17:45:23] 10Gitlab-Application-Security-Pipeline, 10Patch-For-Review, 10SecTeam-Processed, 10Security, 10user-sbassett: Improve related gitlab test repository - https://phabricator.wikimedia.org/T348788 (10CodeReviewBot) mmartorana merged https://gitlab.wikimedia.org/repos/security/ci-cd-testing-gitlab-ci-security... [19:48:41] does gerrit have anything like git hooks, e.g. a pre-receive hook to reject commits based on certain conditions? [20:04:32] there's a hooks plugin, I'm not sure if we enable it [20:04:49] h.ashar is our usual Gerrit expert and he's likely afk for dinner / the weekend [20:05:46] yes we do have it enabled https://gerrit.wikimedia.org/r/plugins/hooks/Documentation/index.html [20:06:06] oh nice :) [20:06:18] if you're worried about Windows-clashing files jhathaway the usual way is just a CI check [20:07:02] cdanis: thanks, I was hoping to reuse a git pre-commit hook, so you could have it locally and in CI [20:07:58] you can run CI checks locally too ;) but yeah fair point [20:11:15] cdanis: yeah definitely, would love if there was some obvious seperation between quick checks, that can easily be run on every commit, and those that might work better in CI, but could be run locally. As an example the commit-message-validator should run on every commit I make locally, rather than kicking out patches I submit in CI with mangled trailers [20:11:23] thanks jeena I'll take a look [20:11:32] +1 [20:12:47] jhathaway: maybe this is the hook you would be interested in: https://gerrit.wikimedia.org/r/plugins/hooks/Documentation/hooks.md#commit-received [20:13:03] yup looks like it! [20:13:33] (03PS1) 10Kosta Harlan: jjb: Install MediaWiki in codehealth coverage jobs [integration/config] - 10https://gerrit.wikimedia.org/r/983476 (https://phabricator.wikimedia.org/T347407) [20:14:25] (03PS2) 10Kosta Harlan: jjb: Install MediaWiki in codehealth coverage jobs [integration/config] - 10https://gerrit.wikimedia.org/r/983476 (https://phabricator.wikimedia.org/T347407) [20:43:34] !log Rebooting gitlab-runner-1002.devtools. It was overloaded by a quibble job. [20:43:36] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:04:23] (03PS1) 10Subramanya Sastry: Remove p-hack for gallery captions to make Parsoid compatible [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/983484 [21:05:17] (03CR) 10Subramanya Sastry: "https://gerrit.wikimedia.org/r/c/mediawiki/core/+/727619 is where this hack was removed in core." [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/983484 (owner: 10Subramanya Sastry) [21:07:34] (03PS1) 10Subramanya Sastry: Remove hardcoded reference to vector v1 skin [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/983486 [21:08:02] (03CR) 10Subramanya Sastry: "FYI: I am going to self-merge this after doing a round of visual diff testing." [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/983484 (owner: 10Subramanya Sastry) [21:09:21] (03CR) 10Subramanya Sastry: "FYI: I am going to self-merge this after doing a round of visual diff testing." [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/983486 (owner: 10Subramanya Sastry) [21:31:04] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10User-brennen: A tool for quickly answering what groups an extension is deployed to - https://phabricator.wikimedia.org/T296050 (10CodeReviewBot) brennen merged https://gitlab.wikimedia.org/brennen/extloc/-/merge_requests/1 stub out basic group scraping and display [21:32:24] 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10User-brennen: A tool for quickly answering what groups an extension is deployed to - https://phabricator.wikimedia.org/T296050 (10brennen) 05Openβ†’03Resolved a:03brennen I'll keep noodling on this a bit, but it does the basic things at this point. [22:10:29] 10Gerrit, 10Release-Engineering-Team, 10Projects-Cleanup: Prevent Gerrit archived repositories from being replicated to GitHub - https://phabricator.wikimedia.org/T351543 (10thcipriani) I created [[ https://gerrit.wikimedia.org/r/admin/repos/All-Archived-Projects,access | All-Archived-Projects ]] just now (n... [22:54:49] jhathaway: cdanis: there is no webhooks , no server run of pre-commit hook [22:55:14] jhathaway: Gerrit has support for web hooks but I always refused to set them up (I actually dreamed about that last night) [22:56:04] the flow is for tools/bots/CI to receive a stream events over ssh [22:56:39] for the pre commit hooks, I don't think Gerrit has a way to execute them server side and it is very likely there is no code/itnerface or whatever to even start a plugin for that [22:56:47] so essentially add a CI job :) [22:57:21] jhathaway: commit-message-validator recently got updated to work as a `pre-commit` plugin. That might be a good solution for your desires to run it locally. See https://www.mediawiki.org/wiki/Commit-message-validator [22:57:54] or add the pre-commit hook system to one of the existing entrypoint ( https://www.mediawiki.org/wiki/Continuous_integration/Entry_points ) [23:31:33] hashar: thanks for the clarification, CI it is [23:31:55] bd808: looks like an interesting project, I'll take a look, thanks [23:34:44] jhathaway: related and potentially interesting to you is that commit-message-validator runs the repo's configured pre-commit checks during the CI run too -- https://gitlab.wikimedia.org/repos/ci-tools/commit-message-validator/-/blob/main/tox.ini?ref_type=heads#L22-29 [23:35:16] ah, that is interesting!