[00:05:26] 10Phabricator, 10Release-Engineering-Team (Bonus Level 🕹️), 10collaboration-services, 10serviceops: Deprecate git-ssh service on phabricator.wikimedia.org - https://phabricator.wikimedia.org/T296022 (10Dzahn) @Aklapper Well... let me take a look, something in between. We don't have to delete the entire cla... [00:14:11] 10Release-Engineering-Team (Priority Backlog 📥), 10Wikimedia-Phabricator-Extensions, 10PHP 8.1 support, 10Patch-For-Review: PHP 8.1 "strlen(null)" exception editing MediaWiki Auth provider - https://phabricator.wikimedia.org/T343568 (10Aklapper) [00:14:15] 10Phabricator, 10Wikimedia-Phabricator-Extensions, 10Epic, 10PHP 8.0 support, 10Patch-For-Review: Make WMF custom Phab extensions and code work with PHP8 - https://phabricator.wikimedia.org/T342244 (10Aklapper) [01:43:06] 10GitLab (Auth & Access), 10Release-Engineering-Team (Priority Backlog 📥), 10gitlab-settings, 10Patch-For-Review, 10User-brennen: Create an approved-accounts project in GitLab for distributing account approval process to non-administrators - https://phabricator.wikimedia.org/T350832 (10CodeReviewBot) bd8... [01:43:16] 10GitLab (Auth & Access), 10Release-Engineering-Team (Radar), 10Striker, 10Patch-For-Review: Automatically approve GitLab accounts created by Striker integration - https://phabricator.wikimedia.org/T344667 (10CodeReviewBot) bd808 opened https://gitlab.wikimedia.org/toolforge-repos/gitlab-account-approval/-... [08:27:12] 10Release-Engineering-Team (Priority Backlog 📥), 10Wikimedia-Phabricator-Extensions, 10PHP 8.1 support, 10Patch-For-Review: PHP 8.1 "strlen(null)" exception editing MediaWiki Auth provider - https://phabricator.wikimedia.org/T343568 (10CodeReviewBot) aklapper merged https://gitlab.wikimedia.org/repos/phabr... [08:27:20] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥), 10Wikimedia-Phabricator-Extensions, 10PHP 8.1 support, 10Patch-For-Review: Potential strlen(null) exceptions in custom MediaWiki OAuth code - https://phabricator.wikimedia.org/T343840 (10CodeReviewBot) aklapper merged https://gitlab.wikimedi... [08:28:21] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Priority Backlog 📥), 10Wikimedia-Phabricator-Extensions, 10PHP 8.1 support: PHP 8.1 "strlen(null)" exception editing MediaWiki Auth provider - https://phabricator.wikimedia.org/T343568 (10Aklapper) [08:28:27] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Priority Backlog 📥), 10Wikimedia-Phabricator-Extensions, 10PHP 8.1 support: Potential strlen(null) exceptions in custom MediaWiki OAuth code - https://phabricator.wikimedia.org/T343840 (10Aklapper) [09:17:38] 10Phabricator: Revert custom non-functional "Updated built-in project profile icons" rPHABde19094b2d611147713ade8131d64ad3b44d8036 - https://phabricator.wikimedia.org/T352782 (10Aklapper) a:03Aklapper [09:18:42] 10Phabricator: Revert custom non-functional "Updated built-in project profile icons" rPHABde19094b2d611147713ade8131d64ad3b44d8036 - https://phabricator.wikimedia.org/T352782 (10Aklapper) This custom code change did not "Removed a bunch of brand-specific icons" as its description says. This code changed `getIcon... [09:35:56] 10Phabricator, 10Patch-For-Review: Revert custom non-functional "Updated built-in project profile icons" rPHABde19094b2d611147713ade8131d64ad3b44d8036 - https://phabricator.wikimedia.org/T352782 (10CodeReviewBot) aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/30 Re... [09:40:27] 10Phabricator, 10Patch-For-Review: Revert custom non-functional "Updated built-in project profile icons" rPHABde19094b2d611147713ade8131d64ad3b44d8036 - https://phabricator.wikimedia.org/T352782 (10CodeReviewBot) aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/30 Re... [09:41:32] 10Phabricator (phabricator-next): Revert custom non-functional "Updated built-in project profile icons" rPHABde19094b2d611147713ade8131d64ad3b44d8036 - https://phabricator.wikimedia.org/T352782 (10Aklapper) [09:48:46] 10Phabricator, 10Patch-For-Review: API: `user.search` should output MediaWiki User - https://phabricator.wikimedia.org/T344303 (10CodeReviewBot) aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/15 Conduit API: Include MediaWiki username in user.search output [09:49:04] 10Phabricator (phabricator-next): API: `user.search` should output MediaWiki User - https://phabricator.wikimedia.org/T344303 (10Aklapper) [09:51:10] 10Phabricator, 10Patch-For-Review: Remove unused code in Diffusion to handle closed almanac cluster services - https://phabricator.wikimedia.org/T352530 (10CodeReviewBot) aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/26 Revert custom changes to Almanac cluster ser... [09:51:38] 10Phabricator (phabricator-next): Remove unused code in Diffusion to handle closed almanac cluster services - https://phabricator.wikimedia.org/T352530 (10Aklapper) [09:56:16] 10Phabricator, 10Patch-For-Review: Remove custom go-get / go-import code in Diffusion repositories - https://phabricator.wikimedia.org/T352322 (10CodeReviewBot) aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/25 Remove custom go-get / go-import code in Diffusion rep... [09:59:41] 10Phabricator, 10Release-Engineering-Team (Quid Pro Crow 🦃), 10Wikimedia-Phabricator-Extensions, 10Patch-For-Review: Remove unused custom /src/elasticsearch/ code - https://phabricator.wikimedia.org/T351085 (10CodeReviewBot) aklapper merged https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_... [10:00:01] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Quid Pro Crow 🦃), 10Wikimedia-Phabricator-Extensions: Remove unused custom /src/elasticsearch/ code - https://phabricator.wikimedia.org/T351085 (10Aklapper) [10:28:42] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10Jelto) a:03Jelto [10:28:57] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10CodeReviewBot) jelto opened https://gitlab.wikimedia.org/repos/releng/gitlab-trusted-runner/-/merge_r... [10:29:31] 10Phabricator: Revert to using upstream src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementWorkflow.php - https://phabricator.wikimedia.org/T352721 (10Aklapper) The description of {T333885} does not list a conflict for `src/infrastructure/daemon/workers/management/PhabricatorWorkerManagement... [10:38:26] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10CodeReviewBot) jelto merged https://gitlab.wikimedia.org/repos/releng/gitlab-trusted-runner/-/merge_r... [11:15:54] 10Phabricator, 10Release-Engineering-Team (Escape Goats🐐), 10VPS-project-Phabricator, 10User-brennen: After a deployment, Phabricator errors out with `Unable to load the "Arcanist" library. Put "arcanist/" next to "phabricator/" on disk.` - https://phabricator.wikimedia.org/T314460 (10Aklapper) >>! In T314... [11:18:47] 10Phabricator, 10Wikimedia-Phabricator-Extensions, 10Patch-For-Review: Remove custom src/customfields/DifferentialApplyPatchWithOnlyGitField.php - https://phabricator.wikimedia.org/T342041 (10CodeReviewBot) aklapper opened https://gitlab.wikimedia.org/repos/phabricator/extensions/-/merge_requests/27 Revert... [11:19:06] 10Phabricator, 10Wikimedia-Phabricator-Extensions, 10Patch-For-Review: Remove custom src/customfields/DifferentialApplyPatchWithOnlyGitField.php - https://phabricator.wikimedia.org/T342041 (10Aklapper) 05Stalled→03Open a:03Aklapper [12:50:17] 10Phabricator: Rename request (ClydeFranklin) - https://phabricator.wikimedia.org/T352723 (10Aklapper) @ClydeFranklin: Could you please answer the last comment? [12:54:50] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review: InvalidArgumentException trying to render workboards when "Other Assignee" undefined - https://phabricator.wikimedia.org/T336135 (10CodeReviewBot) aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/m... [12:56:01] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Priority Backlog 📥): InvalidArgumentException trying to render workboards when "Other Assignee" undefined - https://phabricator.wikimedia.org/T336135 (10Aklapper) a:05brennen→03Aklapper [12:59:03] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Priority Backlog 📥), 10Wikimedia-Phabricator-Extensions: Custom default project menu items have wrong description, typos, use outdated code repo URL - https://phabricator.wikimedia.org/T337297 (10CodeReviewBot) aklapper merged https://gitlab.wikim... [12:59:30] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Priority Backlog 📥), 10Wikimedia-Phabricator-Extensions: Custom default project menu items have wrong description, typos, use outdated code repo URL - https://phabricator.wikimedia.org/T337297 (10Aklapper) a:05brennen→03Aklapper [13:06:48] 10GitLab-Test, 10Release-Engineering-Team, 10cloud-services-team, 10collaboration-services, 10Cloud-VPS (Quota-requests): Request additional resources for devtools project - https://phabricator.wikimedia.org/T353671 (10Jelto) [13:50:35] (03PS1) 10Slyngshede: Review access change [software/debmonitor-client] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/984171 [13:59:12] (03CR) 10Slyngshede: [V: 03+2 C: 03+2] Review access change [software/debmonitor-client] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/984171 (owner: 10Slyngshede) [14:47:55] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥), 10Wikimedia-Phabricator-Extensions, 10Patch-For-Review: Phabricator Project Reports have inaccurate counts for the age histogram - https://phabricator.wikimedia.org/T294998 (10CodeReviewBot) aklapper opened https://gitlab.wikimedia.org/repos/p... [14:51:05] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review: Phabricator Project Reports have inaccurate counts for the age histogram - https://phabricator.wikimedia.org/T294998 (10Aklapper) a:03Aklapper [14:52:37] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥), 10Patch-For-Review: Phabricator Project Reports have inaccurate counts for the age histogram - https://phabricator.wikimedia.org/T294998 (10CodeReviewBot) aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_request... [14:52:49] 10Phabricator (phabricator-next), 10Release-Engineering-Team (Priority Backlog 📥): Phabricator Project Reports have inaccurate counts for the age histogram - https://phabricator.wikimedia.org/T294998 (10Aklapper) [15:05:01] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10Jelto) [15:39:37] 10Phabricator, 10Release-Engineering-Team, 10collaboration-services, 10User-AKlapper: Establish a workflow that scales for requesting Phab 2FA resets - https://phabricator.wikimedia.org/T306708 (10JLam-WMF) If I might insert some input from the Service Desk team, we have established our own [[ https://docs... [15:43:18] 10Release-Engineering-Team, 10Scap: scap backport non_config_is_in_production() check doesn't work right for VisualEditor/VisualEditor repo - https://phabricator.wikimedia.org/T353720 (10dancy) [15:43:38] 10Release-Engineering-Team, 10Scap: scap backport non_config_is_in_production() check doesn't work right for VisualEditor/VisualEditor repo - https://phabricator.wikimedia.org/T353720 (10dancy) @jeena FYI [15:45:12] 10Project-Admins, 10Machine-Learning-Team: Create three Phab Projects for Machine Learning: Lift Wing, Pilot Flag, Test Grounds - https://phabricator.wikimedia.org/T264774 (10calbon) 05Open→03Declined [15:46:44] (03PS1) 10Lucas Werkmeister (WMDE): Zuul: [mediawiki/extensions/Wikibase] Disable Phan on release branches [integration/config] - 10https://gerrit.wikimedia.org/r/984222 (https://phabricator.wikimedia.org/T226945) [16:03:42] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10Documentation, 10SecTeam-Processed, 10Security: Update on-wiki documentation for the AppSec Pipeline for phase 2 work - https://phabricator.wikimedia.org/T346802 (10mmartorana) [16:07:36] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10Documentation, 10SecTeam-Processed, 10Security: Update on-wiki documentation for the AppSec Pipeline for phase 2 work - https://phabricator.wikimedia.org/T346802 (10mmartorana) [16:09:03] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10Documentation, 10SecTeam-Processed, 10Security: Update on-wiki documentation for the AppSec Pipeline for phase 2 work - https://phabricator.wikimedia.org/T346802 (10mmartorana) [16:09:39] 10Phabricator, 10Release-Engineering-Team, 10collaboration-services, 10User-AKlapper: Establish a workflow that scales for requesting Phab 2FA resets - https://phabricator.wikimedia.org/T306708 (10Dzahn) @JLam-WMF Thanks for this! One small question, out of curiosity, how do you determine who the manager o... [16:09:42] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10Documentation, 10SecTeam-Processed, 10Security: Update on-wiki documentation for the AppSec Pipeline for phase 2 work - https://phabricator.wikimedia.org/T346802 (10mmartorana) 05In progress→03Resolved [16:09:48] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10mmartorana) [16:33:51] 10Phabricator, 10Release-Engineering-Team, 10collaboration-services, 10User-AKlapper: Establish a workflow that scales for requesting Phab 2FA resets - https://phabricator.wikimedia.org/T306708 (10JLam-WMF) Ah, there's the rub I guess. We have access to that info via Okta. I guess that creates something... [17:21:54] 10Phabricator: Various AphrontQueryTimeoutQueryException in Phabricator global search - https://phabricator.wikimedia.org/T353738 (10Bugreporter) [17:22:24] 10Phabricator: Various AphrontQueryTimeoutQueryException in Phabricator global search - https://phabricator.wikimedia.org/T353738 (10Bugreporter) [19:44:50] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10Patch-For-Review, 10SecTeam-Processed, and 2 others: Create rule-filtering functionality for semgrep-merge-tool rule repos - https://phabricator.wikimedia.org/T353536 (10CodeReviewBot) sbassett opened https://gitlab.wikimedia.org/repos/security/sem... [19:48:29] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: Add basic unit tests and CI support for semgrep-merge-tool - https://phabricator.wikimedia.org/T353747 (10sbassett) [19:48:38] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security: Add basic unit tests and CI support for semgrep-merge-tool - https://phabricator.wikimedia.org/T353747 (10sbassett) [20:18:03] (03CR) 10Ahmon Dancy: [C: 04-2] "I'm going to add rsync in a deeper image." [integration/config] - 10https://gerrit.wikimedia.org/r/983892 (owner: 10Ahmon Dancy) [20:18:36] 10Phabricator, 10Release-Engineering-Team (Bonus Level 🕹️), 10collaboration-services, 10serviceops, 10Patch-For-Review: Deprecate git-ssh service on phabricator.wikimedia.org - https://phabricator.wikimedia.org/T296022 (10Dzahn) >>! In T296022#9411591, @Aklapper wrote: > The `operations/puppet` repo stil... [20:26:20] (03PS2) 10Ahmon Dancy: Add rsync to ci-{buster,bullseye,bookworm} images. [integration/config] - 10https://gerrit.wikimedia.org/r/983892 [20:26:28] (03CR) 10Ahmon Dancy: Add rsync to ci-{buster,bullseye,bookworm} images. [integration/config] - 10https://gerrit.wikimedia.org/r/983892 (owner: 10Ahmon Dancy) [20:31:32] (03PS3) 10Ahmon Dancy: Add rsync to ci-{buster,bullseye,bookworm} images. [integration/config] - 10https://gerrit.wikimedia.org/r/983892 [20:55:07] 10GitLab (Auth & Access), 10Release-Engineering-Team (Priority Backlog 📥), 10gitlab-settings, 10User-brennen: Create an approved-accounts project in GitLab for distributing account approval process to non-administrators - https://phabricator.wikimedia.org/T350832 (10CodeReviewBot) bd808 merged https://gitl... [21:11:15] 10GitLab: Account pending approval banner shown on initial sign-in gives no context for how to proceed - https://phabricator.wikimedia.org/T353752 (10bd808) [21:21:28] (03CR) 10Ahmon Dancy: [C: 04-1] "not right" [integration/config] - 10https://gerrit.wikimedia.org/r/983892 (owner: 10Ahmon Dancy) [21:23:27] (03PS4) 10Ahmon Dancy: Add rsync to ci-{buster,bullseye,bookworm} images. [integration/config] - 10https://gerrit.wikimedia.org/r/983892 [21:40:48] 10GitLab: Account pending approval banner shown on initial sign-in gives no context for how to proceed - https://phabricator.wikimedia.org/T353752 (10bd808) Subsequent login attempts keep showing the user the same screen and banner until the account has been approved. The "New signins require approval; ..." bann... [21:46:23] 10GitLab: Account pending approval banner shown on initial sign-in gives no context for how to proceed - https://phabricator.wikimedia.org/T353752 (10brennen) Thought: Maybe [[https://gitlab.wikimedia.org/toolforge-repos/gitlab-account-approval/ | gitlab-account-approval]] could send a one-time message directing... [21:54:56] 10Release-Engineering-Team, 10Fundraising-Backlog, 10MediaWiki-extensions-FundraiserLandingPage, 10donate.wikimedia.org, and 2 others: donate.wikimedia.org landing pages don't have descriptions in search engine results - https://phabricator.wikimedia.org/T254808 (10AKanji-WMF) [22:10:24] 10Phabricator: Various AphrontQueryTimeoutQueryException in Phabricator global search - https://phabricator.wikimedia.org/T353738 (10Aklapper) The less specific the search query and the bigger our Phabricator database over time, the more likely broad search queries will hit the query limit, basically. Could you... [22:10:35] 10Phabricator (Search): Various AphrontQueryTimeoutQueryException in Phabricator global search - https://phabricator.wikimedia.org/T353738 (10Aklapper) [22:22:42] 10GitLab: Account pending approval banner shown on initial sign-in gives no context for how to proceed - https://phabricator.wikimedia.org/T353752 (10bd808) I finally did get shown the "New signins require approval; ..." banner when visiting https://gitlab.wikimedia.org/ with an existing session (no redirection... [22:45:31] (03CR) 10Thcipriani: [C: 03+1] "my only nit here is that images that inherit from two different base images have two changelog entries for what amounts to one change." [integration/config] - 10https://gerrit.wikimedia.org/r/983892 (owner: 10Ahmon Dancy) [22:58:51] (03PS5) 10Ahmon Dancy: Add rsync to ci-{buster,bullseye,bookworm} images. [integration/config] - 10https://gerrit.wikimedia.org/r/983892 [22:59:20] (03CR) 10Ahmon Dancy: Add rsync to ci-{buster,bullseye,bookworm} images. (034 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/983892 (owner: 10Ahmon Dancy) [23:00:26] (03CR) 10Ahmon Dancy: Add rsync to ci-{buster,bullseye,bookworm} images. (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/983892 (owner: 10Ahmon Dancy) [23:06:14] (03CR) 10Ahmon Dancy: Add rsync to ci-{buster,bullseye,bookworm} images. (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/983892 (owner: 10Ahmon Dancy) [23:08:18] (03CR) 10Ahmon Dancy: Add rsync to ci-{buster,bullseye,bookworm} images. (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/983892 (owner: 10Ahmon Dancy) [23:08:59] (03PS6) 10Ahmon Dancy: Add rsync to ci-{buster,bullseye,bookworm} images. [integration/config] - 10https://gerrit.wikimedia.org/r/983892 [23:10:01] (03CR) 10Ahmon Dancy: "I reverted back to patchset 4 which is the most consistent." [integration/config] - 10https://gerrit.wikimedia.org/r/983892 (owner: 10Ahmon Dancy) [23:33:25] (03PS1) 10Subramanya Sastry: Don't strip skin + expand Vector 2022 viewport to max size [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/984296 [23:34:07] (03CR) 10CI reject: [V: 04-1] Don't strip skin + expand Vector 2022 viewport to max size [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/984296 (owner: 10Subramanya Sastry) [23:34:25] (03CR) 10Subramanya Sastry: [C: 03+2] "self +2ing this change since I've already run visual diff tests with this and we can always revert it if we want to go back to the previou" [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/984296 (owner: 10Subramanya Sastry) [23:34:59] (03CR) 10CI reject: [V: 04-1] Don't strip skin + expand Vector 2022 viewport to max size [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/984296 (owner: 10Subramanya Sastry) [23:37:41] (03PS2) 10Subramanya Sastry: Don't strip skin + expand Vector 2022 viewport to max size [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/984296 [23:38:51] (03CR) 10Subramanya Sastry: [C: 03+2] Don't strip skin + expand Vector 2022 viewport to max size [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/984296 (owner: 10Subramanya Sastry) [23:39:30] (03Merged) 10jenkins-bot: Don't strip skin + expand Vector 2022 viewport to max size [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/984296 (owner: 10Subramanya Sastry)