[00:45:27] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10Russian-Sites: Add Extension:PlaceNewSection to Russian Wikipedia - https://phabricator.wikimedia.org/T344501 (10Ernstkm) OK, I agree. I only asked because I don't know the first thing about Gerrit, and figured GitLab would be easier to get things ro... [01:03:37] 10GitLab (Administration, Settings & Policy), 10Release-Engineering-Team, 10gitlab-settings, 10User-brennen: Add a timer to run gitlab-settings/configure-projects - https://phabricator.wikimedia.org/T355097 (10brennen) [01:04:11] 10GitLab (Administration, Settings & Policy), 10Release-Engineering-Team, 10gitlab-settings, 10User-brennen: Add a timer to run gitlab-settings/configure-projects - https://phabricator.wikimedia.org/T355097 (10brennen) p:05Triage→03High [03:58:10] 10Release-Engineering-Team (Priority Backlog 📥), 10Release, 10Train Deployments: 1.42.0-wmf.14 deployment blockers - https://phabricator.wikimedia.org/T354432 (10Tgr) ##### Risky Patch! 🚂🔥 * **Change**: {0afe7f7c99cd7706c3bbb6d0ed07bd2bf2c6b207} * **Summary**: ** Previously, setting a user preference to t... [08:23:50] (03PS1) 10DCausse: sonar: analyze with java 17 [integration/config] - 10https://gerrit.wikimedia.org/r/990944 [08:35:24] 10Release-Engineering-Team (Priority Backlog 📥), 10Release, 10Train Deployments: 1.42.0-wmf.14 deployment blockers - https://phabricator.wikimedia.org/T354432 (10jnuche) [08:47:03] (03CR) 10DCausse: "test patch: https://gerrit.wikimedia.org/r/c/wikidata/query/rdf/+/990717" [integration/config] - 10https://gerrit.wikimedia.org/r/990944 (owner: 10DCausse) [09:00:45] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10Jelto) The design-strategy repo got an update in Gerrit so I had to rebase it to the GitLab repositor... [09:36:04] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [extensions/PlaceNewSection] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/990955 [09:36:06] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [extensions/PlaceNewSection] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/990955 (owner: 10QChris) [09:36:08] (03PS1) 10QChris: Import done. Revoke import grants [extensions/PlaceNewSection] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/990956 [09:36:10] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [extensions/PlaceNewSection] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/990956 (owner: 10QChris) [09:47:39] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10Russian-Sites: Add Extension:PlaceNewSection to Russian Wikipedia - https://phabricator.wikimedia.org/T344501 (10QChris) The Gerrit repo is ready: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/PlaceNewSection [09:49:23] (03PS1) 10QChris: Allow “Gerrit Managers” to import history [skins/Aether] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/990958 [09:49:27] (03CR) 10QChris: [V: 03+2 C: 03+2] Allow “Gerrit Managers” to import history [skins/Aether] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/990958 (owner: 10QChris) [09:49:31] (03PS1) 10QChris: Import done. Revoke import grants [skins/Aether] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/990959 [09:49:35] (03CR) 10QChris: [V: 03+2 C: 03+2] Import done. Revoke import grants [skins/Aether] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/990959 (owner: 10QChris) [10:12:48] 10Project-Admins, 10Tracking-Neverending: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10WMDE-leszek) >>! In T706#9383800, @WMDE-leszek wrote: > Kindly asking to have the following accounts of my WMDE colleagues added > @Deniz_WMDE @Fring @Andre... [10:31:15] 10Gerrit, 10Upstream: Gerrit allows merging the same patch twice - https://phabricator.wikimedia.org/T355080 (10hashar) Indeed the `git cherry-pick` command creates a commit which is empty and git bails out since it is most probably a user mistake. `git rebase` or `git cherry-pick` commands, both rely on `git-... [10:34:41] 10Release-Engineering-Team, 10Data-Engineering, 10Data-Platform, 10Data-Platform-SRE, 10Discovery-Search: SonarQube build are failing with Java 11 - https://phabricator.wikimedia.org/T355122 (10Gehel) [10:37:51] (03PS2) 10DCausse: sonar: analyze with java 17 [integration/config] - 10https://gerrit.wikimedia.org/r/990944 (https://phabricator.wikimedia.org/T355122) [10:38:28] (03CR) 10Gehel: [C: 03+1] "LGTM" [integration/config] - 10https://gerrit.wikimedia.org/r/990944 (https://phabricator.wikimedia.org/T355122) (owner: 10DCausse) [10:42:33] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10Jelto) [11:27:32] 10Continuous-Integration-Config, 10SonarQube Bot, 10Quality-and-Test-Engineering-Team (SonarCloud Admin): Upgrade SonarQube / codehealth jobs to use Java 17 - https://phabricator.wikimedia.org/T349983 (10hashar) [11:27:37] 10Release-Engineering-Team, 10Data-Engineering, 10Data-Platform, 10Data-Platform-SRE, and 2 others: SonarQube build are failing with Java 11 - https://phabricator.wikimedia.org/T355122 (10hashar) [11:30:01] 10Release-Engineering-Team, 10Data-Engineering, 10Data-Platform, 10Data-Platform-SRE, and 2 others: SonarQube build are failing with Java 11 - https://phabricator.wikimedia.org/T355122 (10hashar) I though I got them all after @pwangai filed {T349983} but that only covered the job using the releng/sonar-sca... [11:32:05] (03CR) 10Hashar: [C: 03+2] "INFO:jenkins_jobs.builder:Number of jobs generated: 23" [integration/config] - 10https://gerrit.wikimedia.org/r/990944 (https://phabricator.wikimedia.org/T355122) (owner: 10DCausse) [11:32:13] dcaro: merci pour le patch :) [11:32:16] err [11:32:18] wrong david [11:32:22] dcausse: merci pour le patch [11:33:51] (03Merged) 10jenkins-bot: sonar: analyze with java 17 [integration/config] - 10https://gerrit.wikimedia.org/r/990944 (https://phabricator.wikimedia.org/T355122) (owner: 10DCausse) [11:36:30] 10Continuous-Integration-Config, 10SonarQube Bot, 10Quality-and-Test-Engineering-Team (SonarCloud Admin): Upgrade SonarQube / codehealth jobs to use Java 17 - https://phabricator.wikimedia.org/T349983 (10hashar) [11:37:20] 10Release-Engineering-Team, 10Data-Engineering, 10Data-Platform, 10Data-Platform-SRE, and 2 others: SonarQube build are failing with Java 11 - https://phabricator.wikimedia.org/T355122 (10hashar) 05Open→03Resolved a:03dcausse I have updated all the jobs. Please reopen / poke me on IRC if adjustments... [11:40:02] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10CodeReviewBot) jelto opened https://gitlab.wikimedia.org/repos/releng/gitlab-trusted-runner/-/merge_r... [11:41:57] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10Jelto) Traffic for design services was switched to wikikube and traffic for `/`, `/strategy` and `blo... [11:51:16] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10CodeReviewBot) jelto merged https://gitlab.wikimedia.org/repos/releng/gitlab-trusted-runner/-/merge_r... [11:57:05] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10CodeReviewBot) jelto opened https://gitlab.wikimedia.org/repos/sre/miscweb/design-style-guide/-/merge... [11:58:28] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10CodeReviewBot) jelto merged https://gitlab.wikimedia.org/repos/sre/miscweb/design-style-guide/-/merge... [12:35:40] 10Release-Engineering-Team, 10Data-Engineering, 10Data-Platform, 10Data-Platform-SRE, 10Discovery-Search: SonarQube build are failing with Java 11 - https://phabricator.wikimedia.org/T355122 (10gmodena) Java CI jobs started failing with ` 13:29:44 [ERROR] Failed to execute goal on project refinery-spark:... [13:11:39] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10Jelto) [13:14:30] hashar: tu es le bienvenu :) [13:16:04] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10Jelto) All design services run on wikikube now (`/`, `/strategy`, `/blog` and `/style-guide`). Althou... [13:23:10] 10Release-Engineering-Team, 10Data-Engineering, 10Data-Platform, 10Data-Platform-SRE, 10Discovery-Search: SonarQube build are failing with Java 11 - https://phabricator.wikimedia.org/T355122 (10dcausse) tools.jar should only be in jdk8, I'm surprised that this problem did not occur while sonar was runnin... [13:24:17] 10Release-Engineering-Team, 10Data-Engineering, 10Data-Platform, 10Data-Platform-SRE, 10Discovery-Search (Current work): SonarQube build are failing with Java 11 - https://phabricator.wikimedia.org/T355122 (10Gehel) [13:41:27] btullis: :) [13:41:40] btullis: I should have kept youin the loop for https://gerrit.wikimedia.org/r/c/operations/docker-images/production-images/+/989786 [13:41:49] since I was live hacking it while talking about it with brouberol [13:42:00] my fault for not doing the sync in a public channel and ccing you [13:42:42] Ah, no worries. [13:43:13] +1 ed [13:43:27] whether the `&&` are the start or end of lines doesnot matter [13:43:39] brouberol can build them I guess [13:43:49] it might be necessary to invoke docker-pkg twice due to some oddity [13:44:00] Thanks very much. [14:05:14] 10Release-Engineering-Team (Priority Backlog 📥), 10Projects-Cleanup, 10collaboration-services: Migrate SRE repositories to GitLab - Archiving unused Gerrit repositories - https://phabricator.wikimedia.org/T343707 (10LSobanski) Here's an unusual case: operations/debs/prometheus has been migrated but still has... [14:11:29] (03CR) 10Jforrester: layout.yaml: Run tox-docker on ConfirmEdit extension (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:19:53] 10Release-Engineering-Team, 10Gerrit (Gerrit 3.7), 10Patch-For-Review: Upgrade to Gerrit 3.7 - https://phabricator.wikimedia.org/T354885 (10hashar) [14:20:11] 10Release-Engineering-Team, 10Gerrit (Gerrit 3.7): Migrate approval fields in labels configuration - https://phabricator.wikimedia.org/T355068 (10hashar) 05Open→03Declined I have created a dummy Gerrit 3.6.8 locally and copied our label configuration. I then ran the 3.7 initialization: ` Migrating data to... [14:20:42] 10Continuous-Integration-Config, 10Gerrit, 10Upstream: mwext-phpunit-coverage-patch-docker votes, gets overridden - https://phabricator.wikimedia.org/T336660 (10hashar) Self note, Gerrit 3.7 changes the default to `copyAllScoresIfNoChange = false` (ref: T355068 and [[ https://gerrit-review.googlesource.com/c... [14:23:05] (03CR) 10Reedy: layout.yaml: Run tox-docker on ConfirmEdit extension (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:23:50] (03CR) 10Jforrester: layout.yaml: Run tox-docker on ConfirmEdit extension (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:33:36] (03PS2) 10Reedy: layout.yaml: Run tox-docker on ConfirmEdit extension [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) [14:34:42] (03CR) 10CI reject: [V: 04-1] layout.yaml: Run tox-docker on ConfirmEdit extension [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:37:59] (03PS3) 10Reedy: layout.yaml: Run extension-tox-docker on ConfirmEdit extension [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) [14:39:04] (03CR) 10CI reject: [V: 04-1] layout.yaml: Run extension-tox-docker on ConfirmEdit extension [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:41:58] Reedy: Want me to take a twirl? [14:42:18] James_F: I imagine it's gonna be a lot quicker <3 [14:42:48] I should probably do a commit to add a tox config file... which is probably an easy copy pasta from somewhere else [14:43:20] :-) [14:43:23] Yeah. [14:43:34] and then cry at all the code style errors [14:45:36] Yes. [14:45:42] Also it'll apply to all branches. [14:45:44] 10Continuous-Integration-Config: Environements typo spread throughout tox.ini - https://phabricator.wikimedia.org/T355151 (10Reedy) [14:45:47] So fun times backporting fixes. [14:45:51] 10Continuous-Integration-Config: Environements typo spread throughout tox.ini - https://phabricator.wikimedia.org/T355151 (10Reedy) p:05Triage→03Low [14:48:39] 10Release-Engineering-Team (Onboarding 🚀), 10Scap, 10User-brennen: scap deploy-promote uses latest train blocker, which is wrong if a train has been blocked over the weekend - https://phabricator.wikimedia.org/T336179 (10Sandeeps) 05Open→03In progress [14:48:50] (03PS4) 10Jforrester: Zuul: [mediawiki/extensions/ConfirmEdit] Run mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:48:52] (03PS1) 10Jforrester: jjb: Provide mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/991028 (https://phabricator.wikimedia.org/T355151) [14:48:58] 10Release-Engineering-Team (Onboarding 🚀), 10Scap, 10User-brennen: scap deploy-promote uses latest train blocker, which is wrong if a train has been blocked over the weekend - https://phabricator.wikimedia.org/T336179 (10Sandeeps) 05In progress→03Open [14:50:44] 10Continuous-Integration-Config, 10Patch-For-Review: Environements typo spread throughout tox.ini - https://phabricator.wikimedia.org/T355151 (10Reedy) [14:51:23] (03CR) 10Jforrester: [C: 03+2] jjb: Provide mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/991028 (https://phabricator.wikimedia.org/T355151) (owner: 10Jforrester) [14:51:45] (03CR) 10Jforrester: [C: 03+2] Zuul: [mediawiki/extensions/ConfirmEdit] Run mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:51:48] (03CR) 10Hashar: "I am not sure T355151 is the correct task is it?" [integration/config] - 10https://gerrit.wikimedia.org/r/991028 (https://phabricator.wikimedia.org/T355151) (owner: 10Jforrester) [14:52:05] heh [14:52:16] me causing confusion [14:52:26] Oh bah. [14:52:38] (03CR) 10Jforrester: jjb: Provide mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/991028 (https://phabricator.wikimedia.org/T355151) (owner: 10Jforrester) [14:53:05] (03CR) 10CI reject: [V: 04-1] Zuul: [mediawiki/extensions/ConfirmEdit] Run mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:53:13] (03PS2) 10Jforrester: jjb: Provide mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/991028 (https://phabricator.wikimedia.org/T355090) [14:53:18] (03CR) 10Jforrester: [C: 03+2] jjb: Provide mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/991028 (https://phabricator.wikimedia.org/T355090) (owner: 10Jforrester) [14:53:51] 10Continuous-Integration-Config, 10ConfirmEdit (CAPTCHA extension), 10Patch-For-Review: Provide Python linting, ideally enforced via CI, for ConfirmEdit - https://phabricator.wikimedia.org/T355090 (10Jdforrester-WMF) [14:54:33] (03Merged) 10jenkins-bot: jjb: Provide mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/991028 (https://phabricator.wikimedia.org/T355090) (owner: 10Jforrester) [14:55:02] (03PS5) 10Jforrester: Zuul: [mediawiki/extensions/ConfirmEdit] Run mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:55:16] (03CR) 10Jforrester: "…" [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:56:29] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/ConfirmEdit] Run mwgate-tox-docker [integration/config] - 10https://gerrit.wikimedia.org/r/990741 (https://phabricator.wikimedia.org/T355090) (owner: 10Reedy) [14:56:48] !log Zuul: [mediawiki/extensions/ConfirmEdit] Run mwgate-tox-docker for T355090 [14:56:51] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:56:51] T355090: Provide Python linting, ideally enforced via CI, for ConfirmEdit - https://phabricator.wikimedia.org/T355090 [14:56:57] Reedy: It's now live. Good luck! [14:57:18] haha [14:57:44] (03PS3) 10Jforrester: Docker: Drop all node16 images, no longer used [integration/config] - 10https://gerrit.wikimedia.org/r/990137 (https://phabricator.wikimedia.org/T331180) [14:57:50] thanks! [14:58:02] (03CR) 10Jforrester: [C: 03+2] "Let's do it." [integration/config] - 10https://gerrit.wikimedia.org/r/990137 (https://phabricator.wikimedia.org/T331180) (owner: 10Jforrester) [14:59:14] (03Merged) 10jenkins-bot: Docker: Drop all node16 images, no longer used [integration/config] - 10https://gerrit.wikimedia.org/r/990137 (https://phabricator.wikimedia.org/T331180) (owner: 10Jforrester) [15:02:22] well, that's definitely a few errors - https://integration.wikimedia.org/ci/job/mwgate-tox-docker/2/console [15:02:44] Fun. [15:03:27] Especially good luck with the backports, (he says as he goes for a walk in the snow). [15:03:41] I'm just gonna do like we do for PHPCS [15:03:51] Disable the failing rules, get that merged, and work from there [15:05:25] but it's had the desired effect too, it finds bugs [15:13:54] lolol that's a pile of flake8 whines there [15:16:08] well over 10+ year old script with not much love... :D [15:16:29] So why is it now complaining about stuff I already ignored... [15:16:51] oh, semicolon I bet [15:25:06] 10Continuous-Integration-Config, 10ConfirmEdit (CAPTCHA extension), 10Patch-For-Review: Provide Python linting, ideally enforced via CI, for ConfirmEdit - https://phabricator.wikimedia.org/T355090 (10Reedy) 05Open→03Resolved Yay! [15:26:30] \o/ [15:31:55] 10Phabricator: Reset 2FA for Dringsim in Phabricator - https://phabricator.wikimedia.org/T354956 (10Dringsim) ` -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 As of 2024-01-16, I, 沈澄心 (Dringsim, dringsim [at] qq.com), have lost my TOTP 2FA credentials for my Wikimedia Phabricator account (Dringsim), and reques... [15:32:44] 10Phabricator: Reset 2FA for Dringsim in Phabricator - https://phabricator.wikimedia.org/T354956 (10Dringsim) [15:34:26] 10GitLab (Pipeline Services Migration🐤), 10Wikimedia-Design, 10collaboration-services, 10Design, 10Patch-For-Review: move design.wikimedia.org to kubernetes - https://phabricator.wikimedia.org/T350791 (10DDeSouza) > And the design team deployers (@Volker_E and @DDeSouza?) should be onboarded to the new d... [15:49:46] and backported [15:49:49] that wasn't too painful :) [15:51:32] hi releng! Are you seeing a core QUnit test fail on any other extensions? CentralNotice patches are all getting V-1 due to ✖ saveOptions without Unit Separator [15:51:41] e.g. https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/147559/console [15:52:04] triggered by this patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/991018 [15:52:12] which just updates some SVGs [15:52:27] but the rest of the CN patches in review are getting the same thing [15:57:06] (03PS1) 10Zfilipin: jjb: Create selenium-daily-beta-CampaignEvents [integration/config] - 10https://gerrit.wikimedia.org/r/991034 (https://phabricator.wikimedia.org/T354713) [15:58:04] (03CR) 10Vaughn Walters: [C: 03+1] jjb: Create selenium-daily-beta-CampaignEvents [integration/config] - 10https://gerrit.wikimedia.org/r/991034 (https://phabricator.wikimedia.org/T354713) (owner: 10Zfilipin) [16:01:17] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177 (10sbassett) [16:01:38] 10Gitlab-Application-Security-Pipeline, 10Security-Team, 10SecTeam-Processed, 10Security, 10user-sbassett: Create rule-filtering functionality for semgrep-merge-tool rule repos - https://phabricator.wikimedia.org/T353536 (10sbassett) 05Open→03Resolved [16:03:29] !log Updated gitlab-runner to 16.5.0 in gitlab-cloud-runners. [16:03:31] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:07:00] 10GitLab (Project Migration), 10Traffic, 10Patch-For-Review: Migrate Traffic repositories from Gerrit to Gitlab - https://phabricator.wikimedia.org/T347623 (10BCornwall) [16:11:54] 10GitLab (Project Migration), 10Traffic, 10Patch-For-Review: Migrate Traffic repositories from Gerrit to Gitlab - https://phabricator.wikimedia.org/T347623 (10BCornwall) [16:36:01] (03PS1) 10VolkerE: Remove 'WikimediaUI Base' and replace with 'Codex Design Tokens' [integration/docroot] - 10https://gerrit.wikimedia.org/r/991040 (https://phabricator.wikimedia.org/T354310) [17:02:08] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10Russian-Sites: Add Extension:PlaceNewSection to Russian Wikipedia - https://phabricator.wikimedia.org/T344501 (10Iniquity) [17:12:11] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10Russian-Sites: Add Extension:PlaceNewSection to Russian Wikipedia - https://phabricator.wikimedia.org/T344501 (10Iniquity) Thanks a lot! A have started review process :) [17:12:22] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10Russian-Sites: Add Extension:PlaceNewSection to Russian Wikipedia - https://phabricator.wikimedia.org/T344501 (10Iniquity) [17:12:45] hey folks. I'm receiving the following error when pulling from a repo (deploy2002): [17:12:45] fatal: bad object fc850230e09422a438d10184d8f45baa9ac2e2d0 [17:12:45] error: https://gerrit.wikimedia.org/r/p/analytics/refinery.git did not send all necessary objects [17:12:45] does this maybe ring a bell? [17:13:01] gmodena: Are you starting from a shallow clone? [17:13:18] Sometimes that error comes up when trying to hydrate a shallow clone, I believe. [17:13:58] I don't _think_ so. I'm following a deployment how to for a repo that was provisioned on the host. [17:14:15] James_F: I'm getting the same error running `git pull` against that repository from an existing working copy on my workstation. [17:14:21] FWIW I can't checkout the repo with git clone "ssh://gmodena@gerrit.wikimedia.org:29418/analytics/refinery" either [17:14:21] [17:54:13] fatal: did not receive expected object b7135f11e49322a78fbecafc46d51473dd24ef41 [17:14:21] [17:54:13] fatal: fetch-pack: invalid index-pack output [17:14:38] ^ James_F [17:15:08] Hmm. Odd, I get the same in my local check-out. [17:15:28] fc850230e09422a438d10184d8f45baa9ac2e2d0 is https://gerrit.wikimedia.org/r/c/analytics/refinery/+/991068 [17:15:55] yes [17:16:07] that is a CR generated by a jenkins deployment job [17:16:34] triggered by https://integration.wikimedia.org/ci/job/analytics-refinery-update-jars-docker/build [17:16:53] Perhaps some odd sync issue with gerrit-replica (is that still a thing for clones?). [17:17:23] TIL [17:17:46] At this point I defer to actual RelEngers who might know, sorry. :-( [17:18:05] thanks for taking a look James_F <3 [17:21:18] don't know if possibly related, but the github replica of refinery is missing a couple of commits https://github.com/wikimedia/analytics-refinery/commits/master/ [17:24:15] 10GitLab (CI & Job Runners), 10Gitlab-Application-Security-Pipeline, 10Release-Engineering-Team (Radar), 10Security Team AppSec, and 3 others: Security template jobs seem to take over the test stage - https://phabricator.wikimedia.org/T354723 (10sbassett) [17:32:57] hrm, I definitely see that commit on the remote [17:39:06] 10Release-Engineering-Team, 10Wikimedia-Extension-setup, 10Russian-Sites: Add Extension:PlaceNewSection to Russian Wikipedia - https://phabricator.wikimedia.org/T344501 (10Iniquity) [17:41:39] there is a giant blob in that repo and a long pathname (148bytes). I get this same error locally. [17:48:47] gmodena: could you file a task so I can dump some investigation there? This is odd. [17:49:40] thcipriani will do [17:54:04] I definitely see the object, and I found it in a packfile. When I try to clone from gerrit, I get an error about a *different* missing object, which is also not missing b7135f11e49322a78fbecafc46d51473dd24ef41 [18:02:25] 10Release-Engineering-Team, 10Data-Catalog: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10gmodena) [18:02:34] ^ thcipriani [18:05:46] 10GitLab (CI & Job Runners), 10Gitlab-Application-Security-Pipeline, 10Release-Engineering-Team (Radar), 10Security Team AppSec, and 3 others: Gitlab unexpectedly creates multiple pipelines when certain includes/templates are defined within a repo's gitlab-ci.yml - https://phabricator.wikimedia.org/T354723 (... [18:06:14] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10gmodena) [18:06:33] gmodena: thanks, my suspicion is we need to fsck this repo. Are you trying to deploy something right now and can't? [18:07:22] thcipriani I am trying to deploy something, but it's late-ish in my TZ and need to drop in a few. So will pick the deployment up tomorrow anyway :) [18:07:39] it seems gerrit-replica is in a fine state, so if you're trying to pull, you should be able to pull down from there. [18:08:08] thcipriani ah! nice [18:08:57] yup [18:08:59] git clone "ssh://gmodena@gerrit-replica.wikimedia.org:29418/analytics/refinery" worked [18:09:34] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10gmodena) Pulling from `gerrita-replica` works ` git clone "ssh://gmodena@gerrit-replica.wikimedia.org:29418/analytics/refinery" ` [18:13:50] thcipriani can confirm that gerrit-replica is in sync. The commits I wanted to release are there [18:19:14] mmm I can clone from the replica. but I can't pull from it on deploy2002 [18:19:16] fatal: bad object fc850230e09422a438d10184d8f45baa9ac2e2d0 [18:19:16] error: https://gerrit-replica.wikimedia.org/r/p/analytics/refinery.git/ did not send all necessary objects [18:19:35] ^ I added gerrit-replica as an alternate remote [18:19:45] that's interesting [18:20:57] it errors on the same object as gerrit: fc850230e09422a438d10184d8f45baa9ac2e2d0 [18:21:41] yeah, that's the object I see git asking for explicitly when I do a fetch with GIT_TRACE_PACKET=true [18:22:31] and then it sends some packfile, and then does some kind of rev-list and comes up with a missing blob somewhere [18:24:25] which is the commit at the head of both the replica and the primary [18:25:56] git show works fine on both servers...sooo [18:26:18] git clone worked fine (from gerrit-replica) on my machine [18:26:37] could the clone on deploy2002 also be in a bad state? [18:27:28] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10thcipriani) I suspect we need to run an `fsck` on this repo. Both of those objects exist on the gerrit host: ` thcipriani@gerrit1003:/srv/gerrit/git/analytics/... [18:29:20] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10gmodena) >>! In T355173#9463375, @gmodena wrote: > Pulling from `gerrita-replica` works > ` > git clone "ssh://gmodena@gerrit-replica.wikimedia.org:29418/analyti... [18:39:29] thcipriani wrt local clone on deploy2002: stackoverflow suggest we can remove .git/refs/remotes/origin/master, git pull (from the replica) , and hope for the best. Would this make sense to you? I am not thrilled about removing stuff without understanding what's going on. [18:41:26] yeah, I'd say if you're not desperate to get the deploy done I'd hold on that. [18:41:56] thcipriani yup. Will do. [18:42:35] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10brennen) Is there possibly a git version difference involved between your local host and deploy2002? [18:42:40] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10thcipriani) I note the the `fc850230e09422a438d10184d8f45baa9ac2e2d0` object is still loose on gerrit2002, whereas on gerrit1003 it's only present in a packfile:... [18:45:57] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10gmodena) > Is there possibly a git version difference involved between your local host and deploy2002? There is. On deploy2002: ` gmodena@deploy2002$ git --ver... [18:46:54] 10Project-Admins, 10Tracking-Neverending: Requests for addition to the #acl*Project-Admins group (in comments) - https://phabricator.wikimedia.org/T706 (10Ladsgroup) >>! In T706#9461546, @WMDE-leszek wrote: > @Ladsgroup and/or whoever else monitors those requests: kindly reminding of this request. Somehow got... [18:59:33] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10thcipriani) >>! In T355173#9463496, @brennen wrote: > Is there possibly a git version difference involved between your local host and deploy2002? I think that m... [19:09:24] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10thcipriani) I tried: ` scp -r gerrit1003.wikimedia.org:/srv/gerrit/git/analytics/refinery.git /tmp/T355173-analytics-refinery.git git clone /tmp/T355173-analyti... [19:17:54] thcipriani got to drop for today. I'll follow up in the am (CEST). Many thanks for all the help so far <3 [19:18:34] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10thcipriani) So @jeena suggested trying to clone using jgit. So I grabbed the jgit executable from https://www.eclipse.org/jgit/download/ and it does clone the re... [19:24:34] 10Project-Admins: Create project tag for MediaWiki-extensions-IpReputation - https://phabricator.wikimedia.org/T355184 (10kostajh) [19:48:38] 10Continuous-Integration-Config, 10Gerrit, 10NetworkSession: New repo mediawiki/extensions/NetworkSession wrongly inherits from All-Projects, not mediawiki/extensions - https://phabricator.wikimedia.org/T355186 (10Jdforrester-WMF) [20:04:04] 10Project-Admins, 10OurWorldInData: Create project tag for OurWorldInData - https://phabricator.wikimedia.org/T317066 (10Harej) [20:16:08] (03PS1) 10Ebernhardson: Review access change [extensions/NetworkSession] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/991051 [20:17:19] (03PS2) 10Ebernhardson: Access change for mediawiki/extensions/NetworkSession [extensions/NetworkSession] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/991051 [20:18:19] (03CR) 10Ebernhardson: [V: 03+2 C: 03+2] Access change for mediawiki/extensions/NetworkSession [extensions/NetworkSession] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/991051 (owner: 10Ebernhardson) [20:19:19] Any gerrit administrators arround? Looking for a merge on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NetworkSession/+/991051 which changes the parent project to mediawiki/extensions [20:20:41] ebernhardson: Did you manually create the repo yourself rather than going through the process? Trying to understand how it got so broken. [20:20:53] also why is that adding the 'qa' group which seems unrelated? [20:21:43] James_F: yes, although i thought i was following the instructions on wikitech. Apparently not [20:22:03] ebernhardson: There's a bunch of stuff not documented because it's assumed people follow the process of asking for it on-wiki. :-( [20:22:30] taavi: it's not clear why it's failing, so i was comparing against another extension that works and adding what that extension has configured [20:22:33] Like the sync with GitHub which even I don't know how to trigger. [20:22:47] ebernhardson: The qa group isn't needed, BTW. [20:22:53] ok, easily removed [20:23:16] (What wikitech documentation? We should put a banner at the top.) [20:23:17] (03PS3) 10Ebernhardson: Access change for mediawiki/extensions/NetworkSession [extensions/NetworkSession] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/991051 [20:23:29] sec, looking [20:26:09] James_F: https://www.mediawiki.org/wiki/Git/Creating_new_repositories [20:28:32] Right. Tweaked the banner to really strongly hint that you shouldn't do this. :-) [21:28:19] 10Project-Admins, 10MediaWiki-extensions-IpReputation: Create project tag for MediaWiki-extensions-IpReputation - https://phabricator.wikimedia.org/T355184 (10Peachey88) 05Open→03Resolved a:03Peachey88 Requested project, #MediaWiki-extensions-IpReputation has been created. Reminder, Could you please cr... [21:59:43] 10GitLab (CI & Job Runners), 10Gitlab-Application-Security-Pipeline, 10Release-Engineering-Team (Radar), 10Security Team AppSec, and 3 others: Gitlab unexpectedly creates multiple pipelines when certain includes/templates are defined within a repo's gitlab-ci.yml - https://phabricator.wikimedia.org/T354723 (... [22:15:00] 10Release-Engineering-Team, 10Data-Engineering: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10hashar) It is almost 11pm , my old local clone of analytics/refinery.git had b7135f11e49322a78fbecafc46d51473dd24ef41 which is a tree object. fc850230e09422a438... [22:15:14] thcipriani: `git fetch --refetch` [22:15:27] that might do it, at least I had the exact same issue locally and that fixed it :) [22:21:12] 10Gerrit, 10Release-Engineering-Team, 10Data-Engineering, 10Upstream: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10hashar) + #gerrit since I am entirely sure it is an issue somewhere in jgit even though it is unlikely we can fix it ourselve. I do pla... [22:21:15] 10Gerrit, 10Release-Engineering-Team, 10Data-Engineering, 10Upstream: git clone and git pull commands fail for refinery repo - https://phabricator.wikimedia.org/T355173 (10hashar) [22:21:26] 100% sure it is an issue in jgit [22:21:35] * hashar sleeps [22:23:24] thanks h.ashar, please do sleep <3 I wasn't expecting your magic until my morning :)