[00:01:45] (DatasourceError) firing: Queue (Jenkins jobs + Zuul functions) alert - https://grafana.wikimedia.org/alerting/grafana/iS0FSjJ4z/view - https://wikitech.wikimedia.org/wiki/Monitoring/DatasourceError - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [00:03:21] 10Phabricator, 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Patch-For-Review: Require WMF email address when registering Phab user account with a WMF SUL account - https://phabricator.wikimedia.org/T343647 (10bd808) I would like to understand where this requirement is coming from. Has the Wikimedia Fou... [00:06:45] (DatasourceError) resolved: Queue (Jenkins jobs + Zuul functions) alert - https://grafana.wikimedia.org/alerting/grafana/iS0FSjJ4z/view - https://wikitech.wikimedia.org/wiki/Monitoring/DatasourceError - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [00:40:54] 10Continuous-Integration-Config, 10Release-Engineering-Team: Do not run 'test' pipeline for wmf/branch_cut_pretest - https://phabricator.wikimedia.org/T357080 (10taavi) [00:52:30] 10Continuous-Integration-Config, 10Release-Engineering-Team: Do not run 'test' pipeline for wmf/branch_cut_pretest - https://phabricator.wikimedia.org/T357080 (10Jdforrester-WMF) Thinking this through, we'd want to adjust the `test-wmf` trigger to ignore `patchset-created` events if the branch is `branch_cut_p... [03:43:52] 10Continuous-Integration-Config, 10I18n, 10Language-Technical Support (Language-Technical Support (Current) ), 10affects-translatewiki.net: Automatically allow id HTML attribute in message translations - https://phabricator.wikimedia.org/T357086 (10Amire80) [03:44:14] 10Continuous-Integration-Config, 10I18n, 10Language-Technical Support (Language-Technical Support (Current) ), 10affects-translatewiki.net: Automatically allow id HTML attribute in message translations - https://phabricator.wikimedia.org/T357086 (10Amire80) a:03Amire80 [03:47:47] (03PS1) 10Amire80: jjb: [mediawiki-i18n-check-docker] Add "id" to allow list in i18n [integration/config] - 10https://gerrit.wikimedia.org/r/999240 (https://phabricator.wikimedia.org/T357086) [04:48:31] (DatasourceError) firing: Queue (Jenkins jobs + Zuul functions) alert - https://grafana.wikimedia.org/alerting/grafana/iS0FSjJ4z/view - https://wikitech.wikimedia.org/wiki/Monitoring/DatasourceError - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [04:53:31] (DatasourceError) resolved: Queue (Jenkins jobs + Zuul functions) alert - https://grafana.wikimedia.org/alerting/grafana/iS0FSjJ4z/view - https://wikitech.wikimedia.org/wiki/Monitoring/DatasourceError - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [07:39:14] (03CR) 10Kosta Harlan: [C: 03+1] backend: Remove use of mediawiki/core router.php from PhpWebserver [integration/quibble] - 10https://gerrit.wikimedia.org/r/987183 (https://phabricator.wikimedia.org/T357070) (owner: 10Umherirrender) [07:50:28] 10Continuous-Integration-Config, 10Release-Engineering-Team: Do not run 'test' pipeline for wmf/branch_cut_pretest - https://phabricator.wikimedia.org/T357080 (10hashar) I think that can be done by adding a `reject-approval` to the event. We did something like that on https://gerrit.wikimedia.org/r/c/integrati... [08:22:44] 10GitLab (Upstream pit of despair πŸ•³οΈ), 10commit-message-validator: Add support for GitLab markdown linebreak requirement - https://phabricator.wikimedia.org/T351253 (10hashar) > If the trailing double space solution mentioned by @AntiCompositeNumber in T351253#9365740 actually works for the markdown view that... [08:42:21] (03PS1) 10Hashar: zuul: do not test patches having CR+2 [integration/config] - 10https://gerrit.wikimedia.org/r/999500 (https://phabricator.wikimedia.org/T357080) [09:10:16] 10Gerrit: Cannot log in to Gerrit because of duplicate email - https://phabricator.wikimedia.org/T357058 (10hashar) That is {T270233}, Gerrit does not allow two accounts to have the same email address since it uses emails as a unique identifier. An account `chrisdobbins` was created in LDAP and used in LDAP whi... [09:11:45] 10Gerrit: Cannot log in to Gerrit because of duplicate email - https://phabricator.wikimedia.org/T357058 (10hashar) 05Openβ†’03Resolved a:03hashar [09:45:03] 10GitLab (Upstream pit of despair πŸ•³οΈ), 10commit-message-validator: Add support for GitLab markdown linebreak requirement - https://phabricator.wikimedia.org/T351253 (10Lucas_Werkmeister_WMDE) >>! In T351253#9527938, @hashar wrote: >> If the trailing double space solution mentioned by @AntiCompositeNumber in T3... [10:46:39] 10Continuous-Integration-Config, 10I18n, 10Language-Technical Support (Language-Technical Support (Current) ), 10affects-translatewiki.net: Automatically allow id HTML attribute in message translations - https://phabricator.wikimedia.org/T357086 (10hashar) 05Openβ†’03Resolved [12:24:51] 10GitLab (CI & Job Runners), 10Patch-For-Review: docpub: support publishing docs from specific job - https://phabricator.wikimedia.org/T357016 (10CodeReviewBot) jnuche opened https://gitlab.wikimedia.org/repos/releng/docpub/-/merge_requests/14 support multiple builders/publishers [12:29:33] 10GitLab (CI & Job Runners), 10Patch-For-Review: docpub: support publishing docs from specific job - https://phabricator.wikimedia.org/T357016 (10CodeReviewBot) jnuche merged https://gitlab.wikimedia.org/repos/releng/docpub/-/merge_requests/14 support multiple builders/publishers [12:35:28] 10Release-Engineering-Team (Radar), 10Tech-Docs-Team, 10Documentation: Improve deployment pipeline documentation structure - https://phabricator.wikimedia.org/T352264 (10KBach) [12:40:08] (03PS1) 10Krinkle: Enable Jenkins for karma-launcher-firefox [integration/config] - 10https://gerrit.wikimedia.org/r/999694 [12:41:53] (03CR) 10Krinkle: [C: 03+2] Enable Jenkins for karma-launcher-firefox [integration/config] - 10https://gerrit.wikimedia.org/r/999694 (owner: 10Krinkle) [12:43:09] (03Merged) 10jenkins-bot: Enable Jenkins for karma-launcher-firefox [integration/config] - 10https://gerrit.wikimedia.org/r/999694 (owner: 10Krinkle) [12:43:53] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/999694 [12:43:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:45:30] 10Release-Engineering-Team, 10Tech-Docs-Team, 10Documentation, 10User-brennen: Review critical-path deployment pipeline documentation - https://phabricator.wikimedia.org/T352259 (10KBach) 05In progressβ†’03Resolved All pages in scope of this task have now been reviewed. Marking as resolved. >>! In T3522... [12:45:33] 10Release-Engineering-Team (Radar), 10Tech-Docs-Team, 10Documentation: Deployment pipeline (GitLab/Kokkuri/Blubber) documentation improvements - https://phabricator.wikimedia.org/T342317 (10KBach) [12:46:27] (03PS1) 10Krinkle: Zuul: Fix typo [integration/config] - 10https://gerrit.wikimedia.org/r/999701 [12:46:32] (03CR) 10Krinkle: [C: 03+2] Zuul: Fix typo [integration/config] - 10https://gerrit.wikimedia.org/r/999701 (owner: 10Krinkle) [12:47:58] (03Merged) 10jenkins-bot: Zuul: Fix typo [integration/config] - 10https://gerrit.wikimedia.org/r/999701 (owner: 10Krinkle) [12:48:10] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/999701 [12:48:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:53:35] 10GitLab (CI & Job Runners): docpub: support publishing docs from specific job - https://phabricator.wikimedia.org/T357016 (10jnuche) 05Openβ†’03Resolved [12:53:51] (03PS1) 10Krinkle: Zuul: Switch karma-firefox-launcher job to browser variant [integration/config] - 10https://gerrit.wikimedia.org/r/999712 [12:53:58] (03CR) 10Krinkle: [C: 03+2] Zuul: Switch karma-firefox-launcher job to browser variant [integration/config] - 10https://gerrit.wikimedia.org/r/999712 (owner: 10Krinkle) [12:56:04] (03Merged) 10jenkins-bot: Zuul: Switch karma-firefox-launcher job to browser variant [integration/config] - 10https://gerrit.wikimedia.org/r/999712 (owner: 10Krinkle) [13:14:26] Project mediawiki-core-doxygen-docker build #50119: 04FAILURE in 10 min: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/50119/ [13:48:17] 10Release-Engineering-Team (Radar), 10SRE Observability, 10serviceops, 10Patch-For-Review: Introduce a way to retry checks for SystemdUnitFailed before alerting - https://phabricator.wikimedia.org/T357028 (10fgiunchedi) The patch above does essentially that, i.e. match `SystemdUnitFailed` semantics to what... [14:12:52] Yippee, build fixed! [14:12:53] Project mediawiki-core-doxygen-docker build #50120: 09FIXED in 8 min 26 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/50120/ [14:51:41] 10Release-Engineering-Team (Radar), 10SRE Observability, 10serviceops: Introduce a way to retry checks for SystemdUnitFailed before alerting - https://phabricator.wikimedia.org/T357028 (10fgiunchedi) 05Openβ†’03Resolved a:03fgiunchedi Since we're back to Icinga semantics in terms of waiting before alerti... [14:53:05] 10Phabricator: Application to change username - https://phabricator.wikimedia.org/T357137 (10MaksimPinigin) [14:57:10] 10Release-Engineering-Team (Radar), 10SRE Observability, 10serviceops: Introduce a way to retry checks for SystemdUnitFailed before alerting - https://phabricator.wikimedia.org/T357028 (10Clement_Goubert) Thanks! [15:01:31] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Patch-For-Review: Do not run 'test' pipeline for wmf/branch_cut_pretest - https://phabricator.wikimedia.org/T357080 (10Jdforrester-WMF) Oh yeah, that's neat. Let's try it out. [15:01:34] (03CR) 10Jforrester: [C: 03+2] zuul: do not test patches having CR+2 [integration/config] - 10https://gerrit.wikimedia.org/r/999500 (https://phabricator.wikimedia.org/T357080) (owner: 10Hashar) [15:02:47] (03Merged) 10jenkins-bot: zuul: do not test patches having CR+2 [integration/config] - 10https://gerrit.wikimedia.org/r/999500 (https://phabricator.wikimedia.org/T357080) (owner: 10Hashar) [15:05:04] !log Zuul: Do not test patches having CR+2 for T357080 [15:05:07] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:05:08] T357080: Do not run 'test' pipeline for wmf/branch_cut_pretest - https://phabricator.wikimedia.org/T357080 [15:12:11] James_F: Krinkle: hello :) I have a javascript question for you! I wrote some Gerrit plugin against es2018 and I am wondering whether I should just move to es2020 [15:12:51] it looks like any browser most probably has es2020 fully implemented by now, and of course I have no idea what Gerrit frontend web UI expect :) [15:16:17] ohhh https://caniuse.com/?search=es2020 has a search grouping all new features :D [15:19:06] hashar: Yeah, it's probably fine. [15:19:33] I am merely looking to use `string.matchAll( /something/g )` [15:20:00] thanks James_F ! [15:21:38] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Patch-For-Review: Do not run 'test' pipeline for wmf/branch_cut_pretest - https://phabricator.wikimedia.org/T357080 (10Jdforrester-WMF) 05Openβ†’03Resolved a:03hashar OK, this seems to have worked //e.g.// on https://gerrit.wikimedia.org/r/c/... [15:22:35] I'd like how Timo congratulated me on writing modern javascript as I started against es2018 [15:22:43] and I am now confident enough to upgrade to es2020 [15:22:51] * hashar feels like a full stack dev [15:22:59] :-D [15:23:46] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10Patch-For-Review: Do not run 'test' pipeline for wmf/branch_cut_pretest - https://phabricator.wikimedia.org/T357080 (10taavi) I'm fairly sure LibUp patches have been configured that way for a while, LibUp will add V+1 to manually trigger test job... [15:26:07] hashar: probably fine for dev-facing frontends.es2020 finalized in late 2019, and shipped last in Edge in Jan 2020 I think. It might not work on e.g. a Linux LTS-1 distro (e.g. Ubuntu 16 or Ubuntu 18) in the built-in browser, or e.g. on some mobile browsers like Opera or UCWeb that sometimes embed an old Chrome engine, or e.g. iOS devices that can't update past 2017. [15:26:26] but majority supported yes, which seems fine for dev-facing stuff I guess. [15:26:32] 10Phabricator: Application to change username - https://phabricator.wikimedia.org/T357137 (10taavi) 05Openβ†’03Resolved a:03taavi [15:28:28] Krinkle: yeah that was my assumption. Thanks for the detailled report! [15:28:46] with es2020 I can then use `??` [15:28:46] ;) [15:32:36] PHP and ES converging. [15:33:13] I look forward to being able to do $.('div')->array_has_key('hello'); [15:34:26] I'd like to have my server side PHP to be transparently transpiled to javascript and executed on the client side [15:34:44] With WASM that's actually possible. But not a good idea. [15:34:52] MW-on-clientside project, anyone? [15:35:06] I think ruby on rails has some bit of magic like that [15:35:35] where you write some behavior in pure ruby and that generates browser code with some javascript [15:35:40] which I felt like magic [15:36:01] See also Google tools being written in Java and transpiling to JS. [15:36:17] oh yeah I should start a project like that [15:36:28] I'd call that AWT Antoine Web Toolkit [15:36:43] https://gerrit.wikimedia.org/r/999900 [15:36:54] Yup. [15:36:54] NO [15:37:04] I am never going to get change 10^7 :/ [15:37:08] (03PS1) 10Hashar: Bump javascript from es2018 to es2020 [software/gerrit] (deploy/wmf/stable-3.7) - 10https://gerrit.wikimedia.org/r/999902 [15:37:09] I expect us to hit 1M in a couple of hours' time. [15:38:01] I'm fairly sure LibUp has a few hundred patches in the push queue, so sure. [15:38:32] or I think I can break it so that 10000000 is never assigned to the pool of change numbers to pick up from [15:38:55] Wouldn't this be a great time to find out that gerrit has a six-digit limit for change IDs? ;-) [15:39:02] hashar: Tsk. [15:39:21] I wonder how many regexes like \d{6} we have for patchset numbers [15:39:32] Hopefully not many. [15:39:41] well it is either Java Integer.MAX_VALUE [15:40:03] Is that different on different flavours of Java? [15:40:04] or whatever supported by the json library used to store the numbers [15:41:09] anyway, Android has 2.9M changes and Chromium 5.3M changes [15:41:17] Ack. [15:41:21] https://android-review.googlesource.com/q/status:open+-is:wip https://chromium-review.googlesource.com/q/status:open+-is:wip [15:48:48] https://gerrit.wikimedia.org/r/c/operations/software/gerrit/+/999902 that is for the es2020 bump :) [15:53:30] (03CR) 10Jforrester: [C: 03+1] Bump javascript from es2018 to es2020 [software/gerrit] (deploy/wmf/stable-3.7) - 10https://gerrit.wikimedia.org/r/999902 (owner: 10Hashar) [15:54:25] now I need to find code to be replaced by `??` or `?.` [16:02:31] If you wait long enough I'm sure there'll be an auto-fixer bundled into eslint-config-wikimedia at some point. [16:02:53] I guess so yeah one day :) [16:02:58] 10Gerrit: Gerrit patch link dropdown should include wikitext and/or HTML options - https://phabricator.wikimedia.org/T357148 (10cscott) [16:03:09] I think I am doing them manually as an excuse to learn a bit about javascript [16:03:39] next step, teach ESLint that the .js file it is parsing is not in global scope [16:12:46] Hey all is anyone able to do an emergency deploy? [16:12:58] because of the swift train rollout we didnt catch this bug on Wednesday: https://phabricator.wikimedia.org/T356928 [16:13:17] it's problematic from an accessibility point of view and has triggered at least 4 village pump discussions on different projects. [16:13:47] The patch is quite trivial: https://gerrit.wikimedia.org/r/c/998974 [16:16:45] Jdlrobson: according to https://wikitech.wikimedia.org/wiki/Deployments/Emergencies, #wikimedia-operations is probably a better place to ask [16:17:01] (I’m technically able to deploy but would need someone to approve first) [16:17:37] Lucas_WMDE: ack [16:28:02] Jdlrobson: how is that not caught by some test? :) [16:28:24] I have +1ed it and I think the process requires SRE to sign off [16:41:32] hashar: it's a CSS variable [16:41:38] CSS variables can be undefined [16:41:46] (by design) [16:41:56] we could probably flag it with a linter [16:42:49] https://github.com/stylelint/stylelint/issues/2220 ill take a look at this one and see if it would have worked here! [16:43:43] (03PS1) 10Hashar: Gerrit 3.8 no more set redundant real_author [software/gerrit] (deploy/wmf/stable-3.7) - 10https://gerrit.wikimedia.org/r/999928 (https://phabricator.wikimedia.org/T354886) [16:56:36] 10Release-Engineering-Team, 10Gerrit (Gerrit 3.8), 10Patch-For-Review: Upgrade to Gerrit 3.8 - https://phabricator.wikimedia.org/T354886 (10hashar) [16:58:05] 10Release-Engineering-Team, 10Gerrit (Gerrit 3.8), 10Patch-For-Review: Upgrade to Gerrit 3.8 - https://phabricator.wikimedia.org/T354886 (10hashar) [17:01:37] I think I messed up with js/css etc :) [17:01:49] I am off, gotta drill some holes at home and prepare walls for some painting [17:11:35] (it’s deployed now) [17:22:17] happy weekend hashar [17:27:14] Lucas_WMDE: brennen: Danke Schon! [19:54:16] https://gerrit.wikimedia.org/r/1000000 [20:35:50] And lo, it exists: https://gerrit.wikimedia.org/r/c/1000000 [20:51:54] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 10Scap, 10Patch-For-Review: scap backport non_config_is_in_production() check doesn't work right for VisualEditor/VisualEditor repo - https://phabricator.wikimedia.org/T353720 (10CodeReviewBot) jhuneidi merged https://gitlab.wikimedia.org/repos/releng/scap/-/m... [20:56:30] https://gerrit.wikimedia.org/r/c/5 seems to be the first, so are we celebrating the number of the patch or the number of patches? [21:14:32] "round number seems like big deal" is probably the simplest rubric here [21:40:34] 10Continuous-Integration-Infrastructure, 10LibUp, 10ci-test-error: Git repos with direct pushes bypassing gerrit/CI could be a maintenance burden for libup patches - https://phabricator.wikimedia.org/T301201 (10Umherirrender) 05Openβ†’03Resolved a:03Umherirrender ACL for skins and extensions looking clea... [21:46:24] 10GitLab (Upstream pit of despair πŸ•³οΈ), 10commit-message-validator: Add support for GitLab markdown linebreak requirement - https://phabricator.wikimedia.org/T351253 (10bd808) [21:46:35] 10GitLab (Upstream pit of despair πŸ•³οΈ), 10commit-message-validator: Add support for GitLab markdown linebreak requirement - https://phabricator.wikimedia.org/T351253 (10bd808) [22:18:52] (03PS1) 10Zoranzoki21: Zuul: Enable extension-coverage for the Adituor extension [integration/config] - 10https://gerrit.wikimedia.org/r/1000084