[00:19:06] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for USER[S] - https://phabricator.wikimedia.org/T360170 (10Shashankmittaliitbhu) 03NEW [00:20:30] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for USER[S] - https://phabricator.wikimedia.org/T360170#9633048 (10Shashankmittaliitbhu) a:05Shashankmittaliitbhu→03Reedy [00:36:18] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for shashankmittal - https://phabricator.wikimedia.org/T360170#9633060 (10Pppery) [00:36:49] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for shashankmittal - https://phabricator.wikimedia.org/T360170#9633061 (10Pppery) a:05Reedy→03None [01:00:09] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for Yug - https://phabricator.wikimedia.org/T360168#9633091 (10Anoop) [02:45:34] (03PS19) 10Krinkle: fresh-npm: initial commit [fresh] - 10https://gerrit.wikimedia.org/r/675346 [02:47:18] (03PS20) 10Krinkle: fresh-npm: initial commit [fresh] - 10https://gerrit.wikimedia.org/r/675346 [02:56:49] (03CR) 10Krinkle: fresh-npm: initial commit (033 comments) [fresh] - 10https://gerrit.wikimedia.org/r/675346 (owner: 10Krinkle) [09:48:29] 10Gerrit: Gerrit fails to show files / diff on a change - https://phabricator.wikimedia.org/T360178 (10hashar) 03NEW [09:49:30] ah [09:49:35] wikibugs is somehow lagged :) [09:53:19] it may have restarted/network connections issues but not as noticable with a bouncer in front of it now [09:58:09] 10GitLab (Account Approval), 06Release-Engineering-Team: 14Requesting GitLab account activation for Yug - 14https://phabricator.wikimedia.org/T360168#9633509 (10Peachey88) 05Open→03Resolved 14Your account is now active, As you are a member of Trusted-Contributors in Phabricator it was probably automat... [10:44:12] (03PS1) 10Urbanecm: phan: Add CommunityConfiguration as a phan dependency for GrowthExperiments [integration/config] - 10https://gerrit.wikimedia.org/r/1011280 (https://phabricator.wikimedia.org/T360181) [10:49:07] (03CR) 10Jgiannelos: [C:03+1] Some enwikivoyage specific noise-reduction hacks [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1011027 (owner: 10Subramanya Sastry) [10:49:28] (03PS2) 10Urbanecm: Zuul: Add CommunityConfiguration as GrowthExperiments' dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1011280 (https://phabricator.wikimedia.org/T360181) [10:50:45] 10Continuous-Integration-Config, 10CommunityConfiguration, 10GrowthExperiments, 10Growth-Team (Sprint 9 (Growth Team)), 13Patch-For-Review: Add CommunityConfiguration as a Phan dependency for GrowthExperiments - https://phabricator.wikimedia.org/T360181#9633605 (10Urbanecm_WMF) [11:06:09] I can't run Phan :/ [11:06:33] (03CR) 10Hashar: [C:03+2] Zuul: Add CommunityConfiguration as GrowthExperiments' dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1011280 (https://phabricator.wikimedia.org/T360181) (owner: 10Urbanecm) [11:07:51] (03Merged) 10jenkins-bot: Zuul: Add CommunityConfiguration as GrowthExperiments' dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1011280 (https://phabricator.wikimedia.org/T360181) (owner: 10Urbanecm) [11:08:38] urbanecm: I have deployed ^ [11:09:22] thank you so much hashar! [11:09:28] very quick :) [11:09:32] urbanecm: also is phan broken with php 8.2 ? ;) [11:09:38] I got a crash [11:09:49] (Phan 5.4.1 crashed when parsing/analyzing '/home/hashar/projects/mediawiki/core/vendor/composer/pcre/src/MatchAllResult.php') [11:09:50] :) [11:10:08] tbh i fully rely on CI running it for me, so i don't know. but i don't think it's supposed to analyze `vendor`? [11:10:27] I am gonna rely on CI :D [11:11:17] https://integration.wikimedia.org/ci/job/mwext-php74-phan-docker/106091/console : SUCCESS in 1m 08s [11:11:21] good job :D [11:14:38] it is the taint check plugin which is crashing during the parse [11:14:40] grr [11:17:25] 10Continuous-Integration-Config, 10CommunityConfiguration, 10GrowthExperiments, 10Growth-Team (Sprint 9 (Growth Team)), 13Patch-For-Review: 14Add CommunityConfiguration as a Phan dependency for GrowthExperiments - 14https://phabricator.wikimedia.org/T360181#9633640 (10Urbanecm_WMF) 05Open→03Resolv... [11:23:45] AH [11:24:14] upgrading mediawiki/mediawiki-phan-config also upgrades mediawiki/phan-taint-check-plugin which ends up fixing the issue [11:39:16] 10GitLab (Account Approval), 06Release-Engineering-Team: 14Requesting GitLab account activation for Yug - 14https://phabricator.wikimedia.org/T360168#9633724 (10Yug) 14Thank you @Peachey88  [12:03:44] 06Project-Admins, 06Community-Tech: Create Community-Wishlist-Survey-20{19,20,21} tags - https://phabricator.wikimedia.org/T360188 (10TheresNoTime) 03NEW [12:16:19] TheresNoTime: I love of your tasks states "similar to" 2017 and 2022 tags [12:16:26] but each of them show differently (yellow and orange) [12:16:57] there is another ssystem which is to create a Community-whishlist-survey project and then create milestones for each years [12:22:43] 06Project-Admins, 06Community-Tech: Create Community-Wishlist-Survey-20{19,20,21} tags - https://phabricator.wikimedia.org/T360188#9633782 (10hashar) [12:27:21] 06Project-Admins, 06Community-Tech: Create Community-Wishlist-Survey-20{19,20,21} tags - https://phabricator.wikimedia.org/T360188#9633784 (10hashar) I have created all three goals. I have also changed the 2017 one {icon tag color=yellow} to {icon flag-checkered color=orange} An alternative would be to creat... [12:34:47] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for shashankmittal - https://phabricator.wikimedia.org/T360170#9633804 (10Yug) Hello @Reedy , letting you know that @Shashankmittaliitbhu is requesting this within the scope of the Google Summer of Code 2024, he is on... [12:39:07] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for shashankmittal - https://phabricator.wikimedia.org/T360170#9633811 (10RhinosF1) @Yug: why does this need task need to be dealt with by @Reedy in particular ? [12:49:26] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for shashankmittal - https://phabricator.wikimedia.org/T360170#9633828 (10Yug) >>! In T360170#9633811, @RhinosF1 wrote: > @Yug: why does this need task need to be dealt with by @Reedy in particular ? Error on my side... [13:07:19] 06Project-Admins, 06Community-Tech: 14Create Community-Wishlist-Survey-20{19,20,21} tags - 14https://phabricator.wikimedia.org/T360188#9633839 (10TheresNoTime) 05Open→03Resolved a:03hashar 14Perfect, thank you! :-) [13:34:21] 10Release-Engineering-Team (Now this 🫠), 06Security-Team, 13Patch-For-Review, 07SecTeam-Processed: Notify MediaWiki security tasks as soon as an uploaded patch fails to apply - https://phabricator.wikimedia.org/T350065#9633880 (10CodeReviewBot) jnuche opened https://gitlab.wikimedia.org/repos/releng/releas... [13:45:12] 10Beta-Cluster-Infrastructure, 06MediaWiki-Platform-Team, 10MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), 13Patch-For-Review: Cannot create a new wiki on beta cluster - https://phabricator.wikimedia.org/T358236#9633922 (10pmiazga) @Tgr Now, if flag doesn't match one of `SQLPlatform::QUERY_CHANGE_NONE`, `SQLPl... [14:19:54] hashar: are you able to approve gitlab accounts? (or can you point me to a channel where a few people can?) [14:20:30] we have a hackathon going on, so a few accounts may need approval throughout the day/weekend :) [14:21:14] (and to not "ask to ask", if anyone can process the gitlab account approval for `ThierryW23` that would be appreciated!) [14:21:19] TheresNoTime: I can help if needed. [14:21:37] taking a look [14:21:41] thank you dancy [14:23:43] Approved. [14:23:48] Thanks! [14:26:14] TheresNoTime: https://wikitech.wikimedia.org/wiki/Tool:Gitlab-account-approval will auto-approve e.g. people with Toolforge access, or with trusted-contributors status on phabricator (assuming they've linked the developer account there) [14:26:51] ah good to know! [14:27:16] I may have just been being impatient! [14:28:07] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9634002 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/blubber/-/merge_requests/74 Improve autogenerated documentation and... [14:38:27] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation, 13Patch-For-Review: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9634045 (10CodeReviewBot) dancy opened https://gitlab.wikimedia.org/repos/releng/docpub/-/merge_requests/19 Add repos/releng/bl... [14:39:22] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation, 13Patch-For-Review: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9634051 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/docpub/-/merge_requests/19 Add repos/releng/bl... [14:48:07] 10Release-Engineering-Team (Now this 🫠), 06Security-Team, 13Patch-For-Review, 07SecTeam-Processed: Notify MediaWiki security tasks as soon as an uploaded patch fails to apply - https://phabricator.wikimedia.org/T350065#9634077 (10CodeReviewBot) jnuche merged https://gitlab.wikimedia.org/repos/releng/scap/-... [14:48:42] 10Beta-Cluster-Infrastructure, 06MediaWiki-Platform-Team, 10MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), 13Patch-For-Review: Cannot create a new wiki on beta cluster - https://phabricator.wikimedia.org/T358236#9634078 (10Tgr) `Database::query()` uses `QueryBuilderFromRawSql::buildQuery()` to convert raw SQL... [14:54:26] TheresNoTime: glad you got it fixed :) [14:59:48] 10Release-Engineering-Team (Now this 🫠), 06Security-Team, 13Patch-For-Review, 07SecTeam-Processed: Notify MediaWiki security tasks as soon as an uploaded patch fails to apply - https://phabricator.wikimedia.org/T350065#9634090 (10CodeReviewBot) jnuche merged https://gitlab.wikimedia.org/repos/releng/releas... [14:59:56] 10Release-Engineering-Team (Now this 🫠), 06Security-Team, 13Patch-For-Review, 07SecTeam-Processed: Notify MediaWiki security tasks as soon as an uploaded patch fails to apply - https://phabricator.wikimedia.org/T350065#9634091 (10CodeReviewBot) jnuche merged https://gitlab.wikimedia.org/repos/releng/jenkin... [15:00:57] 10Continuous-Integration-Infrastructure, 07Jenkins, 06Release-Engineering-Team: 14Patch testing in releases Jenkins: prevent false positives - 14https://phabricator.wikimedia.org/T359809#9634102 (10jnuche) 05Open→03Resolved a:03jnuche [15:04:53] 10Release-Engineering-Team (Now this 🫠), 06Security-Team, 13Patch-For-Review, 07SecTeam-Processed: Notify MediaWiki security tasks as soon as an uploaded patch fails to apply - https://phabricator.wikimedia.org/T350065#9634112 (10CodeReviewBot) jnuche merged https://gitlab.wikimedia.org/repos/releng/releas... [15:09:04] 10Beta-Cluster-Infrastructure, 06MediaWiki-Platform-Team, 10MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), 13Patch-For-Review: Cannot create a new wiki on beta cluster - https://phabricator.wikimedia.org/T358236#9634130 (10pmiazga) @Tgr In `ExternalStoreDB::initializeTable()` we were passing `QUERY_IGNORE_DBO_... [15:09:41] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation, 13Patch-For-Review: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9634131 (10CodeReviewBot) kbach opened https://gitlab.wikimedia.org/repos/releng/blubber/-/merge_requests/76 Fix loading of ass... [15:14:36] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation, 13Patch-For-Review: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9634142 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/blubber/-/merge_requests/76 Fix loading of ass... [15:27:15] (03PS2) 10Hashar: Drop per-distribution debian-glue jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1011154 (owner: 10Majavah) [15:30:09] hashar: on that CI test VM (zuul on bullseye), do you want to have a copy of /var/lib/zuul data from the prod CI servers or is that not needed / no point ? [15:31:33] (03CR) 10Hashar: [C:03+2] "I have updated the jobs and deleted the two that hardcoded the distribution to `unstable`." [integration/config] - 10https://gerrit.wikimedia.org/r/1011154 (owner: 10Majavah) [15:32:26] mutante: na nothing is needed beside whatever is shipped by Puppet [15:32:42] hashar: ok, gotcha. then I will abandon a patch that was about rsyncing that [15:32:45] (03Merged) 10jenkins-bot: Drop per-distribution debian-glue jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1011154 (owner: 10Majavah) [15:32:59] hashar: fyi, you have contint1003.eqiad.wmnet, was created while you were out [15:33:23] zuul has been deployed there [15:33:24] I am not entirely sure what strategy to use for testing Zuul on that machine, my guess is to use some alternate config [15:33:35] *nod* [15:34:12] we can override the config in puppet or disable it temp. when it's time to get to that [15:37:17] 10Release-Engineering-Team (Now this 🫠), 13Patch-For-Review: 14gitlab-cloud-runner: Roll back pending helm releases before running terraform apply - 14https://phabricator.wikimedia.org/T354787#9634186 (10dancy) 05In progress→03Resolved 14I think we can consider this done.  [15:43:42] (03CR) 10Hashar: [C:03+2] "I have tried it out more this afternoon and it looks good. Lets fly, thank you for having tested the various cases (hint for later: we'd n" [fresh] - 10https://gerrit.wikimedia.org/r/675346 (owner: 10Krinkle) [15:48:47] (03PS1) 10Ilias Sarantopoulos: ml-services: add huggingface pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/1011303 (https://phabricator.wikimedia.org/T357986) [15:53:59] (03Merged) 10jenkins-bot: fresh-npm: initial commit [fresh] - 10https://gerrit.wikimedia.org/r/675346 (owner: 10Krinkle) [15:56:15] 06Release-Engineering-Team, 10Scap, 10MediaWiki-libs-Mime, 10MediaWiki-Platform-Team (Radar), and 2 others: Get rid of the /srv/mediawiki/php symbolic link - https://phabricator.wikimedia.org/T359643#9634233 (10dancy) >>! In T359643#9616500, @Krinkle wrote: > For it to serve `COPYING` it would need to: > 1... [16:01:51] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for shashankmittal - https://phabricator.wikimedia.org/T360170#9634286 (10bd808) [16:02:46] 10GitLab (Account Approval), 06Release-Engineering-Team: 14Requesting GitLab account activation for shashankmittal - 14https://phabricator.wikimedia.org/T360170#9634288 (10bd808) 05Open→03Resolved a:03bd808 14https://gitlab.wikimedia.org/shashankmittal [16:33:42] 10Beta-Cluster-Infrastructure, 06MediaWiki-Platform-Team, 10MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), 13Patch-For-Review: Cannot create a new wiki on beta cluster - https://phabricator.wikimedia.org/T358236#9634399 (10Tgr) >>! In T358236#9634130, @pmiazga wrote: > @Tgr In `ExternalStoreDB::initializeTable... [17:02:48] 10Release-Engineering-Team (Now this 🫠), 13Patch-For-Review: 14gitlab-cloud-runners k8s cluster bootstrapping problem - 14https://phabricator.wikimedia.org/T359661#9634505 (10CodeReviewBot) 14dancy opened https://gitlab.wikimedia.org/repos/releng/gitlab-cloud-runner/-/merge_requests/371 Add dependencies... [18:53:15] 06Release-Engineering-Team, 06Data-Engineering, 06Data-Platform-SRE, 06Discovery-Search, and 3 others: Adapt gitlab pipelines for the new wmf-jvm-parent-pom - https://phabricator.wikimedia.org/T358841#9634740 (10RKemper) [18:58:02] 10Gerrit, 10CommunityConfiguration, 06Growth-Team: Delete two branches from mediawiki/extensions/CommunityConfiguration Gerrit extension - https://phabricator.wikimedia.org/T360225 (10Urbanecm_WMF) 03NEW [18:59:01] 10Gerrit, 10CommunityConfiguration, 06Growth-Team: Delete two branches from mediawiki/extensions/CommunityConfiguration Gerrit extension - https://phabricator.wikimedia.org/T360225#9634761 (10Urbanecm_WMF) p:05Triage→03Medium [19:07:32] Hi releng folks, not sure if this is the right place to ask, but any tips on clearing up seemingly-spurious PhanUndeclaredClassMethod failures? [19:07:58] I'm trying to introduce some namespacing into DonationInterface, starting with this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1011322 [19:08:10] and it's saying a couple of classes are undeclared [19:08:27] one is a non-namespaced SpecialPage subclass in the same DonationInterface extension [19:08:42] and the other is a namespaced class in a library that gets installed under vendor [19:11:00] ejegg: if you're using a non-standard directory name (like `special/` in `special/RecurUpgrade.php`) they need to be listed in `directory_list` in .phan/config.php. the list of directories included by default is https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/phan/+/refs/heads/master/src/config.php#44 [19:15:06] aha, thank you taavi! That should work for the SpecialPage [19:15:33] any tips for the one in vendor? That one has standard namespace / folder correspondance [19:16:37] hmm, let me try adding that dir explicitly [19:43:13] 10Release-Engineering-Team (Now this 🫠), 13Patch-For-Review: 14gitlab-cloud-runners k8s cluster bootstrapping problem - 14https://phabricator.wikimedia.org/T359661#9634841 (10CodeReviewBot) 14dancy merged https://gitlab.wikimedia.org/repos/releng/gitlab-cloud-runner/-/merge_requests/371 Add dependencies... [20:03:42] thanks, taavi, that's got it passing! So that also makes me realize most of DonationInterface is not yet covered by phan since it's not namespaced [23:18:35] 06Release-Engineering-Team, 10Scap, 10MediaWiki-libs-Mime, 10MediaWiki-Platform-Team (Radar), 10MW-1.42-notes (1.42.0-wmf.23; 2024-03-19): Get rid of the /srv/mediawiki/php symbolic link - https://phabricator.wikimedia.org/T359643#9635240 (10Krinkle) @dancy I'd say let's put it in `static.php` for now. I...