[04:49:09] 10GitLab (Account Approval), 06Release-Engineering-Team: 14Requesting GitLab account activation for Jatinder190124 - 14https://phabricator.wikimedia.org/T360328#9640864 (10brennen) 05Open→03Resolved a:03brennen [04:51:12] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for Saltykheera - https://phabricator.wikimedia.org/T360333#9640872 (10brennen) [04:52:51] 10GitLab (Account Approval), 06Release-Engineering-Team: 14Requesting GitLab account activation for Saltykheera - 14https://phabricator.wikimedia.org/T360333#9640874 (10brennen) 05Stalled→03Resolved a:05Saltykheera→03brennen 14I approved `vishalkumar`, which I assume is correct based on the mentio... [04:55:00] 10GitLab (Account Approval), 06Release-Engineering-Team: 14Requesting GitLab account activation for pushkar707 - 14https://phabricator.wikimedia.org/T360301#9640877 (10brennen) 05Open→03Resolved a:03brennen [06:13:40] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation, 13Patch-For-Review: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9640898 (10CodeReviewBot) kbach merged https://gitlab.wikimedia.org/repos/releng/blubber/-/merge_requests/77 Fix logo in vitepr... [09:13:52] 10GitLab (Account Approval), 06Release-Engineering-Team: 14Requesting GitLab account activation for Jatinder190124 - 14https://phabricator.wikimedia.org/T360328#9640940 (10Yug) 14Thank you @brennen  [09:15:40] (03CR) 10Hashar: [C:03+2] Add PageTriage GSoC contributor [integration/config] - 10https://gerrit.wikimedia.org/r/1012397 (owner: 10Samtar) [09:15:48] (03Merged) 10jenkins-bot: Add PageTriage GSoC contributor [integration/config] - 10https://gerrit.wikimedia.org/r/1012397 (owner: 10Samtar) [09:17:25] 06Release-Engineering-Team, 10Scap: scap backport of an mediawiki-config change fetches all repositories - https://phabricator.wikimedia.org/T360400 (10hashar) 03NEW [09:18:25] 10GitLab (Account Approval), 06Release-Engineering-Team: 14Requesting GitLab account activation for Saltykheera - 14https://phabricator.wikimedia.org/T360333#9640980 (10Yug) 14Thank you again @brennen .  [09:18:53] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation, 13Patch-For-Review: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9640981 (10CodeReviewBot) kbach opened https://gitlab.wikimedia.org/repos/releng/blubber/-/merge_requests/78 Fix documentation... [09:19:05] 10GitLab (Account Approval), 06Release-Engineering-Team: 14Requesting GitLab account activation for pushkar707 - 14https://phabricator.wikimedia.org/T360301#9640983 (10Pushkar7077) [09:19:37] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation, 13Patch-For-Review: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9640985 (10CodeReviewBot) kbach merged https://gitlab.wikimedia.org/repos/releng/blubber/-/merge_requests/78 Fix documentation... [09:24:51] (03CR) 10KBach: "Thank you!" [integration/docroot] - 10https://gerrit.wikimedia.org/r/1012376 (https://phabricator.wikimedia.org/T352262) (owner: 10KBach) [09:26:47] 06Release-Engineering-Team, 10MW-on-K8s: Helm deployment of MediaWiki now takes 6 minutes - https://phabricator.wikimedia.org/T360403 (10hashar) 03NEW [09:28:30] 10Gerrit, 06Release-Engineering-Team, 10wikitech.wikimedia.org, 13Patch-For-Review, and 2 others: wikitech hook to disable Gerrit user uses partial matches to identify account - https://phabricator.wikimedia.org/T307558#9641074 (10hashar) With https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/... [09:31:02] 06Release-Engineering-Team, 10MW-on-K8s: Helm deployment of MediaWiki now takes 6 minutes - https://phabricator.wikimedia.org/T360403#9641095 (10akosiaris) I wanted to point out that as the migration progresses and the size of MediaWiki deployments in WikiKube increases, it is inevitable that the deployment ti... [09:37:23] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation, 13Patch-For-Review: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9641166 (10KBach) [09:38:54] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation, 13Patch-For-Review: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9641165 (10KBach) Blubber documentation is now available on https://doc.wikimedia.org/releng/blubber/. I have updated the links... [09:54:25] 10Gerrit, 06Release-Engineering-Team, 10wikitech.wikimedia.org, 07SecTeam-Processed, 07Security: 14wikitech hook to disable Gerrit user uses partial matches to identify account - 14https://phabricator.wikimedia.org/T307558#9641206 (10hashar) 05Open→03Resolved 14Thanks again @bd808 ! [09:59:30] 10Gerrit, 10Release-Engineering-Team (Radar), 10CAS-SSO, 06Infrastructure-Foundations, and 2 others: 14Add logout.d script for Gerrit - 14https://phabricator.wikimedia.org/T286905#9641230 (10hashar) 05Open→03Declined 14Users are blocked in Gerrit via wikitech Special:Block which had some recent fi... [10:01:25] (03Abandoned) 10Hashar: Docker: Provide bullseye-based Quibble images [integration/config] - 10https://gerrit.wikimedia.org/r/914316 (https://phabricator.wikimedia.org/T335766) (owner: 10Jforrester) [10:01:53] (03Abandoned) 10Hashar: Provide a secondary database [integration/quibble] - 10https://gerrit.wikimedia.org/r/949986 (https://phabricator.wikimedia.org/T342763) (owner: 10Urbanecm) [10:20:45] 06Project-Admins, 06WMF-Communications: Create project tag for Wikimedia Foundation Memory Bank project - https://phabricator.wikimedia.org/T357451#9641299 (10Varnent) >>! In T357451#9636354, @Aklapper wrote: > Hi, will this Phabricator project be the canonical place where work tasks are planned, managed, trac... [10:21:36] (03PS1) 10Hashar: dockerfiles: Quibble php-fpm memory_limit to 256M [integration/config] - 10https://gerrit.wikimedia.org/r/1012616 (https://phabricator.wikimedia.org/T356402) [10:24:09] 10Scap (Scap3-MediaWiki-MVP), 10MediaWiki-Configuration: Scap should not rely on extension-list, instead pass --extension-dir to mergeMessageFileList.php - https://phabricator.wikimedia.org/T125678#9641304 (10Ladsgroup) >>! In T125678#9638223, @hashar wrote: >>>! @Ladsgroup wrote: >> There is also the security... [10:26:01] (03CR) 10Arthur taylor: [C:03+1] "Looks good to me! thank you" [integration/config] - 10https://gerrit.wikimedia.org/r/1012616 (https://phabricator.wikimedia.org/T356402) (owner: 10Hashar) [10:26:05] (03CR) 10Arthur taylor: dockerfiles: Quibble php-fpm memory_limit to 256M [integration/config] - 10https://gerrit.wikimedia.org/r/1012616 (https://phabricator.wikimedia.org/T356402) (owner: 10Hashar) [10:26:30] (03CR) 10Arthur taylor: [C:03+1] dockerfiles: Quibble php-fpm memory_limit to 256M [integration/config] - 10https://gerrit.wikimedia.org/r/1012616 (https://phabricator.wikimedia.org/T356402) (owner: 10Hashar) [10:28:21] well [10:51:10] <_joe_> hashar, jnuche around? There si a potentially serious situation on the appservers [10:51:51] <_joe_> while the /srv/mediawiki-staging/php dir exists, I don't find the corresponding /srv/mediawiki/php directory on appservers [10:52:06] <_joe_> this is causing some links to be broken AFAICT [10:52:15] <_joe_> any idea what changed the behaviour of the sync? [10:54:52] _joe_: I have seen something about removing that `php` symlink [10:54:58] (03CR) 10Hashar: [C:03+2] "I have tried it locally:" [integration/config] - 10https://gerrit.wikimedia.org/r/1012616 (https://phabricator.wikimedia.org/T356402) (owner: 10Hashar) [10:55:05] <_joe_> *deep sigh* [10:55:12] <_joe_> ok, thanks [10:55:39] I mean [10:55:59] they are tentatively useless from when we had a series of convenience symlinks such as `/h/w/c/p` [10:56:05] for `/home/wikipedia/common/php` [10:56:21] <_joe_> 100%, but there's clearly some stuff that wasn't fixed [10:56:34] (03Merged) 10jenkins-bot: dockerfiles: Quibble php-fpm memory_limit to 256M [integration/config] - 10https://gerrit.wikimedia.org/r/1012616 (https://phabricator.wikimedia.org/T356402) (owner: 10Hashar) [10:57:30] !log Updating Docker images for "dockerfiles: Quibble php-fpm memory_limit to 256M" | https://gerrit.wikimedia.org/r/1012616 | T356402 [10:57:33] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:57:34] T356402: [ES] Investigate OutOfMemory error in browser test, remove workaround - https://phabricator.wikimedia.org/T356402 [10:58:21] _joe_: https://phabricator.wikimedia.org/T359643 :) [10:58:26] literally `Get rid of the /srv/mediawiki/php symbolic link` [10:58:59] I don't know the code at all though but Ahmond and Timo worked on it [10:59:13] then I don't know whether any of that got merged/deployed [10:59:51] i don't think https://gerrit.wikimedia.org/r/c/operations/puppet/+/1012439 should have been merged before https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1012427 was [11:00:25] OH FUCK FO COURSE [11:00:28] that got force merged [11:00:39] I am so removing the submit permission right now [11:00:49] good catch taavi [11:06:39] <_joe_> yeah that was one of the problems [11:06:55] <_joe_> the other was I ofc ran my tests on an host where apache wasn't reloaded [11:07:01] <_joe_> so it was even more confusing [11:07:26] yeah and I cant drop the submit permission there [11:07:29] that is the operations/puppet repo [11:07:30] well [11:07:49] ideally I'd align that repo with how it is done everywhere else: CR+2 and get CI to submit/merge [11:07:50] :) [11:26:28] grmbmll [11:26:57] (03CR) 10Hashar: [C:03+2] "The php 8 images failed to build for some reason :(" [integration/config] - 10https://gerrit.wikimedia.org/r/1012616 (https://phabricator.wikimedia.org/T356402) (owner: 10Hashar) [11:27:07] 2024-03-19 11:04:11,572 [docker-pkg-build] INFO - W: GPG error: https://packages.sury.org/php buster InRelease: The following signatures were invalid: EXPKEYSIG B188E2B695BD4743 DEB.SURY.ORG Automatic Signing Key [11:27:09] ha [11:29:07] 10Continuous-Integration-Config, 06Release-Engineering-Team: Update sury.org gpg key - https://phabricator.wikimedia.org/T360420 (10hashar) 03NEW [11:34:56] (03PS1) 10Hashar: dockerfiles: update sury.org gpg key [integration/config] - 10https://gerrit.wikimedia.org/r/1012630 (https://phabricator.wikimedia.org/T360420) [11:35:14] (03CR) 10Hashar: [C:03+2] dockerfiles: update sury.org gpg key [integration/config] - 10https://gerrit.wikimedia.org/r/1012630 (https://phabricator.wikimedia.org/T360420) (owner: 10Hashar) [11:37:10] (03Merged) 10jenkins-bot: dockerfiles: update sury.org gpg key [integration/config] - 10https://gerrit.wikimedia.org/r/1012630 (https://phabricator.wikimedia.org/T360420) (owner: 10Hashar) [11:37:25] !log Building Docker images for "update sury.org gpg key" | https://gerrit.wikimedia.org/r/1012630 | T360420 [11:55:45] (03PS2) 10Ilias Sarantopoulos: ml-services: add huggingface pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/1011303 (https://phabricator.wikimedia.org/T357986) [12:26:07] wikibugs: refresh [12:26:09] wikibugs: no [12:26:11] wikibugs: now [12:26:16] :) [12:50:42] (03PS1) 10Hashar: jjb: update Quibble jobs to latest image [integration/config] - 10https://gerrit.wikimedia.org/r/1012636 (https://phabricator.wikimedia.org/T356402) [12:51:14] 10Continuous-Integration-Config, 06Release-Engineering-Team: 14Update sury.org gpg key - 14https://phabricator.wikimedia.org/T360420#9641660 (10hashar) 05Open→03Resolved a:03hashar [12:51:46] wikibugs has a ten minutes lag :/ [12:58:22] 10Continuous-Integration-Config, 06Release-Engineering-Team, 10VisualEditor: Remove CI job language-screenshots-VisualEditor - https://phabricator.wikimedia.org/T360425 (10hashar) 03NEW [13:00:06] 10Continuous-Integration-Infrastructure, 07Jenkins, 06Release-Engineering-Team: Remove the Yaml Axis Jenkins plugin from CI Jenkins - https://phabricator.wikimedia.org/T360426 (10hashar) 03NEW [13:00:23] 10Continuous-Integration-Infrastructure, 07Jenkins, 06Release-Engineering-Team: Remove the Yaml Axis Jenkins plugin from CI Jenkins - https://phabricator.wikimedia.org/T360426#9641754 (10hashar) [13:00:28] 10Continuous-Integration-Config, 06Release-Engineering-Team, 10VisualEditor: Remove CI job language-screenshots-VisualEditor - https://phabricator.wikimedia.org/T360425#9641755 (10hashar) [13:01:38] (03CR) 10Hashar: [C:03+2] "I have updated all the affected jobs, the php-fpm `memory_limit` should now be at 256M." [integration/config] - 10https://gerrit.wikimedia.org/r/1012636 (https://phabricator.wikimedia.org/T356402) (owner: 10Hashar) [13:03:02] (03Merged) 10jenkins-bot: jjb: update Quibble jobs to latest image [integration/config] - 10https://gerrit.wikimedia.org/r/1012636 (https://phabricator.wikimedia.org/T356402) (owner: 10Hashar) [13:06:14] 10Continuous-Integration-Config, 06Release-Engineering-Team, 10VisualEditor: Remove CI job language-screenshots-VisualEditor - https://phabricator.wikimedia.org/T360425#9641791 (10hashar) [13:08:10] !log Deleted `language-screenshots-VisualEditor` Jenkins job # T360425 [13:08:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:08:13] T360425: Remove CI job language-screenshots-VisualEditor - https://phabricator.wikimedia.org/T360425 [13:08:17] (03PS1) 10Hashar: jjb: remove language-screenshots-VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/1012642 (https://phabricator.wikimedia.org/T360425) [13:11:59] (03CR) 10Hashar: [C:03+2] jjb: remove language-screenshots-VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/1012642 (https://phabricator.wikimedia.org/T360425) (owner: 10Hashar) [13:13:47] (03Merged) 10jenkins-bot: jjb: remove language-screenshots-VisualEditor [integration/config] - 10https://gerrit.wikimedia.org/r/1012642 (https://phabricator.wikimedia.org/T360425) (owner: 10Hashar) [13:21:57] 10Continuous-Integration-Infrastructure, 07Jenkins, 06Release-Engineering-Team: 14Remove the Yaml Axis Jenkins plugin from CI Jenkins - 14https://phabricator.wikimedia.org/T360426#9641848 (10hashar) 05Open→03Resolved 14I have deleted the sole job that relied on that plugin (T360425) and uninstalled... [13:41:14] (03CR) 10Hashar: [C:03+2] "INFO:jenkins_jobs.builder:Number of jobs generated: 4" [integration/config] - 10https://gerrit.wikimedia.org/r/1011303 (https://phabricator.wikimedia.org/T357986) (owner: 10Ilias Sarantopoulos) [13:42:00] !log Reloaded Zuul for https://gerrit.wikimedia.org/r/c/integration/config/+/1011303 | T357986 [13:42:03] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:42:03] T357986: Use Huggingface model server image for HF LLMs - https://phabricator.wikimedia.org/T357986 [13:42:13] (03Merged) 10jenkins-bot: ml-services: add huggingface pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/1011303 (https://phabricator.wikimedia.org/T357986) (owner: 10Ilias Sarantopoulos) [13:48:14] (03PS1) 10Jforrester: Zuul: [purtle] Test in PHP 8.2 (but not 8.3) [integration/config] - 10https://gerrit.wikimedia.org/r/1012675 [13:48:15] (03PS1) 10Jforrester: Zuul: [php-session-serializer] Test in PHP 8.2 (but not 8.3) [integration/config] - 10https://gerrit.wikimedia.org/r/1012676 [13:48:21] (03PS1) 10Jforrester: Zuul: Test various passing tools in PHP 8.2 and 8.3 too [integration/config] - 10https://gerrit.wikimedia.org/r/1012677 [13:51:20] (03CR) 10Jforrester: [C:03+2] Zuul: [purtle] Test in PHP 8.2 (but not 8.3) [integration/config] - 10https://gerrit.wikimedia.org/r/1012675 (owner: 10Jforrester) [13:51:28] (03CR) 10Jforrester: [C:03+2] Zuul: [php-session-serializer] Test in PHP 8.2 (but not 8.3) [integration/config] - 10https://gerrit.wikimedia.org/r/1012676 (owner: 10Jforrester) [13:51:44] (03CR) 10Jforrester: [C:03+2] Zuul: Test various passing tools in PHP 8.2 and 8.3 too [integration/config] - 10https://gerrit.wikimedia.org/r/1012677 (owner: 10Jforrester) [13:53:29] (03Merged) 10jenkins-bot: Zuul: [purtle] Test in PHP 8.2 (but not 8.3) [integration/config] - 10https://gerrit.wikimedia.org/r/1012675 (owner: 10Jforrester) [13:53:37] (03Merged) 10jenkins-bot: Zuul: [php-session-serializer] Test in PHP 8.2 (but not 8.3) [integration/config] - 10https://gerrit.wikimedia.org/r/1012676 (owner: 10Jforrester) [13:53:45] (03Merged) 10jenkins-bot: Zuul: Test various passing tools in PHP 8.2 and 8.3 too [integration/config] - 10https://gerrit.wikimedia.org/r/1012677 (owner: 10Jforrester) [14:23:52] 10GitLab (Infrastructure), 06collaboration-services: Evaluate a high available GitLab architecture - https://phabricator.wikimedia.org/T323201#9642208 (10Jelto) We discussed this topic last week. A short summary: We agreed that a full HA setup is not within what out team can build and support currently. Howev... [14:28:47] 10GitLab (Infrastructure), 10Release-Engineering-Team (Radar), 06collaboration-services: Add GitLab upgrades and maintenance to deployment calendar - https://phabricator.wikimedia.org/T336470#9642258 (10Jelto) 05Resolved→03Open I'll reopen the task as the need to not disrupt production deployment is more... [14:34:01] 10Continuous-Integration-Config, 06Release-Engineering-Team, 10VisualEditor: Remove CI job language-screenshots-VisualEditor - https://phabricator.wikimedia.org/T360425#9642284 (10Esanders) There are tasks to get this job running again, and the script for generating screenshots work locally. [14:34:51] 10Continuous-Integration-Config, 06Release-Engineering-Team, 10VisualEditor: Remove CI job language-screenshots-VisualEditor - https://phabricator.wikimedia.org/T360425#9642292 (10Esanders) Also the bot last uploaded content in June 2020: https://commons.wikimedia.org/wiki/Special:Contributions/LanguageScree... [14:37:44] 10Continuous-Integration-Config, 06Release-Engineering-Team, 10VisualEditor: Remove CI job language-screenshots-VisualEditor - https://phabricator.wikimedia.org/T360425#9642296 (10Esanders) See also T139747 [14:49:13] 06Release-Engineering-Team, 06Tech-Docs-Team, 07Documentation, 13Patch-For-Review: Review supporting deployment pipeline documentation - https://phabricator.wikimedia.org/T352262#9642449 (10dancy) Looks great! [14:53:09] _joe_, hashar: Is there something I should have done differently to prepare https://gerrit.wikimedia.org/r/c/operations/puppet/+/1012439 and https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1012427 and to indicate their dependency? [14:53:50] <_joe_> dancy: nothing really, we were just a bit distracted during the sre offsite [14:54:03] OK [15:01:41] <_joe_> dancy: OTOH I'd love your +1 on https://gerrit.wikimedia.org/r/c/operations/puppet/+/1012618/1 [15:01:49] Taking a look [15:02:07] <_joe_> it's just about adding the k8s releases git repo between masters [15:02:18] <_joe_> *the sync of [15:04:14] LGTM [15:10:40] (03CR) 10Hashar: [C:03+2] "My concern was about whether Qunit/Selenium stages would work using the php webserver without a router. Looks like that is working out o" [integration/quibble] - 10https://gerrit.wikimedia.org/r/987183 (https://phabricator.wikimedia.org/T357070) (owner: 10Umherirrender) [15:17:40] 10Phabricator, 06Release-Engineering-Team, 06collaboration-services: Update wmf/stable to Phorge upstream's 2023.49 stable release - https://phabricator.wikimedia.org/T358610#9642598 (10brennen) Noting that I'm deploying a release branch for `repos/phabricator/phabricator` this time rather than `wmf/stable`:... [15:19:34] 06Release-Engineering-Team, 10Quibble: Quibble --command is no more interactive causing "bash" to show no prompt - https://phabricator.wikimedia.org/T360443 (10hashar) 03NEW [15:24:26] 06Release-Engineering-Team, 10Quibble: Quibble --command is no more interactive causing "bash" to show no prompt - https://phabricator.wikimedia.org/T360443#9642661 (10hashar) [15:29:52] 10Phabricator, 06Release-Engineering-Team, 06collaboration-services: Update wmf/stable to Phorge upstream's 2023.49 stable release - https://phabricator.wikimedia.org/T358610#9642685 (10ops-monitoring-bot) Icinga downtime and Alertmanager silence (ID=32334dd4-8e49-4850-8ec1-a894dbff453b) set by jelto@cumin10... [15:30:16] 10Phabricator, 06Release-Engineering-Team, 06collaboration-services: Update wmf/stable to Phorge upstream's 2023.49 stable release - https://phabricator.wikimedia.org/T358610#9642701 (10ops-monitoring-bot) Icinga downtime and Alertmanager silence (ID=b485f4ff-a3d9-4d3e-9220-42f9967a1c08) set by jelto@cumin10... [15:32:02] 06Release-Engineering-Team, 10Quibble: Quibble --command is no more interactive causing "bash" to show no prompt - https://phabricator.wikimedia.org/T360443#9642720 (10hashar) [15:36:57] (03Merged) 10jenkins-bot: backend: Remove use of mediawiki/core router.php from PhpWebserver [integration/quibble] - 10https://gerrit.wikimedia.org/r/987183 (https://phabricator.wikimedia.org/T357070) (owner: 10Umherirrender) [15:39:05] 10GitLab (Infrastructure), 10Release-Engineering-Team (Radar), 06collaboration-services: Add GitLab upgrades and maintenance to deployment calendar - https://phabricator.wikimedia.org/T336470#9642769 (10brennen) > every Friday 11:00 UTC - 11:30 UTC cc: @thcipriani re: above. I think this is probably a reas... [15:52:09] 06Release-Engineering-Team, 10Quibble: Quibble --command is no more interactive causing "bash" to show no prompt - https://phabricator.wikimedia.org/T360443#9642844 (10hashar) From bash man page: > An interactive shell [...] whose standard input **and** error are **both** connected to terminals (as determinate... [15:58:28] (03CR) 10Hashar: [C:03+2] "My concern was whether the Selenium/Qunit tests would work when not using the mediawiki/core router. Turns out they seem to work, so I am" [integration/quibble] - 10https://gerrit.wikimedia.org/r/987183 (https://phabricator.wikimedia.org/T357070) (owner: 10Umherirrender) [16:15:05] 10Phabricator, 06Release-Engineering-Team, 06collaboration-services: Update wmf/stable to Phorge upstream's 2023.49 stable release - https://phabricator.wikimedia.org/T358610#9642933 (10brennen) I'm seeing a handful of these in logs: `lines=10 PHP message: [2024-03-19 15:55:08] EXCEPTION: (PhabricatorDataNo... [16:21:10] <_joe_> dancy: uhm am I reading correctly that "scap sync-world --k8s-only" doesn't run sync-masters? [16:21:49] That sounds right (since sync-masters is about bare metal servers) [16:22:23] Confirmed. [16:22:28] <_joe_> heh not with the change I just made, uhm :) [16:22:50] I can change scap accordingly. [16:23:06] <_joe_> basically we store info about k8s releases in a git repo, and I was using sync-masters to ensure it's kept in sync between deployment servers [16:23:23] nod.. Makes sense. Do you have a ticket I can reference for the corresponding scap changes? [16:23:27] <_joe_> yeah, it's not super-urgent but we might want to do it [16:23:42] It's a one-liner, so might as well get 'er done [16:23:45] <_joe_> dancy: no, I just went rogue and wrote the code without a task. [16:23:51] haha ok [16:24:01] <_joe_> it's a reaction to too much annual planning [16:24:06] x) [16:24:18] <_joe_> so many docs to write and read, I just wanted to fix the issue :P [16:24:23] <_joe_> I guess lesson learned [16:27:57] https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/251 [16:31:57] <_joe_> dancy: lgtm [16:32:17] <_joe_> took me more time to log onto gitlab than to review the code :) [16:32:24] haha totally [16:33:01] every. time. [16:37:56] _joe_: Update scap release deployed. [16:38:00] *Updated [16:44:40] <_joe_> dancy: <3 I'll test it [16:52:16] 10Release-Engineering-Team (Now this 🫠), 10Scap, 10MediaWiki-libs-Mime, 10MediaWiki-Platform-Team (Radar), and 2 others: Get rid of the /srv/mediawiki/php symbolic link - https://phabricator.wikimedia.org/T359643#9643093 (10CodeReviewBot) dancy opened https://gitlab.wikimedia.org/repos/releng/train-dev/-/m... [16:53:13] 10Release-Engineering-Team (Now this 🫠), 10Scap, 10MediaWiki-libs-Mime, 10MediaWiki-Platform-Team (Radar), and 2 others: Get rid of the /srv/mediawiki/php symbolic link - https://phabricator.wikimedia.org/T359643#9643096 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/train-dev/-/m... [17:01:28] i'm going afk for a couple hours to do an airport run. if anybody notices serious problems with the new phab release, WMF releng colleagues have my phone number. [17:07:17] (03PS1) 10MusikAnimal: Zuul: [mediawiki/extensions/CodeMirror] Publish JS documentation [integration/config] - 10https://gerrit.wikimedia.org/r/1012723 (https://phabricator.wikimedia.org/T359986) [18:40:56] dduvall or mutante, do you have an hour or two in the next few days to be my test subject? I'm doing a big puppet upgrade on cloud-vps and hoping to delegate some of the work to project admins; example instructions are here: https://phabricator.wikimedia.org/T360459 [18:41:12] (if mutante volunteers I'll make a ticket for the project of his choice) [18:43:38] Note dduvall is on sabbatical [18:44:05] [18:44:33] Let's hope he's using his time wisely! [18:44:35] dancy: in that case, I think the question falls to you :) [18:44:43] * dancy reads the ticket [18:46:00] 10Continuous-Integration-Config, 10commit-message-validator: commit-message-validator job exits successfully even when it fails - https://phabricator.wikimedia.org/T360460 (10Daimona) 03NEW [18:51:54] ...and here's a near-identical ticket for hashar probably https://phabricator.wikimedia.org/T360461 [18:55:14] 06Release-Engineering-Team, 06cloud-services-team, 10VPS-Projects, 10Puppet (Puppet 7.0): Update Integration project puppetmaster - https://phabricator.wikimedia.org/T360461#9643634 (10dancy) [19:05:19] 10Phabricator: Form 54 has a restricted view policy, but not sure it should - https://phabricator.wikimedia.org/T360463 (10MBinder_WMF) 03NEW [19:21:17] 06Release-Engineering-Team, 10MW-on-K8s: Helm deployment of MediaWiki now takes 6 minutes - https://phabricator.wikimedia.org/T360403#9643760 (10dancy) I used `scap backport` to deploy a mediawiki-config change today. The sync part of the operation took 15 minutes to complete. As an occasional user of scap, t... [19:43:08] andrewbogott: unless mutante has already tackled it, i might be able to try the equivalent thing in the devtools project [19:43:34] great! That's https://phabricator.wikimedia.org/T360470 [19:44:24] I have done that about 10 times now but I'm still not 100% sure that I got all the steps written down so please let me know if you see things obviously missing or something doesn't work. [19:45:04] andrewbogott: right on. [19:45:10] thanks! [20:09:21] 10Release-Engineering-Team (Now this 🫠), 10Scap, 13Patch-For-Review: Scap backporting a patch that gets a -2 hangs - https://phabricator.wikimedia.org/T350628#9643952 (10CodeReviewBot) sandeeps merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/231 Scap Backport: fix scap hang on patches... [20:16:02] (03CR) 10Hashar: [C:03+2] Zuul: [mediawiki/extensions/CodeMirror] Publish JS documentation [integration/config] - 10https://gerrit.wikimedia.org/r/1012723 (https://phabricator.wikimedia.org/T359986) (owner: 10MusikAnimal) [20:17:48] 06Release-Engineering-Team, 06cloud-services-team, 10VPS-Projects, 10Puppet (Puppet 7.0): Update Integration project puppetmaster - https://phabricator.wikimedia.org/T360461#9643977 (10hashar) a:05hashar→03None [20:18:52] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 06cloud-services-team, 10VPS-Projects, 10Puppet (Puppet 7.0): Update Integration project puppetmaster - https://phabricator.wikimedia.org/T360461#9643984 (10hashar) [20:24:07] (03CR) 10Hashar: [C:04-1] "The depends-on should be the other way around. We need to first deploy this CI change, then `recheck` https://gerrit.wikimedia.org/r/c/med" [integration/config] - 10https://gerrit.wikimedia.org/r/1012723 (https://phabricator.wikimedia.org/T359986) (owner: 10MusikAnimal) [20:26:54] (03PS2) 10MusikAnimal: Zuul: [mediawiki/extensions/CodeMirror] Publish JS documentation [integration/config] - 10https://gerrit.wikimedia.org/r/1012723 (https://phabricator.wikimedia.org/T359986) [20:27:35] (03CR) 10MusikAnimal: "Thanks! Done." [integration/config] - 10https://gerrit.wikimedia.org/r/1012723 (https://phabricator.wikimedia.org/T359986) (owner: 10MusikAnimal) [20:45:09] Hey I have a phan issue relating to code from a git submodule - https://integration.wikimedia.org/ci/job/mwskin-php74-phan-docker/8830/console - any idea why it's not picking up the file in the submodule? [20:46:14] Does the phan config for the repo know to even look there? [20:47:34] James_F: says that it might not index non-includes folders? Is that correct? [20:47:35] You'll probably want to add it to the phan config for directory_list or similar, while also excluding it from analysis [20:47:52] Yeah, it doesn't search everywhere just incase there's PHP files [20:47:56] because that'll be slow [20:48:31] https://github.com/wikimedia/mediawiki-skins-Vector/blob/master/.phan/config.php is what we currently have [20:48:51] So I guess I just need to add Vector/shared/ to directory_list? [20:48:58] add shared/whatever/path/you/need to both of those [20:49:13] probably ../shared/whatever/path/you/need [20:50:33] also, shared.git:includes/ConfigHelper.php uses `namespace MediaWiki\Skins\Shared;` but the autoload config in Vector uses `"MediaWiki\\Skins\\SharedVector\\"` [20:50:43] how will this repository make its way into production? [20:51:05] Does this actually need to be a submodule? Or could you just make it depend on the other "skin"? [20:52:14] You mean make Minerva depend on Vector? [20:52:45] well, based on what you're trying to do, make Vector depend on "shared" [20:53:07] Oh I see. Yes it could do that, but my thinking was a submodule might be less hassle than an entire skin repo. [20:53:18] (that's not really a skin - just shared code) [20:53:37] That sounds like it should more be some sort of vendor-ised library then [20:53:40] Which is a more standard pattern... [20:54:09] We considered vendor library/composer but mediawiki platform team advised us that vendor code should not make use of MediaWiki internals. [20:54:37] Long term we would want this code in core, I think that just needs some more thought/input from other teams and we're looking for a more short term solution. [20:56:14] It could live in core using Depends-On: a patch in core, if that's the desired end goal [20:56:48] If it is truely a short term solution... Fixing the phan config as above, and also the namespacing usage/declaration as per taavi would "work" [20:57:42] for some definition of "work". I'm not sure how scap and the branching tools handle arbitrary submodules like that. [20:58:15] wikifunctions and VisualEditor use submodules so the tooling supports this because of them (James_F should be able to confirm) [20:58:18] VE has the same thing [20:58:34] I'm pretty sure the tooling does a submodule recursive checkout [21:00:12] musikanimal: for the jsdoc change and the CI config, I guess you will have to sync up with someone that has the rights to deploy the CI config change [21:00:26] well possibly me in your afternoon :) [21:01:04] cause there are bunch of changes that need to be merged first, then the the CI Config can be enabled (which would enforce `npm run doc` from now on) and finally the change introducing the `doc` entry point can be `recheck` or CR+2 [21:01:10] and if the doc works, then it will merge [21:06:33] Jdlrobson: https://gerrit.wikimedia.org/r/mediawiki/skins/shared [21:06:36] that sounds like a terrible idea [21:06:41] with submodules [21:09:47] That repo really shouldn't have been created there too [21:10:33] and I don't think using git submodules is any a good ida [21:10:35] idea [21:11:17] then there are so many multiple ways [21:11:43] one is for example to created a Shared skin and have each of Minerva and Vector to require it [21:11:44] As above, we're already doing it... But indeed, doesn't mean it's a pattern we should continue to propagate [21:12:37] I wonder what would happen when the two "shared" repos are out of sync between the two skins :D [21:13:35] Well, indeed.. If we have multiple skins including that same gitmodule... [21:34:24] or I guess get the code in Vector [21:34:36] it is already the default skin for most purpose and is always cloned by CI / Quibble [21:34:47] so shareable code can fit there [21:34:48] anyway [21:35:25] so many solutions, but the git submodule sounds prone to future troubles [21:35:29] * hashar sleeps & [22:06:09] 10Continuous-Integration-Infrastructure, 07Jenkins, 06Release-Engineering-Team: 14Remove the Yaml Axis Jenkins plugin from CI Jenkins - 14https://phabricator.wikimedia.org/T360426#9644230 (10hashar) [22:07:51] 10Continuous-Integration-Config, 06Release-Engineering-Team, 10VisualEditor, 10MW-1.42-notes (1.42.0-wmf.24; 2024-03-26): 14Remove CI job language-screenshots-VisualEditor - 14https://phabricator.wikimedia.org/T360425#9644228 (10hashar) 05Open→03Resolved 14>>! In T360425#9642292, @Esanders wrote:... [23:07:06] 10Continuous-Integration-Config, 10commit-message-validator: commit-message-validator job exits successfully even when it fails - https://phabricator.wikimedia.org/T360460#9644324 (10bd808) > which wasn't the case until recently. If the change comes from commit-message-validator itself, which is completely po... [23:20:07] 10Continuous-Integration-Config, 10commit-message-validator: commit-message-validator job exits successfully even when it fails - https://phabricator.wikimedia.org/T360460#9644343 (10bd808) p:05Triage→03High `lang=shell-session $ git clone ssh://gerrit/mediawiki/extensions/CampaignEvents $ cd CampaignEvent... [23:21:47] 10Continuous-Integration-Config, 10commit-message-validator: commit-message-validator job exits successfully even when it fails - https://phabricator.wikimedia.org/T360460#9644349 (10bd808) As stated, older versions of commit-message-validator exited with a non-zero status on failure: ` $ pipx install --force... [23:22:20] 10Phabricator: Submitting actions taking ~10 seconds to load after making changes - https://phabricator.wikimedia.org/T360484 (10HNordeenWMF) 03NEW [23:38:52] 10Continuous-Integration-Config, 10commit-message-validator: commit-message-validator job exits successfully even when it fails - https://phabricator.wikimedia.org/T360460#9644417 (10bd808) The single file validator mode works as expected in commit-message-validator 2.0.0: `lang=shell-session $ pipx install --... [23:39:05] 10Phabricator: Submitting actions taking ~10 seconds to load after making changes - https://phabricator.wikimedia.org/T360484#9644418 (10HNordeenWMF) @HNordeenWMF (Test mention) [23:44:53] 10Phabricator: Submitting actions taking ~10 seconds to load after making changes - https://phabricator.wikimedia.org/T360484#9644421 (10HNordeenWMF) @HNordeenWMF mention test [23:50:52] 10Continuous-Integration-Config, 10commit-message-validator, 13Patch-For-Review: commit-message-validator job exits successfully even when it fails - https://phabricator.wikimedia.org/T360460#9644435 (10CodeReviewBot) bd808 opened https://gitlab.wikimedia.org/repos/ci-tools/commit-message-validator/-/merge_r... [23:57:37] 10Continuous-Integration-Config, 10commit-message-validator, 13Patch-For-Review: commit-message-validator job exits successfully even when it fails - https://phabricator.wikimedia.org/T360460#9644444 (10bd808) A quicker fix for this problem in Jenkins than waiting for a new release will be to change the comm... [23:58:33] 10Continuous-Integration-Config, 10commit-message-validator, 13Patch-For-Review: commit-message-validator job exits successfully even when it fails - https://phabricator.wikimedia.org/T360460#9644445 (10CodeReviewBot) bd808 merged https://gitlab.wikimedia.org/repos/ci-tools/commit-message-validator/-/merge_r...