[03:41:42] Can you suppress https://phabricator.wikimedia.org/F33942293 [03:41:50] I am requesting https://phabricator.wikimedia.org/F33942293 to be oversighted [04:06:41] Guest71: done. [09:24:00] 10Release-Engineering-Team (Radar), 10Temporary accounts, 13Patch-For-Review: Enable temp account creation in DevelopmentSettings.php - https://phabricator.wikimedia.org/T359043#9747246 (10kostajh) [09:31:50] 10Release-Engineering-Team (Radar), 10Temporary accounts, 13Patch-For-Review: Enable temp account creation in DevelopmentSettings.php - https://phabricator.wikimedia.org/T359043#9747255 (10kostajh) a:03kostajh [09:34:21] 06Release-Engineering-Team, 10Temporary accounts, 06Trust and Safety Product Team, 13Patch-For-Review: Make PHPUnit, Selenium, and API testing tests pass with temp account feature flag enabled - https://phabricator.wikimedia.org/T355879#9747271 (10kostajh) @hashar, @stran, @Dreamy_Jazz and myself met to di... [09:58:34] GitLab needs maintenance for around 15-20 minutes in an hour. The downtime will be a bit longer because we also have to restart the host as well. [10:22:16] 10Phabricator (Upstream), 07Upstream: tooltip mentions non-existent "Wishlist priority" in Open Tasks by Project and Priority report - https://phabricator.wikimedia.org/T91428#9747379 (10Aklapper) 05Open→03Stalled p:05Lowest→03Low a:03Aklapper [10:30:05] (03PS1) 10Subramanya Sastry: Suppress one more vertical-whitespace noisy diff on enwikivoyage [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1024616 [10:44:17] (03PS2) 10Subramanya Sastry: Suppress one more vertical-whitespace noisy diff on enwikivoyage [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1024616 [10:44:53] (03CR) 10CI reject: [V:04-1] Suppress one more vertical-whitespace noisy diff on enwikivoyage [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1024616 (owner: 10Subramanya Sastry) [10:47:34] (03PS3) 10Subramanya Sastry: Suppress one more vertical-whitespace noisy diff on enwikivoyage [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1024616 [11:18:37] GitLab maintenance done [12:11:27] (03CR) 10Isabelle Hurbain-Palatin: "I don't even know if we can have empty

, or if it actually crashes if it's the case, but I'm not confident in either, so I'm checking :" [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1024616 (owner: 10Subramanya Sastry) [12:47:30] 10Phabricator maintenance bot: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573 (10Daimona) 03NEW [12:52:29] hashar: here is an example of the problem I mentionned yesterday: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/1024619 [12:53:36] I removed the -1 vote from cindy but there's still an icon in red in the "Submit Requirements" section [12:54:56] ah [12:55:28] then the Verified chip on left is marked Verified [12:55:45] wth is that red chip hehe [12:56:10] HO [12:56:12] of couse [12:56:49] so the submit requirement line shows: [v] Verified [+2][+1](!1) [12:57:43] looking at the dom, the +2 and +1 are `` elements which represent jenkins-bot +2 and sonarqube bot +1 [12:57:47] so far so good [12:57:54] Cindy-the-browser-test-bot [12:58:40] the last one (!1) is an entire different beast, that is a `` [12:59:19] why it shows up there? I have no clue, I guess cause it is reported as being an error and that is added there as a hint [12:59:39] even though the Cindy brower bot did not vote at all [13:01:46] it did vote but I removed the vote [13:03:02] and the bot is considered to be contributing to the Verified label [13:03:17] so since it is marked in ERROR, the UI considers it has voted Verified -1 [13:03:22] and shows the chip there [13:03:30] it assumes it [13:03:52] and in my code I have: // A more robust alternative would be to parse the message for the labels that got voted [13:04:18] so that when parsing the messages emitted, the code could detect the verified -1 got dropped [13:09:03] dcausse: yeah I have confirmed by reading the code [13:09:18] the Cindy bot is marked as participating to the Verified label [13:09:34] and since it was in ERROR state , it is show next to the submit requirements [13:09:51] I mean I had the intuition for that and I have confirmed it in gr-submit-requirements [13:10:11] I guess an alternative would be to stop it making vote Verified and make it report a WARNING [13:10:18] or move it to its own label [13:10:52] essentially, I think something can be enhanced yes :] [13:11:41] hashar: ok, thanks! nothing urgent here, I'll file a low prio task and see if we have time to improve this :) [13:23:27] sounds good [13:55:20] 10Phabricator: Phabricator should recognize "Bug: Tnnn" in commit messages same as "refs Tnnn" and connect the commit to the task - https://phabricator.wikimedia.org/T117434#9748005 (10Aklapper) 05Open→03Declined [15:29:59] 06Release-Engineering-Team, 10Scap, 06serviceops, 13Patch-For-Review: scap should optionally display helmfile diffs for review - https://phabricator.wikimedia.org/T362717#9748270 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/295 Optionally collect, display,... [16:11:38] 10Phabricator maintenance bot: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748443 (10Umherirrender) The regex to search for comment does not include `#` as added by {T358940} for new comments to avoid autolinking of numbers. Tw... [16:27:22] 06Release-Engineering-Team, 10Scap, 06serviceops: scap should optionally display helmfile diffs for review - https://phabricator.wikimedia.org/T362717#9748533 (10Scott_French) 05Open→03Resolved Many thanks to @dancy for the review. I think I'm happy with this simple solution for now. The fact that t... [16:45:53] 10Phabricator maintenance bot, 13Patch-For-Review: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748607 (10CodeReviewBot) daimona opened https://gitlab.wikimedia.org/ladsgroup/Phabricator-maintenance-bot/-/merge_requests/5 Upda... [16:46:33] 10Phabricator maintenance bot, 13Patch-For-Review: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748629 (10Daimona) Lol, my first conflict in gitlab. [16:47:37] 10Phabricator maintenance bot: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748639 (10CodeReviewBot) daimona closed https://gitlab.wikimedia.org/ladsgroup/Phabricator-maintenance-bot/-/merge_requests/5 Update regex for gerrit ch... [16:47:47] 10Phabricator maintenance bot: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748623 (10Ladsgroup) Fixed in https://gitlab.wikimedia.org/ladsgroup/Phabricator-maintenance-bot/-/commit/982cfc2f33f8190728363c5ecdc55fbbab1ea40e I dep... [16:48:14] 10Phabricator maintenance bot: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748643 (10Ladsgroup) >>! In T363573#9748629, @Daimona wrote: > Lol, my first conflict in gitlab. I'm sorry 😅 [16:49:10] 10Phabricator maintenance bot: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748647 (10Ladsgroup) We probably should actually fix the gitlab part before running it again [16:49:51] 10Phabricator maintenance bot: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748649 (10Daimona) >>! In T363573#9748647, @Ladsgroup wrote: > We probably should actually fix the gitlab part before running it again Indeed, I was jus... [16:50:56] 06Release-Engineering-Team, 10Scap: scap: hide helmfile operations behind a progress bar - https://phabricator.wikimedia.org/T325530#9748651 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/292 Simple k8s deployment progress reporting [16:50:58] 10Scap, 10MW-on-K8s: Provide some feedback in scap whilst waiting for helmfile deploys to complete - https://phabricator.wikimedia.org/T361747#9748652 (10CodeReviewBot) dancy merged https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/292 Simple k8s deployment progress reporting [16:55:08] 06Release-Engineering-Team, 10Scap: scap: hide helmfile operations behind a progress bar - https://phabricator.wikimedia.org/T325530#9748680 (10dancy) 05Open→03In progress p:05Triage→03Medium a:03dancy [17:00:11] 10Scap, 10MW-on-K8s: Provide some feedback in scap whilst waiting for helmfile deploys to complete - https://phabricator.wikimedia.org/T361747#9748708 (10dancy) 05Open→03In progress p:05Triage→03Medium a:03dancy [17:07:35] Hi [17:07:52] Is it possible to install this Extension:CentralNotice on a Wikimedia project? [17:24:42] (03CR) 10Subramanya Sastry: Suppress one more vertical-whitespace noisy diff on enwikivoyage (032 comments) [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1024616 (owner: 10Subramanya Sastry) [17:27:40] (03PS4) 10Subramanya Sastry: Suppress one more vertical-whitespace noisy diff on enwikivoyage [integration/visualdiff] - 10https://gerrit.wikimedia.org/r/1024616 [17:28:38] Gerges: https://www.mediawiki.org/wiki/Extension:CentralNotice is actively used across all of the content projects. It is among other things the system by which the WMF does fundraising banners. [17:40:23] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.43.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T361397#9748902 (10Jdlrobson) [17:47:50] 10Phabricator maintenance bot, 13Patch-For-Review: Phabricator maintenance bot removed Patch-for-Review from task with open gitlab MR - https://phabricator.wikimedia.org/T363232#9748924 (10CodeReviewBot) ladsgroup merged https://gitlab.wikimedia.org/ladsgroup/Phabricator-maintenance-bot/-/merge_requests/6 pat... [17:47:52] 10Phabricator maintenance bot, 13Patch-For-Review: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748925 (10CodeReviewBot) ladsgroup merged https://gitlab.wikimedia.org/ladsgroup/Phabricator-maintenance-bot/-/merge_requests/6 pa... [17:47:56] 06Gerrit-Privilege-Requests: Add Pppery to trusted-contributors on Gerrit - https://phabricator.wikimedia.org/T363598 (10Pppery) 03NEW [17:48:20] 10Phabricator maintenance bot: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748947 (10Ladsgroup) That's fixed. [17:48:41] 10Phabricator maintenance bot: Phabricator maintenance bot removed Patch-for-Review from task with open gitlab MR - https://phabricator.wikimedia.org/T363232#9748950 (10Ladsgroup) We actually had support for gitlab but it had a bug. That's fixed now. [17:49:41] 10Phabricator maintenance bot: Phabricator maintenance bot removed Patch-for-Review from task with open gitlab MR - https://phabricator.wikimedia.org/T363232#9748920 (10CodeReviewBot) ladsgroup opened https://gitlab.wikimedia.org/ladsgroup/Phabricator-maintenance-bot/-/merge_requests/6 patchforreview_remove... [17:49:55] 10Phabricator maintenance bot: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748922 (10CodeReviewBot) ladsgroup opened https://gitlab.wikimedia.org/ladsgroup/Phabricator-maintenance-bot/-/merge_requests/6 patchforreview_remov... [17:49:57] 10Phabricator maintenance bot: Phabricator maintenance bot removed Patch-for-Review from task with open gitlab MR - https://phabricator.wikimedia.org/T363232#9748954 (10Ladsgroup) 05Open→03Resolved a:03Ladsgroup [17:51:05] 10Phabricator maintenance bot: Maintenance_bot not removing patch-for-review when all conditions are seemingly met - https://phabricator.wikimedia.org/T363573#9748966 (10Ladsgroup) 05Open→03Resolved a:03Ladsgroup [17:53:54] 06Release-Engineering-Team, 10Scap: scap: hide helmfile operations behind a progress bar - https://phabricator.wikimedia.org/T325530#9748997 (10dancy) 05In progress→03Resolved Deployed in scap 4.80.0 Sample output: ` 17:51:21 Finished sync-canaries-k8s (duration: 01m 07s) 17:51:21 Started sync-prod-k8... [17:55:02] 10Scap, 10MW-on-K8s: Provide some feedback in scap whilst waiting for helmfile deploys to complete - https://phabricator.wikimedia.org/T361747#9749010 (10dancy) 05In progress→03Open p:05Medium→03Triage a:05dancy→03None [17:55:54] 10Scap, 10MW-on-K8s: Provide some feedback in scap whilst waiting for helmfile deploys to complete - https://phabricator.wikimedia.org/T361747#9749018 (10dancy) I completed related work in T325530 and I'm inclined to leave it at that for now. [18:15:55] (03PS2) 10Jforrester: Zuul: Re-apply PHP 8.2 CI to Wikibase-based code [integration/config] - 10https://gerrit.wikimedia.org/r/1023401 (https://phabricator.wikimedia.org/T360560) [18:15:59] (03CR) 10Jforrester: [C:03+2] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code [integration/config] - 10https://gerrit.wikimedia.org/r/1023401 (https://phabricator.wikimedia.org/T360560) (owner: 10Jforrester) [18:17:42] (03Merged) 10jenkins-bot: Zuul: Re-apply PHP 8.2 CI to Wikibase-based code [integration/config] - 10https://gerrit.wikimedia.org/r/1023401 (https://phabricator.wikimedia.org/T360560) (owner: 10Jforrester) [18:18:26] !log Zuul: Re-apply PHP 8.2 CI to Wikibase-based code for T360560 T324202 T353161 [18:18:31] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:18:31] T360560: Make PHP 8.2 voting on development branch of Wikibase - https://phabricator.wikimedia.org/T360560 [18:18:32] T324202: Remove use of utf8_encode and utf8_decode in Wikibase - https://phabricator.wikimedia.org/T324202 [18:18:32] T353161: [CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated - https://phabricator.wikimedia.org/T353161 [18:21:44] 06Gerrit-Privilege-Requests: Add Pppery to trusted-contributors on Gerrit - https://phabricator.wikimedia.org/T363598#9749210 (10taavi) 05Open→03Resolved a:03taavi [18:22:05] 10Continuous-Integration-Config, 07PHP 8.2 support: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) - https://phabricator.wikimedia.org/T352085#9749216 (10Jdforrester-WMF) [18:22:18] 06Gerrit-Privilege-Requests, 10Librarization: Allow `mediawiki` group (and project owners?) to set Verified+2 and submit `mediawiki/libs`, like for `mediawiki/extensions` etc. - https://phabricator.wikimedia.org/T362980#9749218 (10taavi) 05Open→03Resolved a:03taavi Done for the `mediawiki` group. [18:24:31] 10Continuous-Integration-Config, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10wmde-wikidata-tech, and 4 others: Make PHP 8.2 voting on development branch of Wikibase - https://phabricator.wikimedia.org/T360560#9749206 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF [18:45:09] (03PS2) 10Jforrester: Zuul: [mediawiki/extensions/Wikibase] Run REL1_42 on PHP 8.1 jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1020216 (https://phabricator.wikimedia.org/T362412) [18:45:10] (03PS2) 10Jforrester: Zuul: [mediawiki/extensions/Wikibase] Run PHP 8.1 jobs by default [integration/config] - 10https://gerrit.wikimedia.org/r/1020217 [18:46:33] (03CR) 10CI reject: [V:04-1] Zuul: [mediawiki/extensions/Wikibase] Run PHP 8.1 jobs by default [integration/config] - 10https://gerrit.wikimedia.org/r/1020217 (owner: 10Jforrester) [18:46:34] (03CR) 10CI reject: [V:04-1] Zuul: [mediawiki/extensions/Wikibase] Run REL1_42 on PHP 8.1 jobs [integration/config] - 10https://gerrit.wikimedia.org/r/1020216 (https://phabricator.wikimedia.org/T362412) (owner: 10Jforrester) [18:49:22] (03PS1) 10Jforrester: Zuul: [mediawiki/extensions/Math] Re-enable PHP 8.2 CI voting [integration/config] - 10https://gerrit.wikimedia.org/r/1024786 (https://phabricator.wikimedia.org/T360709) [18:51:47] (03CR) 10Jforrester: [C:03+2] Zuul: [mediawiki/extensions/Math] Re-enable PHP 8.2 CI voting [integration/config] - 10https://gerrit.wikimedia.org/r/1024786 (https://phabricator.wikimedia.org/T360709) (owner: 10Jforrester) [18:53:54] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/Math] Re-enable PHP 8.2 CI voting [integration/config] - 10https://gerrit.wikimedia.org/r/1024786 (https://phabricator.wikimedia.org/T360709) (owner: 10Jforrester) [18:55:19] !log Zuul: [mediawiki/extensions/Math] Re-enable PHP 8.2 CI voting for T360709 [18:55:23] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:55:23] T360709: Make PHP 8.2 voting on development (master) branch of Math extension - https://phabricator.wikimedia.org/T360709 [18:55:44] 10Continuous-Integration-Config, 10Math, 13Patch-For-Review, 07PHP 8.2 support: Make PHP 8.2 voting on development (master) branch of Math extension - https://phabricator.wikimedia.org/T360709#9749499 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF [18:56:40] 10Continuous-Integration-Config, 07PHP 8.2 support: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) - https://phabricator.wikimedia.org/T352085#9749504 (10Jdforrester-WMF) [18:58:21] 10Continuous-Integration-Config, 07PHP 8.2 support: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) - https://phabricator.wikimedia.org/T352085#9749530 (10Jdforrester-WMF) [19:00:09] 10Continuous-Integration-Config, 07PHP 8.2 support: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) - https://phabricator.wikimedia.org/T352085#9749536 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF OK, this is sort-of done. C... [19:08:47] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure: Migrate all CI jobs from buster to bullseye or later and drop buster testing support - https://phabricator.wikimedia.org/T335765#9749612 (10Jdforrester-WMF) [19:33:19] huh, what's up with https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php82-noselenium/422/console? [20:27:11] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.43.0-wmf.3 deployment blockers - https://phabricator.wikimedia.org/T361397#9749762 (10BPirkle) ##### Risky Patch! 🚂🔥 * **Change**: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1016820 * **Summary**: ** !! If things go...