[07:13:42] (03CR) 10Kosta Harlan: Add notice at the end of console log for parallel test runs (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/1049919 (https://phabricator.wikimedia.org/T361190) (owner: 10Arthur taylor) [07:30:33] (03open) 10aklapper: Create Herald task condition to have Projects include their subprojects [repos/phabricator/phabricator] (wmf/stable) - 10https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/62 (https://phabricator.wikimedia.org/T144041) [07:31:55] (03PS4) 10Arthur taylor: Add notice at the end of console log for parallel test runs [integration/quibble] - 10https://gerrit.wikimedia.org/r/1049919 (https://phabricator.wikimedia.org/T361190) [07:32:15] (03CR) 10Arthur taylor: Add notice at the end of console log for parallel test runs (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/1049919 (https://phabricator.wikimedia.org/T361190) (owner: 10Arthur taylor) [07:32:56] 10Phabricator (Upstream), 13Patch-For-Review, 07Upstream: Avoid the need to update Herald exclusion rules everytime a new team sprint project is created - https://phabricator.wikimedia.org/T144041#9929378 (10Aklapper) [07:33:12] 10Phabricator, 13Patch-For-Review: Avoid the need to update Herald exclusion rules everytime a new team sprint project is created - https://phabricator.wikimedia.org/T144041#9929379 (10Aklapper) [07:51:03] 14Gerrit (Gerrit 3.9), 07Upstream: "Press c to comment" is placed incorrectly when using Firefox 126 and 128 on macOS - https://phabricator.wikimedia.org/T367029#9929429 (10kostajh) 05Resolved→03Open This issue is occurring again. [07:52:12] (03CR) 10Kosta Harlan: Add notice at the end of console log for parallel test runs (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/1049919 (https://phabricator.wikimedia.org/T361190) (owner: 10Arthur taylor) [07:57:55] (03CR) 10Arthur taylor: Add notice at the end of console log for parallel test runs (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/1049919 (https://phabricator.wikimedia.org/T361190) (owner: 10Arthur taylor) [08:02:37] (03approved) 10jnuche: kubernetes: Make k8s deployment failures fatal [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/367 (owner: 10dancy) [08:14:59] 10Phabricator (Upstream), 07Upstream: After "Log In to Comment", go back to previous page instead of Phab home page - https://phabricator.wikimedia.org/T132335#9929481 (10Aklapper) Merged in upstream on 2024-06-27. [08:20:18] (03open) 10jnuche: branch-cut-test-patches: clean up MW checkouts [repos/releng/release] - 10https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/85 (https://phabricator.wikimedia.org/T368239) [08:20:39] (03update) 10jnuche: branch-cut-test-patches: clean up MW checkouts [repos/releng/release] - 10https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/85 (https://phabricator.wikimedia.org/T368239) [08:21:04] (03close) 10jnuche: scap clean: perform l10n cleanup only when l10n files can be found [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/365 (https://phabricator.wikimedia.org/T368239) [08:59:19] 10Gerrit, 10Release-Engineering-Team (Radar), 07Voice & Tone: Gerrit: default branch for new projects should be "main" - https://phabricator.wikimedia.org/T279612#9929583 (10ArthurTaylor) @thcipriani since the migration to GitLab seems to be postponed (indefinitely?) can we reopen this ticket? [09:05:27] (03CR) 10Kosta Harlan: Add notice at the end of console log for parallel test runs (031 comment) [integration/quibble] - 10https://gerrit.wikimedia.org/r/1049919 (https://phabricator.wikimedia.org/T361190) (owner: 10Arthur taylor) [09:07:10] (03PS5) 10Arthur taylor: Add notice at the end of console log for parallel test runs [integration/quibble] - 10https://gerrit.wikimedia.org/r/1049919 (https://phabricator.wikimedia.org/T361190) [09:07:32] 06Release-Engineering-Team, 10docker-pkg, 06serviceops: Attach opencontainers image metadata to docker images - https://phabricator.wikimedia.org/T345070#9929594 (10MoritzMuehlenhoff) [09:14:31] 06Project-Admins: Archive #Reading_Epics and its subprojects - https://phabricator.wikimedia.org/T368196#9929620 (10Aklapper) @MBinder_WMF: By any chance, do you know / can you confirm that this is obsolete nowadays? TIA! [09:19:09] 06Project-Admins, 06tech-decision-forum: Archive tech-decision-forum - https://phabricator.wikimedia.org/T368599 (10taavi) 03NEW [09:26:54] 06Project-Admins, 06tech-decision-forum: Archive tech-decision-forum - https://phabricator.wikimedia.org/T368599#9929654 (10Aklapper) https://www.mediawiki.org/wiki/Technical_decision_making states that "we are currently conducting a retrospective" (no idea if still true). {T333235} is resolved and no idea whe... [09:33:46] 06Project-Admins, 06tech-decision-forum: Archive tech-decision-forum - https://phabricator.wikimedia.org/T368599#9929669 (10Jdforrester-WMF) 05Open→03Declined Indeed, TDF is still active according to all documentation and practice. [09:37:03] 10Phabricator, 07Technical-Debt: Upstream rPHABf2fd14dc1edeb41aa2874336548cfaa7fa0e87a0 (maniphest.gettasktransactions API) - https://phabricator.wikimedia.org/T364728#9929676 (10Aklapper) [10:12:28] 06Release-Engineering-Team, 06collaboration-services, 06Traffic, 13Patch-For-Review: CI on gitlab for eBPF / networking heavy projects - https://phabricator.wikimedia.org/T353279#9929840 (10Vgutierrez) 05Open→03Resolved a:03Vgutierrez This has been solved by running the code inside a fully emulat... [10:16:39] 10Phabricator: Disable remaining commit-based Herald rules H49, H50, H51? - https://phabricator.wikimedia.org/T366578#9929882 (10He7d3r) Nope, so I went ahead and just disabled the rules. [10:25:43] (03PS1) 10KBach: Draft: Add AQS documentation to landing page [integration/docroot] - 10https://gerrit.wikimedia.org/r/1050291 (https://phabricator.wikimedia.org/T368484) [10:30:58] 10Phabricator: Disable remaining commit-based Herald rules H49, H50, H51? - https://phabricator.wikimedia.org/T366578#9929927 (10Aklapper) 05Open→03Resolved a:03He7d3r Ah, thanks! [10:31:06] (03update) 10aklapper: Disallow creating commit-based Herald rules [repos/phabricator/phabricator] (wmf/stable) - 10https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/60 (https://phabricator.wikimedia.org/T367651) [10:31:22] (03update) 10aklapper: Disallow creating commit-based Herald rules [repos/phabricator/phabricator] (wmf/stable) - 10https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/60 (https://phabricator.wikimedia.org/T367651) [10:34:21] 10Phabricator, 13Patch-For-Review: Disallow creating commit-based Herald rules - https://phabricator.wikimedia.org/T367651#9929938 (10Aklapper) 05Stalled→03Open [10:59:36] (03open) 10simone-this-dot: Add "sysop" to centralauth-rename permission [repos/ci-tools/patchdemo] - 10https://gitlab.wikimedia.org/repos/ci-tools/patchdemo/-/merge_requests/621 [11:21:07] 10MediaWiki-Releasing, 06MediaWiki-Engineering, 05MW-1.42-release: Write and send release announcement for 1.42.0 - https://phabricator.wikimedia.org/T359849#9930075 (10MSantos) 05In progress→03Resolved @Reedy The release announcement has been sent a few minutes ago, please re-open this task in case... [12:03:05] (03CR) 10Kosta Harlan: [C:03+2] Add notice at the end of console log for parallel test runs [integration/quibble] - 10https://gerrit.wikimedia.org/r/1049919 (https://phabricator.wikimedia.org/T361190) (owner: 10Arthur taylor) [12:03:36] 10Gerrit, 06Release-Engineering-Team: Install gerrit image-diff plugin - https://phabricator.wikimedia.org/T341291#9930165 (10hashar) a:03hashar The patches have been merged upstream thanks to @Paladox [12:06:12] (03PS1) 10Hashar: Add image-diff plugin [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050334 (https://phabricator.wikimedia.org/T341291) [12:19:58] (03Merged) 10jenkins-bot: Add notice at the end of console log for parallel test runs [integration/quibble] - 10https://gerrit.wikimedia.org/r/1049919 (https://phabricator.wikimedia.org/T361190) (owner: 10Arthur taylor) [12:22:06] (03CR) 10CI reject: [V:04-1] Add image-diff plugin [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050334 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [12:25:13] 10Phabricator, 07Performance Issue: Herald rules causing delays to task edit saves - getting worse - https://phabricator.wikimedia.org/T108586#9930251 (10Jdforrester-WMF) [12:30:00] (03PS2) 10Hashar: Add image-diff plugin [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050334 (https://phabricator.wikimedia.org/T341291) [12:30:49] (03update) 10matmarex: Add "sysop" to centralauth-rename permission [repos/ci-tools/patchdemo] - 10https://gitlab.wikimedia.org/repos/ci-tools/patchdemo/-/merge_requests/621 (owner: 10simone-this-dot) [12:33:23] (03merge) 10matmarex: Add "sysop" to centralauth-rename permission [repos/ci-tools/patchdemo] - 10https://gitlab.wikimedia.org/repos/ci-tools/patchdemo/-/merge_requests/621 (owner: 10simone-this-dot) [12:40:59] (03close) 10matmarex: Use ES6 classes for custom OOUI widgets [repos/ci-tools/patchdemo] - 10https://gitlab.wikimedia.org/repos/ci-tools/patchdemo/-/merge_requests/561 [12:41:00] (03update) 10matmarex: Use ES6 classes for custom OOUI widgets [repos/ci-tools/patchdemo] - 10https://gitlab.wikimedia.org/repos/ci-tools/patchdemo/-/merge_requests/561 [12:41:58] (03CR) 10CI reject: [V:04-1] Add image-diff plugin [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050334 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [12:47:46] 10Release-Engineering-Team (Seen), 10LPL Technical Support, 10MediaWiki-Configuration: Automate WMF wiki creation - https://phabricator.wikimedia.org/T158730#9930370 (10MaryMunyoki) [14:00:33] 10Beta-Cluster-Infrastructure: Error logs in beta have vanished - https://phabricator.wikimedia.org/T368620 (10Daimona) 03NEW [14:02:40] Uhm, hi folks, could someone help me with today's installment of "Beta Cluster is FUBAR" (task above)? [14:19:17] (03PS3) 10Hashar: Add image-diff plugin [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050334 (https://phabricator.wikimedia.org/T341291) [14:32:25] (03PS2) 10Paladox: Also archive .js artifacts files for the gerrit job [integration/config] - 10https://gerrit.wikimedia.org/r/1050384 [14:32:32] hashar: ^ [14:34:43] (03PS2) 10Paladox: Use bullseye image when running chmod for bazel [integration/config] - 10https://gerrit.wikimedia.org/r/1050385 [14:36:46] paladox: a I was wondering whether the job captured everything or not :D [14:37:29] Daimona: sorry the logging stack is way too complicated for me nowadays. I'd ask #wikimedia-observability , I think that is the SRE team owning logging [14:37:41] Daimona: or maybe it is a misconfiguration in operations/mediawiki-config [14:38:01] (03CR) 10Hashar: [C:03+2] Also archive .js artifacts files for the gerrit job [integration/config] - 10https://gerrit.wikimedia.org/r/1050384 (owner: 10Paladox) [14:38:50] hashar: there's also https://gerrit.wikimedia.org/r/1050385 [14:39:06] (03Merged) 10jenkins-bot: Also archive .js artifacts files for the gerrit job [integration/config] - 10https://gerrit.wikimedia.org/r/1050384 (owner: 10Paladox) [14:39:19] (03CR) 10Hashar: "recheck after making the job to capture `*.js` files ( https://gerrit.wikimedia.org/r/c/integration/config/+/1050384 )" [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050334 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [14:39:25] Merci hashar, I'll ask in -observability. [14:39:44] Daimona: I wish I could help, but I clearly don't know anything anymore about that stack :) [14:40:32] It's fine :) In the meantime I was also able to debug the issue I was investigating, so... [14:41:13] (03CR) 10Hashar: [C:03+2] Use bullseye image when running chmod for bazel [integration/config] - 10https://gerrit.wikimedia.org/r/1050385 (owner: 10Paladox) [14:41:25] paladox: done thanks! [14:41:31] thanks! [14:42:32] (03Merged) 10jenkins-bot: Use bullseye image when running chmod for bazel [integration/config] - 10https://gerrit.wikimedia.org/r/1050385 (owner: 10Paladox) [14:45:32] I should look at why the job does not reuse the Bazel cache between builds [14:45:37] but well that will be for another time [14:50:12] (03CR) 10Hashar: [C:03+2] Add image-diff plugin [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050334 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [14:51:43] (03PS2) 10Paladox: java8: fix typo in apt source file name [integration/config] - 10https://gerrit.wikimedia.org/r/1050393 [14:52:55] (03PS1) 10Hashar: Add image-diff plugin [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050395 (https://phabricator.wikimedia.org/T341291) [14:53:23] (03CR) 10CI reject: [V:04-1] Add image-diff plugin [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050395 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [14:54:23] (03PS2) 10Paladox: maven: use ci-bullseye [integration/config] - 10https://gerrit.wikimedia.org/r/1050396 [14:54:50] hashar: ^ [14:55:25] (03CR) 10CI reject: [V:04-1] maven: use ci-bullseye [integration/config] - 10https://gerrit.wikimedia.org/r/1050396 (owner: 10Paladox) [14:55:32] paladox: I can't work on those now [14:56:42] (03PS3) 10Paladox: maven: use ci-bullseye [integration/config] - 10https://gerrit.wikimedia.org/r/1050396 [15:00:33] (03PS2) 10Hashar: Add image-diff JavaScript plugin [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050395 (https://phabricator.wikimedia.org/T341291) [15:01:06] (03Merged) 10jenkins-bot: Add image-diff plugin [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050334 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [15:02:37] (03CR) 10Hashar: [C:03+2] java8: fix typo in apt source file name [integration/config] - 10https://gerrit.wikimedia.org/r/1050393 (owner: 10Paladox) [15:03:13] (03CR) 10Hashar: [C:03+2] Add image-diff JavaScript plugin [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050395 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [15:03:47] (03Merged) 10jenkins-bot: Add image-diff JavaScript plugin [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050395 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [15:03:50] (03Merged) 10jenkins-bot: java8: fix typo in apt source file name [integration/config] - 10https://gerrit.wikimedia.org/r/1050393 (owner: 10Paladox) [15:04:56] I have deployed the image-diff plugin [15:05:33] which I guess I should have tested properly :D [15:05:42] cause surely TypeError: window.resemble is undefined [15:08:05] 10Beta-Cluster-Infrastructure: Error logs in beta have vanished - https://phabricator.wikimedia.org/T368620#9930886 (10Daimona) 05Open→03Invalid Classic PEBKAC -- the host was changed as part of T345566. Docs updated. [15:08:49] (03PS1) 10Hashar: Revert "Add image-diff JavaScript plugin" [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050399 (https://phabricator.wikimedia.org/T341291) [15:09:00] (03CR) 10Hashar: [C:03+2] Revert "Add image-diff JavaScript plugin" [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050399 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [15:09:31] (03Merged) 10jenkins-bot: Revert "Add image-diff JavaScript plugin" [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050399 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [15:10:46] what did I do [15:10:55] https://integration.wikimedia.org/ci/job/gerrit/56/ has image-diff.js 14.57 KiB [15:12:38] (03approved) 10dancy: branch-cut-test-patches: clean up MW checkouts [repos/releng/release] - 10https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/85 (https://phabricator.wikimedia.org/T368239) (owner: 10jnuche) [15:13:34] hashar: I guess it's because the plugin doesn't contain resemble which I think it's due to plugins/package.json not containing that package. [15:14:01] yeah the README.md says to: ln --symbolic --force image-diff/package.json plugins/package.json [15:15:08] (03update) 10dancy: kubernetes: Make k8s deployment failures fatal [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/367 [15:15:12] (03merge) 10dancy: kubernetes: Make k8s deployment failures fatal [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/367 [15:15:21] 10MediaWiki-Releasing: Write and send release announcements for MediaWiki 1.39.8/1.40.4/1.41.2/1.42.1 - https://phabricator.wikimedia.org/T368626 (10Reedy) 03NEW [15:15:31] 10MediaWiki-Releasing: Write and send release announcements for MediaWiki 1.39.8/1.40.4/1.41.2/1.42.1 - https://phabricator.wikimedia.org/T368626#9930931 (10Reedy) [15:15:56] and there is an external_package.json file bah [15:19:25] 10MediaWiki-Releasing: Write and send release announcements for MediaWiki 1.39.8/1.40.4/1.41.2/1.42.1 - https://phabricator.wikimedia.org/T368626#9930970 (10Reedy) [15:19:44] 10MediaWiki-Releasing: Write and send release announcements for MediaWiki 1.39.8/1.40.4/1.41.2/1.42.1 - https://phabricator.wikimedia.org/T368626#9930974 (10Reedy) 05Open→03In progress p:05Triage→03Medium [15:27:13] 10MediaWiki-Releasing: Write and send release announcements for MediaWiki 1.39.8/1.40.4/1.41.2/1.42.1 - https://phabricator.wikimedia.org/T368626#9931074 (10Reedy) [15:28:53] 10MediaWiki-Releasing: Write and send release announcements for MediaWiki 1.39.8/1.40.4/1.41.2/1.42.1 - https://phabricator.wikimedia.org/T368626#9931081 (10Reedy) [15:33:10] (03open) 10dancy: blubber.yaml: Use latest buildkit stuff [repos/releng/kokkuri] - 10https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/95 [15:33:12] (03update) 10dancy: blubber.yaml: Use latest buildkit stuff [repos/releng/kokkuri] - 10https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/95 [15:34:45] 10MediaWiki-Releasing: Write and send release announcements for MediaWiki 1.39.8/1.40.4/1.41.2/1.42.1 - https://phabricator.wikimedia.org/T368626#9931107 (10Reedy) 05In progress→03Resolved a:03Reedy [15:43:36] 10Continuous-Integration-Config, 10MediaWiki-Vendor, 07Composer, 05MW-1.39-release, and 3 others: Upgrade composer from 2.6.4 to 2.7.x - https://phabricator.wikimedia.org/T360973#9931147 (10Reedy) [15:43:39] 10Phabricator, 07Technical-Debt: Upstream rPHABf2fd14dc1edeb41aa2874336548cfaa7fa0e87a0 (maniphest.gettasktransactions API) - https://phabricator.wikimedia.org/T364728#9931148 (10Aklapper) [15:44:57] (03update) 10dancy: blubber.yaml: Use latest buildkit stuff [repos/releng/kokkuri] - 10https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/95 [15:45:00] (03update) 10dancy: blubber.yaml: Use latest buildkit stuff [repos/releng/kokkuri] - 10https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/95 [15:49:30] error Package "polymer-bridges" refers to a non-existing file '"/home/hashar/projects/operations/software/polymer-bridges"'. [15:49:33] stupid relative paths [15:49:35] reeekk [15:51:15] (03merge) 10jnuche: branch-cut-test-patches: clean up MW checkouts [repos/releng/release] - 10https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/85 (https://phabricator.wikimedia.org/T368239) [16:25:54] 10MediaWiki-Releasing, 05MW-1.42-notes, 05MW-1.42-release, 05Release: Release MediaWiki 1.42.0 - https://phabricator.wikimedia.org/T359833#9931316 (10Jdforrester-WMF) 05In progress→03Resolved [16:25:59] 10MediaWiki-Releasing, 05MW-1.42-release: Mark REL1_42 in ExtensionDistributor as a stable release - https://phabricator.wikimedia.org/T359850#9931313 (10Jdforrester-WMF) 05Open→03Resolved a:03Urbanecm_WMF [16:36:52] (03PS1) 10Hashar: Handle image-diff external dependencies [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050420 (https://phabricator.wikimedia.org/T341291) [16:42:55] (03CR) 10CI reject: [V:04-1] Handle image-diff external dependencies [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050420 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [16:44:19] (03PS2) 10Hashar: Handle image-diff external dependencies [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050420 (https://phabricator.wikimedia.org/T341291) [16:58:10] (03CR) 10Hashar: [C:03+2] Handle image-diff external dependencies [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050420 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [16:58:10] (03PS1) 10Hashar: Add image-diff JavaScript plugin (take 2) [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050428 (https://phabricator.wikimedia.org/T341291) [16:59:53] (03CR) 10Hashar: [C:03+2] Add image-diff JavaScript plugin (take 2) [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050428 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [17:00:42] pfff [17:00:46] * hashar whistles [17:09:26] (03CR) 10CI reject: [V:04-1] Handle image-diff external dependencies [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050420 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [17:09:54] (03Merged) 10jenkins-bot: Add image-diff JavaScript plugin (take 2) [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050428 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [17:14:30] (03CR) 10Hashar: [C:03+2] Handle image-diff external dependencies [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050420 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [17:15:12] well clearly there is something seriously broken [17:15:18] when it works for me but not in prod :/ [17:18:52] (03PS1) 10Hashar: Revert "Add image-diff JavaScript plugin (take 2)" [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050433 [17:18:58] (03CR) 10Hashar: [C:03+2] Revert "Add image-diff JavaScript plugin (take 2)" [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050433 (owner: 10Hashar) [17:25:58] (03Merged) 10jenkins-bot: Handle image-diff external dependencies [software/gerrit] (wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050420 (https://phabricator.wikimedia.org/T341291) (owner: 10Hashar) [17:25:59] (03Merged) 10jenkins-bot: Revert "Add image-diff JavaScript plugin (take 2)" [software/gerrit] (deploy/wmf/stable-3.10) - 10https://gerrit.wikimedia.org/r/1050433 (owner: 10Hashar) [18:02:12] 10Phabricator, 06collaboration-services, 10LDAP-Access-Requests, 06SRE: Offboard Lea WMDE (Lea Voget) from the WMF systems - https://phabricator.wikimedia.org/T368139#9931829 (10Dzahn) a:05Dzahn→03SLyngshede-WMF Hi Simon, could you take a look? [18:09:26] Ah [18:09:28] I found the issue [18:09:36] https://gerrit.wikimedia.org/r/r/changes/operations%2Fmediawiki-config~902211/revisions/1/files/static%2Fimages%2Fproject-logos%2Fdkwikimedia.png/content [18:09:54] a double `/r` is used in the URL when trying to fetch the base and revision images [18:10:04] which yields some HTML content [18:10:33] so that when looking at diff for a file, there is nothing shown: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/902211/1/static/images/project-logos/dkwikimedia.png [18:32:46] (03open) 10dancy: Makefile: Add BUILD_QUIET variable [repos/releng/kokkuri] - 10https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/96 [18:32:48] (03update) 10dancy: Makefile: Add BUILD_QUIET variable [repos/releng/kokkuri] - 10https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/96 [18:35:00] (03update) 10dancy: blubber.yaml: Use latest buildkit stuff [repos/releng/kokkuri] - 10https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/95 [18:35:03] (03update) 10dancy: blubber.yaml: Use latest buildkit stuff [repos/releng/kokkuri] - 10https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/95 [18:38:31] (03update) 10dancy: blubber.yaml: Use latest buildkit stuff [repos/releng/kokkuri] - 10https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/95 [18:38:39] (03update) 10dancy: Makefile: Add BUILD_QUIET variable [repos/releng/kokkuri] - 10https://gitlab.wikimedia.org/repos/releng/kokkuri/-/merge_requests/96 [18:43:39] 10Continuous-Integration-Config, 10CiteThisPage, 07affects-translatewiki.net, 07I18n, 10LPL Technical Support (LPL Technical Support (Current)): Automatically allow tag in message translations - https://phabricator.wikimedia.org/T360519#9932027 (10MaryMunyoki) [18:47:41] 10Continuous-Integration-Config, 07affects-translatewiki.net, 07I18n, 10LPL Technical Support (LPL Technical Support (Current)): Automatically allow id HTML attribute in message translations - https://phabricator.wikimedia.org/T357086#9932055 (10MaryMunyoki) [18:49:26] 10Continuous-Integration-Config, 07affects-translatewiki.net, 07I18n, 10LPL Technical Support (LPL Technical Support (Current)): Automatically allow tag in message translations - https://phabricator.wikimedia.org/T357670#9932057 (10MaryMunyoki) [18:49:55] 10Continuous-Integration-Config, 07affects-translatewiki.net, 07I18n, 10LPL Technical Support (LPL Technical Support (Current)): Automatically allow
in message translations - https://phabricator.wikimedia.org/T356548#9932063 (10MaryMunyoki) [18:53:15] 10Phabricator (Upstream), 06Release-Engineering-Team, 07Upstream: Hovercards: (RuntimeException) Undefined index: objectPHID (due to RequestURI all lowercase) - https://phabricator.wikimedia.org/T346876#9932124 (10Aklapper) [19:18:38] hashar: is that a bug with the plugin or Gerrit [19:42:12] (03open) 10dancy: sync: Prompt for log message if not supplied on command line [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/368 [19:42:15] (03update) 10dancy: sync: Prompt for log message if not supplied on command line [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/368 [19:42:33] (03open) 10dancy: Change "Started scap:" to "Started scap sync-world:" [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/369 [19:42:36] (03update) 10dancy: Change "Started scap:" to "Started scap sync-world:" [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/369 [19:44:39] (03update) 10dancy: sync: Prompt for log message if not supplied on command line [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/368 [19:45:04] (03update) 10dancy: Change "Started scap:" to "Started scap sync-world:" [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/369 [20:00:12] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥), 13Patch-For-Review: Automate weekly request for Phabricator data for potential Tech News entries - https://phabricator.wikimedia.org/T368460#9932455 (10Dzahn) @Quiddity Please check your inbox. You should have just received one of these new gene... [20:09:49] (03open) 10dancy: interaction: Add input_line() [repos/releng/scap] (master-I84cead756b8b510442236ff4a9bb2e9e8bf7dfab) - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/370 [20:09:49] (03update) 10dancy: Change "Started scap:" to "Started scap sync-world:" [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/369 [20:09:49] (03open) 10dancy: backport: Use interaction.input_line [repos/releng/scap] (master-I49e3f3f3ef3633c7575397c317ec757b38e64c4f) - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/371 [20:09:50] (03update) 10dancy: interaction: Add input_line() [repos/releng/scap] (master-I84cead756b8b510442236ff4a9bb2e9e8bf7dfab) - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/370 [20:09:50] (03update) 10dancy: backport: Use interaction.input_line [repos/releng/scap] (master-I49e3f3f3ef3633c7575397c317ec757b38e64c4f) - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/371 [20:09:52] (03update) 10dancy: sync: Prompt for log message if not supplied on command line [repos/releng/scap] (master-I17999acd3865ff8cfc3f0a324595709fcda256aa) - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/368 [20:09:58] (03update) 10dancy: Change "Started scap:" to "Started scap sync-world:" [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/369 [20:10:00] (03update) 10dancy: sync: Prompt for log message if not supplied on command line [repos/releng/scap] (master-I17999acd3865ff8cfc3f0a324595709fcda256aa) - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/368 [20:10:04] (03update) 10dancy: interaction: Add input_line() [repos/releng/scap] (master-I84cead756b8b510442236ff4a9bb2e9e8bf7dfab) - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/370 [20:10:08] (03update) 10dancy: backport: Use interaction.input_line [repos/releng/scap] (master-I49e3f3f3ef3633c7575397c317ec757b38e64c4f) - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/371 [20:11:14] (03update) 10dancy: backport: Use interaction.input_line [repos/releng/scap] (master-I49e3f3f3ef3633c7575397c317ec757b38e64c4f) - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/371 [20:36:23] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥): Automate weekly request for Phabricator data for potential Tech News entries - https://phabricator.wikimedia.org/T368460#9932553 (10Dzahn) [20:46:27] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥): Automate weekly request for Phabricator data for potential Tech News entries - https://phabricator.wikimedia.org/T368460#9932585 (10Quiddity) Looks great! Thank you very much. Resolved from my end. [20:52:13] paladox: that is a bug in Gerrit. The example diff would be https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/902211/1/static/images/project-logos/dkwikimedia.png [20:52:27] 10Gerrit, 06Release-Engineering-Team: Install gerrit image-diff plugin - https://phabricator.wikimedia.org/T341291#9932608 (10hashar) when looking at the test file https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/902211/1/static/images/project-logos/dkwikimedia.png , Gerrit retrieves the image us... [20:52:32] hashar: do you know which element? [20:52:37] that does requests for each images but with TWO `/r` [20:52:48] and I can't find which element triggers the requests [20:52:50] :/ [20:53:07] I fixed ci for the plugin with https://gerrit-review.googlesource.com/c/plugins/image-diff/+/431658?tab=checks [20:53:29] I also found out that you have added ResembleJS in Gerrit core itself some years ago [20:53:37] and eventually I reached https://gerrit-review.googlesource.com/c/gerrit/+/310486 [20:56:36] so essentially I am confused [20:57:23] polygerrit-ui/app/embed/diff/gr-diff-builder/gr-diff-builder-image.ts [21:02:52] think I may have found it [21:02:59] https://github.com/GerritCodeReview/gerrit/blob/01cca05c4fcd197d0f755db7034602a059e17cd5/polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts#L2901 [21:03:05] https://github.com/GerritCodeReview/gerrit/blob/01cca05c4fcd197d0f755db7034602a059e17cd5/polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts#L2887 [21:03:45] (03merge) 10thcipriani: Change "Started scap:" to "Started scap sync-world:" [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/369 (owner: 10dancy) [21:03:47] (03update) 10dancy: interaction: Add input_line() [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/370 [21:03:50] think it's https://github.com/GerritCodeReview/gerrit/blob/01cca05c4fcd197d0f755db7034602a059e17cd5/polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts#L2875 has [21:03:51] hashar: [21:05:21] OH MY GOD [21:05:34] https://github.com/GerritCodeReview/gerrit/blob/01cca05c4fcd197d0f755db7034602a059e17cd5/polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts#L2873-L2875 [21:05:35] yeah [21:05:41] .fetch({url: getBaseUrl() + url}) [21:06:30] and here is the fix I did previously https://gerrit-review.googlesource.com/c/gerrit/+/404937/3/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts [21:09:46] (03merge) 10thcipriani: interaction: Add input_line() [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/370 (owner: 10dancy) [21:09:48] (03update) 10dancy: backport: Use interaction.input_line [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/371 [21:12:30] hashar: fixed with https://gerrit-review.googlesource.com/c/gerrit/+/431757 [21:13:40] paladox: I am not sure [21:13:50] hashar: I can guarantee it [21:13:52] I had a look [21:13:56] yeah yeah I imagine [21:14:02] inside fetch() it adds the base url [21:14:16] but I don't get why since getB64FileContents() forges an URL using _changeBaseURL() [21:14:17] adds it here https://github.com/GerritCodeReview/gerrit/blob/01cca05c4fcd197d0f755db7034602a059e17cd5/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts#L413 [21:14:23] which would not have the `/r` [21:14:26] ah [21:14:36] THAT IST THE restApiHelper doing magic! [21:14:45] yeh [21:14:54] it's similar to how I fixed the caching [21:18:10] paladox: and that would have been broken for quite a while cause that code is all the way back to at least stable-3.5 [21:18:30] yeh probably [21:18:43] (03update) 10dancy: sync: Prompt for log message if not supplied on command line [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/368 [21:18:47] (03update) 10dancy: sync: Prompt for log message if not supplied on command line [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/368 [21:18:51] I'll only backport to 3.10/3.9/3.8 once merged as the other branches are EOL [21:18:53] (03update) 10dancy: backport: Use interaction.input_line [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/371 [21:18:58] (03update) 10dancy: backport: Use interaction.input_line [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/371 [21:19:18] paladox: and you should run prettier :D [21:19:41] well npm run eslintfix :D [21:19:54] yeah [21:20:15] and I guess that can be made against stable-3.8 [21:20:34] I will try tomorrow [21:20:38] I do changes on master then I do backports (cherry picks) [21:20:43] ahh [21:20:52] did that change? [21:21:12] I thought changes were supposed to be made to earliest affected stable branch and then merged up the chain of stable branches [21:21:16] ? [21:21:41] well I guess it depends on the person but the frontend like it done on master first [21:30:04] 10Phabricator, 10Release-Engineering-Team (Priority Backlog 📥): Automate weekly request for Phabricator data for potential Tech News entries - https://phabricator.wikimedia.org/T368460#9932688 (10Dzahn) 05Open→03Resolved [21:30:57] paladox: +1 thank you for the explanation [21:32:52] so my guess is that the image view has been broken for ever [21:33:22] and since 3.5 has learned to use resemblejs, we might not need the image-diff plugin [21:33:24] we weill see [21:34:42] 06Project-Admins: Create project tag for - https://phabricator.wikimedia.org/T368676 (10debt) 03NEW [21:34:44] there's a new image and old image mode in gerrit when I was looking at where it was adding a duplicate base url [21:34:50] but I don't know what the new one does [21:35:03] 06Project-Admins: Create project tag for 2024's Wikimania Hackathon - https://phabricator.wikimedia.org/T368676#9932709 (10debt) [21:39:29] ah yeh hashar https://github.com/GerritCodeReview/gerrit/commit/308f964711e85e1b05e6d8c45e38d1a96f0ef845 [21:39:56] currently behind a experimental flag. [21:40:04] dunno why it's still behind it though [21:43:58] looks like some new diff was being worked on by Hermann Loose from Google [21:46:46] I guess that was a side project, maybe it was a port of a feature that was in Critique [21:46:51] who knows ;) [21:58:47] paladox: what is the feature flag for the new UI? [21:58:55] the new diff I mean [21:59:31] hashar: https://github.com/GerritCodeReview/gerrit/blob/01cca05c4fcd197d0f755db7034602a059e17cd5/polygerrit-ui/app/services/flags/flags.ts#L18 [21:59:40] ahh [22:00:10] and that needs to be enabled on the server side isn't it? [22:01:01] Hermann Loose committed Feb 16, 2021 (3.4.0-rc.0) [22:01:02] so yeah [22:02:11] 06Project-Admins: Create project tag for 2024's Wikimania Hackathon - https://phabricator.wikimedia.org/T368676#9932786 (10Peachey88) 05Open→03Resolved a:03Peachey88 Created #Wikimania-Hackathon-2024 :) [22:02:44] hashar: yeh [22:05:18] 10Gerrit, 06Release-Engineering-Team: Install gerrit image-diff plugin - https://phabricator.wikimedia.org/T341291#9932817 (10hashar) Apparently the image diff had been broken for quite a while and @Paladox has a fix for the `/r/r` in URL with: https://gerrit-review.googlesource.com/c/gerrit/+/431757 The Rese... [22:05:35] so hmm [22:05:43] get your fix in stable-3.10 [22:05:46] turn on UiFeature__new_image_diff_ui [22:05:50] success [22:05:56] thank you paladox ! [22:06:01] I am off, it is past midnight [22:06:05] yw :) [22:18:51] (03open) 10dancy: Allow empty requirements list to enable Python builder [repos/releng/blubber] - 10https://gitlab.wikimedia.org/repos/releng/blubber/-/merge_requests/101 [22:18:53] (03update) 10dancy: Allow empty requirements list to enable Python builder [repos/releng/blubber] - 10https://gitlab.wikimedia.org/repos/releng/blubber/-/merge_requests/101 [22:24:55] (03update) 10dancy: Allow empty requirements list to enable Python builder [repos/releng/blubber] - 10https://gitlab.wikimedia.org/repos/releng/blubber/-/merge_requests/101 [23:09:37] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.43.0-wmf.12 deployment blockers - https://phabricator.wikimedia.org/T366957#9933023 (10Jdlrobson) Error rate for T368685 is high so I'm marking it as a deployment blocker. [23:09:37] 10Release-Engineering-Team (Priority Backlog 📥), 05Release, 05Train Deployments: 1.43.0-wmf.12 deployment blockers - https://phabricator.wikimedia.org/T366957#9933025 (10Jdlrobson)