[00:03:31] (03update) 10lwatson: Draft: web: improve JobViewerPage UI [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/608 (https://phabricator.wikimedia.org/T379413) [08:45:58] 10Release-Engineering-Team (Priority Backlog πŸ“₯): Delete wmf branches from Gerrit repositories - https://phabricator.wikimedia.org/T303828#10456908 (10hashar) `lines=20 Systemd timer ran the following command: /usr/bin/scap clean --delete-gerrit-branch auto Its return value was 0 and emitted the following o... [09:27:26] (03CR) 10Hashar: [C:03+2] Zuul: [mediawiki/extensions/EventLogging] Add Phan dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1110865 (owner: 10Fomafix) [09:28:42] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/EventLogging] Add Phan dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1110865 (owner: 10Fomafix) [09:30:00] (03CR) 10Hashar: [C:03+2] "deployed and I have done a `recheck` on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/1110859" [integration/config] - 10https://gerrit.wikimedia.org/r/1110865 (owner: 10Fomafix) [09:32:47] (03CR) 10Hashar: "The tox jobs are somewhat broken because upgrading tox from v3 to v4 is a breaking change. I have looked into it some months ago but did " [integration/config] - 10https://gerrit.wikimedia.org/r/1110851 (owner: 10Jforrester) [10:27:25] (03PS1) 10Fomafix: Zuul: [mediawiki/extensions/EntitySchema] Add Phan dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1111186 [11:51:48] hashar: do you have a minute by chance to unpuzzle some gerrit permission? I'm unable to submit https://gerrit.wikimedia.org/r/c/operations/debs/calico/+/1109671 ("You don't have permission to submit change") although I'm in cn=ops [12:18:01] 10Scap, 06serviceops-radar, 06SRE: Introduce state to Scap - https://phabricator.wikimedia.org/T209881#10457507 (10jijiki) 05Openβ†’03Invalid With #mw-on-k8s, this task is invalid. [12:19:53] 10Scap, 06serviceops: Scap2 to use etcd for target servers - https://phabricator.wikimedia.org/T218328#10457510 (10jijiki) 05Openβ†’03Invalid With #mw-on-k8s, this is invalid now. [12:20:36] 10Release-Engineering-Team (Radar), 10Scap, 06serviceops: Allow scap sync to deploy gradually - https://phabricator.wikimedia.org/T212147#10457518 (10jijiki) 05Openβ†’03Invalid With #mw-on-k8s, this task is invalid [12:23:04] 10MediaWiki-Releasing, 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10Scap, 06serviceops: Define a mediawiki "version" - https://phabricator.wikimedia.org/T218412#10457528 (10jijiki) [12:23:14] 10MediaWiki-Releasing, 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10Scap, 06serviceops: Define a mediawiki "version" - https://phabricator.wikimedia.org/T218412#10457531 (10jijiki) [12:23:19] 10Scap, 06serviceops-radar, 06SRE: Introduce state to Scap - https://phabricator.wikimedia.org/T209881#10457532 (10jijiki) [12:24:22] 10MediaWiki-Releasing, 10Release-Engineering-Team (Yak Shaving πŸƒπŸͺ’), 10Scap, 06serviceops: Define a mediawiki "version" - https://phabricator.wikimedia.org/T218412#10457533 (10jijiki) 05Openβ†’03Stalled I am not sure where this task should go and if it is still relevant. For the time being, I am marking i... [12:26:40] 10Scap, 06serviceops, 06SRE, 05Goal: SRE FY2019 Q3:TEC6: First steps towards Canary Deployments - https://phabricator.wikimedia.org/T213156#10457542 (10jijiki) 05Openβ†’03Resolved a:03jijiki Main goal was T282148. [12:45:46] 10Phabricator (Upstream), 10Release-Engineering-Team (Priority Backlog πŸ“₯), 07Upstream: Uploaded files via the drag-and-drop are defaulting to private-access - https://phabricator.wikimedia.org/T310833#10457609 (10awight) Seems to have regressed for me: I took several screenshots for unrelated task T378570 an... [13:20:03] Project beta-update-databases-eqiad build #81831: 04FAILURE in 2.4 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/81831/ [14:21:57] 10Release-Engineering-Team (Priority Backlog πŸ“₯), 13Patch-For-Review: Delete wmf branches from Gerrit repositories - https://phabricator.wikimedia.org/T303828#10457972 (10hashar) For: ` remote: remote: Processing changes: refs: 1 remote: Processing changes: refs: 1, done ` That is emitted by Gerrit and... [14:23:49] (03PS3) 10Hashar: Zuul: [mediawiki/extensions/Cite] Add cldr dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1082573 (https://phabricator.wikimedia.org/T377936) (owner: 10Awight) [14:25:23] (03CR) 10Hashar: [C:03+2] "I am assuming that is for the WIP change https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1082494" [integration/config] - 10https://gerrit.wikimedia.org/r/1082573 (https://phabricator.wikimedia.org/T377936) (owner: 10Awight) [14:26:43] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/Cite] Add cldr dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1082573 (https://phabricator.wikimedia.org/T377936) (owner: 10Awight) [14:31:16] Yippee, build fixed! [14:31:16] Project beta-update-databases-eqiad build #81832: 09FIXED in 11 min: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/81832/ [14:31:47] (03update) 10addshore: Fix OTEL configuration [repos/releng/cli] - 10https://gitlab.wikimedia.org/repos/releng/cli/-/merge_requests/596 (owner: 10cdanis) [14:42:19] (03CR) 10Hashar: [C:03+2] "Deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/1082573 (https://phabricator.wikimedia.org/T377936) (owner: 10Awight) [14:48:02] (03CR) 10Awight: "That was the oneβ€”thanks!" [integration/config] - 10https://gerrit.wikimedia.org/r/1082573 (https://phabricator.wikimedia.org/T377936) (owner: 10Awight) [14:50:23] 10Release-Engineering-Team (Doing 😎), 13Patch-For-Review: Delete wmf branches from Gerrit repositories - https://phabricator.wikimedia.org/T303828#10458119 (10thcipriani) [15:28:34] (03open) 10pwangai: Update documentation to reflect the new SonarQube path [repos/ci-tools/sonarqube] - 10https://gitlab.wikimedia.org/repos/ci-tools/sonarqube/-/merge_requests/11 (https://phabricator.wikimedia.org/T383685) [15:29:04] (03merge) 10pwangai: Update documentation to reflect the new SonarQube path [repos/ci-tools/sonarqube] - 10https://gitlab.wikimedia.org/repos/ci-tools/sonarqube/-/merge_requests/11 (https://phabricator.wikimedia.org/T383685) [15:53:34] (03update) 10dancy: spiderpig: CAS auth integration [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/625 [15:55:55] 10Scap, 10SRE Observability (FY2024/2025-Q3): Migrate scap metrics to Prometheus - https://phabricator.wikimedia.org/T377273#10458527 (10lmata) [16:01:46] (03open) 10marostegui: deployments-calendar.yaml: Add Federico Ceratto [repos/releng/release] - 10https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/145 [16:02:05] (03merge) 10dancy: deployments-calendar.yaml: Add Federico Ceratto [repos/releng/release] - 10https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/145 (owner: 10marostegui) [16:09:09] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for [YOUR DEVELOPER ACCOUNT USERNAME HERE] - https://phabricator.wikimedia.org/T383698 (10Priyanshu_Chahal) 03NEW [16:09:54] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for Priyanshu Chahal - https://phabricator.wikimedia.org/T383698#10458715 (10Priyanshu_Chahal) [16:17:09] 10GitLab (Account Approval), 06Release-Engineering-Team: Requesting GitLab account activation for Priyanshu Chahal - https://phabricator.wikimedia.org/T383698#10458752 (10Priyanshu_Chahal) [16:20:09] (03open) 10dancy: spiderpig/api.py: Set SPIDERPIG_DIR [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/627 [16:20:11] (03update) 10dancy: spiderpig/api.py: Set SPIDERPIG_DIR [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/627 [16:22:37] (03merge) 10dancy: spiderpig/api.py: Set SPIDERPIG_DIR [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/627 [16:26:07] 10GitLab-Application-Security-Pipeline, 06Security-Team, 07SecTeam-Processed, 07Security: Update the image used by the python-bandit appsec include - https://phabricator.wikimedia.org/T360721#10458795 (10sbassett) 05Openβ†’03Declined Given the work in T371814, this task seems unnecessary at this point. [16:27:18] 10GitLab-Application-Security-Pipeline, 06Security-Team, 07SecTeam-Processed, 07Security: Update the image used by the python-bandit appsec include - https://phabricator.wikimedia.org/T360721#10458805 (10sbassett) [16:28:15] 10GitLab-Application-Security-Pipeline, 06Security-Team: Craft more mediawiki-specific and php semgrep rule sets - https://phabricator.wikimedia.org/T342468#10458829 (10sbassett) [16:28:18] 10GitLab-Application-Security-Pipeline, 06Security-Team, 07Epic, 07SecTeam-Processed, 07Security: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177#10458831 (10sbassett) [16:29:13] 10GitLab-Application-Security-Pipeline, 06Security-Team, 07Epic, 07SecTeam-Processed, 07Security: [EPIC] Application Security Pipeline Components for Gitlab - Phase 2 Work - https://phabricator.wikimedia.org/T342177#10458834 (10sbassett) 05Openβ†’03Resolved Nearly all of the work for this was compl... [16:37:39] FIRING: [2x] DatasourceNoData: - https://alerts.wikimedia.org/?q=alertname%3DDatasourceNoData [16:38:32] FIRING: DatasourceError: Queue (Jenkins jobs + Zuul functions) - https://grafana.wikimedia.org/alerting/grafana/b9a8470a-ebab-46f7-9be2-22b5e74a528b/view - https://wikitech.wikimedia.org/wiki/Monitoring/DatasourceError - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [16:42:54] RESOLVED: [2x] DatasourceNoData: - https://alerts.wikimedia.org/?q=alertname%3DDatasourceNoData [16:43:32] RESOLVED: DatasourceError: Queue (Jenkins jobs + Zuul functions) - https://grafana.wikimedia.org/alerting/grafana/b9a8470a-ebab-46f7-9be2-22b5e74a528b/view - https://wikitech.wikimedia.org/wiki/Monitoring/DatasourceError - https://alerts.wikimedia.org/?q=alertname%3DDatasourceError [16:50:40] !log integration project: create integration-agent-docker-1058 for T383254 [16:50:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:50:42] T383254: Jenkins: In the integration project in WMCS, test out larger workers for CI - https://phabricator.wikimedia.org/T383254 [17:56:32] 10Continuous-Integration-Config, 10Release-Engineering-Team (Doing 😎): Jenkins: In the integration project in WMCS, test out larger workers for CI - https://phabricator.wikimedia.org/T383254#10459383 (10brennen) Wound up burning `-1058` during setup process. Started over with `-1059` which is current running.... [17:56:47] ah yeah https://phabricator.wikimedia.org/T138401#9030517 [17:57:00] cause you upgrade to node20 [17:57:03] with a new os [17:57:06] with thus a new ruby [17:57:13] Oh, rigth. [17:57:17] and jsduck or its json is not compatible [17:57:19] I was planning to delete the Ruby too. [17:57:30] which I guess means the REL branches are broken [17:57:43] * James_F sighs. [17:58:07] jsduck is only in REL1_39; 1.42+ all have jsdoc. [17:58:57] then for fundraising/REL1_39 we can amend the package.json and remove the `npm run doc` [17:58:58] solved [17:58:59] Let's just drop the jsduck stuff from REL1_39? [17:59:02] Yes. [17:59:05] cause the doc is not published for that branch [18:00:21] (03update) 10lwatson: web: improve JobViewerPage UI [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/608 (https://phabricator.wikimedia.org/T379413) [18:03:14] hashar: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1111291 [18:03:22] 10GitLab-Application-Security-Pipeline, 06Security-Team: Craft more mediawiki-specific and php semgrep rule sets - https://phabricator.wikimedia.org/T342468#10459430 (10sbassett) a:05sbassettβ†’03None [18:05:08] I slightly amended to refer to the jsduck > jsdoc task [18:05:56] damilare: you will need to cherry pick https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1111291 then rebase your change on top of it and that will fix it [18:06:03] once it has merged I guess [18:06:04] well [18:06:07] I can cherry pick [18:06:18] awesome, thanks a lot! [18:07:18] damilare: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1111293 is the cherry pick [18:07:25] and I have rebased your patch on to pof it [18:07:42] nice! even better [18:07:48] James and I can not CR+2 that change cause we don't have access to fundraising/REL1_39 branch [18:07:59] that is only for the cool kids at fundraising tech :b [18:08:15] yh that's alright, we usually self +2 at that stage [18:09:34] bah CI failed already: [18:09:34] 00:00:44.368 # Lock file errors [18:09:35] 00:00:44.368 - Required package "wikimedia/smash-pig" is in the lock file as "v0.8.26" but that does not satisfy your constraint "0.8.26.1". [18:09:37] https://integration.wikimedia.org/ci/job/mwgate-composer-php74/1514/console [18:09:38] :( [18:14:50] damilare: for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1111250/ the commit message has the wrong version :) [18:15:08] hmm it hasn't failed yet on my own view. The lock file in that patch bumps smashpig to 0.26.1 [18:15:40] it says v0.8.26.1 [18:15:45] (an extra 8) :b [18:15:50] so anyway [18:15:51] ahh [18:15:53] right [18:16:25] we can try rolling back CI to node 18 to have the job pass through [18:16:54] or revert fundraising/REL1_39 vendor patch [18:17:02] have the jsduck removal pass through [18:17:12] looks like it passed the one it was failing at earlier [18:17:19] mwgate-node20 [18:17:30] yeah [18:17:40] on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1111250/ [18:17:44] that fixes the jsduck thing [18:17:56] but that change is now broken because mediawiki/vendor received an update of smashpig [18:18:33] oh i know [18:19:30] sorry I'm confused, the change has been verified now: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1111250 [18:19:57] yeah that is for the REL1_39 branch [18:20:01] err [18:20:01] hmm [18:21:10] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Doing 😎), 13Patch-For-Review: Zuul/Jenkins: Investigate caching of build results for MediaWiki testsuite jobs - https://phabricator.wikimedia.org/T383243#10459489 (10dduvall) @hashar pointed out that the `XDG_CACHE_HOME` directory is only s... [18:23:44] ohh I see the failing patch, would merging this fundraising branch patch help? [18:28:23] yh merging the update change to the build patch should fix it. Thanks hashar, I don't think you need to change anything else. [18:40:37] arh [18:40:40] the node18 jobs are gone [18:48:25] (03PS1) 10Hashar: Switch fundraising branch back to Node 18 [integration/config] - 10https://gerrit.wikimedia.org/r/1111301 [18:48:33] ^^^ [18:48:47] (03CR) 10Hashar: [C:03+2] Switch fundraising branch back to Node 18 [integration/config] - 10https://gerrit.wikimedia.org/r/1111301 (owner: 10Hashar) [18:48:55] INFO:jenkins_jobs.builder:Creating jenkins job mwgate-node18 [18:49:57] (03Merged) 10jenkins-bot: Switch fundraising branch back to Node 18 [integration/config] - 10https://gerrit.wikimedia.org/r/1111301 (owner: 10Hashar) [18:53:09] damilare: thanks for the rebase of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1111250 :) [18:53:56] (03PS1) 10Hashar: Revert "Switch fundraising branch back to Node 18" [integration/config] - 10https://gerrit.wikimedia.org/r/1111304 [18:54:26] no worries, thanks for all the work also [18:54:42] (03PS2) 10Hashar: Revert "Switch fundraising branch back to Node 18" [integration/config] - 10https://gerrit.wikimedia.org/r/1111304 [18:55:09] hmm [18:55:13] I mixed up the patches again somehow [18:55:33] noo [18:55:38] damilare: you have merged both patches in :/ [18:56:20] yea I did [18:56:29] that messes up what I did [18:56:40] which part [18:57:46] I had to merge the composer update with the build patch because of the codependency [18:58:09] well I rolled back CI to use nodejs 18 [18:58:22] which would let the patch updating smashpig to be updated in core [18:59:57] hmm, merging gets both updated. do you want me to take it back to the previous state? [19:00:20] yeah back to patchset 7 [19:00:20] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1111250/7 [19:03:48] damilare: oh I got them. Let me send the updates [19:04:08] ok [19:04:30] so your patch to update smashpig at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1111250 [19:04:33] is the first to come [19:04:45] it should now pass because I have moved CI to use Node 18 / some old OS [19:04:49] and thus jsduck will work [19:04:59] that can then +2ed [19:05:21] then https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1111293/ disables jsduck in fundraising/REL1_39 [19:05:24] and it should pass [19:05:45] and I guess in between I can set CI back to Node20 but it probably does not matter [19:05:46] ok that makes sense [19:05:52] do we still get node20? [19:06:04] after everything is merged [19:06:10] yup [19:06:19] cool, thanks! [19:06:52] sorry for the mess :b [19:08:15] ahh no worries, git is fun [19:08:18] 😩 [19:09:29] (03CR) 10Jforrester: "This won't work? The quibble jobs will still be Node 20." [integration/config] - 10https://gerrit.wikimedia.org/r/1111304 (owner: 10Hashar) [19:11:13] (03CR) 10Hashar: "quibble-donationinterface-REL1_39-php74 only runs phpunit and thus does not run `npm test` :)" [integration/config] - 10https://gerrit.wikimedia.org/r/1111304 (owner: 10Hashar) [19:15:21] damilare: both patches are green now https://gerrit.wikimedia.org/r/q/project:mediawiki/core+branch:fundraising/REL1_39+is:open :) [19:15:49] once merged I'll merge https://gerrit.wikimedia.org/r/c/integration/config/+/1111304 to switch the repo back to node20 [19:15:56] which will run given jsduck is gone [19:16:04] dinner! [19:20:12] sounds good [19:21:15] (03CR) 10Jforrester: "(Meant for I3fc6a64f8330498f16faa72ac522df9356e03788, sorry.)" [integration/config] - 10https://gerrit.wikimedia.org/r/1111304 (owner: 10Hashar) [19:38:54] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 10MediaWiki-General: coverage build fails with Error: your composer.lock file is not up to date - https://phabricator.wikimedia.org/T383725 (10Urbanecm_WMF) 03NEW [19:55:45] (03open) 10lwatson: styles: convert CSS values to Codex design tokens [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/628 [19:58:18] 10Scap, 06MediaWiki-Platform-Team, 13Patch-For-Review, 05SUL3: Add SUL3 authentication domain to deploy canary checks - https://phabricator.wikimedia.org/T380574#10460146 (10Tgr) 05Openβ†’03Resolved [20:20:22] (03open) 10dancy: lock.py: Fix comment typo [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/629 [20:20:25] (03update) 10dancy: lock.py: Fix comment typo [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/629 [20:22:14] (03merge) 10dancy: lock.py: Fix comment typo [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/629 [20:22:42] (03update) 10dancy: spiderpig: CAS auth integration [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/625 [20:25:49] (03update) 10lwatson: web: improve JobViewerPage UI [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/608 (https://phabricator.wikimedia.org/T379413) [20:26:12] (03update) 10dancy: spiderpig: CAS auth integration [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/625 [20:26:21] (03update) 10lwatson: styles: convert CSS values to Codex design tokens [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/628 [21:34:15] (03approved) 10egardner: styles: convert CSS values to Codex design tokens [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/628 (owner: 10lwatson) [22:22:09] (03merge) 10dancy: styles: convert CSS values to Codex design tokens [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/628 (owner: 10lwatson)