[00:33:49] (03open) 10bd808: ci: Switch back to Digital Ocean runners by default [repos/releng/zuul/tofu-provisioning] - 10https://gitlab.wikimedia.org/repos/releng/zuul/tofu-provisioning/-/merge_requests/12 (https://phabricator.wikimedia.org/T317341 https://phabricator.wikimedia.org/T374129) [00:34:35] (03merge) 10bd808: ci: Switch back to Digital Ocean runners by default [repos/releng/zuul/tofu-provisioning] - 10https://gitlab.wikimedia.org/repos/releng/zuul/tofu-provisioning/-/merge_requests/12 (https://phabricator.wikimedia.org/T317341 https://phabricator.wikimedia.org/T374129) [06:30:30] 10GitLab (Infrastructure), 10Ceph, 06collaboration-services, 10Data-Persistence-Backup, and 2 others: Migrate gitlab storage to apus (also: backups from S3?) - https://phabricator.wikimedia.org/T378922#10952844 (10jcrespo) I leave you with some homework meanwhile: T387833#10952842 [07:10:49] 10Continuous-Integration-Infrastructure (Zuul upgrade): Artifact storage for updated Zuul CI - https://phabricator.wikimedia.org/T397385#10952971 (10MatthewVernon) FWIW, I would advise against using Swift (the protocol) if you want to move storage to Ceph, and rather use only S3 against Ceph. I don't think the S... [07:25:00] 10GitLab (Infrastructure), 10Ceph, 06collaboration-services, 10Data-Persistence-Backup, and 2 others: Migrate gitlab storage to apus (also: backups from S3?) - https://phabricator.wikimedia.org/T378922#10953025 (10Jelto) Thanks for the update @jcrespo ! T387833#10952842 should be unrelated to the efforts... [08:08:37] 10Phabricator (Upstream), 07Upstream: Make it possible to change the 'default' column of a Phabricator workboard - https://phabricator.wikimedia.org/T397862#10953116 (10Aklapper) Also, it seems that the only reason for switching the default column which I've come across so far is //Backlog Bankruptcy//. Is tha... [08:40:21] 10Phabricator: Allow @pfischer to create and archive milestones in Phabricator for the Search Platform team - https://phabricator.wikimedia.org/T398015 (10Gehel) 03NEW [08:45:16] codders: Lucas_WMDE: looks like I got a bug in https://phpunit-results-cache.toolforge.org/ :] [08:45:34] what's your bug? [08:45:45] I have a build failing because: Could not find file for class \MediaWikiFarmHooksTest [08:45:51] that is this build https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaWikiFarm/+/1164312 [08:46:08] the next change is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaWikiFarm/+/1163866/ which is the one removing that class [08:46:28] and the \MediaWikiFarmHooksTest class can not be found at https://phpunit-results-cache.toolforge.org/results/quibble-composer-mysql-php81 [08:46:38] I guess cause the second change updated the cache somehow :] [08:46:48] I'll take a look in a bit - I'm in meetings until 11h30 [08:46:57] cool :] [08:47:09] does a developer have a way to purge the cache? [08:47:17] there is no rush, those changes can wait [08:47:57] no, but the cache ideally has no impact on whether anything passes - if there's no data in the cache the test should run, and if there is data it should just affect the bucketing / sorting of tests [08:48:57] "Could not find class" should only be about whether `--list-tests-xml` run on the checkout contains references to PHP classes that don't exist on the local checkout [08:49:12] an example build failure is https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php81/9667/console [08:49:20] anyway, focus on your meeting. That can wait :) [08:50:04] I restarted the tool, that should clear the cache at least [08:50:13] idk if it’ll help, sounds like the bug is in the MediaWiki core test code [08:51:19] just as an aside, blowing away the cache makes some (especially wikibase) jobs take so long that they time out until the cache is fully populated again, because of reasons. I was planning to file a ticket so that we don't just junk all the data once a week. [09:03:41] FWIW if I run that extension’s tests locally I get several warnings and errors [09:03:42] including [09:03:45] > Test case class not matching filename is deprecated [09:03:54] > in …/MediaWikiFarm/tests/phpunit/HooksTest.php [09:03:59] > Class name was 'MediaWikiFarmHooksTest', expected 'HooksTest' [09:04:10] I wonder if something in the PHPUnit splitter expects the class and file name to match [09:04:51] yeah it sure does https://gerrit.wikimedia.org/g/mediawiki/core/+/cf629a2ceeb68cfdcd0718ff5440bad20a3c7d0e/includes/composer/PhpUnitSplitter/PhpUnitXmlManager.php#115 [09:15:05] hashar: let’s see if https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1164394 helps [09:17:45] ohh [09:17:53] well I can remove the class/file [09:18:47] ugh, still fails [09:18:48] my 1st change already had to make adjustement to updates made to MediaWiki [09:18:52] so I can as well rename it [09:18:52] now complaining about MediaWikiFarm*List*Test [09:18:58] which is still in ListTest.php [09:19:10] yeah probably best to just rename all the tests to the correct file name [09:25:22] Lucas_WMDE: could it be the composer autoloader requiring some specific config? [09:26:08] ah no that is PhpUnitXmlManager.php doing it apparently [09:35:01] so yeah, the assumption about filenames is built into the splitter, and apparently until now there has always been a correspondence. Has MediaWikiFarm just not been tested this whole time? [09:35:41] is it worth looking into making the splitter handle files with different names? Or should we just fix the issue in "badly-named" files when we find it? [09:35:46] that is well possible it is not tested :) [09:36:13] it an extension written by a french company that hosts MediaWiki as a service ( https://wiki-valley.com/ ) [09:36:23] s/it/it is/ [09:36:39] my guess is that it is stable software. Or maybe they are no omre using it [09:36:41] I'm happy to open an issue for fixing it - if we have a workaround that we're happy with for now, I would at least not try and urgently fix anything today (on friday and I have to hop on a train soon) [09:37:23] is that cause the code does not use the autoloader to map between class and files? [09:37:54] and MediaWikiFarm could use some PHP Namespacing while at it :) [09:38:00] anyway that is a long tail of fixes [09:38:15] I just wanted to remove UnitTestsList hook https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaWikiFarm/+/1163866/ [09:39:03] autoloader> could be? I'm not sure why I decided for the approach I did. Could just have been ignorance, or could be something about the not-quite-mediawiki environment that the splitting code runs in [09:39:29] it also breaks for me locally cuse it scan test files in the MediaWiki/core root dir [09:39:39] but my extensions and skins are elsewhere :] [09:39:42] anyway [09:39:51] I will just disable the parallel testing for that extension [09:40:21] okay. that sounds like a good fix for now. But like I say, I'm happy to work on issues with the splitting if we actually want to make it better-behaved [09:40:38] I think it is fine for this extension [09:40:48] it is probably light enough that we do not need the parlalel test [09:48:09] I need to file a bug [09:51:01] looks like that extension has had various CI troubles [09:51:05] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaWikiFarm/+/545263 was abandoned after a five-year hiatus [09:51:10] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MediaWikiFarm/+/578885 was force-merged [09:51:30] I think it’s worth asking that company if they still use it, and if not, perhaps retiring it [09:52:11] yeah true [09:53:23] (s/retiring/archiving/, that’s the word I was looking for ^^) [09:54:26] (I love that there’s an enwiktionary entry for s/ https://en.wiktionary.org/wiki/s/) [09:54:57] 10Continuous-Integration-Config, 10MediaWiki-extensions-MediaWikiFarm: MediaWikiFarm does not work with MediaWiki tests splitter (PhpUnitXmlManager.php) - https://phabricator.wikimedia.org/T398023#10953409 (10hashar) [09:55:13] (03PS1) 10Hashar: Zuul: [mediawiki/extensions/MediaWikiFarm] disable parallel testing [integration/config] - 10https://gerrit.wikimedia.org/r/1164405 (https://phabricator.wikimedia.org/T398023) [09:55:21] codders: Lucas_WMDE: https://phabricator.wikimedia.org/T398023 :) [09:55:28] you don't have to subscribe [09:55:44] and I am disabling the parallel testing [09:57:44] (03CR) 10Lucas Werkmeister (WMDE): [C:03+1] "I’d include T398023 in the comment somewhere, otherwise LGTM :)" [integration/config] - 10https://gerrit.wikimedia.org/r/1164405 (https://phabricator.wikimedia.org/T398023) (owner: 10Hashar) [09:58:11] perfect - thank you! [09:58:11] I attached my core changes to the task before abandoning them, just for visibility :> [09:58:24] disabling parallel testing sounds like a fine solution [09:59:03] excellent thanks [10:00:15] (03CR) 10Hashar: "Done! 😊" [integration/config] - 10https://gerrit.wikimedia.org/r/1164405 (https://phabricator.wikimedia.org/T398023) (owner: 10Hashar) [10:00:18] (03PS2) 10Hashar: Zuul: [mediawiki/extensions/MediaWikiFarm] disable parallel testing [integration/config] - 10https://gerrit.wikimedia.org/r/1164405 (https://phabricator.wikimedia.org/T398023) [10:00:42] Lucas_WMDE: if you don't mind CR+1 again https://gerrit.wikimedia.org/r/c/integration/config/+/1164405/1..2/zuul/parameter_functions.py [10:00:43] :) [10:02:29] (03CR) 10Lucas Werkmeister (WMDE): [C:03+1] Zuul: [mediawiki/extensions/MediaWikiFarm] disable parallel testing [integration/config] - 10https://gerrit.wikimedia.org/r/1164405 (https://phabricator.wikimedia.org/T398023) (owner: 10Hashar) [10:02:38] (03CR) 10Hashar: [C:03+2] Zuul: [mediawiki/extensions/MediaWikiFarm] disable parallel testing [integration/config] - 10https://gerrit.wikimedia.org/r/1164405 (https://phabricator.wikimedia.org/T398023) (owner: 10Hashar) [10:02:42] danke schon [10:02:49] and maybe I will convert it to use namespaces [10:04:08] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/MediaWikiFarm] disable parallel testing [integration/config] - 10https://gerrit.wikimedia.org/r/1164405 (https://phabricator.wikimedia.org/T398023) (owner: 10Hashar) [10:10:54] 10Continuous-Integration-Config, 10MediaWiki-extensions-MediaWikiFarm, 13Patch-For-Review: MediaWikiFarm does not work with MediaWiki tests splitter (PhpUnitXmlManager.php) - https://phabricator.wikimedia.org/T398023#10953448 (10hashar) I think MediaWikiFarm classes should no more use a prefix in their names... [10:11:24] reloaded. Lets see how it behaves now [10:13:35] (03PS1) 10Fomafix: Zuul: [mediawiki/extensions/VisualData] Add Scribuntu phan dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1164412 [10:19:48] 10Continuous-Integration-Infrastructure (Zuul upgrade): Artifact storage for updated Zuul CI - https://phabricator.wikimedia.org/T397385#10953456 (10hashar) > FWIW, I would advise against using Swift (the protocol) if you want to move storage to Ceph, and rather use only S3 against Ceph. I don't think the Swift... [10:20:10] (03CR) 10Hashar: [C:03+2] Zuul: [mediawiki/extensions/VisualData] Add Scribuntu phan dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1164412 (owner: 10Fomafix) [10:21:24] (03Merged) 10jenkins-bot: Zuul: [mediawiki/extensions/VisualData] Add Scribuntu phan dependency [integration/config] - 10https://gerrit.wikimedia.org/r/1164412 (owner: 10Fomafix) [10:23:20] 00:02:20.012 1) ConstructionTest::testFailedConstruction9 [10:23:20] 00:02:20.012 $wgUser reassignment detected [Called from PHPUnit\Framework\TestCase::restoreGlobalState in /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php at line 2363] [10:23:32] 00:02:20.012 2) MediaWikiFarmScriptTest::testMissingArgumentScript [10:23:32] 00:02:20.012 preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated [10:23:32] :) [10:27:27] yeah I saw the first one locally too [10:27:48] and I think the second one as well, but I ignored that because I haven’t fully internalized that we run CI on PHP 8.1+ now ;) [10:46:41] 10Phabricator (Upstream), 07Upstream: Make it possible to change the 'default' column of a Phabricator workboard - https://phabricator.wikimedia.org/T397862#10953496 (10A_smart_kitten) >>! In T397862#10953116, @Aklapper wrote: > Also, it seems that the only reason for switching the default column which I've co... [10:58:10] 10Phabricator: Allow @pfischer to create and archive milestones in Phabricator for the Search Platform team - https://phabricator.wikimedia.org/T398015#10953510 (10Peachey88) 05Open→03Invalid Please see existing process for requesting permissions {T706} [11:04:18] 06Project-Admins: Create a tag for PagePermissions extension - https://phabricator.wikimedia.org/T397873#10953522 (10Peachey88) 05Open→03Resolved a:03Peachey88 Requested project #MediaWiki-extensions-PagePermissions has been created. :) [11:11:16] 06Project-Admins, 10MediaWiki-extensions-PagePermissions: Create a tag for PagePermissions extension - https://phabricator.wikimedia.org/T397873#10953546 (10Peachey88) [12:39:18] 10Gerrit: Slow connection to gerrit via ssh - https://phabricator.wikimedia.org/T398030#10953842 (10Peachey88) [12:40:40] I'll revisit MediaWikiFarm extension next week [12:46:14] 10Continuous-Integration-Infrastructure (Zuul upgrade): Artifact storage for updated Zuul CI - https://phabricator.wikimedia.org/T397385#10953896 (10MatthewVernon) You can achieved automatic expiry via S3, though, using a lifecycle policy - IBM's docs have a [[ https://www.ibm.com/docs/en/storage-ceph/8.0.0?topi... [13:10:44] Any chance somebeing could take a look at https://gerrit.wikimedia.org/r/c/integration/config/+/1164451 (phan_dependencies: Add 'CommunityConfiguration' depend for 'TemplateData') — ideally to merge it, but if not, to advise if it would resolve the failures I'm seeing at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateData/+/1164192 (i.e. phan failing with `includes/CommunityConfigurationHooks.php:11 [13:10:44] PhanUndeclaredInterface Class implements undeclared interface \MediaWiki\Extension\CommunityConfiguration\Hooks\CommunityConfigurationProvider_initListHook`) [13:12:55] (03PS1) 10Samtar: phan_dependencies: Add 'CommunityConfiguration' depend for 'TemplateData' [integration/config] - 10https://gerrit.wikimedia.org/r/1164451 (https://phabricator.wikimedia.org/T397814) [13:16:29] TheresNoTime: if it’s urgent then you could probably unblock your work with phan stubs like the ones removed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/791326 [13:16:48] but AFAIK adding a Phan dependency on the real code is the preferred approach these days [13:17:04] so I hope somebody will be able to review that integration config change soon :) [13:18:12] Lucas_WMDE: ah did see something about stubs.. thank you [13:31:28] hashar: sorry to bother, is there a chance you could take a quick look at https://gerrit.wikimedia.org/r/c/integration/config/+/1164451 ? [13:51:00] 10Phabricator (Upstream), 07Upstream: Active Bot usernames are struckout in search suggestions, like disabled accounts - https://phabricator.wikimedia.org/T227963#10954136 (10Aklapper) p:05Lowest→03Low [14:09:56] TheresNoTime: I can merge that for you [14:10:29] dancy: oh, thank you! :D [14:11:03] (03CR) 10Ahmon Dancy: [C:03+2] phan_dependencies: Add 'CommunityConfiguration' depend for 'TemplateData' [integration/config] - 10https://gerrit.wikimedia.org/r/1164451 (https://phabricator.wikimedia.org/T397814) (owner: 10Samtar) [14:12:24] (03Merged) 10jenkins-bot: phan_dependencies: Add 'CommunityConfiguration' depend for 'TemplateData' [integration/config] - 10https://gerrit.wikimedia.org/r/1164451 (https://phabricator.wikimedia.org/T397814) (owner: 10Samtar) [14:12:52] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/c/integration/config/+/1164451 [14:12:53] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:13:08] TheresNoTime: Done [14:13:17] thank you! :3 [14:47:15] \o/ [14:47:32] thank you dancy! [14:47:36] I was in call :-] [14:47:47] and I am off now, I had a loong and dense week [14:47:56] Have a good weekend hashar! [14:48:08] thx you too! [18:29:21] 10Gerrit, 06Infrastructure-Foundations: Slow connection to gerrit via ssh - https://phabricator.wikimedia.org/T398030#10955086 (10Aklapper) [19:10:19] (03merge) 10dancy: Emit logstash records in ECS 1.7.0 format (v2) [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/862 (https://phabricator.wikimedia.org/T279086 https://phabricator.wikimedia.org/T397967) [19:11:37] (03update) 10dancy: Emit logstash records in ECS 1.7.0 format (v2) [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/862 (https://phabricator.wikimedia.org/T279086 https://phabricator.wikimedia.org/T397967) [19:14:13] (03open) 10dancy: Release 4.184.1 [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/865 [19:16:22] (03merge) 10dancy: Release 4.184.1 [repos/releng/scap] - 10https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/865 [19:37:17] 10Release-Engineering-Team (Priority Backlog 📥), 10Scap, 10observability: Update Scap to emit ECS-compatible structured logs - https://phabricator.wikimedia.org/T279086#10955230 (10dancy) 05In progress→03Resolved Deployed via scap 4.184.1. [20:07:35] (03open) 10dancy: scap.cfg: Drop unused php_fpm* config parameters [repos/releng/train-dev] - 10https://gitlab.wikimedia.org/repos/releng/train-dev/-/merge_requests/145 (https://phabricator.wikimedia.org/T396166) [20:07:37] (03update) 10dancy: scap.cfg: Drop unused php_fpm* config parameters [repos/releng/train-dev] - 10https://gitlab.wikimedia.org/repos/releng/train-dev/-/merge_requests/145 (https://phabricator.wikimedia.org/T396166) [20:08:39] (03merge) 10dancy: scap.cfg: Drop unused php_fpm* config parameters [repos/releng/train-dev] - 10https://gitlab.wikimedia.org/repos/releng/train-dev/-/merge_requests/145 (https://phabricator.wikimedia.org/T396166) [20:49:33] 10Release-Engineering-Team (Priority Backlog 📥), 07Essential-Work, 05Release, 05Train Deployments: 1.45.0-wmf.7 deployment blockers - https://phabricator.wikimedia.org/T392177#10955321 (10thcipriani) 05Open→03Resolved [23:27:29] (03open) 10bd808: puppetserver: Manage Project Puppet settings [repos/releng/zuul/tofu-provisioning] - 10https://gitlab.wikimedia.org/repos/releng/zuul/tofu-provisioning/-/merge_requests/13 (https://phabricator.wikimedia.org/T396936 https://phabricator.wikimedia.org/T397994)