[07:38:02] hmm, page layout of the cirrustestwiki is dramatically different than the one on wikipedia [07:38:24] also, input ids changed (or rather dissapeared [07:39:10] classes changed as well [07:39:30] I think that's what broke smoke tests [07:39:36] likely related to desktop refresh, I think ?useskinversion=1 should present the old layout [07:39:56] or we should adapt the tests to the new layout [07:40:00] yeah, it was a desktop refresh [07:40:15] I'll go the second route, makes more sense to me [07:40:54] in the new version [07:41:05] I can't find a logo anywhere, so ASCII unicorn is gone :( [07:41:49] sure, once you've updated the tests please update tests/selenium/pageobjects/random.page.js as well and drop the { useskinversion: 1 } [07:41:57] ok, will do [07:46:15] huh, chrome has a "copy selector" menu item :) [07:46:37] ah, but it only copies top level id [07:49:18] no ids on those elements, which leaves me with the ugly "#searchform > div > div > input" :( [07:49:56] sorry, "#searchform > button" -better, still ugly [08:25:07] errand [09:52:29] lunch [11:32:20] lunch [12:12:01] title completion recommendations no longer have "title" attirbute, meaning that actual title is broken into two seperate html elements (one highlighted, other not) :( [12:12:10] there's precious little ids present as well [14:02:53] hmm, I dd update random.page.js, but of course forgot to add it to a patch [14:03:44] also, there's a flakey test, but judging from a comment it's a common knowledge [14:05:16] yes, it's related to indexing speed and/or proper ordering of the index requests IIRC, fine to ignore unless it's complaining too much [14:57:27] \o [14:58:21] o/ [16:14:21] fyi, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/709404 - fix for cindy tests, I incorporated dcausse comment [16:14:51] merged thanks! [17:28:27] dinner