[07:41:02] wdqs1010 is still running the old updater I wonder if we're confident enough in the new updater that we can switch this machine to it [07:42:32] I would not mind keeping it around but it's relying on $kafka_reporting_topic (puppet var, c.f. https://phabricator.wikimedia.org/T296699#7536195) that we know to be problematic during DC switches [07:42:52] so keeping wdqs1010 on the old updater might cause alerts to be fired [07:53:17] it's been 1.5 months without incident, I vote we make the leap and drop the old updater from wdqs1010 [07:53:42] we have some time before the next DC switch, so no emergency! [07:54:20] ebernhardson: I suspect that the JMX stuff relies on exported resources, which are not handled by PCC: https://puppet.com/docs/puppet/7/lang_exported.html [07:54:23] checked the puppet code and test machines do not seem to have lag alerts enabled [07:55:19] well, I prepared a patch to switch wdqs1010 in case it starts to be annoying [08:52:11] we don't seem to have any mediainfo relevant integration tests [08:52:45] they probably weren't needed before [08:56:32] I think the changes required so far were all small enough that unit testing was sufficient [08:57:37] yeah, but with the conditional on mediainfo namespace filter I feel like we should have it [08:58:13] I'm not sure that different id parsing is properly tested now as well [09:02:11] those are all incomingstreams, maybe I can still get away without mediainfo integration tests... [09:29:48] ok, I actually didn't need that integration test, it seems [09:52:42] zpapierski: can we continue with th update [09:53:26] I'm in a meeting now, afterwards I need a grab of food and we can continue on update [09:57:25] Ok cool [11:34:16] lunch [12:17:56] https://github.com/elastic/elasticsearch/blob/6.8/server/src/main/java/org/elasticsearch/index/query/QueryShardContext.java [12:31:02] https://github.com/elastic/elasticsearch/blob/678e82d13b0b5a31b0ef9c42f383514dc1d12062/server/src/main/java/org/elasticsearch/search/aggregations/metrics/scripted/ScriptedMetricAggregationBuilder.java#L219 [12:48:32] Are you there [12:48:41] I'm there [12:48:46] you can't hear me I assume [12:49:27] I'm reconnectin [12:50:43] anyway - I'd use Float.MAX_VALUE here [15:30:53] meh, camera not starting ... reboot and join in a sec [17:47:00] someone else built a search from our images, they only used ~100k though: https://imagioo.com/about/ [18:33:36] dinner [21:41:00] ebernhardson: congratulations on taking vacation days ! Could you update the spreadsheet as well ? [21:41:03] Thanks ! [21:45:00] done