[00:02:00] ebernhardson gotcha, thanks [00:04:07] Wow, it's 6 PM my time all of a sudden. See y'all tomorrow! [00:04:48] see ya! [00:08:13] latersville [00:13:59] ebernhardson: y'all are going to do 7.10 rather than going right OpenSearch? [00:14:07] *right to [00:14:57] bd808: indeed, expecting open search to be more painful as we make use of quite a few plugins [00:15:12] *nod* [00:15:48] there is some question of what is the appropriate system to run search, because despite the name opensearch seems to have trippled down on logs compared to elastic, who were already pretty log heavy :) [00:16:05] (although i haven't looked exceptionally deeply) [00:16:08] actually looking at the OpenSearch docs they recommend rolling update to 7.10.2 before moving to OpenSearch [00:17:17] yeah, I could see OpenSearch being skewed in favor of ELK use cases depending on who does the work of driving the roadmap [00:18:59] i'm sure we will end up on opensearch at some point, i can't really see other options that make sense given reality. but who knows when :) [00:19:33] right after a CVE comes out that requires going past the FOSS versions ;) [00:20:24] yea thats one way :) [00:21:02] * bd808 is mostly interested because Toolhub is a stowaway on the chi cluster [00:22:49] we've talked a little, but i imagine you're safe for at least a year or so [00:22:57] after the 7.10 upgrade [00:24:45] I need to watch 7.x first because of the versioned python client libs I'm using. I think they all freak out when a 6.x client tries to talk to a 7.x server [00:25:16] * bd808 should probably start a task to POC 7.10 in the dev environment [00:28:27] hh, yes that will come much sooner, es 6.8 and then 7.10 are the next project after wcqs is released this month. Previous upgrades of the same sort took maybe 3-5 months [08:26:47] ejoseph: let me know once you're available [08:32:27] zpapierski: good morning [08:32:44] I'll be available in 10 mins [08:33:03] great, let's sync then [08:52:32] ejoseph: I'm going to brew myself a coffee and I'm back - meet.google.com/afu-jhht-grf [09:31:38] errand, back in a bit [10:36:13] errand and lunch probably later [10:39:07] lunch [11:09:29] lunch [13:54:39] dcausse: try as I might, I can't understand how the index mapping is constructed for the tests like TokenCountRouterBuilderESTest . Migrating to 7.10 makes them fail with "MapperParsingException[No handler for type [geo_shape] declared on field [mapped_geo_shape]]" I'm guessing the default mapping handling was changed somehow, but can't get to see how - any ideas? [13:56:19] zpapierski: this error is fixed by adding the TestGeo plugin (from the method getPlugins) [13:56:32] lemme find the real name [13:56:52] TestGeoShapeFieldMapperPlugin [13:56:52] ? [13:57:06] yes that's it [13:57:10] just the mapper I guess? [13:57:14] mappers.put("geo_shape", new org.elasticsearch.index.mapper.GeoShapeFieldMapper.TypeParser()); [13:57:27] no just add the plugin [13:57:36] ok [13:58:49] https://gerrit.wikimedia.org/r/c/search/extra/+/737664/4..5/extra/src/test/java/org/wikimedia/search/extra/router/DegradedRouterBuilderESTest.java#50 [13:58:53] ok, much better - some test fail, but most of them passes now, thanks! [13:59:01] yw! [13:59:15] btw - it's deprecated,why? [13:59:54] no clue it's some BC testing code but I'm not sure why it got to pollute everything like that [14:00:24] ah, it's decompiled code, maybe source will shed some light [14:00:49] I think they used to generate a standard mapping for all the tests and got stuck when deprecating stuff so that's why they created this Test plugin? [14:01:38] it's possible that using their standard gradle build it's getting imported automatically [14:01:51] "Some tests depend on the GeoShapeFieldMapper. This mapper is registered in the spatial-extras module, but used in many integration tests in server code. The goal is to migrate all of the spatial/geo pieces to the spatial-extras module such that no tests in server depend on this test plugin" [14:01:51] s/imported/discovered&loaded/ [14:01:54] you might be correct [14:03:18] other classic problem I saw is that now elastic is more strict when dealing with term queries on undeclared fields [14:03:33] they get rewritten to MatchNone [14:04:03] so that's why some tests now requires defining the field they work on [14:04:21] this testgeoshape plugin generates a huge wall of deprecation warnings now :/ [14:04:37] :/ [14:04:57] yeah, not much we can do, unless we want to disable those [14:05:11] maybe I can disable this specific warning somehow [14:05:28] deprecation from elastic? [14:09:17] greetings! [14:09:34] hey! [15:00:53] inflatador: let's get to our 1/1 meet actually - if anyone wants to join for a "get to know" https://meet.google.com/cex-ouqe-ybj [15:24:11] inflatador: looks like we have a disk issue on elastic2051, having a look at https://icinga.wikimedia.org/icinga/ [15:25:28] and that's one of our master eligible, we need to switch the master [15:33:55] inflatador: we can have a look at that server during our pairing session later today [15:36:21] ejoseph: I pushed the changes for that geo stuff, we can move on further [15:37:22] gehel sounds good, just had a nice discussion with Z [15:38:15] inflatador: or if you are around now, we can have a look [15:38:51] gehel sure, whenever you want [15:39:33] inflatador: meet.google.com/oam-gbmu-eef [16:03:16] \o [16:08:34] o/ [16:32:21] dcausse: can you help a bit with that failing rewrites with match_none? [16:32:35] I'm not sure which way we need to go with fixing that [16:54:23] inflatador: now that we've moved the master eligible node, we still need to get a new disk for that server. Let's connect during our pairing session this evening [16:57:39] Dinner, back later [16:59:34] gehel ACK, taking a workout break, back in ~30 [17:51:47] back, but cable guy is on his way, so may be right back out [18:10:50] aaand back for real [18:18:46] The cable guy was very confused by my MoCA (ethernet to coax) adapters [18:19:14] heh, i don't think i would recognize those either :) [18:24:12] It's always confusing, because I have multiple cable lines but no "cable" service (just Internet) [18:25:10] I have an old house with coax taps in every room, it's much faster than Wifi for my wife's office (she is WFH also) [18:27:41] makes sense, had to google what they are but reusing any wire thats already run everywhere is a huge win :) [19:03:46] lunch, back in ~30 [19:26:28] inflatador: I might be 5' late for our meeting, need to get Oscar to bed first [19:26:57] gehel perfect, gives me a little more time to stuff my face ;P [20:35:02] good night! [20:44:57] lunch [21:29:17] back [22:06:18] ebernhardson or anyone else, LMK if you have time/feel comfortable giving a +1 here: https://gerrit.wikimedia.org/r/c/operations/puppet/+/752005 [22:15:34] inflatador: lgtm [22:17:02] Thanks, let the +2 begin! [23:07:34] Out slightly early to make pizza, see y'all tomorrow! [23:10:44] 🍕