[07:19:53] <hashar>	 dcausse: bonjour!  there was a Wikidata/search train blocker yesterday, turns out it got fixed by Erik over night ( was https://phabricator.wikimedia.org/T307586 )
[07:20:07] <hashar>	 so you can ignore notifications by Lucas and me 
[07:50:33] <gehel>	 hashar: merci!
[07:51:28] <hashar>	 gehel: to be fair Erik has done all the fixing work  :]
[07:51:41] <gehel>	 noted!
[08:35:02] <gehel>	 inflatador: I played with https://gerrit.wikimedia.org/r/c/operations/puppet/+/789559/ which might be of interest to you. There is still an issue with Swift. I'll let you move this forward. Or let me know if I should abandon it.
[14:16:16] <inflatador>	 greetings
[14:19:14] <gehel>	 o/
[14:20:36] <gehel>	 Trey314159: Do you want to schedule that "Tell us why your search sucks" session? Since you're probably the main person to answer those questions, your time availability is the most important.
[14:28:24] <Trey314159>	 gehel: sure.. though I certainly don't have all the answers.
[14:28:49] <gehel>	 I'll be there as well, and I suspect that others will be interested.
[14:32:18] <inflatador>	 <o/
[14:58:53] <ebernhardson>	 \o
[16:19:07] <inflatador>	 gehel or anyone else, can I get a review on https://gerrit.wikimedia.org/r/c/operations/puppet/+/789644 if/when you have time? I was a bad reviewer last time and merged your patch that didn't quite remove that java param
[16:19:47] <inflatador>	 there's a lot of whitespace changes too, should not have added those
[16:20:23] <inflatador>	 but that's from asking rubymine to fix the formatting, if we need to split those out into 2 changes I'm happy to do that
[16:22:16] <ebernhardson>	 hmm, the test search `d*e*a*d*l*y*w*i*l*d*c*a*r*d*d*e*a*d*l*y*w*i*l*d*c*a*r*d*d*e*a*d*l*y*w*i*l*d*c*a*r*d*d*e*a*d*w*i*l*d*c*a*r*d` runs for 2s and doesn't obviously fail or give warnings in es7
[16:22:21] <ebernhardson>	 i guess it's good there is a test :)
[16:23:55] <ebernhardson>	 inflatador: that indentation still looks off, the `} else {` should line up with `if $gc_log == true {`
[16:24:19] <ryankemper>	 Car battery died at an inopportune moment, will be late for puppet deploy window
[16:24:28] <inflatador>	 ebernhardson OK, let me revert that back to original spacing
[16:32:52] <inflatador>	 All right, I think it's good now, let me know what you think
[16:40:12] <inflatador>	 ebernhardson do you have any puppet patches? I don't see any
[16:41:27] <ebernhardson>	 inflatador: it looks like this still knocked things down to 2-space indentation, style guide says 4: https://wikitech.wikimedia.org/wiki/Puppet_coding#Coding_Style
[16:41:34] <inflatador>	 booo
[16:41:55] <inflatador>	 OK, I gotta go to lunch but will address when I get back
[16:42:01] <ebernhardson>	 np
[17:27:32] <gehel>	 inflatador: you can configure rubymine to use 4 spaces
[17:28:30] <gehel>	 you could add a section to https://wikitech.wikimedia.org/wiki/Puppet_coding#Miscellaneous about the settings you use
[17:47:37] <inflatador>	 back
[18:21:01] <ebernhardson>	 heh, elastisearch builds with jdk 12. So of course my apt has jdk's 8, 11, 13, 16 and 17 available
[18:21:12] <ebernhardson>	 oh well, easy enough, just amusing :)
[18:27:07] <inflatador>	 Guessing that's ES 7?
[18:33:42] <ebernhardson>	 6.8.23, since i can't find any explanation in lucene or elasticsearch for why these very expensive queries don't get short-circuited i need to run it through the elasticsearch test suite with various versions and see when it changed
[18:34:53] <gehel>	 inflatador: we're in https://meet.google.com/eki-rafx-cxi if you want to join us
[18:49:03] <ryankemper>	 ebernhardson: is the `elasticsearch test suite` something that es provides? or is that our test suite
[19:03:35] <ebernhardson>	 ryankemper: it's inside elastic, i'm suspecting though that i'm only going to find it's down to a lucene version change
[19:04:20] <ebernhardson>	 ryankemper: also i wouldn't be running the whole suite, basically find a relevant place in elastic and add a test that triggers our 'TooComplexToDeterminize' exception, and then re-run with bisect
[19:32:35] <gehel>	 ebernhardson: metrics meeting: https://meet.google.com/jtz-copb-gso
[19:59:58] <inflatador>	 This looks like an interesting way to test our puppet changes without grinding thru as many PRs https://wikitech.wikimedia.org/wiki/Bolt
[20:09:26] <inflatador>	 quick break, back in ~15
[20:37:34] <inflatador>	 back
[21:02:45] <ebernhardson>	 meh. The docker images for elastic 7.6.2 fail the query (as expected), 7.7.0 doesn't. But my test case which triggers the failure makes it fail correctly in both :S
[21:35:52] <inflatador>	 correct failures, my favorite kind of failures ;P
[21:40:59] <inflatador>	 we're 2/3rds of the way to bullseye in deployment prep. Still need to fix the puppet code but at least we're making progress
[21:41:28] <inflatador>	 https://phabricator.wikimedia.org/P25970#115261 list of gross stuff needed