[08:32:36] dcausse: I had a look at https://gerrit.wikimedia.org/r/c/wikimedia-event-utilities/+/810387 (and left plenty of comments, a bunch of those are my OCD, feel free to ignore) [08:33:02] gehel: thanks! just looked at those and they make sense! thanks :) [08:33:25] One that I'm curious about is https://gerrit.wikimedia.org/r/c/wikimedia-event-utilities/+/810387/3/eventutilities/src/test/java/org/wikimedia/eventutilities/core/event/TestJsonEventGenerator.java#63 [08:33:48] I don't really understand why there is this double cast. I suspect that there is a good reason, but I'm not sure which [08:33:55] this is to make the lambda serializable [08:34:18] but I see some confusion there to I'll add function interface [08:34:28] like SerializableClock [08:34:46] this will silence the spotbug warning as well [08:34:58] Oh, that makes sense! [08:35:05] * gehel isn't used to lambda enough [08:35:37] Then you can probably just ignore that comment. It seems that it would be obvious enough to someone more up to date than myself. [08:36:30] reasoning was to ease testing but I think I agree with you, I was just too lazy to add that interface but since it's used in several places I might add it [08:37:13] nah, looks good enough to me [12:55:39] greetings [13:08:06] o/ [13:12:16] o/ [13:54:37] \o [14:37:40] o/ [14:52:36] Gerrit is showing me: "DCausse 58 comments". Not sure I've seen that many comments in a single PS yet. [14:52:56] yes... this one is getting too big :( [14:53:30] I'm responding to sonar too so that might explain :) [15:34:19] unmeeting has started on https://meet.google.com/eki-rafx-cxi [15:37:38] gehel: I think your problem is: https://bugs.openjdk.org/browse/JDK-8148463 [15:37:58] Oh, that might be it! [15:52:47] tanny411: the event debugging i mentioned is documented here: https://www.mediawiki.org/wiki/Extension:EventLogging/Programming#Monitoring_events [15:56:39] This came in yesterday https://usercontent.irccloud-cdn.com/file/09qQeWOe/IMG_4574.MP4 [15:58:04] ejoseph: oh cool, those are the new employee things? [15:58:20] shirts look cooler now, the old one was the `i edit wikipedia` shirts [15:58:33] (which are nice, but it's only text on a shirt) [15:59:57] Yes the new employee things [16:00:32] yeah, i like this one [16:18:19] ebernhardson: Thanks! [16:19:52] ryankemper thanks for catching that alert [17:12:20] * ebernhardson tries and fails to remember how i was trying to make shellbox-media work with mwdd a month ago...memory is hard :P [17:14:44] my wip git commit even has todo's listed, but i can't seem to remember how i was intending to fix them :P [17:51:00] lunch, back in ~30-45 [18:44:43] back [18:54:38] lunch [19:45:34] back [19:56:33] inflatador: ryankemper: are you restarting instances today? I'll kickoff the wikidatawiki and commonswiki rebuilds once we know we aren't going to be restarting more instances for the weekend [19:56:59] ebernhardson I'm not planning on doing any more today [19:57:04] ebernhardson: inflatador: fire away [19:57:10] alright, thanks! [20:24:02] heh, no big surprise but the big clusters are processing wikidatawiki items at about double the speed of cloudelastic [20:26:30] the main reindexing has only made it up to letter i (its all alphabetical). Hopefully finishes next week [20:26:40] did you just start it? [20:27:26] the main reindexing has been running since monday :) [20:27:40] but i just started wikidatawiki and commonswiki across the three clusters [20:28:20] ah OK