[09:27:51] erradn, back in 20' [10:29:44] dcausse: if you have a moment: https://gerrit.wikimedia.org/r/c/wikimedia/discovery/discovery-maven-tool-configs/+/853247 [10:30:28] (and rpevious) [10:47:14] lunch [11:01:22] lunch [13:28:39] o/ [13:31:32] o/ [13:31:39] dcausse: another string of patches at https://gerrit.wikimedia.org/r/c/wikimedia/discovery/discovery-parent-pom/+/853252/1 [13:32:13] Zuul is super busy. The failing build should be fixed now that maven-tools-config has been published. [13:32:50] gehel: looking [13:35:58] There are 173 errors reported by Checkstyle :) [13:36:43] the blazegraph module in the rdf repo [13:36:56] ouch! [13:37:18] I'll have a look. Maybe add a suppression for that project. [13:37:27] I only tested on the search/extra plugin [13:38:06] looking at those [13:38:42] hm perhaps "L'abréviation dans le nom 'loadJSONConfig' ne doit pas contenir plus de '4' lettres majuscules. [AbbreviationAsWordInName]" [13:38:58] loadJsonConfig? [13:39:34] Or disable the rule if it is too constraining [13:41:21] ah actually one file was tab indented [13:41:37] Ah, that explains a lot! [13:41:51] and an easy fix [14:56:49] \o [14:57:40] o/ [14:59:24] indent on array constructs is not inline with intellij defaults: checkstyle wants: \tString[] v = new String[] {\n\t\t"entry1"}; intellij wants an extra tag [14:59:27] s/tag/tab [14:59:52] i never liked that extra tab :P [14:59:59] but it seems to be normal java [15:03:00] meh, we're screwed, checkstyle no long wants to name a var 'var' [15:05:35] sounds like a reasonable rule :) [15:59:13] workout, back in ~40... [16:08:28] perhaps allowing test method names to be snake case might be nice [16:31:58] skipping unmeeting and heading out early, have a nice week-end [16:38:06] just got back [17:23:49] lunch, back in ~1h [18:20:54] back