[16:02:26] dr0ptp4kt: we're in our weekly Search meeting: https://meet.google.com/eki-rafx-cxi [16:53:08] * ebernhardson tries to rub a smudge off the screen, but nope. That e̪ has a special underline [18:04:00] Trey314159: i realized while checking into why cindy doesn't work that it's testing acronyms, and we reverted some of the acronym work due to perf issues. I don't 100% remember how much of that was brought back, but wonder if cindy is trying to test something that was reverted [18:04:15] in tests/integration/features/acronym_fixer.feature [18:08:21] ebernhardson: we didn't revert the acronym processing using regexes, we just stopped reindexing. Later config made it a fallback.. which could be failing to fall back for cindy. Let me look at the config again... [18:09:34] Trey314159: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/957806 is suspicious, since it says "Remove acronym_fixer" and the test is named "acronym_fixer" [18:13:59] But it got put back in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/965576/ Cindy has all the installed plugins available, right? Also, do you want to just disable the test and see if it solves anything? [18:16:22] Trey314159: running locally, only the acroym tests and a one wbcs test related to stemming fails. For this it's pulling 7.10.2-wmf8. Prod has -wmf10 on the main extra plugin, can try updating [18:28:20] ebernhardson: looking at the tests, I do think some of them will fail using the fallback config, and the acronym plugin (textify) is only available in -wmf10. ( https://repo1.maven.org/maven2/org/wikimedia/search/extra-analysis-textify/maven-metadata.xml ) So that's not helping. [18:29:28] almost have it updated, will see here in a sec [18:31:17] I could be convinced to simplify the tests so they pass with the fallback config, though this should be less of a problem in the future. It's arguably kinda good that the test requires you to have updated plugins, maybe? (Though the hassle of figuring out that that's the problem is not good.) [18:34:15] it's curious that it would require it, we don't really do run-time detection of capabilities. Sadly with updated plugins it's failing at the same place, [18:35:19] hello! sorry to be bugging ye about this again and thanks for the patches on https://phabricator.wikimedia.org/T356526 - any chance they could go out today? this alert is getting pretty dangerous for us as we're having other issues with the jobrunners and knowing when the alerts are valid is pretty crucial. we also had a deploy think that they had triggered the errors [18:35:44] hnowlan: yes there is a patch up and scheduled for the next backport window [18:35:53] great, thank you! <3 [18:37:37] ebernhardson: can you see which specific test query is failing? (I forget how precise Cindy logging is) [18:39:34] specifically, the broken acronyms are all the "Multi-codepoint acronyms find are are found" - all fail. Then Ю́В from "joined initial match with or without periods". And then two that should not have matched but did: the two e̪fg variants in the last test [18:39:37] Trey314159: ^ [18:40:05] ebernhardson: thanks.. I will look some more [18:41:16] thanks [18:53:05] Looking more closely and doing some quick tests, those are all the ones I'd expect to fail if the textify plugin isn't available and we were only using the fallback regex. Is there a chance that something changed (or your local config is wonky) and the plugins aren't being installed or used correctly? I'm also going to investigate the downloadable plugin and make sure it looks good, too. [18:53:09] ebernhardson: ^ [18:54:59] Trey314159: hmm, this is installing the same .deb we use on production. Theres nothing from _cat/plugins that suggests textify is installed. Same in prod. So i guess we found our problem :) [18:55:38] That's certainly *a* problem. [18:59:51] (My wife walked by and I said that some tests I had written were causing problems for Erik, and she immediately guessed it was Cindy. I think I may badmouth Cindy a little too often!) [19:00:31] cmon, it's been months :P [19:02:15] * ebernhardson wonders if all the plugins should be updated to wmf10. Probably? [19:03:10] curiously there is also a mix of wmf8 and wmf10 in prod eqiad [19:03:25] ebernhardson: you could expand T356651 if you think that's a good idea [19:03:25] T356651: Rebuild and deploy textify plugin - https://phabricator.wikimedia.org/T356651