[11:45:20] lunch [14:15:20] o/ [14:33:51] \o [14:34:07] pfischer: yea i gave it a bash script that reaches into my env and runs phpunit [14:43:07] o/ [15:54:31] i suppose i should mention though, the tests it was writing were terrible :P Just too specific, way too much duplication between tests, etc. [15:55:24] it seems unlikely to make architectural decisions like separating out a bunch of tests, removing duplication, making them run from a provider, etc. But probably you could tell it to and it might get there. [16:05:20] pfischer: event.mediawiki_cirrussearch_request [18:52:03] wondering what's the best way to package sparknlp... manually push their fat jars from https://github.com/JohnSnowLabs/spark-nlp/releases to gitlab? [19:12:49] dcausse: hmm, yea that seems reasonable. I think thats what mjolnir is doing for the jars, but it's a little different since we had to fork them to make compatible with latest spark [19:18:47] wondering if https://gitlab.wikimedia.org/repos/wmf-packages/ is the right place [19:19:51] seems to be only wmf artifacts not thirdparties [19:19:54] dcausse: i'm not sure if we've used it that way yet, but makes plenty of sense [19:33:23] ack, will take a closer look perhaps it still needs a small repo to download and push this fat jar [19:33:34] dinner [21:17:59] turns out the problem with https://dumps.wikimedia.org/other/ was on my end, issuing a force-refresh loaded the new content. [21:34:55] sigh..somehow my patches broke a bunch of things in cindy and i'm not sure why yet :S [21:43:30] (of course it all passes in my local copy of cindy) [21:56:28] inflatador: nothing more satisfying than a patch nuking 200+ lines of hardcoding, nice work! (ref https://gerrit.wikimedia.org/r/c/operations/puppet/+/1225639/3/hieradata/regex.yaml) [22:04:07] ryankemper thanks, I give all the credit to g-ehel for spurring me on with a long chain of patches (such as https://gerrit.wikimedia.org/r/c/operations/puppet/+/1224713/2 )